Commit graph

1444 commits

Author SHA1 Message Date
Paul Faria
51ae7334f5 Responded to more code review comments. Simplified code a lot. 2015-05-19 23:54:38 -04:00
Paul Faria
fe0b77d669 Responded to code review comments, general cleanup 2015-05-19 23:54:36 -04:00
Paul Faria
8e78564dc3 Fixing one missed trailing whitespace, and fixed url 2015-05-19 23:54:34 -04:00
Paul Faria
0362d254b8 Removing trailing whitespace 2015-05-19 23:54:31 -04:00
Paul Faria
31b709a7c2 Initial work on #6061. 2015-05-19 23:54:29 -04:00
bors-servo
c51e9f0455 Auto merge of #6131 - glennw:jquery-exit-fix, r=jdm
This fixes a hang found while testing the jQuery test suite.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6131)
<!-- Reviewable:end -->
2015-05-19 21:44:45 -05:00
bors-servo
e2b0922d42 Auto merge of #6084 - WriterOfAlicrow:radiobutton-fix, r=jdm
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6084)
<!-- Reviewable:end -->
2015-05-19 20:49:32 -05:00
Patrick Walton
7d9eda916b script: Implement the color attribute of the <font> element.
Improves Hacker News.
2015-05-19 16:31:20 -07:00
Patrick Walton
72f031e2a1 layout: Support inline incremental reflow, and stop reconstructing all
flows when mousing over the document.

This exposes more "jumpiness" on sites like Hacker News, but the bug
that causes it was pre-existing.
2015-05-19 11:08:27 -07:00
Glenn Watson
35a570ab66 Fix several hangs / panics during pipeline cleanup of in progress loads.
This fixes a hang found while testing the jQuery test suite.
2015-05-19 16:14:25 +10:00
bors-servo
0f1f71b56f Auto merge of #6064 - nox:characterdata-overflow, r=Ms2ger
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6064)
<!-- Reviewable:end -->
2015-05-17 13:40:30 -05:00
Keith Yeung
ea2bc0023b Made open event in WebScoket not cancelable (fixes #6101) 2015-05-18 00:35:23 +08:00
bors-servo
9f2079f6ba Auto merge of #6067 - Jinwoo-Song:backgroundclip, r=pcwalton
This property determines the background painting area, which determines the area
within which the background is painted.

Spec: http://dev.w3.org/csswg/css-backgrounds-3/#background-clip

Fixes #6066.

r? @pcwalton 
cc @yichoi

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6067)
<!-- Reviewable:end -->
2015-05-15 22:05:05 -05:00
WriterOfAlicrow
11a4aac2a2 fixup! Fix for Issue #6073 2015-05-15 23:04:15 -04:00
WriterOfAlicrow
85c88c707f Fix for Issue #6073 2015-05-15 22:44:10 -04:00
Jinwoo Song
a51d5de860 Implement 'background-clip' property in CSS3 Background
This property determines the background painting area, which determines the area
within which the background is painted.

Spec: http://dev.w3.org/csswg/css-backgrounds-3/#background-clip

Fixes #6066.
2015-05-16 09:43:46 +09:00
bors-servo
65c30224a1 Auto merge of #6043 - mukilan:get_root_element, r=Ms2ger
The [current implementation](http://mxr.mozilla.org/servo/source/components/script/dom/element.rs#666) is wrong as it always tries to cast the furthest ancestor into an element.
When the method is invoked on an element that is in the document tree, this will be the `Document` node, which is not an element. The ```last().map(ElementCast::to_temporary)``` returns Some(None) hence the method will return ```None```, while the correct behaviour is to return the ```html``` node.

This PR interprets the line ```"furthest ancestor element node of whatever node is being discussed"``` in the spec to mean ```"find the furthest ancestor that is an element node"```.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6043)
<!-- Reviewable:end -->
2015-05-15 03:35:37 -05:00
bors-servo
8c40272824 Auto merge of #6046 - Jinwoo-Song:background_origin, r=pcwalton
This property determines the background positioning area, that is the position of
the origin of an image specified using the 'background-image' CSS property.

'background-origin' is ignored when background-attachment is fixed.

Spec: http://dev.w3.org/csswg/css-backgrounds-3/#background-origin

Fixes #6045.

r? @pcwalton 
cc @yichoi

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6046)
<!-- Reviewable:end -->
2015-05-14 20:53:02 -05:00
Jinwoo Song
b1b22c0c53 Implement 'background-origin' property in CSS3 Background
This property determines the background positioning area, that is the position of
the origin of an image specified using the 'background-image' CSS property.

'background-origin' is ignored when background-attachment is fixed.

Spec: http://dev.w3.org/csswg/css-backgrounds-3/#background-origin

Fixes #6045.
2015-05-15 10:02:58 +09:00
Anthony Ramine
d0f62c7b73 Fix overflow in CharacterData 2015-05-15 01:59:59 +02:00
bors-servo
8faa9f877d Auto merge of #5902 - nox:length, r=jdm
Blocked by https://github.com/w3c/testharness.js/pull/124.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5902)
<!-- Reviewable:end -->
2015-05-14 13:37:10 -05:00
Anthony Ramine
d9619853e2 Fix length value of interface methods 2015-05-14 19:11:10 +02:00
Anthony Ramine
0e8bd5dd98 Partially implement getter of Document 2015-05-14 18:28:43 +02:00
Anthony Ramine
69220dfc10 Make HTMLFormElement name attribute use an atom 2015-05-14 18:28:42 +02:00
Anthony Ramine
70e67d5e11 Make HTMLImageElement name attribute use an atom 2015-05-14 18:28:40 +02:00
Anthony Ramine
b86672af0c Implement HTMLAppletElement.name 2015-05-14 18:28:39 +02:00
Anthony Ramine
2176aab642 Import string_cache::Atom into the attributes' macros 2015-05-14 18:28:38 +02:00
Mukilan Thiyagarajan
3c56c58e38 Fix implementation of Element::get_root_element 2015-05-14 18:22:28 +05:30
bors-servo
7bda431e61 Auto merge of #6044 - Ms2ger:cleanup, r=jdm
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6044)
<!-- Reviewable:end -->
2015-05-14 07:16:42 -05:00
Ms2ger
d84c3e7a30 Fix some overlong lines. 2015-05-14 13:26:13 +02:00
Ms2ger
40a91d6227 Use HTMLDataListElementCast in HTMLFormElement. 2015-05-14 13:11:49 +02:00
James Graham
50f59c8255 Add support for timing out scripts 2015-05-14 10:59:20 +01:00
James Graham
8d10fa1f2d Add basic support for executeAsyncScript.
This relies on a global webdriverCallback function, which is visible to content.
Obviously that's not a long term solution for a number of reasons, but it allows
us to experiment for now
2015-05-14 10:59:17 +01:00
Glenn Watson
2b3737d34e Various fixes for cleaning up iframes, compositor layers, pipelines and threads.
This allows most of the jquery test suite to run without exhausting thread resources.
2015-05-14 11:42:54 +10:00
bors-servo
398e7f07fe Auto merge of #6019 - Ms2ger:preshint-border, r=pcwalton
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6019)
<!-- Reviewable:end -->
2015-05-12 14:47:49 -05:00
Ms2ger
69f92596ca Move table border to the new infrastructure. 2015-05-12 14:18:58 +02:00
bors-servo
f4381a6f1e Auto merge of #6018 - Jinwoo-Song:select_attributes, r=Ms2ger
r? @jdm 
cc @yichoi

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6018)
<!-- Reviewable:end -->
2015-05-12 06:15:56 -05:00
Ms2ger
1b99fd7ecb Implement get_attr_for_layout that returns an AttrValue. 2015-05-12 13:02:50 +02:00
Ms2ger
9951e0b4d6 Parse table border. 2015-05-12 12:08:18 +02:00
Jinwoo Song
656a8ee3c8 Implement HTMLSelectElement.{multiple, name, size} (fixes #6017) 2015-05-12 16:22:36 +09:00
bors-servo
8fa604be9d Auto merge of #5988 - Ms2ger:preshints, r=pcwalton
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5988)
<!-- Reviewable:end -->
2015-05-12 02:15:11 -05:00
Ms2ger
8b0505930f Move textarea cols/rows to the new infrastructure. 2015-05-12 09:14:42 +02:00
Ms2ger
f571a69b2e Move table/td width to the new infrastructure. 2015-05-12 09:14:40 +02:00
bors-servo
10d8200a54 Auto merge of #6005 - Jinwoo-Song:button_name_value, r=jdm
Implemented getter and setter of the attributes.

r? @jdm 
cc @yichoi

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6005)
<!-- Reviewable:end -->
2015-05-11 21:27:10 -05:00
Jinwoo Song
94c3077edc Implement name and value attributes of HTMLButtonElement (fixes #6003)
Implemented getter and setter of the attributes.
2015-05-12 09:52:25 +09:00
Ms2ger
0c8e55bff1 Move input size to the new infrastructure. 2015-05-11 23:43:58 +02:00
Ms2ger
83f4b077eb Move table cellspacing to the new infrastructure. 2015-05-11 23:43:56 +02:00
bors-servo
2baa69595e Auto merge of #5804 - jdm:docloader, r=Ms2ger
This implements a simple load-tracking system and tracks stylesheet loads as an example of how it fits together. This is a simplified and rebased version of #3714; I do not believe that the main thrust of hsivonen's comments (related to tracking navigation in browsing contexts) affect this part of the work. 

r? @Ms2ger

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5804)
<!-- Reviewable:end -->
2015-05-11 14:35:33 -05:00
Josh Matthews
a1ae53a230 Delay stylesheet load in test to increase confidence. 2015-05-11 15:35:10 -04:00
Josh Matthews
f3cdba6b8b Make link elements fire a load event. 2015-05-11 13:41:52 -04:00