Manish Goregaokar
53e155e8ac
Cleanup treewalker
2015-08-18 18:37:10 +05:30
Manish Goregaokar
b21df4844c
Cleanup node.rs
2015-08-18 18:37:02 +05:30
Manish Goregaokar
94cd004c28
Cleanup script_task
2015-08-18 18:35:47 +05:30
Ms2ger
a9671550ff
Update js.
2015-08-18 12:21:03 +02:00
bors-servo
0d6d6a0500
Auto merge of #7257 - jxs:master, r=Ms2ger
...
Replace uses of `for foo in bar.iter()`,
and `for foo in bar.iter_mut(), and for foo in bar.into_iter()
(continuation of #7197 )
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7257 )
<!-- Reviewable:end -->
2015-08-18 02:46:46 -06:00
bors-servo
f340900c38
Auto merge of #7246 - glennw:platform-ua, r=larsbergstrom
...
Add a simple method to emulate a platform UA (e.g. pretend a desktop build is an android UA).
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7246 )
<!-- Reviewable:end -->
2015-08-17 22:44:38 -06:00
Glenn Watson
6d9fccbae7
Add a simple method to emulate a platform UA (e.g. pretend a desktop build is an android UA).
2015-08-18 14:42:28 +10:00
João Oliveira
067a22a868
Replace uses of for foo in bar.iter(),
...
and `for foo in bar.iter_mut(), and for foo in bar.into_iter()
(continuation of #7197 )
2015-08-18 01:46:11 +01:00
Nicholas Nethercote
97e3b24aa6
Fix panics in the script_task memory reporter.
...
These are caused by page_root being empty.
2015-08-17 04:37:43 -07:00
bors-servo
71ae18bae4
Auto merge of #7219 - vectorijk:issue#7042, r=Ms2ger
...
remove unused static collection type in htmlcollection.rs
ref #7042
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7219 )
<!-- Reviewable:end -->
2015-08-17 02:03:23 -06:00
wartman4404
8d665008f8
Remove the DOMRefCell wrapper around Window::compositor.
2015-08-16 17:28:21 -05:00
vectorijk
59d704b53f
turn enum into struct
...
pub enum CollectionTypeId -> pub struct Collection
2015-08-16 12:01:51 -07:00
vectorijk
d853aaba65
remove unused static collection
2015-08-16 11:38:22 -07:00
Josh Matthews
8bb853f643
Fix existing syntactics nits.
2015-08-16 10:30:43 -04:00
bors-servo
a2978f2add
Auto merge of #7236 - nox:dictionary-failure-code, r=Ms2ger
...
Fix dictionary member conversion failure (fixes #7231 )
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7236 )
<!-- Reviewable:end -->
2015-08-16 06:39:56 -06:00
Anthony Ramine
47e76ff4ab
Fix dictionary member conversion failure ( fixes #7231 )
2015-08-16 14:32:54 +02:00
vectorijk
270df6bac8
without the explicit dereferencing
2015-08-16 01:34:58 -07:00
vectorijk
7758f81ffd
dereference via * instead of RefMut
2015-08-16 01:34:57 -07:00
vectorijk
14ac1ef75a
remove ScriptListener
...
ref #7175
2015-08-16 01:34:55 -07:00
bors-servo
7c63c7d7c1
Auto merge of #7214 - tomjakubowski:websocket-binaryType, r=Ms2ger
...
Implement WebSocket#binaryType
Closes #7098
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7214 )
<!-- Reviewable:end -->
2015-08-15 19:57:58 -06:00
Tom Jakubowski
e92f4629db
WebSocket: Implement WebSocket#binaryType
2015-08-15 12:44:22 -07:00
bors-servo
55e755e35a
Auto merge of #7233 - nox:default-float-value, r=Ms2ger
...
Support default values for restricted float members (fixes #7217 )
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7233 )
<!-- Reviewable:end -->
2015-08-15 10:59:44 -06:00
bors-servo
31413f4313
Auto merge of #7188 - servo:set_inline_style_property_priority, r=nox
...
Fix Element::set_inline_style_property_priority’s handling of priority
Thanks to @michaelwu for pointing out a copy-paste error.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7188 )
<!-- Reviewable:end -->
2015-08-15 09:17:31 -06:00
Anthony Ramine
ec2a6b24b1
Support default values for restricted float members ( fixes #7217 )
2015-08-15 14:45:26 +02:00
bors-servo
6a52ec9484
Auto merge of #7006 - Wafflespeanut:script_cleanup, r=jdm
...
Splitting ScriptMsg into various enums...
... for #3734 , which is also one of the oldest issues. (/cc @jdm)
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7006 )
<!-- Reviewable:end -->
2015-08-15 03:48:47 -06:00
João Oliveira
0038580abf
Replace uses of for foo in bar.iter() and for foo in bar.iter_mut()
...
closes #7197
2015-08-15 02:27:39 +01:00
Ravi Shankar
89153116fb
Splitting ScriptMsg into various enums; r=jdm
2015-08-15 02:00:48 +05:30
João Oliveira
9c11781880
replace .len() == 0 with is_empty()
...
closes #7198
2015-08-14 04:00:33 +01:00
bors-servo
2e1ca10eea
Auto merge of #7199 - frewsxcv:codegen-if-let, r=Manishearth
...
Prefer if..let over if..is_some..unwrap in codegen
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7199 )
<!-- Reviewable:end -->
2015-08-13 15:35:21 -06:00
bors-servo
289decb064
Auto merge of #7196 - frewsxcv:double-unsafe, r=jdm
...
Avoid marking codegen method bodies as unsafe twice
`CGAbstractMethod` takes a couple boolean parameters, among others:
* `extern`: will mark the method as `unsafe` and `extern`
* `unsafe`: will wrap the method body in an `unsafe` block
Passing both as `True` should not mark it as `unsafe` twice.
Example from a generated `HTMLCollectionBinding.rs`:
Before:
```
unsafe extern fn get_length(..) -> u8 {
unsafe {
// code here
}
}
```
After
```
unsafe extern fn get_length(..) -> u8 {
// code here
}
```
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7196 )
<!-- Reviewable:end -->
2015-08-13 15:00:37 -06:00
Corey Farwell
43429abce4
Avoid marking codegen method bodies as unsafe twice
...
`CGAbstractMethod` takes a couple boolean parameters, among others:
* `extern`: will mark the method as `unsafe` and `extern`
* `unsafe`: will wrap the method body in an `unsafe` block
Passing both as `True` should not mark it as `unsafe` twice.
Example from a generated `HTMLCollectionBinding.rs`:
Before:
```
unsafe extern fn get_length(..) -> u8 {
unsafe {
// code here
}
}
```
After
```
unsafe extern fn get_length(..) -> u8 {
// code here
}
```
2015-08-13 16:50:17 -04:00
Corey Farwell
7a774a198c
Prefer if..let over if..is_some..unwrap in codegen
2015-08-13 16:35:21 -04:00
bors-servo
42d74324e2
Auto merge of #7190 - Ms2ger:node-clone, r=jdm
...
Correct the default value for Node#cloneNode's deep argument.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7190 )
<!-- Reviewable:end -->
2015-08-13 13:51:06 -06:00
bors-servo
a03616f379
Auto merge of #7097 - boghison:memtypes, r=jdm
...
Measure heap memory usage for more types. Fixes #6951
Also adds HeapSizeOf implementations/derive for some types. I've used "Cannot calculate Heap size" as a reason everywhere, because my imagination is rather limited. If you'd like me to change this message for specific types, please write something like this: "Trusted - Cannot calculate Heap size for Trusted" so that it would be easier for me to replace them through a script :)
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7097 )
<!-- Reviewable:end -->
2015-08-13 13:16:14 -06:00
Bogdan Cuza
45145108da
Measure heap memory usage for more types. Fixes #6951
2015-08-13 21:44:41 +03:00
bors-servo
f3b7c5cb4b
Auto merge of #7132 - jdm:docenum, r=ms2ger
...
Document the use and meaning of the devtools control messages. Fixes …
…#6922.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7132 )
<!-- Reviewable:end -->
2015-08-13 12:41:48 -06:00
Josh Matthews
820c74649b
Improve documentation for devtools messages a bit more.
2015-08-13 13:44:54 -04:00
Simon Sapin
39ce15f20d
Fix Element::set_inline_style_property_priority’s handling of priority
...
Thanks to mwu for pointing out a copy-paste error.
2015-08-13 17:07:17 +02:00
Ms2ger
c007b66d97
Correct the default value for Node#cloneNode's deep argument.
2015-08-13 12:12:45 +02:00
Ms2ger
f62e7be168
Merge the fragment handling into handle_navigate.
...
This is handled in the 'navigate' algorithm in the specification.
2015-08-12 20:03:18 +02:00
Ms2ger
2cdc043fcf
Remove ScriptControlChan.
2015-08-12 16:24:09 +02:00
Ms2ger
4f9ec8915d
Store a Sender<ConstellationControlMsg> in ScriptReflow.
2015-08-12 15:47:35 +02:00
Ms2ger
41ac66112a
Store a Sender<ConstellationControlMsg> in Window.
2015-08-12 15:34:41 +02:00
Ms2ger
26d191f068
Remove the unused Window::control_chan() method.
2015-08-12 15:32:30 +02:00
Ms2ger
c05f0906d5
Store a Sender<ConstellationControlMsg> in ScriptTask.
2015-08-12 15:25:31 +02:00
Josh Matthews
aac53344b8
fixup! Simplify devtools frame marker notification. Record each frame tick based on a single message sent from the script task that ticked.
2015-08-12 09:05:05 -04:00
Josh Matthews
e59de75608
Simplify devtools frame marker notification. Record each frame tick based on a single message sent from the script task that ticked.
2015-08-12 00:59:58 -04:00
bors-servo
0c5158587d
Auto merge of #6757 - mskrzypkows:document_hasFocus, r=jdm
...
Implementing document.hasFocus method, needs tests. #6475
I'm not sure if I have to implement some test for a new document method. As I remember there were tests for document methods, is it changed now? Where should I add tests?
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6757 )
<!-- Reviewable:end -->
2015-08-11 15:35:21 -06:00
bors-servo
d9925f5f92
Auto merge of #7104 - dzbarsky:add_color_stop, r=Ms2ger
...
CanvasGradient#addColorStop should throw for invalid colors and offsets
The new test failure is because the color stop has a value of 'currentColor' which we don't support yet.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7104 )
<!-- Reviewable:end -->
2015-08-11 06:24:35 -06:00
David Zbarsky
a3ee46fc9c
Make CSSStyleDeclaration setters rethrow errors instead of unwrapping and crashing.
2015-08-11 00:34:41 -04:00
