Commit graph

20225 commits

Author SHA1 Message Date
bors-servo
d2db39634e Auto merge of #11746 - DarinM223:master, r=mbrubeck
Image with height defined in % resizes properly

<!-- Please describe your changes on the following line: -->

Checked the html in the github issue and the image looks like it is resized properly in Servo.
Fixed image resizing when height is specified in percentages.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11723  (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because this issue is marked with has-test?

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11746)
<!-- Reviewable:end -->
2016-06-16 03:57:38 -05:00
bors-servo
c164a2e41c Auto merge of #11758 - mskrzypkows:construct, r=SimonSapin
Small performance improvement

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

node.selection() is not used when text_content is equal to
TextContent::GeneratedContent(content_items)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11758)
<!-- Reviewable:end -->
2016-06-16 02:12:15 -05:00
Maciej Skrzypkowski
27b05c58f6 Small performance improvement
node.selection() is not used text_content is equal to 
TextContent::GeneratedContent(content_items)
2016-06-16 08:58:03 +02:00
jmr0
2bff131535 Implement non-visible pipeline and iframe visibility methods 2016-06-15 23:28:07 -04:00
Darin Minamoto
4a4be1d7e5 Image with height defined in % resizes properly 2016-06-15 16:39:22 -07:00
Ravi Shankar
dfe32b0ada Removed unused function and minor cleanup 2016-06-16 00:07:21 +05:30
bors-servo
033786cd0d Auto merge of #11749 - asajeffrey:constellation-failing-failure, r=glennw
Check to see if about:failure failed.

<!-- Please describe your changes on the following line: -->
Check to see if about:failure is failing,

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11747
- [X] These changes do not require tests because we're not testing panic recovery

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11749)
<!-- Reviewable:end -->
2016-06-15 07:19:08 -05:00
Alan Jeffrey
5109ece29a Check to see if about:failure failed. 2016-06-15 06:39:53 -05:00
Emilio Cobos Álvarez
fa6dd1d61b
stylo: Support the rest of the background-xxx P1 properties.
We do the same that with background-{image, repeat}, we just use the first
element until servo can parse and use a list efficiently.
2016-06-15 11:49:57 +02:00
bors-servo
2086d216dd Auto merge of #11697 - mrmiywj:form-index-getter, r=Ms2ger
indexed getter of form elements

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11405 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11697)
<!-- Reviewable:end -->
2016-06-15 01:10:49 -05:00
mrmiywj
4bb88432b2 indexed getter of form elements 2016-06-14 21:40:32 -07:00
bors-servo
bc2f4c3450 Auto merge of #11621 - h4xr:mach_fix, r=Wafflespeanut
Make mach test-tidy consider ignored dirs

Made changes so that mach test-tidy considers the ignored directories

Fixes #11386

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11621)
<!-- Reviewable:end -->
2016-06-14 23:33:52 -05:00
Saurabh Badhwar
28312d0e17 Make mach consider ignored dirs
Address indentation changes
2016-06-15 09:58:04 +05:30
bors-servo
40e2b7d674 Auto merge of #11745 - servo:rustup, r=mbrubeck
Update to rustc 2016-06-14.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11745)
<!-- Reviewable:end -->
2016-06-14 18:32:37 -05:00
Ms2ger
0addbe36b0 Update to rustc 2016-06-14. 2016-06-15 00:27:36 +01:00
Emilio Cobos Álvarez
4af508afca
webgl: Unlock WebRender by default by adding a readback based fallback to WebGL context creation.
This should give us the chance to use WebRender by default in OSX.
2016-06-15 01:01:54 +02:00
Per Lundberg
22fddac3ad Added detection for case-sensitive file systems
This is needed for the moment because of a bug in virtualenv (reported upstream).
2016-06-14 20:24:06 +03:00
bors-servo
0cfae3a3e7 Auto merge of #11717 - izgzhen:filepicker, r=Manishearth
Add filepicker

Add file picker based on tinyfiledialog to the file manager implementation.

Changes:
- [x] Add the picker invocation code
- [x] Rewrite unit test to accommodate the change
- [x] Patch up `htmlinputelement` to make things work

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes are related to #11131.

<!-- Either: -->
- [x] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11717)
<!-- Reviewable:end -->
2016-06-14 07:27:47 -05:00
Zhen Zhang
256c7e894e filepicker 2016-06-14 20:22:51 +08:00
bors-servo
ebf412a2aa Auto merge of #11738 - Ms2ger:abspos, r=KiChjang
Disable transform-abspos-{002,007}.htm.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11738)
<!-- Reviewable:end -->
2016-06-13 17:10:13 -05:00
Ms2ger
6e38023042 Disable transform-abspos-{002,007}.htm. 2016-06-13 15:44:30 +01:00
bors-servo
e0772c59a6 Auto merge of #11737 - Ms2ger:init-data, r=pcwalton
Move the initialize_data method out of the TNode trait.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11737)
<!-- Reviewable:end -->
2016-06-13 09:21:45 -05:00
Ms2ger
e723d72570 Move the initialize_data method out of the TNode trait.
This reduces the dependency of TNode implementations on layout types.
2016-06-13 15:21:29 +01:00
Ms2ger
ae5cb0ceb0 Move the TNode::initialize_data() call from recalc_style_at to its callers.
This will allow us to make it an inherent method.
2016-06-13 15:11:21 +01:00
bors-servo
e32b2c9ddf Auto merge of #11736 - Ms2ger:detransmute, r=jdm
Use Ref/RefMut::map rather than transmute for ServoLayoutNode.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11736)
<!-- Reviewable:end -->
2016-06-13 06:31:57 -05:00
Ms2ger
172aa226cc Use Ref/RefMut::map rather than transmute for ServoLayoutNode. 2016-06-13 12:29:14 +01:00
bors-servo
4f1837e9ab Auto merge of #11715 - pcwalton:wr-overscroll-event-targeting-fix, r=glennw
compositor: Rerequest scroll positions from WebRender while overscrolled layers are bouncing back.

This fixes a very annoying issue whereby overscrolling would cause mouse
events to go to the wrong place until the layer was scrolled again.

r? @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11715)
<!-- Reviewable:end -->
2016-06-13 01:03:48 -05:00
bors-servo
df4693489d Auto merge of #11734 - DarinM223:master, r=Ms2ger
Replace RefCell in SCRIPT_THREAD_ROOT with Cell

<!-- Please describe your changes on the following line: -->
Replaced RefCell usage in SCRIPT_THREAD_ROOT with Cell.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes fix #11732  (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it is refactoring existing code

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11734)
<!-- Reviewable:end -->
2016-06-12 20:29:47 -05:00
Darin Minamoto
a158e478b8 Replace RefCell in SCRIPT_THREAD_ROOT with Cell 2016-06-12 18:16:08 -07:00
bors-servo
b5115fc895 Auto merge of #11696 - mrmiywj:rename-to-less-repetitive, r=ConnorGBrewster
use less repetitive name

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11689  (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because just renaming

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11696)
<!-- Reviewable:end -->
2016-06-12 14:47:02 -05:00
bors-servo
0b2cc910d4 Auto merge of #11666 - asajeffrey:cross-origin-parentage-test, r=ConnorGBrewster
Added tests for cross-origin iframe parentage.

<!-- Please describe your changes on the following line: -->
Added (currently failing) tests for cross-origin iframe parentage.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11478
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11666)
<!-- Reviewable:end -->
2016-06-12 09:54:51 -05:00
bors-servo
7f4fe45639 Auto merge of #11718 - perlun:patch-3, r=metajack
Removed reference to update-core

It's `pacman -Su` nowadays, per https://github.com/Alexpux/MSYS2-pacman/pull/26.

(This is a very selective cherry-pick of #11392. The other parts were more controversial; they didn't fully work so let's disregard them for now.)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11718)
<!-- Reviewable:end -->
2016-06-12 06:47:29 -05:00
bors-servo
278c1a7da7 Auto merge of #11720 - canaltinova:sandbox, r=nox
Fix the type of HTMLIFrameElement.sandbox

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11598 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11720)
<!-- Reviewable:end -->
2016-06-11 23:40:11 -05:00
mrmiywj
46cadfdd2c use less repetitive name 2016-06-12 12:28:07 +08:00
bors-servo
0c11e8340b Auto merge of #11556 - Manishearth:make-fetch-happen, r=jdm
Make fetch happen

<!-- Please describe your changes on the following line: -->
Moves XHR over to the fetch backend.

Previous PR: https://github.com/servo/servo/pull/114

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors (Will fix later)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11556)
<!-- Reviewable:end -->
2016-06-11 19:30:28 -05:00
bors-servo
3fa0dca3a3 Auto merge of #11700 - Ms2ger:assert, r=jdm
Remove an invalid assertion in fire_timer.

It's not clear to me if this is something we should expect to happen, but it
does indeed happen, so we should disable the assertion while we investigate.

Fixes #9984.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11700)
<!-- Reviewable:end -->
2016-06-11 18:42:53 -05:00
bors-servo
90a8aba853 Auto merge of #11690 - asajeffrey:navigation-history-spec-tests, r=ConnorGBrewster
Added test for whether only fully active documents contribute to the joint session history

<!-- Please describe your changes on the following line: -->
The spec https://html.spec.whatwg.org/multipage/#joint-session-history says that only fully active documents contribute to the joint session history, but this appears not to be what's implemented.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11690)
<!-- Reviewable:end -->
2016-06-11 16:08:58 -05:00
bors-servo
2d93380855 Auto merge of #11680 - pcwalton:wr-overflow-scroll-hit-testing, r=jdm
script: When using WebRender, keep the DOM-side scroll positions for elements with `overflow: scroll` up to date, and take them into account when doing hit testing.

Closes #11648.

r? @jdm
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11680)
<!-- Reviewable:end -->
2016-06-11 11:01:36 -05:00
Manish Goregaokar
9deecd793c
Review fixes 2016-06-11 11:49:40 +05:30
Patrick Walton
041cfe6d0a script: When using WebRender, keep the DOM-side scroll positions for
elements with `overflow: scroll` up to date, and take them into account
when doing hit testing.

Closes #11648.
2016-06-10 18:43:04 -07:00
Nazım Can Altınova
47984a52c6 Add Sandbox field to HTMLIFrameElement 2016-06-11 01:59:59 +03:00
Patrick Walton
8c5b7ff330 compositor: Rerequest scroll positions from WebRender while overscrolled
layers are bouncing back.

This fixes a very annoying issue whereby overscrolling would cause mouse
events to go to the wrong place until the layer was scrolled again.
2016-06-10 15:56:57 -07:00
Nazım Can Altınova
41230fe03d Change sandbox to sandbox_allowance in HTMLIFrameElement 2016-06-11 01:24:20 +03:00
bors-servo
ce88b8ed30 Auto merge of #11702 - nox:fonts, r=metajack
Don't load all font faces sources

We stop at the first one we manage to load.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11702)
<!-- Reviewable:end -->
2016-06-10 14:52:55 -05:00
Anthony Ramine
b97c7a8c4d Don't load all font faces sources
We stop at the first one we manage to load.
2016-06-10 21:51:06 +02:00
Per Lundberg
b888f895d7 Removed reference to update-core
It's `pacman -Su` nowadays, per https://github.com/Alexpux/MSYS2-pacman/pull/26.

(This is a very selective cherry-pick of #11392. The other parts were more controversial; they didn't fully work so let's disregard them for now.)
2016-06-10 22:22:03 +03:00
bors-servo
08a55e2951 Auto merge of #11214 - farodin91:windowproxy, r=jdm
Support WindowProxy return values in bindings

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy --faster` does not report any errors
- [x] These changes fix #10965 (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11214)
<!-- Reviewable:end -->
2016-06-10 10:53:35 -05:00
Manish Goregaokar
8b9479f8bf Make send-usp tests less timeout-prone 2016-06-10 20:55:32 +05:30
Manish Goregaokar
fd6f9bd411 Test fixes; update for changes in spec 2016-06-10 20:55:25 +05:30
Manish Goregaokar
f4e3e8e38e Re-support gzip 2016-06-10 20:53:47 +05:30