Commit graph

7545 commits

Author SHA1 Message Date
Anthony Ramine
5a206d5137 Make validate_framebuffer return a WebGLResult<()> 2018-09-06 11:25:22 +02:00
Anthony Ramine
0579fbe4fa Use WebGLResult for returns of instanced draw methods 2018-09-06 10:41:58 +02:00
bors-servo
162826d6a9
Auto merge of #21583 - AgustinCB:add-task-source-name, r=jdm
Add task source name

Refactor `CommonScriptMsg::Task` to include `TaskSourceName`.

Sorry for the delay, between doing this after work and the time I spent trying to ramp up on the project, it took me a bit longer than I expected.

Test still don't pass in local, but they fail the same way on master, so I guess it's ok.

I may have forgotten something, I refactored mostly the stuff that the compiler complained about. Please let me know if I missed anything.

I tried to dump my thought process on the commit messages, so feel free to go commit by commit to understand context.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21527

- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it's mostly refactor, no new behavior added.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21583)
<!-- Reviewable:end -->
2018-09-04 14:17:33 -04:00
bors-servo
02c689625b
Auto merge of #21601 - servo:descobj, r=jdm
Properly set desc.obj in CodegenRust.py (fixes #11868)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21601)
<!-- Reviewable:end -->
2018-09-04 09:24:39 -04:00
Agustin Chiappe Berrini
e286fdcc53 Add the TaskSourceName to CommonScriptMsg::Task
Update QueuedTaskConversion and the TaskQueue to use it
2018-09-04 09:17:11 -04:00
Anthony Ramine
baa94702e4 Properly set desc.obj in CodegenRust.py (fixes #11868) 2018-09-04 13:57:10 +02:00
bors-servo
81f6ac8f92
Auto merge of #21591 - Manishearth:channelmergernode, r=ferjm
Implement ChannelMergerNode

partial https://github.com/servo/servo/issues/21558

Haven't yet tested, wanted to get this up as an example for https://github.com/servo/servo/issues/21558

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21591)
<!-- Reviewable:end -->
2018-09-04 02:38:08 -04:00
Manish Goregaokar
af5b1c4011 Add createChannelMerger() 2018-09-04 11:23:00 +05:30
Manish Goregaokar
28c21421ca Throw on out-of-bounds channelCount in AudioNodes 2018-09-03 20:31:52 +05:30
Manish Goregaokar
03d6fb18da Add ChannelMergerNode 2018-09-03 20:07:02 +05:30
Manish Goregaokar
91b8cbe1db Allow overriding GainNode's settings from the constructor 2018-09-03 18:51:03 +05:30
Emilio Cobos Álvarez
5d8545d2b4
Fix other parts of the Servo build. 2018-09-03 13:09:10 +02:00
nupurbaghel
b1adf8ee8a correct failing tests 2018-09-01 08:49:50 +00:00
nupurbaghel
d7cb68cb84 correct currentSrc function 2018-09-01 08:49:49 +00:00
Manish Goregaokar
303b62ae8d Throw errors for invalid values in panner node constructor 2018-08-31 05:27:59 -07:00
bors-servo
1ee3deea27
Auto merge of #21388 - gterzian:introduce_task_queues, r=jdm
Introduce task queues, and throttling performance timeline tasksource

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #19997 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21388)
<!-- Reviewable:end -->
2018-08-30 14:56:26 -04:00
Gregory Terzian
029715aba6 introduce a generic worker event-loop 2018-08-31 02:10:45 +08:00
Gregory Terzian
ca6306c430 introduce task-queues, and throttling the performance-timeline task-source, in script and worker threads.
queue
2018-08-31 02:10:34 +08:00
bors-servo
6f81ed49f6
Auto merge of #21523 - servo:webgl, r=avadacatavra,jdm
Some more drive-by WebGL fixes and cleanups

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21523)
<!-- Reviewable:end -->
2018-08-30 12:23:31 -04:00
Anthony Ramine
900a19058e Support unions of objects in overloads
Part of #20513, implementing the parts useful for WebGL.
2018-08-30 16:15:40 +02:00
Anthony Ramine
4cf944eab8 Fix gl.isBuffer for buffers that are marked for deletion but still attached 2018-08-30 16:15:39 +02:00
Anthony Ramine
7b673de4d6 Always emit INVALID_OPERATION on null element buffers in drawElements 2018-08-30 16:15:39 +02:00
Anthony Ramine
83e27e4167 Remove WebGLRenderingContext.STENCIL_INDEX 2018-08-30 16:15:38 +02:00
Anthony Ramine
7f9d560f28 Allow binding the null buffer in vertexAttribPointer if offset is 0 2018-08-30 16:15:38 +02:00
Anthony Ramine
0ba66f9f12 Fix the error for invalid arrays passed to gl.vertexAttrib*v() 2018-08-30 16:15:38 +02:00
Anthony Ramine
cb2f83cf8e Fix Drop assertion for WebGLBuffer
A buffer that is dropped may not have been marked for deletion but it
must not be attached to any VAO.
2018-08-29 02:05:49 +02:00
Simon Sapin
a6dcfdcd55 Upgrade to rustc 1.30.0-nightly (721913067 2018-08-26) 2018-08-27 10:47:49 +02:00
Gregory Terzian
7b8d903d57 fire error when placeholder image is loaded 2018-08-26 19:06:16 +08:00
bors-servo
f2306c8e19
Auto merge of #21516 - servo:bindgenup, r=SimonSapin
Update bindgen to 0.39.0

This fixes a build error for i686-linux-android with some versions of libclang:

```rust
error[E0560]: struct `generated::root::JS::Value` has no field named `__bindgen_align`sys
  --> /home/simon/projects/mozjs/src/jsval.rs:83:2
   |
83 |     __bindgen_align: [],
   |     ^^^^^^^^^^^^^^^ `generated::root::JS::Value` does not have this field
   |
   = note: available fields are: `data`

error: aborting due to previous error
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21516)
<!-- Reviewable:end -->
2018-08-24 20:50:44 -04:00
bors-servo
d827370804
Auto merge of #21502 - Manishearth:listener, r=ferjm
Add AudioListener/AudioPanner DOM interfaces

Seems to work.

I'll need some changes to the servo-media side to support the panner
node getters as well as the older `setPosition()`/etc APIs. I'll get to
those later.

r? @ferjm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21502)
<!-- Reviewable:end -->
2018-08-24 19:13:05 -04:00
Manish Goregaokar
5dd830344b Handle channel count constraints in panner constructor 2018-08-24 12:51:37 -07:00
Manish Goregaokar
58176c4148 Add some checks in PannerNode accessors 2018-08-24 12:51:37 -07:00
Manish Goregaokar
18960b6c94 Add PannerNode.setPosition(), setOrientation() 2018-08-24 12:22:19 -07:00
Manish Goregaokar
7daec55010 Add accessors for PannerNode 2018-08-24 12:22:19 -07:00
Manish Goregaokar
7d5b4b204c Add constraints for PannerNode 2018-08-24 12:22:19 -07:00
Manish Goregaokar
062c1d6071 Add BaseAudioContext.createPanner() 2018-08-24 12:22:19 -07:00
Manish Goregaokar
43ea9e0e4a cleanup: Remove Rc from BaseAudioContext 2018-08-24 12:22:19 -07:00
Manish Goregaokar
e4e01a6452 Add PannerNode DOM interface 2018-08-24 12:22:19 -07:00
Simon Sapin
bcc1b25fd9 Update bindgen to 0.39.0
This fixes a build error for i686-linux-android with some versions of libclang:

```
error[E0560]: struct `generated::root::JS::Value` has no field named `__bindgen_align`sys
  --> /home/simon/projects/mozjs/src/jsval.rs:83:2
   |
83 |     __bindgen_align: [],
   |     ^^^^^^^^^^^^^^^ `generated::root::JS::Value` does not have this field
   |
   = note: available fields are: `data`

error: aborting due to previous error
```
2018-08-24 20:22:27 +02:00
Simon Sapin
1333b6ee45 Fix the build for NLL
Test with `RUSTFLAGS="-Zborrowck=mir -Ztwo-phase-borrows" cargo build`

https://internals.rust-lang.org/t/help-us-get-non-lexical-lifetimes-nll-over-the-finish-line/7807/7
2018-08-24 17:49:58 +02:00
Manish Goregaokar
9228ca3a02 Add AudioListener DOM interface 2018-08-24 08:33:22 -07:00
Manish Goregaokar
4b48cfa3ec Upgrade to latest servo-media 2018-08-23 13:33:40 -07:00
bors-servo
a1abdde8c6
Auto merge of #21341 - servo:webgl, r=avadacatavra
Properly check limit in gl.activeTexture()

Fixes #20531.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21341)
<!-- Reviewable:end -->
2018-08-23 09:16:56 -04:00
Anthony Ramine
8b1c753c6c Properly check limit in gl.activeTexture() 2018-08-23 15:15:33 +02:00
bors-servo
aac4a3485f
Auto merge of #21430 - Eijebong:ws-origin, r=jdm
Properly set the origin on websocket messages

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21430)
<!-- Reviewable:end -->
2018-08-22 15:53:26 -04:00
Alan Jeffrey
74c1e00d81 Upgraded to SM 60 2018-08-20 18:22:29 -04:00
Bastien Orivel
a1925aab52 Properly set the origin on websocket messages 2018-08-16 16:53:38 +02:00
bors-servo
3ccfc288de
Auto merge of #21394 - servo:jdm-patch-6, r=cbrewster
Remove unnecessary CEReactions.

This incorporates a spec update in https://github.com/whatwg/html/pull/3901.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21394)
<!-- Reviewable:end -->
2018-08-15 00:04:13 -04:00
bors-servo
bc82521eb7
Auto merge of #21372 - Eijebong:num-traits, r=jdm
Dedupe num-traits

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21372)
<!-- Reviewable:end -->
2018-08-14 11:09:46 -04:00
Josh Matthews
6d3ff9f742
Remove unnecessary CEReactions.
This incorporates a spec update in https://github.com/whatwg/html/pull/3901.
2018-08-13 11:16:46 -04:00