Ms2ger
19e44362e2
Cleanup Node::ChildNodes.
2014-12-08 12:13:17 +01:00
Ms2ger
91c43ac18d
Cleanup Node::clone.
2014-12-08 12:09:58 +01:00
Ms2ger
1611b8d0a8
Cleanup Node::summarize.
2014-12-08 12:03:12 +01:00
Ms2ger
54c0601950
Cleanup Node::query_selector.
2014-12-08 11:58:59 +01:00
bors-servo
ea907c1311
auto merge of #4266 : Ms2ger/servo/js-document-crash, r=Manishearth
...
This prevents a crash when the script in the javascript URL accesses the
document attribute.
2014-12-08 02:49:06 -07:00
bors-servo
bdb3a2538b
auto merge of #4257 : johnathan79717/servo/4008, r=jdm
...
This is a fix for issue #4008 .
2014-12-08 01:55:08 -07:00
Tetsuharu OHZEKI
71257e6604
Rename CanvasRenderTask -> CanvasPaintTask.
2014-12-08 14:01:07 +09:00
Tetsuharu OHZEKI
062854b164
Rename canvas_render_task -> canvas_paint_task
2014-12-08 11:46:43 +09:00
Emanuel Rylke
b5e7cba598
Fix bug of TextInput.adjust_horizontal causing stack overflow or wraparound
...
When the edit_point is in the first position of a multiline TextInput
adjust_horizontal(-1) moves the edit_point to the end of the first line.
When the first line is empty this causes a stack overflow. When the edit_point
is in the last position adjust_horizontal(1) causes a stack overflow.
2014-12-06 20:59:04 +01:00
bors-servo
c68e2af0a7
auto merge of #4263 : Ms2ger/servo/or_init, r=jdm
2014-12-06 08:01:06 -07:00
Ms2ger
f0ef1f97ad
Use or_init where appropriate.
2014-12-06 15:59:17 +01:00
Emanuel Rylke
f99c0e2c15
Implement Page(Up|Down) functionality for TextInput.
2014-12-06 15:34:37 +01:00
Emanuel Rylke
2ec16a0e88
Fix bug of TextInput.adjust_vertical(1) always moving to the end of text.
2014-12-06 15:34:37 +01:00
bors-servo
b805e74fef
auto merge of #4265 : ProgramFOX/servo/issue-4251, r=Ms2ger
...
Resolves #4251
2014-12-06 07:31:01 -07:00
Ms2ger
10e39161f7
Create the root frame before evaluating the javascript URL.
...
This prevents a crash when the script in the javascript URL accesses the
document attribute.
2014-12-06 15:04:37 +01:00
bors-servo
3eec780c00
auto merge of #4262 : tamird/servo/4261, r=jdm
...
`self` is never used, so there's no need for this to be a method.
Fixes #4261 . @jdm
2014-12-06 04:28:01 -07:00
bors-servo
19c69b1625
auto merge of #4002 : Manishearth/servo/activation, r=jdm
...
Still need to impl `Activatable` on all activatable elements. I'll probably push those changes to this PR, however they can be made separately as well.
2014-12-06 03:55:04 -07:00
Manish Goregaokar
5511e02a78
Add Comparable trait to js.rs; fixups
2014-12-06 02:51:52 -08:00
Ms2ger
6322b0bfab
Clarify the panic in get_uint_attribute.
2014-12-06 10:19:05 +01:00
Tamir Duberstein
b916974f78
should_move_clip_rect is a bare function
...
`self` is never used, so there's no need for this to be a method.
Fixes #4261 .
2014-12-05 20:11:02 -08:00
bors-servo
33836715a8
auto merge of #4254 : medopaw/servo/settimeout-on-sync-error, r=Manishearth
...
fix #4253
2014-12-05 20:13:02 -07:00
Manish Goregaokar
e7b3caa386
Add oninput/onchange so tests work
2014-12-05 18:49:34 -08:00
Manish Goregaokar
e7ac792ed6
Switch to NodeFlags (the footprint has not changed)
2014-12-05 18:34:53 -08:00
Manish Goregaokar
b20d7d89c1
Switch over to query_selector_iter
2014-12-05 18:34:52 -08:00
Manish Goregaokar
3ba4bba28b
Implement QuerySelectorIterator ( fixes #4082 )
2014-12-05 18:34:52 -08:00
Manish Goregaokar
a2f7e0fbd6
Address review comments
2014-12-05 18:34:51 -08:00
Manish Goregaokar
6482e313d6
Implement implicit form submission
2014-12-05 18:34:49 -08:00
Manish Goregaokar
c89ec3910f
Hook up synthetic click activation to script_task and <>.click()
2014-12-05 18:33:03 -08:00
Manish Goregaokar
e68119f82f
Move InputRadio to Activatable
2014-12-05 18:32:13 -08:00
Manish Goregaokar
a5180a473d
Refactor code for fetching radio siblings
2014-12-05 18:32:13 -08:00
Manish Goregaokar
14a6e54371
Move InputCheckbox to Activatable
2014-12-05 18:32:13 -08:00
Manish Goregaokar
d1547e3a7c
Move InputSubmit to Activatable
2014-12-05 18:32:13 -08:00
Manish Goregaokar
2ed9626f1a
Some reorganization of activation code:
...
- Make method name apply to trait implementor better (When a user agent is to run post-click activation steps on an element, it must run the activation behavior defined for that element)
- Mention invariants and conditions on authentic_click_activation
2014-12-05 18:32:12 -08:00
Manish Goregaokar
03207dea81
Hook up authentic click activation to the script task
2014-12-05 18:32:12 -08:00
Manish Goregaokar
ddfa0c7de7
Implement basic (unhooked) framework for element activation
2014-12-05 18:32:12 -08:00
Manish Goregaokar
c3fdd60adc
Add trusted setter to Event
2014-12-05 18:32:12 -08:00
Manish Goregaokar
e2376a64bf
Add stub Activatable trait
2014-12-05 18:32:11 -08:00
Manish Goregaokar
7d51a543d8
Implement form control mutability, rename FormOwner -> FormControl
2014-12-05 18:32:11 -08:00
Manish Goregaokar
2c2d741b1f
Split up the InputButton variant
2014-12-05 18:32:11 -08:00
Med0paW
dacd21ac52
Issue 4253 - Setting timeout on a sync XHR should throw InvalidAccessErr
2014-12-05 18:29:39 -08:00
bors-servo
d5c62ac2c4
auto merge of #4256 : ema-fox/servo/password_input, r=jdm
2014-12-05 17:13:05 -07:00
bors-servo
a369dcfa01
auto merge of #4152 : mttr/servo/textview, r=jdm
...
Fixes #3918
Can be tested in `tests/html/textarea.html`. Also implemented some content reflecting IDL attributes for HTMLTextAreaElement while I was in there.
There are some major problems with TextInput when Multiple is enabled that I haven't addressed here, but I'm prepared to open up a follow-up issue.
2014-12-05 16:25:07 -07:00
Jonathan Hao
ccb4e8b273
Implement the "messageevent" argument to Document#createEvent. #4008
2014-12-05 13:54:07 -08:00
Emanuel Rylke
1ecbe021ff
Make the password input element show the correct number of dots for multibyte chars.
2014-12-05 22:03:02 +01:00
Matthew Rasmus
c97a4d999e
Handle default uint attributes properly
...
...and passing a whole bunch of new tests.
2014-12-05 12:31:32 -08:00
Matthew Rasmus
f5bd8f830a
HTMLTextArea: Implements a dirty value flag
2014-12-05 12:31:31 -08:00
Matthew Rasmus
ed37b53a62
Updates WPT to expect newly passing tests
...
Addresses reviews
More review addressing
2014-12-05 12:31:31 -08:00
Matthew Rasmus
29241699fd
Implements multi line text input for TextArea
2014-12-05 12:21:31 -08:00
Matthew Rasmus
fd65b5f438
Implements some HTMLTextAreaElement attributes
...
These attributes all reflect their own related content values, with the
exception of defaultValue, which acts as an alias for its IDL
textContent attribute.
Many of these do have default values and constraints which are currently unimplemented.
2014-12-05 12:21:31 -08:00
ProgramFOX
e2e5536315
Use .clone() instead of.as_slice().to_string()
2014-12-05 21:12:20 +01:00
