Ms2ger
73b9925cc1
Remove a pointless clone() call.
2015-09-16 16:29:03 +02:00
Ms2ger
f4cf90f127
Remove an obsolete TODO comment.
2015-09-16 16:29:02 +02:00
Ms2ger
e85b1e4e89
Use an early return in dispatch_to_listeners.
2015-09-16 16:29:02 +02:00
Ms2ger
b7a0440f91
Emit markers for all events, not just UI events.
2015-09-16 16:29:01 +02:00
Ms2ger
6dab37c88c
Implement a global_object_for_reflector method.
2015-09-16 16:29:00 +02:00
Ms2ger
69ed59d78f
Remove the outdated no_move annotation from GlobalRoot.
2015-09-16 16:28:59 +02:00
Ms2ger
a85196398d
Return immediately from dispatch_to_listeners if propagation is stopped.
2015-09-16 16:28:58 +02:00
Ms2ger
af6bc108f3
Use early returns in dispatch_to_listeners.
2015-09-16 16:28:57 +02:00
Ms2ger
995cb21b48
Use if-let in dispatch_to_listeners, and simplify break conditions.
2015-09-16 16:28:56 +02:00
Ms2ger
a5925020ce
Avoid calling any listeners for events whose stop propagation flag is set prior to dispatching.
2015-09-16 16:28:31 +02:00
Ms2ger
b342dff07d
Add more assertions to dispatch_event.
2015-09-16 14:48:36 +02:00
bors-servo
6a12f00d6d
Auto merge of #7605 - nox:skew, r=mbrubeck
...
Implement "transform: skew()"
Thanks to @Jinwoo-Song for the original commit, which I just rebased and cleaned up. Fixes #6237 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7605 )
<!-- Reviewable:end -->
2015-09-16 06:31:48 -06:00
Ms2ger
76eea43c83
Factor out a dispatch_to_listeners function from dispatch_event.
2015-09-16 13:36:18 +02:00
Ms2ger
15717173ee
Reorder the code in dispatch_event a bit.
2015-09-16 13:36:17 +02:00
Ms2ger
9ddeec09c3
Remove outdated FIXME comment.
2015-09-16 13:36:17 +02:00
bors-servo
4935323ebf
Auto merge of #7623 - aidanhs:aphs-atomise-forwarded-events, r=nox
...
Match forwarded events as atoms, fixes #7495
Hopefully I understood the issue correctly...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7623 )
<!-- Reviewable:end -->
2015-09-15 12:11:11 -06:00
bors-servo
e3d36bfceb
Auto merge of #7631 - jxs:rewrite_uses_of_map, r=jdm
...
rewrite uses of map as if let
in the end only found this case as re-writable, am i missing some?
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7631 )
<!-- Reviewable:end -->
2015-09-14 21:31:53 -06:00
João Oliveira
832cfac747
rewrite uses of map as if let
...
closes #7580
2015-09-15 02:51:59 +01:00
bors-servo
25abe646f8
Auto merge of #7619 - frewsxcv:font-face, r=nox
...
Implement <font> 'face' attribute
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7619 )
<!-- Reviewable:end -->
2015-09-14 18:32:17 -06:00
Corey Farwell
3ae76f4e76
Implement <font> 'face' attribute
2015-09-14 20:24:52 -04:00
Aidan Hobson Sayers
d1fcbca3b1
Match forwarded events as atoms, fixes #7495
2015-09-14 14:16:33 +01:00
Ms2ger
9faa2de0fc
Use static atoms in some places.
2015-09-14 10:33:16 +02:00
Corey Farwell
768993f03f
Fix incorrect indentation
2015-09-13 23:17:38 -04:00
Ali Sabil
2e9d8a76d1
Use cached element ID in LayoutElement::get_id
2015-09-13 23:55:40 +02:00
Ali Sabil
ea655ada10
Cache the id
attribute on Element
2015-09-13 23:55:40 +02:00
Anthony Ramine
cba8856309
Fix Node::query_selector() and Node::query_selector_iter()
...
These should not find the root of the tree to start matching.
2015-09-13 23:40:24 +02:00
Anthony Ramine
650afc9d3e
Fix cloning of Element's attributes
...
No virtual method was invoked when copies of attributes were appended to
newly-cloned elements.
2015-09-13 23:40:24 +02:00
bors-servo
d5ee58caf2
Auto merge of #7606 - nox:move-typeid, r=jdm
...
Move the type_id fields to DOMClass
Cc @michaelwu.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7606 )
<!-- Reviewable:end -->
2015-09-13 11:53:42 -06:00
Anthony Ramine
c25085f68a
Introduce [Abstract] to mark non-leaf interfaces
...
Some interfaces like Node, CharacterData and HTMLTableCellElement are never
instantiated directly, only their descendant interfaces are. Those are marked
with [Abstract] to set their type_id to None instead of having dummy values
in the TypeId enums.
2015-09-13 19:46:28 +02:00
bors-servo
6a21bcd9c5
Auto merge of #7615 - frewsxcv:obsolete-link-anchor, r=nox
...
Add obsolete reflecting attributes on <a> and <link>
From my understanding, setting any of these will not affect any
presentational hints for the elements
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7615 )
<!-- Reviewable:end -->
2015-09-13 10:47:32 -06:00
bors-servo
e10c5c74cc
Auto merge of #7616 - Ms2ger:js-reflector, r=jdm
...
Stop implementing Reflectable for JS<T>.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7616 )
<!-- Reviewable:end -->
2015-09-13 09:20:25 -06:00
Ms2ger
3781567c19
Stop implementing Reflectable for JS<T> ( fixes #2285 ).
...
It's not generally safe to expose the contents of a JS<T>.
2015-09-13 16:47:12 +02:00
Ms2ger
ca5e7097a0
Stop requiring that the type argument to RootedVec implements Reflectable.
...
It is sufficient that it implements JSTraceable.
2015-09-13 16:43:28 +02:00
Corey Farwell
fdebd2ae2a
Add obsolete reflecting attributes on <a> and <link>
...
From my understanding, setting any of these will not affect any
presentational hints for the elements
2015-09-13 09:45:02 -04:00
Corey Farwell
cc8994422b
Fix a few incorrect Element interfaces
2015-09-13 08:02:51 -04:00
Corey Farwell
9331dc7bd1
Minor script::dom: 🪟 :Window cleanup
2015-09-12 15:03:18 +01:00
Michael Wu
941f7dc04b
Move EventTargetTypeId/NodeTypeId to DOMClass
2015-09-12 01:09:46 +02:00
Anthony Ramine
f11fcebd9c
Bump euclid to 0.2
2015-09-12 01:06:26 +02:00
Anthony Ramine
4dbf391e83
Fix NodeIterator.root attributes
...
It should be [SameObject].
2015-09-11 02:57:41 +02:00
Anthony Ramine
d93c8da7d7
Fix Element missing attributes
...
Attributes classList and attributes are [SameObject].
2015-09-11 02:57:24 +02:00
Anthony Ramine
42254bac7e
Fix ParentNode missing attributes
...
ParentNode.children is [SameObject], querySelectorAll() is [NewObject].
2015-09-11 02:57:02 +02:00
Anthony Ramine
a33e5f9179
Fix Node.childNodes attributes
2015-09-11 02:56:45 +02:00
bors-servo
4c64c870c6
Auto merge of #7592 - nox:nonelementparentnode, r=jdm
...
Introduce NonElementParentNode
This is the interface where Document.getElementById() belong.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7592 )
<!-- Reviewable:end -->
2015-09-10 07:29:47 -06:00
Corey Farwell
a4027f0259
Link to Servo issue instead of Gecko bug
2015-09-10 10:54:30 +02:00
bors-servo
c349b7b3a1
Auto merge of #7426 - dzbarsky:surroundcontents, r=glennw
...
Implement Range#surroundContents
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7426 )
<!-- Reviewable:end -->
2015-09-09 21:54:06 -06:00
Anthony Ramine
dc125f9eb1
Implement NonElementParentNode for DocumentFragment
2015-09-10 01:33:13 +02:00
Anthony Ramine
3f5b3053b9
Introduce NonElementParentNode
...
This is the interface where Document.getElementById() belong.
2015-09-10 01:14:26 +02:00
bors-servo
be9a9ffda1
Auto merge of #7523 - eefriedman:unnecessary-unsafe, r=SimonSapin
...
Fix up some unnecessary uses of `unsafe`.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7523 )
<!-- Reviewable:end -->
2015-09-09 00:05:17 -06:00
David Zbarsky
3bec4d37dd
Implement Range#surroundContents
2015-09-08 22:01:49 -07:00
Corey Farwell
244af42d89
Use OS-agnostic filesystem paths in Python
...
This will eventually need to be done for #1908
2015-09-08 21:16:02 +02:00