webbeef
1c9f486f88
webgpu: leverage routed_promise in calls returning promises ( #35859 )
...
Using the RoutedPromiseListener let us define a different
response type for each promise. This removes unreachable branches
that used to exist when they all shared the same WebGPUResponse.
Signed-off-by: webbeef <me@webbeef.org>
2025-03-23 18:52:46 +00:00
Simon Wülker
bb0d08432e
Migrate to the 2024 edition ( #35755 )
...
* Migrate to 2024 edition
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
* Allow unsafe_op_in_unsafe_fn lint
This lint warns by default in the 2024
edition, but is *way* too noisy for servo.
We might enable it in the future, but not now.
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
* Compile using the 2024 edition
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
---------
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
2025-03-13 10:28:11 +00:00
Simon Wülker
3d320fa96a
Update rustfmt to the 2024 style edition ( #35764 )
...
* Use 2024 style edition
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
* Reformat all code
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
---------
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
2025-03-03 11:26:53 +00:00
Samson
3c3b6cfdc4
chore: Update wgpu ( #35639 )
...
* Update wgpu
2f255edc60
2025-02-24 20:27:36 +00:00
Martin Robinson
643885e6f1
deps: Upgrade to webrender@0.66 ( #35325 )
...
In addition to some small API changes, this downstream version of
WebRender no longer depends on a very old version of time. This is the
last step toward removing the dependency on `time0.1`.
The review for this commit should also include: 9f552bebab
2025-02-07 11:57:26 +00:00
Samson
35835af857
webgpu: implement get image for webgpu canvas ( #35237 )
...
* Implement `get_image_data` for WebGPU canvas
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Update expectations
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Add docs
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2025-01-31 15:24:33 +00:00
Samson
b92a598e62
chore: Update wgpu and fix webgpu pref ( #35020 )
...
* Update wgpu to v24
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* `dom.webgpu.enabled` -> `dom_webgpu_enabled`
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Update expectations
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2025-01-16 14:42:47 +00:00
Martin Robinson
0e616e0c5d
api: Flatten and simplify Servo preferences ( #34966 )
...
Flatten and simplify Servo's preferences code. In addition, have both
preferences and options passed in as arguments to `Servo::new()` and
make sure not to use the globally set preferences in `servoshell` (as
much as possible now).
Instead of a complex procedural macro to generate preferences, just
expose a very simple derive macro that adds string based getters and
setters.
- All command-line parsing is moved to servoshell.
- There is no longer the concept of a missing preference.
- Preferences no longer have to be part of the resources bundle because
they now have reasonable default values.
- servoshell specific preferences are no longer part of the preferences
exposed by the Servo API.
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
2025-01-14 13:54:06 +00:00
Samson
4e51c7be43
Update wgpu and impl WGSLLanguageFeatures ( #34928 )
...
* Update wgpu and impl `WGSLLanguageFeatures`
dc9b2eb718
2025-01-10 17:41:11 +00:00
Samson
626ef037f3
Update wgpu for supporting TextureView.usage ( #34721 )
...
* Update wgpu and add support for TextureView.usage
53f40794f2
2024-12-21 05:18:27 +00:00
Samson
d7eb0c5c38
Update wgpu to better handle optional attachment load/store ops ( #34646 )
...
* Update wgpu to better handle attachment load/store ops
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Update expectations
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-12-16 18:58:53 +00:00
Samson
d24234ac72
Update wgpu to trunk ( #34607 )
...
* Update wgpu
8f82992b9f
2024-12-13 18:28:47 +00:00
Jonathan Schwender
6a816649d6
Upgrade Rust to 1.82.0 ( #34592 )
...
* Fix deprecated PanicInfo alias
Fixes:
```rust
use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead
```
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
* build: upgrade rustc to 1.82.0
Tracking issue for the silenced lints:
https://github.com/servo/servo/issues/34591
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
---------
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
2024-12-12 12:00:51 +00:00
Samson
43d1601016
Only send mapping back on unmap when MapMode = WRITE ( #34054 )
...
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-10-29 18:42:07 +00:00
Samson
a01d66df53
webgpu: Move supported context format to content timeline ( #34028 )
...
* Move supported context format to content timeline
https://github.com/gpuweb/gpuweb/pull/4911
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Update expectations
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-10-28 09:15:46 +00:00
tanishka
0a5540f6a4
clippy: Fix warnings in components/script & components/webgpu ( #33653 )
...
* clippy: Fix warnings in component/script & component/webgpu
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com>
* fix: use same variable name in if-let block
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com>
---------
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com>
2024-10-05 14:10:32 +00:00
Samson
20eb927843
chore: Update wgpu again ( #33635 )
...
* Update wgpu again
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Update expectations
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Update components/webgpu/swapchain.rs
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
Signed-off-by: Samson <16504129+sagudev@users.noreply.github.com>
* Update components/webgpu/wgpu_thread.rs
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
Signed-off-by: Samson <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: Samson <16504129+sagudev@users.noreply.github.com>
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
2024-10-04 17:29:24 +00:00
tanishka
4850caeec4
clippy: Fix too_many_arguments warnings ( #33648 )
...
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com>
2024-10-04 16:27:23 +00:00
tanishka
03b8034f68
clippy: Fix several warnings in components/script and components/webgpu ( #33633 )
...
* clippy: Fix several warnings in components
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com>
* fix: Allow upper_case_acronyms
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com>
* clippy: Fix more warnings
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com>
---------
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com>
2024-10-04 05:29:10 +00:00
Samson
6e043cd09e
webgpu: Introduce PresentationId to ensure updates with newer presentation ( #33613 )
...
* Introduce PresentationId to ensure update with newer presentation
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Update swapchain.rs
Signed-off-by: Samson <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: Samson <16504129+sagudev@users.noreply.github.com>
2024-10-04 04:50:26 +00:00
Mercy Bassey
43d559a1c2
replaced .map with .and_then and removed .flatten() ( #33631 )
...
Signed-off-by: mercybassey <udohmercy911@gmail.com>
2024-10-03 13:23:01 +00:00
Samson
05ecb8eddb
webgpu: renovate gpucanvascontext and webgpu presentation to match the spec ( #33521 )
...
* Reimpl gpucanvascontext
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* ValidateTextureDescriptorAndCreateSwapChain
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* reconfigure
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* resize
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* work around deadlocks in wgpu core
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* match spec even more by moving all swapchain operations into one updatecontext
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* error handling
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* enable one test
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* label dummy texture
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* update expect
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* clean some expectation (they are not flaky anymore)
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* one more
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* change for configuration change in update_wr_image
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* DEFAULT_IMAGE_FORMAT
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* fixup
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* introduce WebGPUImageDescriptor
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-10-01 10:03:11 +00:00
Samson
6f797709cf
webgpu: destroy GPUTexture without erroring ( #33534 )
...
* destroy GPUTexture without erroring (errors can be safely ignored)
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Update expectations
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-09-25 09:36:09 +00:00
Samson
bab769a7cf
reuse ImageKey for gpucanvascontext ( #33517 )
...
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-09-22 11:57:50 +00:00
Samson
24ad2a0526
chore: Update wgpu ( #33506 )
...
* Update wgpu
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* use all backends at runtime
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* clean up some adapter stuff
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Update expectations
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* flakes
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-09-21 04:20:18 +00:00
Martin Robinson
aa0029c11c
Add rust-version to all Cargo.toml files ( #33483 )
...
This is another step preparing for building Servo without `mach`.
Fixes #33430 .
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
2024-09-17 16:39:07 +00:00
Samson
06bf6124c4
webgpu: Use PresentationBufferState instead of bucketing buffer_ids per state ( #33457 )
...
* `PresentationBufferState`
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* fixups
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-09-16 14:06:27 +00:00
Samson
261d60e456
webgpu: Do one allocation less on presentation by keeping GPUBuffer mapped ( #33387 )
...
* `GPUPresentationBuffer` in `WGPUExternalImages`
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* mv presentation_buffer in if let
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* docs
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-09-13 13:32:00 +00:00
Samson
687f356db9
webgpu: Factor out swapchain to separate file ( #33367 )
...
* Move some stuff to swapchain.rs
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Use typed WebGPUContextId instead of u64
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Extract create_swapchain function and move more stuff in it
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* extract destroy_swapchain
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* extract swapchain_present
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* extract update_wr_image callback
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* fixup
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-09-09 13:29:04 +00:00
Martin Robinson
e70507ca40
tidy: Fix rustdoc warnings and add a tidy check for a common URL issue ( #33366 )
...
This change fixes all rustdoc errors and also adds a tidy check for a
very common rustdoc URL issue. Eventually rustdoc warnings should likely
cause the build to fail, but this catches those issues sooner in order
to not waste so much developer time.
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
2024-09-08 15:04:19 +00:00
Samson
817a91f2ac
webgpu: Clean up GPUCommandEncoders and add some validation ( #33223 )
...
* TextureUsages::from_bits_retain
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Fixup CreateBindGroupLayout
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* GPUExtent3D checking and converting
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Cleanup GPUCommandEncoders and some TODOs
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* validate gpuorigin3d
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* validate GPUColor
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* set good expect
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-08-30 11:23:17 +00:00
Samson
12661c1920
Update wgpu ( #33209 )
...
no gfx_select macro and some minor changes to passes
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-08-27 20:31:31 +00:00
Samson
7fce24f9d5
webgpu: Sync GPUBuffer ( #33154 )
...
* More helpers on `Promise`
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Sync `GPUBuffer`
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Set some good expectations
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Some bad expect
also on firefox
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Extract DataBlock, DataView impl from GPUBuffer
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Fix size check to work on 32bit platforms
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-08-27 07:54:55 +00:00
Samson
65bd5a3b99
webgpu: Align writeBuffer with spec ( #33147 )
...
* Sync `WriteBuffer`
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Set good expectations
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Change assert to debug_assert
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-08-21 11:46:23 +00:00
Samson
24b1404d12
Update wgpu ( #32981 )
...
* Update wgpu to 781b54a8b9
2024-08-08 20:27:16 +00:00
Samson
b8cf0cf9af
webgpu: Implement proper async pipeline creation and GPUPipelineError ( #32636 )
...
* Add GPUPipelineError
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Proper GetBindGroupLayout
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Proper Create*PipelineAsync
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Expectations
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* fixups
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* more good expectations
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-08-08 11:48:43 +00:00
Samson
f989d3776e
separate Queue&Device Id ( #32966 )
...
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-08-08 07:53:17 +00:00
Samson
5e59988c87
webgpu: Use wgpu's instead of string errors and update limits handling ( #32925 )
...
* Use wgpu specific errors
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* fixup expect
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* WIP
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Fix records erasing enforcerange
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* page can already be destroyed
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Support more limits
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Set good results
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Set OK (not PASS) expect CRASH
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* fixup expectation
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* bad expectations
https://github.com/gfx-rs/wgpu/issues/6075
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* set bad expectation
render bundleencoder needs to be rewritten
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-08-04 17:19:46 +00:00
Samson
ad74bfc4ea
webgpu: Update wgpu to 22.0 ( #32827 )
...
* Update wgpu to c0e7c1ef94
2024-07-25 08:27:26 +00:00
Samson
b471f6473f
Remove failure breaks from webgpu thread ( #32814 )
...
* Remove breaks from webgpu requests
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* expect
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* limit,out_of_range TIMEOUT->FAIL
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-07-20 19:57:53 +00:00
Rodion Borovyk
4bf5024ee0
fix a couple of simple clipy warnings ( #32813 )
...
Signed-off-by: Rodion Borovyk <rodion.borovyk@gmail.com>
2024-07-19 13:18:34 +00:00
Samson
34eed29037
Less nesting in webgpu response ( #32799 )
...
* Remove Option wrap of WebGPUResponse
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* Replace WebGPUResponseResult with WebGPUResponse
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2024-07-17 20:37:52 +00:00
Samson
91ca727eb9
webgpu: Divide message code into separate files ( #32700 )
...
* Spilt webgpu ipc messages even more
* Add license to mod.rs
* file docs
2024-07-12 11:01:15 +00:00
Samson
99c1f886b8
webgpu: Update wgpu and revamp RenderPass ( #32665 )
...
* Update wgpu and revamp RenderPass
* Set good expectations
* Set one bad expectation
* send_render_command
* small fixups
* docs
* doc
* Put RenderPass inside PassState
* Use Pass enum for ComputePass too
* fix docs
2024-07-04 12:16:42 +00:00
Samson
c0105de82b
webgpu: Implement ShaderCompilationInfo ( #32642 )
...
* ShaderCompilationInfo
* expectations
* Handle CompilationInfo promise in GPUShaderModule
* Fix my english
2024-07-02 13:39:06 +00:00
Samson
e9cf4d4971
webgpu: Update wgpu and revamp computepass ( #32575 )
...
* Do not wait on drop, but rather wake poller thread
* Update wgpu and render stuff
* Set some good expectations
* Update wgpu again
* handle IPC error as warning
* More good expectations
* Some more expectations
CTS does not match the spec: https://github.com/gpuweb/cts/issues/3806
* This expectations are due to other changes in servo
also happening on main
* Explain error_command_encoders and remove RefCell around it
* fixup
* store validness of passes
* More good expectations
* More docs
* this assert is wrong
* This is even more right per CTS/spec
Only Command encoder state errors are allowed here, but wgpu does not exposes them.
* More good expectations
* One bad expectation
* Fix my english
2024-06-28 04:49:35 +00:00
Samson
bf99cf7f30
Proper GPUDevice cleanup ( #32520 )
...
* Make device cleanup right
* Use weakref for GPUDevice in globalscope
* No need to destroy device on drop
* DeviceReason early return
* make remove_gpu_device to be the only way to remove device
2024-06-20 05:56:59 +00:00
Martin Robinson
4a7f3bac7c
Use workspace definitions for all crates and update to the 2021 edition ( #32544 )
2024-06-18 09:22:08 +00:00
Samson
cbc9304c20
webgpu: Implement device lost ( #32354 )
...
* device lost promise should be init at creation of device object
* device lost impl
* lock for device poll
workaround for wgpu deadlocks
* expect
* Less lost reason reasoning in script
2024-06-17 12:47:25 +00:00
Hieu Do
4f5184b6e2
webgpu: Enable gles support ( #32452 )
2024-06-09 04:35:27 +00:00
