Commit graph

3608 commits

Author SHA1 Message Date
Pyfisch
6f62723898 Fix several bugs related to scrolling
* scrollLeft/scrollTop returned values of parent or even document root
   Only the scroll of the node itself is returned. Otherwise 0.0.
* Scrolling via script had set viewport.
   This resulted in other nodes appearing scrolled.
   Now scroll_offsets are updated with correct node id.

These bugs caused other odd behavior like both body and
document.documentElement being scrolled or the view for scrolled
elements jumping.
2017-10-12 12:36:32 -04:00
Jonathan Chan
b6667181ee Correctly test CSSStyleRule.style.
Remove the assert_readonly test and add one to verify that assigning to
CSSStyleRule.style correctly forwards to CSSStyleRule.style.cssText.

We currently test for whether CSSStyleRule.style is read-only by
trying to assign to it; however, the spec has it as actually:

interface CSSStyleRule : CSSRule {
  ...
  [SameObject, PutForwards=cssText] readonly attribute CSSStyleDeclaration style;
};

See: https://drafts.csswg.org/cssom/

The `PutForwards=cssText` means that assigning to CSSStyleRule.style
should actually assign to style.cssText.
2017-10-12 12:36:30 -04:00
Josh Matthews
1f531f66ea Update web-platform-tests to revision 8a2ceb5f18911302b7a5c1cd2791f4ab50ad4326 2017-10-12 12:36:21 -04:00
Josh Matthews
462c272380 Improve diagnostics of upstreaming WPT changes. 2017-10-12 08:49:33 -04:00
bors-servo
528d0fb409 Auto merge of #18825 - servo:urls, r=emilio
Fix a bunch of URL-reflecting IDL attributes

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18825)
<!-- Reviewable:end -->
2017-10-11 08:45:44 -05:00
Anthony Ramine
71b015173f Fix the form action IDL attributes
The returned string, if the attribute is present and non-empty,
should be a URL resolved against the element's document's base URL.
2017-10-11 13:56:10 +02:00
Anthony Ramine
605c679fee Fix URL attributes
URL attributes should always use AttrValue::Url, and the input should be
resolved against the document's base URL at setting time always.
2017-10-11 13:56:07 +02:00
Emilio Cobos Álvarez
90ee40f43f
style: Fix ex computation with more than one operand. 2017-10-10 18:41:23 +02:00
bors-servo
bbb2a3cde9 Auto merge of #18790 - upsuper:scope, r=emilio
Support :scope pseudo-class

This fixes [bug 1406817](https://bugzilla.mozilla.org/show_bug.cgi?id=1406817).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18790)
<!-- Reviewable:end -->
2017-10-09 23:04:15 -05:00
Xidorn Quan
dd0366c6b9 Add wpt for :scope pseudo-class 2017-10-10 12:09:38 +11:00
Xidorn Quan
4667e811dd Cherry pick w3c/web-platform-tests#6874 to fix this test. 2017-10-10 12:09:36 +11:00
bors-servo
e3624e62a4 Auto merge of #18747 - jdm:serializing-childrenonly, r=jdm
Serializing childrenonly

Rebased from #17896.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14975 (github issue number if applicable).
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18747)
<!-- Reviewable:end -->
2017-10-09 11:12:53 -05:00
bors-servo
712d32e899 Auto merge of #18758 - stuartnelson3:stn/dynamic-body-bgcolor, r=emilio
Add support for dynamic bgcolor change

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18758)
<!-- Reviewable:end -->
2017-10-08 07:47:50 -05:00
Stuart Nelson
c886e3ee75 Update manifest and move files 2017-10-08 11:29:49 +02:00
Jyotsna Prakash
6c0f87a1d6 ChildrenOnly -> ChildrenOnly(Option<QualName>)
use this updated type from html5ever
2017-10-07 08:05:11 -04:00
Stuart Nelson
aff8b0a4e9 add help link and regen manifest 2017-10-07 11:34:00 +02:00
bors-servo
0444d76c6b Auto merge of #18742 - servo:media-metadata, r=jdm
Some low-key media improvements

This just makes our code fail more gracefully.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18742)
<!-- Reviewable:end -->
2017-10-05 15:41:22 -05:00
Stuart Nelson
1977352bff Simplify and move ref test 2017-10-05 20:51:03 +02:00
Stuart Nelson
3b4deb4388 Add support for dynamic bgcolor change 2017-10-05 20:51:02 +02:00
Josh Matthews
3347094373 Update WPT results. 2017-10-05 09:23:30 +02:00
Josh Matthews
bceaca9694 Fix up a test metadata classification. 2017-10-05 00:43:16 +02:00
Josh Matthews
da8677221e Avoid endless testrunner restart loops.
If the first test selected by a testrunner thread had a CRASH expectation,
the testrunner believed that it needed to restart and would never actually
get around to running the test.
2017-10-05 00:43:13 +02:00
Josh Matthews
c1c60beda1 Minimal changes to get WPT tests running on Windows. 2017-10-05 00:43:11 +02:00
Josh Matthews
2fb74cb9e9 Avoid testharness.js errors for assert_throws. 2017-10-05 00:43:09 +02:00
Josh Matthews
933b42ef46 Allow running wpt directories by path on the command line. 2017-10-05 00:43:07 +02:00
Josh Matthews
ca340eca39 Use upstream wptrunner from web-platform-tests. 2017-10-05 00:43:03 +02:00
Josh Matthews
d9baadd3df Use git's path stripping when upstreaming patches. 2017-10-05 00:42:22 +02:00
Josh Matthews
578498ba24 Update web-platform-tests to revision a46616a5b18e83587ddbbed756c7b96cbb4b015d 2017-10-05 00:42:13 +02:00
bors-servo
d8c7066464 Auto merge of #18724 - mrobinson:test-runner-count, r=jdm
Fix the test count in the WPT grouping_formatter

The internal WPT API seems to have changed again, so we must revert the
previous change here to get the correct test count.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because this is a change to the test harness runner script.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18724)
<!-- Reviewable:end -->
2017-10-04 13:54:47 -05:00
Anthony Ramine
eb0c1a53ad Implement MediaError::Message
The spec says that it's ok to put an empty string in it if we don't have more
informations.
2017-10-04 11:41:41 +02:00
Anthony Ramine
b8c55e7da6 Set have_metadata for audio elements too
We don't store video-specific metadata anymore, and we don't ignore audio-specific
metadata anymore. We now just acknowledge that we received some metadata.
2017-10-04 11:28:47 +02:00
Martin Robinson
618fd27a3d Fix the test count in the WPT grouping_formatter
The internal WPT API seems to have changed again, so we must revert the
previous change here to get the correct test count.
2017-10-03 10:03:53 +02:00
Emilio Cobos Álvarez
8976b1aeab
layout_thread: Avoid adding the UA sheets multiple times when there's no root flow.
Fixes #18631
2017-10-01 23:05:58 +02:00
Anthony Ramine
12023a7384 Reenable c62-percent-000.htm (fixes #7791)
This seems to pass fine now.
2017-09-30 12:04:09 +02:00
bors-servo
81044e0019 Auto merge of #18612 - servo:event-listener-options, r=asajeffrey
Implement EventListenerOptions for EventTarget

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18612)
<!-- Reviewable:end -->
2017-09-29 19:13:36 -05:00
Guillaume Gomez
3d0b7fbc41 Implement EventListenerOptions for EventTarget
For now, only "capture" is supported.
2017-09-30 02:12:35 +02:00
Anthony Ramine
b47331812a Properly fail in video_008.html 2017-09-29 19:16:37 +02:00
Anthony Ramine
622533ef48 Properly fail in readyState_during_playing.html 2017-09-29 19:10:08 +02:00
Anthony Ramine
d7d18fc239 Properly fail in readyState_during_loadedmetadata.html 2017-09-29 19:08:19 +02:00
Anthony Ramine
ce8fc063db Properly fail in readyState_during_loadeddata.html 2017-09-29 19:03:57 +02:00
Anthony Ramine
9856580e25 Properly fail in readyState_during_canplaythrough.html 2017-09-29 19:01:30 +02:00
Anthony Ramine
4ca5a05eed Properly fail in readyState_during_canplay.html 2017-09-29 18:59:37 +02:00
Anthony Ramine
d0020888a2 Properly fail in autoplay.html 2017-09-29 18:57:01 +02:00
Anthony Ramine
71e987951f Properly fail in paused_false_during_play.html 2017-09-29 18:53:34 +02:00
Anthony Ramine
6aa9d80a00 Properly fail in load-events-networkState.html 2017-09-29 18:53:32 +02:00
Anthony Ramine
b6e3faa317 Properly fail in autoplay-overrides-preload.html 2017-09-29 18:53:30 +02:00
Anthony Ramine
fb9d3bf350 Properly fail on error event in event_timeupdate_noautoplay.html
The tests still time out when the browser doesn't fire a timeupdate event
at all.
2017-09-29 18:53:27 +02:00
Anthony Ramine
c93b3d1639 Properly fail in event_progress_noautoplay.html 2017-09-29 18:53:21 +02:00
Anthony Ramine
97adf791cd Properly fail in event_playing.html 2017-09-29 18:53:13 +02:00
Anthony Ramine
edd3824519 Properly fail in event_play.html 2017-09-29 18:53:10 +02:00