Commit graph

5743 commits

Author SHA1 Message Date
Anthony Ramine
60b5b77ccb Properly fail in event_order_canplay_playing.html 2017-09-29 17:55:31 +02:00
Anthony Ramine
026130094d Properly fail in event_order_canplay_canplaythrough.html 2017-09-29 17:12:29 +02:00
Anthony Ramine
59c56de103 Properly fail in event_loadedmetadata.html 2017-09-29 17:05:40 +02:00
bors-servo
9ffd2b8c9e Auto merge of #18604 - emilio:animated-value-cleanup, r=nox
style: Cleanup the animated value setup.

We have three different enums to represent slightly different things. Reuse them
properly, and kill some code in the animated_properties module while at it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18604)
<!-- Reviewable:end -->
2017-09-29 10:01:52 -05:00
Anthony Ramine
9f71ac9155 Properly use test() in networkState_during_progress.html 2017-09-29 16:58:44 +02:00
Anthony Ramine
2b64c3e6c0 Properly use test() in event_order_loadstart_progress.html 2017-09-29 16:55:11 +02:00
Anthony Ramine
7bab9caafd Properly use test() in event_progress.html 2017-09-29 16:51:55 +02:00
Anthony Ramine
37f5f52049 Properly fail in event_loadedmetadata_noautoplay.html 2017-09-29 15:37:10 +02:00
Anthony Ramine
7e06d2a1be Properly fail in event_loadeddata_noautoplay.html 2017-09-29 15:37:01 +02:00
Anthony Ramine
3185a7917e Fix some shortcomings in event_loadeddata.html
Variable 'v' was undefined in second test, and both tests were missing an onerror event handler.
2017-09-29 15:36:57 +02:00
Anthony Ramine
c0040b27fd Properly fail in event_canplaythrough_noautoplay.html 2017-09-29 15:30:04 +02:00
Anthony Ramine
8a3afe35fe Properly fail in event_canplaythrough.html 2017-09-29 15:29:02 +02:00
Anthony Ramine
4923045353 Properly fail in event_canplay_noautoplay.html 2017-09-29 15:28:03 +02:00
Anthony Ramine
bf3d6948c1 Properly fail in event_canplay.html 2017-09-29 15:27:12 +02:00
Anthony Ramine
0e56b79e78 Properly fail in /html/semantics/embedded-content/media-elements/error-codes/error.html 2017-09-29 14:25:13 +02:00
Anthony Ramine
83488a20f1 Properly fail in audio_loop_base.html 2017-09-29 14:23:14 +02:00
Emilio Cobos Álvarez
3215e36b5b
style: Cleanup the animated value setup.
We have three different enums to represent slightly different things. Reuse them
properly, and kill some code in the animated_properties module while at it.

MozReview-Commit-ID: 5ZAly8f4lWy
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-09-29 13:20:50 +02:00
bors-servo
16b6686bbb Auto merge of #18672 - servo:DETERMINISTIC-ALL-THE-THINGS, r=SimonSapin
Fix 3 intermittent tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18672)
<!-- Reviewable:end -->
2017-09-29 02:46:31 -05:00
Anthony Ramine
53e2a4449a Make networkState_during_progress.html deterministic (fixes servo/servo#17954) 2017-09-29 09:41:45 +02:00
Anthony Ramine
abcf91e5c6 Make event_order_loadstart_progress.htm deterministic (fixes servo/servo#18289) 2017-09-29 09:39:53 +02:00
Anthony Ramine
b489d0c159 Make event_progress.html deterministic (fixes servo/servo#18427) 2017-09-29 09:39:47 +02:00
Bobby Holley
ef042899d2 Round hashglobe allocations up to the nearest page size.
MozReview-Commit-ID: 34KFtcwCkBB
2017-09-28 15:06:48 -07:00
Hiroyuki Ikezoe
ded0c713db Store custom properties in keyframes into servo's PropertyDeclarationBlock 2017-09-27 18:27:48 +09:00
bors-servo
e6099b4364 Auto merge of #18617 - TheDan64:master, r=KiChjang
Removed integrity check and test for no-cors requests

Removed Step 30.2 which raised a JS TypeError if the integrity metadata was not empty. I manually ran `new Request("", {"mode" : "no-cors", "integrity" : "not an empty string"});` in servo to validate that the exception no longer arose.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #18345
- [x] These changes do not require tests because according to the ticket "Unfortunately, there's no automated test available for this yet because we are having trouble updating our copy of the upstream tests. "

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18617)
<!-- Reviewable:end -->
2017-09-25 19:15:26 -05:00
Daniel Kolsoi
96f9cc77e6 Removed integrity check and test for no-cors requests
Also updated request-headers.html manifest hash
2017-09-25 19:11:30 -04:00
bors-servo
f3214372bf Auto merge of #18582 - servo:media, r=emilio
Improve HTMLMediaElement

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18582)
<!-- Reviewable:end -->
2017-09-25 03:51:53 -05:00
Anthony Ramine
5245931dc2 Implement the error path for source children of media elements
This removes some test timeout.
2017-09-25 00:35:35 +02:00
Manish Goregaokar
454fb9f1e4 stylo: Update ComputedValues size in test 2017-09-23 11:25:42 -07:00
Anthony Ramine
6c5fe041d7 Ignore media-related tasks when starting the media load algorithm 2017-09-23 12:01:39 +02:00
bors-servo
5838c35140 Auto merge of #18520 - servo:media, r=emilio
Continue to clean up HTMLMediaElement

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18520)
<!-- Reviewable:end -->
2017-09-19 11:06:19 -05:00
Anthony Ramine
7e835c351e Handle invalid MIME types in HTMLMediaElement::CanPlayType 2017-09-19 14:26:10 +02:00
Glenn Watson
2b6fe42236 Update WR (implement blur filter, text-shadow blend fixes, frame output fix). 2017-09-19 11:56:03 +10:00
bors-servo
a5282cabe0 Auto merge of #17862 - asajeffrey:script-paint-worklet-border, r=pcwalton
Implemented paint worklets drawing to a border.

<!-- Please describe your changes on the following line: -->

Allow paint worklets to draw to a border.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17451.
- [X] These changes do not require tests because the existing css-paint-api test check this (but annoyingly, all fail for other reasons)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17862)
<!-- Reviewable:end -->
2017-09-18 16:54:54 -05:00
Alan Jeffrey
6754b2834f Made PipelineId non-zero, so optional ids take no more space. 2017-09-18 15:49:38 -05:00
bors-servo
ba90e13863 Auto merge of #18543 - emilio:named-getter-int, r=nox
script: Fix integer-JSID handling in named getters.

On top of #18539, fixes #10686.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18543)
<!-- Reviewable:end -->
2017-09-18 06:27:25 -05:00
bors-servo
cff9b427fc Auto merge of #18517 - BorisChiou:stylo/filter/clamp, r=emilio
style: Clamp some filter functions to one if the values over 100%

For grayscale, invert, opacity, and sepia, "values of amount over 100%
are allowed but UAs must clamp the values to 1" [1]-[4], so we clamp its value
in the parser.

[1] https://drafts.fxtf.org/filter-effects/#funcdef-filter-grayscale
[2] https://drafts.fxtf.org/filter-effects/#funcdef-filter-invert
[3] https://drafts.fxtf.org/filter-effects/#funcdef-filter-opacity
[4] https://drafts.fxtf.org/filter-effects/#funcdef-filter-sepia

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1399799](https://bugzilla.mozilla.org/show_bug.cgi?id=1399799).
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18517)
<!-- Reviewable:end -->
2017-09-18 05:23:36 -05:00
bors-servo
1da581f49b Auto merge of #18506 - mrobinson:position-sticky-table, r=emilio
Fix issues with the combination of position:sticky and tables

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #18441 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18506)
<!-- Reviewable:end -->
2017-09-18 04:18:17 -05:00
Emilio Cobos Álvarez
90fb284720
script: Properly implement LegacyPlatformGetOwnProperty in WebIDL.
We were missing the "ignoreNamedProperties" bit, which my previous patch
uncovers.
2017-09-18 09:15:14 +02:00
Emilio Cobos Álvarez
f5d16fc069
script: Fix integer-JSID handling in named getters.
Fixes #10686
2017-09-18 09:15:13 +02:00
Boris Chiou
e719df53c0 Clamp some filter functions to one if the values over 100%.
For grayscale, invert, opacity, and sepia, "values of amount over 100%
are allowed but UAs must clamp the values to 1" [1]-[4], so we clamp its value
in the parser.

[1] https://drafts.fxtf.org/filter-effects/#funcdef-filter-grayscale
[2] https://drafts.fxtf.org/filter-effects/#funcdef-filter-invert
[3] https://drafts.fxtf.org/filter-effects/#funcdef-filter-opacity
[4] https://drafts.fxtf.org/filter-effects/#funcdef-filter-sepia
2017-09-18 12:52:55 +08:00
bors-servo
280ccf685d Auto merge of #18542 - mhaessig:selector-tests, r=emilio
Land the test cases that should've landed with the selectors update

PR for #15448
- Added test for pseudo-element with whitespace #15335
- Added tests for empty values in `[att^=""]`, `[att$=""]` and `[att*=""]` selectors #15394 (tests for `[att~=""]` have been added with #15440)

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15448
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18542)
<!-- Reviewable:end -->
2017-09-17 16:22:56 -05:00
Emilio Cobos Álvarez
f9c06d7932
style: Generalise BorderCornerRadius as Size. 2017-09-17 21:33:14 +02:00
Emilio Cobos Álvarez
4936314b7e
style: Simplify serialisation of BorderCornerRadius when possible.
Closes #18458.

Matches other browsers in test-cases like:

<div id="t" style="border-top-left-radius: 5px 5px"></div>
<script>alert(t.style.borderTopLeftRadius)</script>

(I think it'd be nicer to preserve the original value completely, but not going
to complain given we already do this for all sorts of Rect<T>s and such, and
this is much easier).
2017-09-17 21:33:11 +02:00
Manuel Hässig
62d363b3cb added tests for empty values in prefix, suffix and substring selectors 2017-09-17 19:05:21 +02:00
Emilio Cobos Álvarez
91f238f326
script: Properly throw when "this" is not an object in a generic call. 2017-09-17 18:42:27 +02:00
Emilio Cobos Álvarez
b29e56eefc
script: Fix code generation for named getters.
Fixes part of #18535
2017-09-17 18:42:23 +02:00
Manuel Hässig
8b589dd6aa added test for whitespace in pseudo element 2017-09-17 16:24:14 +02:00
bors-servo
4911706f75 Auto merge of #18510 - mrobinson:truncated-fragment-stacking-context-collection, r=emilio
Properly handle stacking context collection for truncated fragments

Before we did not properly descend intro truncated fragments when
collecting stacking contexts. This change makes sure that we descend
properly

Fixes #18254.
Fixes #17072.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #18254,  #17072 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18510)
<!-- Reviewable:end -->
2017-09-15 19:00:24 -05:00
bors-servo
564fb5c53b Auto merge of #18410 - paulrouget:harfbuzz-update, r=mbrubeck
harfbuzz-sys update

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18410)
<!-- Reviewable:end -->
2017-09-15 17:51:30 -05:00
Martin Robinson
f1596e83a9 Fix panic when tables having position:sticky
We no longer do any stacking context or clip node creation for table
wrappers, instead relying on their TableFlows to do this.
2017-09-15 15:55:56 +02:00