Anthony Ramine
88685be649
Don't use SequenceWriter if there is a single field to serialise
2018-03-06 13:14:26 +01:00
bors-servo
226d9a5b0e
Auto merge of #20210 - emilio:justify-items-kinda-sucks, r=Manishearth
...
style: Add a comment about the weird setup for justify-items.
And derive ToCss while at it.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20210 )
<!-- Reviewable:end -->
2018-03-06 05:29:17 -05:00
Emilio Cobos Álvarez
a5fc724349
style: Add a comment about the weird setup for justify-items.
...
And derive ToCss while at it.
2018-03-06 11:28:41 +01:00
Anthony Ramine
85950a801f
Move #[css(iterable)] on fields rather than variants
2018-03-06 11:08:19 +01:00
Anthony Ramine
f5393cef8d
Add some assertions for #[derive(ToCss)] on enums
2018-03-06 11:08:19 +01:00
Anthony Ramine
3b31ec36f1
Don't use Ident for #[css(function)]
...
CSS identifiers aren't Rust identifiers.
2018-03-06 11:08:19 +01:00
Anthony Ramine
529a30a682
Extract variant code to its own function in style_derive::to_css
2018-03-06 11:08:19 +01:00
Anthony Ramine
14dd4217fa
Qualify path to ToCss in #[derive(ToCss)]
2018-03-06 11:08:19 +01:00
bors-servo
17b5a8332b
Auto merge of #20200 - servo:derive-all-the-things, r=emilio
...
Derive some more ToCss stuff again
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20200 )
<!-- Reviewable:end -->
2018-03-06 03:33:18 -05:00
bors-servo
b7a8d78972
Auto merge of #20209 - servo:jdm-patch-6, r=glennw
...
Fix exception when updating WPT metadata.
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20209 )
<!-- Reviewable:end -->
2018-03-05 22:42:12 -05:00
Josh Matthews
00738bf1f6
Fix exception when updating WPT metadata.
2018-03-05 22:23:09 -05:00
bors-servo
2d3771daab
Auto merge of #20206 - servo:jdm-patch-2, r=nox
...
Ensure default paths are set when updating WPT metadata.
This fixes https://github.com/w3c/web-platform-tests/issues/9819 and will allow our nightly upstream sync to complete.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20206 )
<!-- Reviewable:end -->
2018-03-05 14:47:38 -05:00
Josh Matthews
ac156f74a9
Ensure default paths are set when updating WPT metadata.
2018-03-05 14:37:16 -05:00
bors-servo
e20d338fed
Auto merge of #20202 - servo:fork-blurmac, r=jdm
...
Update devices and fork blurmac
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20202 )
<!-- Reviewable:end -->
2018-03-05 13:49:02 -05:00
bors-servo
e682862906
Auto merge of #20203 - emilio:backout-toml-bump, r=backout
...
Revert "Auto merge of #20201 - Eijebong:bump, r=nox"
This reverts commit 05dcfe2983
, reversing
changes made to 9dbb69868c
.
This broke autoland because we don't build components/style/build_gecko.rs on
Servo's CI.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20203 )
<!-- Reviewable:end -->
2018-03-05 12:27:46 -05:00
Simon Sapin
917ccaf268
Update devices and fork blurmac
2018-03-05 17:56:21 +01:00
Emilio Cobos Álvarez
39fb9e3a51
Revert "Auto merge of #20201 - Eijebong:bump, r=nox"
...
This reverts commit 05dcfe2983
, reversing
changes made to 9dbb69868c
.
This broke autoland because we don't build components/style/build_gecko.rs on
Servo's CI.
2018-03-05 17:30:36 +01:00
bors-servo
05dcfe2983
Auto merge of #20201 - Eijebong:bump, r=nox
...
Bump some dependencies now that metadeps is out of the way ᕕ( ᐛ )ᕗ
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20201 )
<!-- Reviewable:end -->
2018-03-05 10:22:24 -05:00
Bastien Orivel
f09173506f
Update error-chain to 0.11
2018-03-05 16:19:24 +01:00
Bastien Orivel
3fd8b63069
Update toml to 0.4
2018-03-05 16:19:09 +01:00
Anthony Ramine
2aa5f68c92
Derive ToCss for FontSize
2018-03-05 15:53:16 +01:00
Anthony Ramine
ca45695db1
Introduce #[css(skip)]
2018-03-05 15:53:15 +01:00
bors-servo
9dbb69868c
Auto merge of #20199 - Eijebong:metadeps, r=emilio
...
Remove metadeps from the dependency tree
🎉
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20199 )
<!-- Reviewable:end -->
2018-03-05 09:20:33 -05:00
bors-servo
7931df716d
Auto merge of #20198 - servo:derive-all-the-things, r=emilio
...
Use darling::util::Override in #[derive(ToCss)]
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20198 )
<!-- Reviewable:end -->
2018-03-05 08:24:35 -05:00
Bastien Orivel
fdd7f91f86
Remove metadeps from the dependency tree
2018-03-05 13:47:46 +01:00
Anthony Ramine
c4cfb127b8
Use darling::util::Override in #[derive(ToCss)]
2018-03-05 13:23:33 +01:00
bors-servo
266258331e
Auto merge of #20196 - servo:derive-all-the-things, r=emilio
...
Derive some more ToCss implementations
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20196 )
<!-- Reviewable:end -->
2018-03-05 06:03:53 -05:00
Anthony Ramine
75b05c518d
Derive ToCss for DeclaredValueOwned rather than DeclaredValue
2018-03-05 12:02:32 +01:00
Anthony Ramine
247bcbbbd6
Derive ToCss for all vector longhands that cannot be empty
...
We don't need to check for emptiness and write `none` for them.
2018-03-05 12:02:31 +01:00
Anthony Ramine
31036d6510
Derive ToCss for MediaList
...
This uncovered the fancy snowflake `use fmt::Write` in the impl of ToCss
for NonTSPseudoClass.
2018-03-05 12:02:31 +01:00
Anthony Ramine
fb8b6fc0a5
Derive ToCss for CounterBound
2018-03-05 12:02:30 +01:00
Anthony Ramine
0b3a5b42ba
Introduce enum CounterBound for the bounds in counter_style::Ranges
2018-03-05 12:02:25 +01:00
bors-servo
e3f69668ae
Auto merge of #20195 - sanxiyn:no-freeglut, r=jdm
...
Remove FreeGLUT
Current Servo does not require FreeGLUT. Update accordingly.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20195 )
<!-- Reviewable:end -->
2018-03-04 14:25:06 -05:00
bors-servo
fbeb5a81a8
Auto merge of #20194 - emilio:ascii-ext-stuff, r=nox
...
style: remove unused AsciiExt imports.
eq_ignore_ascii_case is not in AsciiExt since rustc 1.23.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20194 )
<!-- Reviewable:end -->
2018-03-04 13:35:04 -05:00
bors-servo
ec3aa8bd7a
Auto merge of #20182 - paulrouget:ctrl_l, r=jdm
...
Prompt URL on Cmd/Ctrl-L
<!-- Please describe your changes on the following line: -->
The `sanitize_url` code is very naive. I'm sure we can do better.
This ServoShell issue describes the problem: https://github.com/paulrouget/servoshell/issues/59
I can fix that now if someone can help me figure out how to tell if a string is a valid url which is just missing a scheme. Or we can do that in a follow up.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20165
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20182 )
<!-- Reviewable:end -->
2018-03-04 12:48:30 -05:00
bors-servo
1783e41f34
Auto merge of #20191 - jfkthame:font-shorthand-resets-variation-settings, r=emilio
...
style: Make 'font' shorthand reset 'font-variation-settings' property
As required by the spec: https://drafts.csswg.org/css-fonts-4/#font-prop
See https://bugzilla.mozilla.org/show_bug.cgi?id=1435983
Basically, make font-variation-settings work in the same way as font-feature-settings
already does.
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because font-variation-settings isn't supported in servo; it is implemented here for gecko/stylo, and will be tested by mozilla-central mochitests.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20191 )
<!-- Reviewable:end -->
2018-03-04 11:50:56 -05:00
Seo Sanghyeon
5121258bc5
Remove FreeGLUT
2018-03-05 01:18:12 +09:00
bors-servo
d09ea8476e
Auto merge of #20193 - emilio:needless-stuff-is-needless, r=nox
...
style: Remove more rustc_has_pr45225 stuff.
Also cleans up references to a fixed issue.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20193 )
<!-- Reviewable:end -->
2018-03-04 10:41:54 -05:00
Emilio Cobos Álvarez
39a3d93b4f
style: remove unused AsciiExt imports.
...
eq_ignore_ascii_case is not in AsciiExt since rustc 1.23.
2018-03-04 15:31:06 +01:00
bors-servo
a716dfd40b
Auto merge of #20192 - servo:derive-all-the-things, r=emilio
...
Derive ToCss for DeclaredValue
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20192 )
<!-- Reviewable:end -->
2018-03-04 09:29:01 -05:00
Emilio Cobos Álvarez
b486c89149
style: Remove more rustc_has_pr45225 stuff.
...
Also cleans up references to a fixed issue.
2018-03-04 15:23:54 +01:00
Anthony Ramine
886554dba5
Derive ToCss for DeclaredValue
2018-03-04 15:21:11 +01:00
Anthony Ramine
1937f594ac
Implement ToCss for UnparsedValue
2018-03-04 15:16:09 +01:00
Jonathan Kew
188687d6a3
style: update stack size of SourcePropertyDeclaration
2018-03-04 13:48:11 +00:00
Jonathan Kew
33ead015b1
style: Make 'font' shorthand reset the 'font-variation-settings' property.
...
As required by the spec: https://drafts.csswg.org/css-fonts-4/#font-prop
See https://bugzilla.mozilla.org/show_bug.cgi?id=1435983
Basically, make font-variation-settings work in the same way as font-feature-settings
already does.
2018-03-04 12:26:32 +00:00
Paul Rouget
bb04b95a79
Prompt URL on Cmd/Ctrl-L
2018-03-04 10:55:10 +01:00
bors-servo
86a7010082
Auto merge of #20189 - servo:squared-distance-for-real, r=emilio
...
Never store a squared root in SquaredDistance
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20189 )
<!-- Reviewable:end -->
2018-03-03 20:11:41 -05:00
Anthony Ramine
6ce5e9a869
Never store a squared root in SquaredDistance
2018-03-04 02:10:44 +01:00
bors-servo
b59a8afd0f
Auto merge of #20190 - emilio:context-opacity, r=upsuper
...
style: Don't guard the context opacity keywords with the svg in opentype pref.
This is effectively the stylo version of the second patch for bug 1365926, and should fix bug 1442867.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20190 )
<!-- Reviewable:end -->
2018-03-03 19:12:18 -05:00
Emilio Cobos Álvarez
9ace0e43ce
style: Cleanup indentation in a couple places.
2018-03-04 01:07:29 +01:00