Commit graph

26683 commits

Author SHA1 Message Date
Ekta Siwach
7ce78f5a74
clippy: Fix some warnings in script/dom (#31915)
* fixed some clippy warnings

* resolved conflict

* updated texttracklist.rs

---------

Co-authored-by: Martin Robinson <mrobinson@igalia.com>
2024-03-28 16:57:25 +00:00
Azhar Ismagulova
9303c90159
clippy: refactor struct literals to use shorthands (#31924) 2024-03-28 16:39:50 +00:00
Azhar Ismagulova
0728378424
clippy: remove unneeded return statements (#31923) 2024-03-28 16:17:47 +00:00
Oluwatobi Sofela
7349ce5b6a
clippy: Fix manual_map warnings (#31922) 2024-03-28 15:58:36 +00:00
Ekta Siwach
5d518ca8dc
layout: Use Au in ResolvedMargins and CollapsedMargin (#31848)
* change ResolvedMargins to use Au instead of length

* made suggested changes

removed whitespace changes

made suggested changes

* Update components/layout_2020/flexbox/layout.rs

Co-authored-by: Oriol Brufau <obrufau@igalia.com>

* Update components/layout_2020/flow/mod.rs

Co-authored-by: Oriol Brufau <obrufau@igalia.com>

* fixed errors

fixed errors

fixed formatting

fixed errors

* modified changes

made suggested changes

* Update components/layout_2020/fragment_tree/fragment.rs

Co-authored-by: Oriol Brufau <obrufau@igalia.com>

updated components/layout_2020/fragment_tree/fragment.rs

* Update components/layout_2020/flow/mod.rs

Co-authored-by: Oriol Brufau <obrufau@igalia.com>

* Update components/layout_2020/flow/mod.rs

Co-authored-by: Oriol Brufau <obrufau@igalia.com>

* updated changes

updated changes

* unified all the suggested changes here

* fixed formatting

* reverted unnecessary changes

* fixed unnecessary warnings

---------

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
2024-03-28 14:20:14 +00:00
Oluwatobi Sofela
66ad795014
clippy: Fix mem_replace_with_default warnings (#31921) 2024-03-28 13:10:37 +00:00
Rosemary Ajayi
7100465d1a
clippy: Fix various clippy warnings in components/scripts/dom/bindings (#31901)
* single-character string constant used as pattern

* singuse of  with literal radix of 16
2024-03-28 11:49:36 +00:00
Rosemary Ajayi
18054d0737
clippy: Fix another set of clippy problems in components/script/dom (#31909)
* a reference to a reference

* length comparison to zero

* length comparison to zero

* length comparison to zero
2024-03-28 11:33:29 +00:00
Rosemary Ajayi
af358f51db
clippy: Fix another batch of clippy warnings in components/scripts (#31912)
* boolean can be simplified

* boolean can be simplified

* boolean can be simplified
2024-03-28 11:28:33 +00:00
Rosemary Ajayi
3ddb47e902
clippy: Fix more clippy warnings in components/scripts/dom (#31914)
* refrence to a reference

* refrence to a reference
2024-03-28 11:26:39 +00:00
Rosemary Ajayi
5aae820f6d
clippy: Fix a few clippy problems in components/scripts/dom (#31905)
* option_as_ref_deref

* fix
2024-03-28 11:24:39 +00:00
Ekta Siwach
1bc63801e7
fix redundant closures in component/script/dom (#31917)
* fixed unnecessary conversions

* resolved conflicts

* resolved conflicts

* fix redundant closures in component/script/dom

* resolved conflicts

* fixed formatting
2024-03-28 09:06:02 +00:00
Azhar Ismagulova
f183170786
clippy: Fix all errors in components/script (#31911)
* clippy: Fix errors in components/script/dom

* clippy: fixed remaining errors in components/script
2024-03-28 09:03:18 +00:00
Rosemary Ajayi
eccb60e548
deref on an immutable reference (#31899) 2024-03-28 08:57:56 +00:00
Rosemary Ajayi
072b892706
clippy:fix various clippy problems in components/scripts (#31907)
* manual implementation of an assign operation

* manual implementation of an assign operation

* single-character string

* manual cjheck for common ascii range
2024-03-27 22:14:41 +00:00
eri
1c8c287f01
WebIDL: Replace NonNull<JSObject> in xmlhttprequest (#31880)
* WebIDL: Replace `NonNull<JSObject>` in `xmlhttprequest.rs`

* doc: Update functions comments to docstring

* fix: Actually allocate `response_arraybuffer`

* fix: Change step descriptions

* fix: change step numbers
2024-03-27 20:28:51 +00:00
Azhar Ismagulova
ff95ce5abd
fix: omitted the let bindings (#31908) 2024-03-27 20:22:51 +00:00
Oluwatobi Sofela
da76ebabe9
clippy: Fix option_map_unit_fn warnings (#31906) 2024-03-27 18:43:56 +00:00
Rosemary Ajayi
a5bcae212a
clippy: Fix clippy problems in components/script/dom (#31891)
* deref on an immutable reference

* use of  with literal radix of 10

* fix
2024-03-27 18:36:16 +00:00
Oriol Brufau
b77ec08ab6
Ignore spaces before atomic inline for the min-content size (#31896)
* Ignore spaces before atomic inline for the min-content size

For the min-content size we should wrap lines wherever is possible,
so wrappable spaces shouldn't increase the length of the line,
they will just be removed or hang at the end of the line.

* Add a clarifying comment

Co-authored-by: Martin Robinson <mrobinson@igalia.com>

---------

Co-authored-by: Martin Robinson <mrobinson@igalia.com>
2024-03-27 16:46:54 +00:00
Oluwatobi Sofela
da518823ff
clippy: Fix op_ref warnings (#31900) 2024-03-27 16:45:58 +00:00
Oluwatobi Sofela
773e881971
clippy: Fix unnecessary_lazy_evaluations warnings (#31898) 2024-03-27 16:16:48 +00:00
Rosemary Ajayi
bb7778774d
clippy:Fix clippy problems in components/scripts/binding (#31893)
* constants have by default a static lifetime

* constants have by default a static lifetime

* unneeded unit expression

* unneeded unit expression

* Box of default value

* casting raw pointers

* casting raw pointers
2024-03-27 12:32:04 +00:00
Aarya Khandelwal
1f31609952
clippy: Fix warnings in components/script/dom/request.rs (#31867) 2024-03-27 12:10:43 +00:00
Martin Robinson
b8c82c1ab0
layout: Allow transforming inline replaced elements (#31833)
This requires passing through information about whether or not the
element in question is replaced when checking to see if it's
transformable and transitively all functions that make decisions about
containing blocks. A new FragmentFlag is added to help track this -- it
will be set on both the replaced items BoxFragment container as well as
the Fragment for the replaced item itself.

Fixes #31806.
2024-03-27 11:57:27 +00:00
Rosemary Ajayi
15cb9dd5fc
clippy: Fix various warnings in components/script/dom (#31890)
* redundant field names in struct initialization

* reduthis pattern creates a reference to a reference
2024-03-27 10:19:49 +00:00
komuhangi
29f796a1de
clippy: Fix some warnings in components/script/timers.rs (#31878)
* Fixed some clippy warnings in components/script/timers.rs

* Formatted changes in components/script/timers.rs

* Updated changes in components/script/timers.rs

* Updated Default implementation of JsTimers in components/script/timers.rs

* UPDATED DEFAULT METHOD IMPLEMENTATION OF JsTimers in components/script/timers.rs
2024-03-27 10:15:15 +00:00
Ekta Siwach
92b557867c
clippy: fixed some warnings in components/script (#31888) 2024-03-26 21:25:42 +00:00
Martin Robinson
8dece05980
fonts: Add support for WOFF2 and properly load web fonts from @imports (#31879)
This change also makes two fixes that are necessary to get WOFF2 fonts
working:

1. It adds support for loading web fonts from stylesheets included via
   @import rules.
2. It ensure that when web fonts are loaded synchronusly they invalidate
   the font cache. This led to incorrect font rendering when running
   tests before.

Fixes #31598.
2024-03-26 20:31:52 +00:00
Oluwatobi Sofela
b55d0a2053
clippy: Fix clone-on-copy warnings (#31877) 2024-03-26 19:55:20 +00:00
Frederik Reiter
5f7baf31c2
dom: Abort media element load on decode errors (#31748)
Signed-off-by: Frederik Reiter <hi@frereit.de>
2024-03-26 19:05:37 +00:00
Martin Robinson
bf3798bbde
layout: More conservatively replace Stylist's Device (#31857)
Instead of replacing Stylist's device on every reflow, only replace it
when the viewport changes. In addition, preserve the root font size from
the previous reflow fixing an issue where `rem` units were not properly
computed between reflows.

This fixes a bug where fonts that are sized using `rem` units change
size on reload.
2024-03-26 15:00:50 +00:00
Oluwatobi Sofela
b71de92569
clippy: Fix single_match warnings (#31876) 2024-03-26 14:01:10 +00:00
Oriol Brufau
d16f259e1d
Fix table with rows but no column (#31862)
* Fix table with rows but no column

We weren't generating any fragment for the rows, which meant that JS
APIs like clientWidth would be 0, and also outlines weren't painted.

This aligns Servo with Blink and WebKit. Gecko is broken, it distributes
twice the table height among the rows.

* Feedback

* Avoid conflict with #31874
2024-03-26 12:36:43 +00:00
Ekta Siwach
68b0be6dc7
clippy: Map to an error type instead of using allowing result_unit_err in components/url (#31834)
* clippy: fix warnings in components/url

* Fix code formatting issues in components/url/lib.rs

* Update components/url/lib.rs

Co-authored-by: eri <eri@inventati.org>

* made requested changes

---------

Co-authored-by: Ekta Siwach <ektasiwach@Ektas-MacBook-Air.local>
Co-authored-by: eri <eri@inventati.org>
2024-03-26 12:23:07 +00:00
Ekta Siwach
188f3caff1
clippy: fix some warnings in components/script (#31865) 2024-03-26 10:31:22 +00:00
Samson
58f170c97a
Update python detection in codegen (#31873)
* Update python detection in codegen

* Update build.rs
2024-03-26 10:14:06 +00:00
Oluwatobi Sofela
f8a2eaea47
clippy: Fix collapsible_else_if warnings (#31853) 2024-03-26 09:15:04 +00:00
Aarya Khandelwal
d814d05539
fixed the unneeded return statement warnings. (#31863) 2024-03-26 08:58:34 +00:00
Aarya Khandelwal
f7669b5238
fixes dereferencing on an immutable reference (#31864) 2024-03-26 08:37:44 +00:00
Oriol Brufau
e77dc36842
Pick the first or last baseline as appropriate (#31705)
The old logic was always picking the last baseline, but this should only
happen for inline-blocks.

Since replaced elements and flex containers aren't currently setting
their baselines, this is only an improvement for inline-tables.
2024-03-25 16:19:06 +00:00
Oluwatobi Sofela
a53632c0e5
clippy: Fix collapsible_if warnings (#31852) 2024-03-25 13:55:45 +00:00
Rosemary Ajayi
3d10dbae32
clippy: Fix some clippy warnings in components/script (#31843)
* deref on an immutable reference

* fix deref on an immutable reference

* fix deref on an immutable reference
2024-03-25 12:57:35 +00:00
Bastiaan van der Plaat
97144ddf71
script: Add pre element obsolete width attribute support (#31792) 2024-03-25 11:36:48 +00:00
Aarya Khandelwal
bd39e03eeb
changed match to 'matches!' (#31850) 2024-03-25 11:28:12 +00:00
eri
9a76dd9325
clippy: Fix remaining warnings in generated code (#31844)
* clippy: fix warnings in generated code

* clippy: fix wrap_panic closure warnings
2024-03-25 11:12:36 +00:00
Ekta Siwach
d8adeb1b44
clippy: Fix some warnings in components/script (#31849)
* clippy: fixed some warnings in components/script

* fixed formatting

* fix formatting
2024-03-25 10:22:21 +00:00
Oriol Brufau
dbe3cb8a3c
Don't update row baseline if cell is empty (#31831)
Gecko, Blink and WebKit agree that the if a row only has empty cells,
its baseline should be at the bottom, not at the top.

There isn't interoperability when the cells are just empty-ish, so this
patch takes the simplest approach, aligning with Blink: any out-of-flow
or in-flow content other than collapsed whitespace counts as not empty.
2024-03-25 09:39:02 +00:00
eri
58081579e9
WebIDL: Remove JSObject from Document::NamedGetter (#31841)
* WebIDL: Remove `JSObject` from `Document::NamedGetter`

* fix: update rustdoc comment
2024-03-24 18:04:04 +00:00
Oluwatobi Sofela
1ab38fcd3f
clippy: Fix default_constructed_unit_structs warnings in components (#31827)
* clippy: Fix default constructed unit structs warnings

* refactor: Allow default constructed unit structs to avoid gfx build error
2024-03-24 17:24:34 +00:00