Commit graph

6022 commits

Author SHA1 Message Date
bors-servo
7f156b8c12 Auto merge of #9072 - Manishearth:password-placeholder, r=eefriedman
Fix placeholders for password inputs

currently they show dots instead of the placeholder text

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9072)
<!-- Reviewable:end -->
2016-01-03 10:21:26 +05:30
Manish Goregaokar
cc5844a373 Move placeholder logic out of get_raw_textinput_value 2016-01-03 09:47:30 +05:30
bors-servo
9da739acef Auto merge of #9123 - karyon:clippy_cleanup, r=Manishearth
Fix a bunch of clippy lints

This fixes about 130 clippy lints. Let me know if i should split up the commit.

I wasn't sure about some of the changes, especially map_or instead of map(...).unwrap_or(...) and if let instead of single arm match were not always a strict improvement in my opinion, but i'll leave that decision to the reviewer :)

There are about 150 lints left which i thought were clippy bugs or i didn't know how to fix.

cc @Manishearth

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9123)
<!-- Reviewable:end -->
2016-01-03 09:16:34 +05:30
bors-servo
6844adbe2d Auto merge of #9082 - nikkisquared:websocket_bufferedamount, r=eefriedman
Updated WebSocket buffered_amount to match change to html specification

The size of WebSocket's buffered_amount was changed[1] after an issue I opened, which I found while working on WebSocket previously[2]. @jdm suggested I make a PR updating Servo reflecting this, and so I have! As always, I'd like to hear any feedback on anything I can do to improve this.

[1] https://github.com/whatwg/html/issues/296
[2] https://github.com/servo/servo/pull/8218#issuecomment-152021737 point 5)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9082)
<!-- Reviewable:end -->
2016-01-03 08:43:55 +05:30
bors-servo
ebf4ce8288 Auto merge of #9070 - antrik:debug-fonts, r=nox
Derive Debug for more font-related types

Needs to pull in newer ipc-channel and azure.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9070)
<!-- Reviewable:end -->
2016-01-03 08:11:57 +05:30
bors-servo
06d84e6e4b Auto merge of #9134 - iszak:issue-9132, r=nox
Fixes https://github.com/servo/servo/issues/9132

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9134)
<!-- Reviewable:end -->
2016-01-03 07:32:09 +05:30
Olaf Buddenhagen
3c5a3ca4ff Derive Debug for more font-related types 2016-01-03 02:54:55 +01:00
Olaf Buddenhagen
7197e7f311 cargo-update azure to get <Debug> 2016-01-03 02:54:52 +01:00
Olaf Buddenhagen
61149b316a cargo-update ipc-channel to get <Debug> 2016-01-03 02:54:49 +01:00
bors-servo
1ac330837f Auto merge of #9130 - iszak:issue-9081, r=nox
Fixes https://github.com/servo/servo/issues/9081

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9130)
<!-- Reviewable:end -->
2016-01-03 06:27:54 +05:30
Iszak Bryan
603d0a54ea Use atom's for matching to gain performance benefits 2016-01-03 00:13:52 +00:00
Iszak Bryan
1fa3d36167 Store state of fill or style for canvas pattern 2016-01-02 23:35:04 +00:00
Johannes Linke
6b215f38ee Fix a bunch of clippy lints 2016-01-02 23:27:15 +01:00
bors-servo
c0835ec336 Auto merge of #9122 - ckimes89:inputevent, r=nox
Add 'input' event for HTMLInputElement

Fixes #8613

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9122)
<!-- Reviewable:end -->
2016-01-03 00:31:55 +05:30
Chad Kimes
0e663e0f2f De-duplicate input event send code 2016-01-02 11:31:22 -05:00
Chad Kimes
12a0884f51 Add 'input' event for HTMLInputElement 2016-01-02 11:07:12 -05:00
bors-servo
b1ca3d1cdf Auto merge of #9111 - frewsxcv:rm-parsed-attr, r=nox
Remove parsed attribute 'bgcolor' field HTMLTableElement

https://github.com/servo/servo/issues/7863

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9111)
<!-- Reviewable:end -->
2016-01-02 18:20:10 +05:30
Michael Howell
92e9afa00a Revert "Update glutin"
This reverts commit ff7524af09.
2016-01-01 11:41:10 -07:00
bors-servo
7a5522a263 Auto merge of #9049 - KiChjang:form-data-refactor, r=eefriedman
Refactor FormData code to match updated spec

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9049)
<!-- Reviewable:end -->
2016-01-01 21:37:09 +05:30
bors-servo
11d160fc73 Auto merge of #9109 - nerith:createpattern, r=jdm
Support empty strings as the repeat argument (CreatePattern)

According to the third step in the specification [1], createPattern
should let the repetition argument be "repeat" when it is the empty
string.

The code in CanvasRenderingContext2D::CreatePattern did not implement
this step and instead threw a SyntaxError exception when an empty
string was supplied as the repetition argument.

Fixes #9079.

[1] https://html.spec.whatwg.org/multipage/#dom-context-2d-createpattern

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9109)
<!-- Reviewable:end -->
2016-01-01 21:04:51 +05:30
Keith Yeung
7001583047 Refactor FormData code to match updated spec
Use Atoms instead of Strings as keys
2016-01-01 05:38:10 -08:00
bors-servo
b8e7cd71d6 Auto merge of #8871 - KiChjang:task-source-channels, r=KiChjang
Add 5 different task source channels

This is **not** complete. I really need feedback right away since I felt that the direction I'm heading is very wrong.

Partial #7959.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8871)
<!-- Reviewable:end -->
2016-01-01 14:31:51 +05:30
Corey Farwell
7649748b83 Remove parsed attribute 'bgcolor' field HTMLTableElement
https://github.com/servo/servo/issues/7863
2015-12-31 14:15:54 -08:00
bors-servo
7371da6ca0 Auto merge of #9078 - nikkisquared:split_http_loader_load, r=jdm
Split http_loader::load into two methods

This is intended to fix #8976 by moving the http_loader::load code that deals with getting a response and moving it into its own function. I've built it and run existing tests against my changes and that looks fine. I'd like feedback on changes I've made to accommodate refactoring the code. And I'm sure there's a more descriptive function name than "load_response", I just wasn't sure how to describe what it does.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9078)
<!-- Reviewable:end -->
2016-01-01 01:48:09 +05:30
bors-servo
5e497cf311 Auto merge of #9099 - frewsxcv:rm-parsed-attr, r=nox
Remove fields with parsed attribute values on HTMLTextAreaElement

https://github.com/servo/servo/issues/7863

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9099)
<!-- Reviewable:end -->
2016-01-01 01:15:13 +05:30
bors-servo
3afbff27b6 Auto merge of #9096 - servo:glutinup, r=nox
Update glutin

… in order to pick up https://github.com/tomaka/glutin/pull/679, which will hopefully get rid of the `[glutin] x error code=8 major=42 minor=0!` messages printed on stdout.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9096)
<!-- Reviewable:end -->
2016-01-01 00:34:58 +05:30
bors-servo
d9bf672cb0 Auto merge of #9094 - servo:silent-debug-message, r=SimonSapin
Make a debugging println!() conditional on is_running_problem_test

… like other print messages introduced in 19a1e57c90

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9094)
<!-- Reviewable:end -->
2015-12-31 22:40:59 +05:30
Brandon Fairchild
1ccab328f9 Support empty strings as the repeat argument (CreatePattern)
According to the third step in the specification [1], createPattern
should let the repetition argument be "repeat" when it is the empty
string.

The code in CanvasRenderingContext2D::CreatePattern did not implement
this step and instead threw a SyntaxError exception when an empty
string was supplied as the repetition argument.

Fixes #9079.

[1] https://html.spec.whatwg.org/multipage/#dom-context-2d-createpattern
2015-12-31 11:48:15 -05:00
bors-servo
3791447de8 Auto merge of #9090 - Ms2ger:stylesheets-vec, r=SimonSapin
Don't copy the list of stylesheets in LayoutTask::handle_reflow.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9090)
<!-- Reviewable:end -->
2015-12-31 21:50:22 +05:30
Josh Matthews
20668da061 Accept all Content-Type values for fonts if sniffing is disabled. Restore the status quo. 2015-12-31 09:12:59 -05:00
Josh Matthews
bda341b217 Update mime_guess to incorporate TTF MIME changes. 2015-12-31 07:45:51 -05:00
Josh Matthews
afb4d90ad3 Send a response to font load initiators even when a font is ignored. 2015-12-31 07:45:50 -05:00
Josh Matthews
3d8881c6f2 Remove unneeded dead_code annotations. 2015-12-31 07:45:50 -05:00
Josh Matthews
cca25e2b3a Enable MIME sniffing via a pref instead of a global option. 2015-12-31 07:45:49 -05:00
Josh Matthews
9601d555cd Use valid MIME types in the font classifier. 2015-12-31 07:45:48 -05:00
Josh Matthews
e17e553f04 Restrict font loads to known MIME types. 2015-12-31 07:45:48 -05:00
David Rajchenbach-Teller
1e81b8c133 Resolves #4183 - Implemementing context-based MIME type sniffing
The version of the standard is not finalized at the time of this writing.
Specifications may be found here: https://mimesniff.spec.whatwg.org/#context-specific-sniffing .
2015-12-31 07:45:03 -05:00
bors-servo
66c8aa8cda Auto merge of #8420 - craftytrickster:8371/generic-font-family, r=glennw
Enabled use of FontFamily enum type

https://github.com/servo/servo/issues/8371

In addition to replacing loose strings with the FontFamily enum in `font_cache_task.rs`, I also centralized the add_generic_font calls into one single function. If centralizing into one function is not desired or if anything else needs to be changed, please let me know.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8420)
<!-- Reviewable:end -->
2015-12-31 16:49:48 +05:30
bors-servo
77b23d1bb9 Auto merge of #9105 - jdm:buttoneventsintermittent, r=nox
Implement support for modifying the type attribute of <button>

https://github.com/servo/servo/pull/9100

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9105)
<!-- Reviewable:end -->
2015-12-31 15:56:16 +05:30
Simon Sapin
ff7524af09 Update glutin
… in order to pick up https://github.com/tomaka/glutin/pull/679, which will hopefully get rid of the `[glutin] x error code=8 major=42 minor=0!` messages printed on stdout.
2015-12-31 00:58:44 +00:00
David Raifaizen
d942bfb474 Enabled use of FontFamily enum type and replaced plain string parameters with enum 2015-12-30 18:21:37 -05:00
Josh Matthews
3ef39e1a30 Implement the onreset event handler. 2015-12-30 16:04:16 -05:00
Josh Matthews
ffc1c777fe Implement support for modifying the type attribute of button elements. Fixes #9091. 2015-12-30 16:04:05 -05:00
Corey Farwell
3eb585f547 Remove fields with parsed attribute values on HTMLTextAreaElement
https://github.com/servo/servo/issues/7863
2015-12-30 12:27:13 -08:00
bors-servo
3d969e429d Auto merge of #7919 - 6112:master, r=nox
form submission for <textarea> and <select>

Fixes #7849.
Fixes #7850.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7919)
<!-- Reviewable:end -->
2015-12-30 23:58:40 +05:30
Nikki
b95af756ad now panics on integer overflow 2015-12-30 10:38:53 -07:00
Simon Sapin
46bb3e5778 Make a debugging println!() conditional on is_running_problem_test
… like other print messages introduced in 19a1e57c90
2015-12-30 17:21:15 +00:00
bors-servo
d6d70feabd Auto merge of #9089 - Ms2ger:style-unsafe, r=nox
Deny unsafe code in style.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9089)
<!-- Reviewable:end -->
2015-12-30 20:12:20 +05:30
Ms2ger
828392b41c Don't copy the list of stylesheets in LayoutTask::handle_reflow.
It would be nice to avoid exposing the fact that these are stored in an Arc
to the selector matching code.
2015-12-30 15:13:08 +01:00
Ms2ger
2fa45aa064 Deny unsafe code in style. 2015-12-30 14:46:35 +01:00