Commit graph

39889 commits

Author SHA1 Message Date
bors-servo
b274d59875
Auto merge of #25236 - pshaughn:safelistct, r=jdm
De-deplicate is_cors_safelisted_request_header helper functions

<!-- Please describe your changes on the following line: -->
Separate is_cors_safelisted_request_header implementations in script::dom::request and net::fetch::methods have been merged to a single implementation in net_traits::request, with additional logic for spec requirements that weren't previously there. This doesn't pass all the failing tests, but it doesn't fail any passing ones either and it reduces confusion about what's supposed to happen where.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25235 and some but not all subcases in #25175

<!-- Either: -->
- [X] There are tests for these changes, in that the WPT CORS tests that did already pass still do

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-16 20:51:09 -05:00
bors-servo
d205194618
Auto merge of #25070 - cagandhi:named-form-getter, r=jdm
Named form getter

This PR contains changes related to adding named getter in Servo for getting the list of all meaningful property names for a HTMLFormElement object, and getting the value of a specific property name. The following changes have been made:

* uncomment the [named getter](f63b404e0c/components/script/dom/webidls/HTMLFormElement.webidl (L30)) from HTMLFormElement.webidl
* add the missing `NamedGetter` and `SupportedPropertyNames` methods to [HTMLFormElement](f63b404e0c/components/script/dom/htmlformelement.rs (L113))
* implement `SupportedPropertyNames` according to [the specification](https://html.spec.whatwg.org/multipage/forms.html#the-form-element:supported-property-names):
  * create an enum to represent the `id`, `name`, and `past` states for the sourced names
  * create a vector of `(SourcedName, DomRoot<HTMLElement>)` by iterating over `self.controls` and checking the element type and calling methods like `HTMLElement::is_listed_element`
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #16479 (GitHub issue number if applicable)
2019-12-16 18:10:12 -05:00
bors-servo
846aa5b56a
Auto merge of #25309 - jdm:publisher, r=<try>
Adjust UWP packaging for submission.
2019-12-16 15:16:16 -05:00
Josh Matthews
b3d0388d83 Adjust UWP packaging for submission. 2019-12-16 15:15:13 -05:00
bors-servo
fb5ab1fc74
Auto merge of #25306 - paulrouget:lessAnimMsg, r=jdm
Do not wake up embedder on each animation tick

The constellation should only update the compositor if the animation state actually changed.
2019-12-16 14:59:50 -05:00
Alex Touchet
f634100c69
Use Windows 10 instead of 7 in user agent string 2019-12-16 10:34:18 -08:00
Anshul Jethvani
ef8496c7bc updated expected test results in log 2019-12-16 13:07:28 -05:00
bors-servo
c9baa5b9fc
Auto merge of #25211 - kunalmohan:6631-Worker-Id, r=jdm
`worker_id` type changed to uuid

<!-- Please describe your changes on the following line: -->
Fixes #6631
`worker_id` is now generate as uuid and saved as string.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #6631  (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-16 11:31:44 -05:00
Paul Rouget
016d9a62ab Do not wake up embedder on each animation tick 2019-12-16 16:50:36 +01:00
Simon Sapin
d670b4420a Add layout-2020 option to the .servobuild file
… and `--with-layout-2013` command-line option to disable it.
2019-12-16 15:36:18 +01:00
Patrick Shaughnessy
67827debd8 Now just one is_cors_safelisted_request_header, with closer spec alignment 2019-12-16 09:07:02 -05:00
Emilio Cobos Álvarez
7513bc293e Cherry-pick some parts of the cssparser update. 2019-12-16 14:23:56 +01:00
Emilio Cobos Álvarez
f7c5df5703 Update WPT expectations. 2019-12-16 14:23:56 +01:00
Emilio Cobos Álvarez
75a05f0fff Appease tidy. 2019-12-16 14:23:56 +01:00
Emilio Cobos Álvarez
ef16c5844f Rustfmt recent changes. 2019-12-16 14:23:56 +01:00
Emilio Cobos Álvarez
e885ccb7ae layout-2020: build fixes. 2019-12-16 14:23:56 +01:00
Emilio Cobos Álvarez
7d30a7da75 Servo build fixes. 2019-12-16 14:23:56 +01:00
Emilio Cobos Álvarez
c1c2b746c8 Update Cargo.lock. 2019-12-16 14:23:56 +01:00
Emilio Cobos Álvarez
ad61cae6b0 style: Update smallvec to 1.0.
Differential Revision: https://phabricator.services.mozilla.com/D56044
2019-12-16 14:23:56 +01:00
Emilio Cobos Álvarez
789ddd9dc1 style: Make LengthPercentage not copy.
This is needed to support min() / max() / clamp(), etc.

Differential Revision: https://phabricator.services.mozilla.com/D57249
2019-12-16 14:23:56 +01:00
Emilio Cobos Álvarez
a541046147 style: Use less Au in font code.
Font code is the only thing that was using Au in the style system without
interfacing with Gecko, and there was no real reason for it to do so.

This slightly simplifies the code.

Differential Revision: https://phabricator.services.mozilla.com/D57248
2019-12-16 14:23:56 +01:00
Emilio Cobos Álvarez
4cd8813a81 style: Remove full-screen-api.unprefix.enabled.
It's been enabled since Firefox 64.

Differential Revision: https://phabricator.services.mozilla.com/D56951
2019-12-16 14:23:56 +01:00
jeffin143
4b62e9ff2b style: convert NS_STYLE_VISIBILITY_* to an enum class in nsStyleConsts.h
Differential Revision: https://phabricator.services.mozilla.com/D56140
2019-12-16 14:23:56 +01:00
Emilio Cobos Álvarez
02c30bccbd style: Preserve CSS input exactly during sanitization.
This avoids the mutation due to the different serialization in some cases.

Differential Revision: https://phabricator.services.mozilla.com/D56732
2019-12-16 14:23:56 +01:00
jeffin143
e8a3a71080 style: convert NS_STYLE_POINTER_EVENTS_* to an enum class in nsStyleConsts.h
Differential Revision: https://phabricator.services.mozilla.com/D56203
2019-12-16 14:23:56 +01:00
Emilio Cobos Álvarez
d954f516e9 style: Fix serialization of @namespace rule.
This code comes from:

https://hg.mozilla.org/mozilla-central/rev/2418cfba72c33c5623f6fb4c243c5203819c8240

I audited other callers of write_str, they seem ok.

Differential Revision: https://phabricator.services.mozilla.com/D54601
2019-12-16 14:23:56 +01:00
Emilio Cobos Álvarez
7cd59da2a0 style: Invalidate shadow part pseudo-class styles correctly.
I was going to send a test for `:focus` via wpt, but then realized it was
probably not spec-compliant with the new rules people want to follow for
:focus, so I filed https://github.com/w3c/csswg-drafts/issues/4555 instead.

Testing `:hover` / `:active` via wpt looked quite a bit of a hassle.

Differential Revision: https://phabricator.services.mozilla.com/D55591
2019-12-16 14:23:56 +01:00
Cameron McCormack
6973317a58 style: Correctly style dark scrollbars in tree components.
We need to ensure the rules that override all properties for scrollbar
part elements only apply to those that are NAC (and so will be eligible
for NAC style sharing).  We have some uses of non-NAC <scrollbar>
elements that should continue to inherit properties from their parents.

To avoid any changes in rule matching order that come with changing specificity,
we add a new :-moz-native-anonymous-no-specificity pseudo-class.

While we're here, we note :-moz-native-anonymous-no-specificity (and the
regular :-moz-native-anonymous pseudo-class) as not needing style
sharing cache revalidation, as we never share NAC styles.

Differential Revision: https://phabricator.services.mozilla.com/D56154
2019-12-16 14:23:56 +01:00
jeffin143
e944962fe2 style: convert NS_STYLE_ISOLATION_* to an enum class in nsStyleConsts.h.
Differential Revision: https://phabricator.services.mozilla.com/D55378
2019-12-16 14:23:56 +01:00
Emilio Cobos Álvarez
baa9ac1903 style: Update derive_more.
Differential Revision: https://phabricator.services.mozilla.com/D56043
2019-12-16 14:23:56 +01:00
Emilio Cobos Álvarez
80ac4d2ff2 style: Avoid writing into the empty array header.
Differential Revision: https://phabricator.services.mozilla.com/D55291
2019-12-16 14:23:56 +01:00
Jan Andre Ikenmeyer
19226c5190
Let hyper automatically add a host header for HTTP/1 2019-12-16 14:01:18 +01:00
WPT Sync Bot
bbb2e62331 Update web-platform-tests to revision 47ce6ccdc49acfae697f1e04f90ce7678c78e2db 2019-12-16 11:08:21 +00:00
Anshul Jethvani
254bbc3b8c removed duplicate entries from sourcedNamesVec for step 7 of SupportedPropertyNames 2019-12-16 01:41:59 -05:00
Emilio Cobos Álvarez
f89c31120f
style: Remove layout.css.xul-box-display-values.survive-blockification.enabled.
Differential Revision: https://phabricator.services.mozilla.com/D55898
2019-12-15 21:03:48 +01:00
enordin
5e7d429c0a
style: Refactor InvalidationMap flags to use bitflags.
Differential Revision: https://phabricator.services.mozilla.com/D55862
2019-12-15 21:03:38 +01:00
Jonathan Kew
51c1dfee2d
style: Add support for parsing of the CSS text-underline-position property.
Differential Revision: https://phabricator.services.mozilla.com/D54722
2019-12-15 21:03:31 +01:00
enordin
3bd62cf0cd
style: Check for border-image-* initial specified values when serializing border shorthand.
Differential Revision: https://phabricator.services.mozilla.com/D55588
2019-12-15 21:03:23 +01:00
jeffin143
7e3e8e1ca8
style: convert NS_STYLE_RUBY_POSITION_* to an enum class in nsStyleConsts.h
Differential Revision: https://phabricator.services.mozilla.com/D55379
2019-12-15 21:03:15 +01:00
jeffin143
24f21f375a
style: convert NS_STYLE_TEXT_SIZE_ADJUST_* to an enum class in nsStyleConsts.h
Differential Revision: https://phabricator.services.mozilla.com/D55382
2019-12-15 21:03:10 +01:00
jeffin143
5cc43940ad
style: convert NS_STYLE_RUBY_ALIGN_* to an enum class in nsStyleConsts.h
Differential Revision: https://phabricator.services.mozilla.com/D55380
2019-12-15 21:03:04 +01:00
jeffin143
519a0e7759
style: convert NS_STYLE_TOP_LAYER_* to an enum class in nsStyleConsts.h
Differential Revision: https://phabricator.services.mozilla.com/D55377
2019-12-15 21:02:56 +01:00
bors-servo
b7aaff4995
Auto merge of #25298 - servo-wpt-sync:wpt_update_15-12-2019, r=servo-wpt-sync
Sync WPT with upstream (15-12-2019)

Automated downstream sync of changes from upstream as of 15-12-2019.
[no-wpt-sync]
r? @servo-wpt-sync
2019-12-15 09:25:58 -05:00
WPT Sync Bot
7c092deb11 Update web-platform-tests to revision a9e454c8001472320dc3f049f6180427256a44dc 2019-12-15 11:04:52 +00:00
bors-servo
2a54d41295
Auto merge of #25291 - servo-wpt-sync:wpt_update_14-12-2019, r=jdm
Sync WPT with upstream (14-12-2019)

Automated downstream sync of changes from upstream as of 14-12-2019.
[no-wpt-sync]
r? @servo-wpt-sync
2019-12-14 18:07:34 -05:00
bors-servo
e8b93d3af3
Auto merge of #25253 - marmeladema:issue-23607/test-tidy-self-test, r=jdm
Make `mach test-tidy --self-test` compatible with Python3

It now runs in CI to avoid future regressions.
See #23607

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-14 14:26:13 -05:00
bors-servo
226b341078
Auto merge of #25205 - shnmorimoto:fix_performance_interface_timing_member, r=jdm
Fix performance interface timing member

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23330 and #24468 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-14 10:42:16 -05:00
Josh Matthews
a4c7e9b00a
Remove intermittent failure. 2019-12-14 09:31:22 -05:00
Josh Matthews
95491bcf4a
Remove intermittent error. 2019-12-14 09:26:25 -05:00
marmeladema
4fc5154dd1 Make mach test-tidy --self-test compatible with Python3 2019-12-14 12:42:47 +00:00