Commit graph

17092 commits

Author SHA1 Message Date
bors-servo
0a3a50a129 Auto merge of #10706 - zwn:unused-extern-crates, r=nox
Turn on unused-extern-crates warning.

As discussed in #9256. It should solve second half of the issue.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10706)
<!-- Reviewable:end -->
2016-04-22 13:40:38 -07:00
Michael Howell
7940b22158 compositing/script: Do not dispatch the resize event when initially loading.
No bug report corresponds to this, but I noticed it while trying to
reduce #10593
2016-04-22 13:36:43 -07:00
Zbynek Winkler
4bdc895d95 Turn on unused-extern-crates warning. 2016-04-22 22:20:07 +02:00
Zbynek Winkler
41c293293b Remove references to unused crates.
The cleanup is based on info from using "-W unused-extern-crates".
2016-04-22 22:20:06 +02:00
Zbynek Winkler
b021874ba0 Silence unused-extern-crates false positives.
Added #[allow(unused_extern_crates)] to silence false positives

 * bitflags, lazy_static and matches because macro_use
 * alloc_jemalloc because builtin crate

See https://github.com/rust-lang/rust/issues/30849
2016-04-22 22:20:05 +02:00
bors-servo
c372dee6ca Auto merge of #10697 - bholley:need_clone, r=SimonSapin
Implement enough of geckolib to cascade the first node

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10697)
<!-- Reviewable:end -->
2016-04-22 12:56:13 -07:00
bors-servo
82938547ed Auto merge of #10757 - ineol:root-node, r=Ms2ger
Implement Node::rootNode

Fixes #10747.

I don't know whether it's OK to recurse up the tree, though it is a tail call.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10757)
<!-- Reviewable:end -->
2016-04-22 12:10:52 -07:00
bors-servo
f1defb446e Auto merge of #10443 - emilio:webgl-teximage2d-overload, r=jdm
webgl: Implement the pending texImage2D overload, and add more validation

This is a large-ish refactor of the Texture2D code, but it should be
easier to read and of course more correct.

I tried to annotate every error condition with a spec paragraph.

I made just a reftest to ensure this works as intended, since I expect #10373 to land pretty soon.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10443)
<!-- Reviewable:end -->
2016-04-22 11:25:29 -07:00
bors-servo
d926b5d376 Auto merge of #10751 - zwn:tidy-start-operator, r=Wafflespeanut
Report lines starting with && in tidy

Partial implementation of the issue #10692 (the easy part).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10751)
<!-- Reviewable:end -->
2016-04-22 10:40:06 -07:00
bors-servo
4da6855e23 Auto merge of #10651 - craftytrickster:10601/current-color, r=Ms2ger
Setting current color to black if canvas is not rendered in document

Fixes #10601

The change seems deceptively easy, I hope I am not missing anything...

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10651)
<!-- Reviewable:end -->
2016-04-22 09:26:51 -07:00
bors-servo
a262c3121f Auto merge of #10807 - jdm:disable_sslfail, r=Wafflespeanut
Disable sslfail.html pending further investigation in #10760.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10807)
<!-- Reviewable:end -->
2016-04-22 08:42:11 -07:00
Josh Matthews
055a852f18 Disable sslfail.html pending further investigation in #10760. 2016-04-22 11:34:23 -04:00
bors-servo
3aae162426 Auto merge of #10803 - servo:css-20160422, r=Ms2ger
Update CSS tests to revision b9c63d615a65c4d96f26969bcd504d4e1c3cdab8

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10803)
<!-- Reviewable:end -->
2016-04-22 07:18:04 -07:00
David Raifaizen
b5159dc7ff Setting current color to black if canvas is not rendered in document 2016-04-22 09:59:49 -04:00
bors-servo
340a25e68c Auto merge of #10729 - fitzgen:unit-tests-for-time-profiler, r=larsbergstrom
Add unit tests skeleton for the time profiler

This commit adds a test crate for the time profiler to `tests/unit/profile`. The
only unit test contained in this crate is a smoke test that the time profiler
thread can be created and destroyed. It serves as a place for adding new tests
in the future.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10729)
<!-- Reviewable:end -->
2016-04-22 06:05:49 -07:00
Zbynek Winkler
39780ca39f Report lines starting with &&. 2016-04-22 14:28:20 +02:00
Zbynek Winkler
924d804583 Move '&&' to the end of the previous line.
Following https://github.com/servo/servo/issues/10692 this is just a
formating change to satisfy a new tidy requirement of not having '&&' at
the beginning of a line.
2016-04-22 14:28:18 +02:00
Zbynek Winkler
01b111c43e Add newline to the output.
The last line of output from tidy did not end with a newline if some
errors were reported.
2016-04-22 14:28:17 +02:00
Nazım Can Altınova
47f43d45a7 Implement Element::hasAttributes 2016-04-22 15:18:08 +03:00
bors-servo
f2c213fa58 Auto merge of #10754 - Ms2ger:disable-mutation-events, r=nox
Disable tests for mutation events.

We have no intention of implementing them, so there's not much point in
running them.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10754)
<!-- Reviewable:end -->
2016-04-22 05:09:50 -07:00
Léo Stefanesco
00b3f7930e Implement Node::rootNode 2016-04-22 13:18:50 +02:00
bors-servo
6f801e3f3f Auto merge of #10758 - jdm:tidy_check_completeness, r=Wafflespeanut
Ensure that we aren't missing any errors in the tidy self-test.

r? @Wafflespeanut

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10758)
<!-- Reviewable:end -->
2016-04-22 02:40:29 -07:00
bors-servo
a89dff95f8 Auto merge of #10802 - servo:webgl, r=Ms2ger
Disable WebGL tests.

They're not stable enough right now, with no expectation of improvement
any time soon.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10802)
<!-- Reviewable:end -->
2016-04-22 01:26:17 -07:00
Ms2ger
4d13f9f5d5 Update CSS tests to revision b9c63d615a65c4d96f26969bcd504d4e1c3cdab8 2016-04-22 10:06:45 +02:00
Ms2ger
64b26e0e78 Disable WebGL tests.
They're not stable enough right now, with no expectation of improvement
any time soon.
2016-04-22 09:57:31 +02:00
Tyler Southwick
b747951d15 Remove unused code and make utils private 2016-04-22 00:45:17 -07:00
Bobby Holley
735f1ff523 Replace panics with warnings for unimplemented property setters and copiers. 2016-04-21 23:57:45 -07:00
Bobby Holley
e6fe4791f3 Remove no_move annotation now that gecko style structs are movable. 2016-04-21 23:57:44 -07:00
Bobby Holley
4c5f1a375e Regenerate style struct bindings with latest bindgen and gecko. 2016-04-21 23:57:43 -07:00
Bobby Holley
81f3239f69 Stub out is_multicol for now. 2016-04-21 23:57:42 -07:00
Bobby Holley
1a727225a6 Unstub text-orientation.
The spec has changed a bit since the servo implementation. We still need to alias
sideways-right to sideways and add other writing modes, but we can do that later.
2016-04-21 23:57:41 -07:00
Bobby Holley
6d2284cdb7 Implement border-*-width. 2016-04-21 23:57:40 -07:00
Bobby Holley
6e09ff3234 Implement font-size. 2016-04-21 23:57:39 -07:00
Bobby Holley
2b415bfe97 Implement outline-style and outline_has_nonzero_width. 2016-04-21 23:57:38 -07:00
Bobby Holley
81a1d32387 Implement border_SIDE_has_nonzero_width. 2016-04-21 23:57:37 -07:00
Bobby Holley
9cec012765 Add support for border-*-style. 2016-04-21 23:57:36 -07:00
Bobby Holley
bba4447637 Support the text-decoration-style property. 2016-04-21 23:57:35 -07:00
Bobby Holley
611a2f0991 Handle BORDER_STYLE_MASK.
Gecko uses the higher bits of certain border-style-like properties to store other things.
This duplicates the logic in Gecko's {Get,Set}BorderStyle and similar.
2016-04-21 23:57:34 -07:00
Bobby Holley
ca7e80e50c Regenerate bindings with gfx/2d/Types.h included. 2016-04-21 23:57:33 -07:00
Bobby Holley
8099e0c0b9 Manually implement overflow-y. 2016-04-21 23:57:32 -07:00
Bobby Holley
980c814e2a Manually implement the display property for now. 2016-04-21 23:57:31 -07:00
Bobby Holley
972cc7ead5 Use strings rather than arrays for skip_longhands and skip_additionals.
This matches what we do in components/style.
2016-04-21 23:57:30 -07:00
Bobby Holley
cc35d4fcce Get rid of some of our custom additional methods in favor of clonable keywords.
Now that I'm pretty convinced we can auto-generate these and make them fast, we can
ditch the additional complexity.
2016-04-21 23:57:29 -07:00
Bobby Holley
456b05e9cf Make predefined_type use kwargs. 2016-04-21 23:57:28 -07:00
Bobby Holley
a4ee11da0a Track cloning separately from additional_methods and auto-generate clone methods. 2016-04-21 23:57:27 -07:00
bors-servo
0e0e902edd Auto merge of #10727 - jdm:canvas_panic, r=pcwalton
Use DOM width/height for canvas display list item.

Fixes #10705.

r? @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10727)
<!-- Reviewable:end -->
2016-04-21 20:50:27 -07:00
Josh Matthews
1623114376 Use DOM width/height for canvas display list item. 2016-04-21 23:20:21 -04:00
bors-servo
dff217c2e3 Auto merge of #10723 - edunham:modelines, r=Wafflespeanut
Remove some Emacs & Vim modelines

This might be a bad idea, especially on the webidl side. However, we started talking about the idea that modelines are a lint error (https://github.com/servo/servo/issues/10719), and these changes would be required before enabling a modeline lint.

If it bitrots, it's easy to recreate with
```
find * -type f -exec sed '/- Mode:/d' -i {} +
find * -type f -exec sed '/ vim:/d' -i {} +
git checkout -- python/tidy/servo_tidy/tidy.py
git checkout -- python/tidy/servo_tidy_tests/spec.webidl
git commit -a
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10723)
<!-- Reviewable:end -->
2016-04-21 20:05:04 -07:00
bors-servo
b080da474f Auto merge of #10791 - servo:explicit-python-path, r=KiChjang
Blind attempt at fixing a Python import error on Windows.

See #10789.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10791)
<!-- Reviewable:end -->
2016-04-21 17:26:11 -07:00
Corey Farwell
89c4daa834 Complete 'inefficient' FIXME by remove unnecessary clone. 2016-04-21 18:40:42 -04:00