Ms2ger
1dad710063
Replace Root::deref() calls by Root::r() calls where possible.
...
This changes those calls that were already sound.
2015-01-01 20:36:43 +01:00
bors-servo
56d1b16d1b
auto merge of #4173 : Manishearth/servo/a-more-dom-struct, r=kmcallister
...
Now `#[dom_struct]` also generates Reflectable impls, and there's another lint to ensure that a DOM struct only contains one bare DOM field (as the first field) or a Reflector.
A lot of this was generated by sed -- each autogenerated change has its own commit for easy review; these will be squashed later.
2014-12-27 22:12:45 -07:00
Manish Goregaokar
e9d1740e19
script: to_string() -> into_string()
2014-12-27 14:48:36 +01:00
Manish Goregaokar
21a888341d
Ensure that Reflectors are the first field
2014-12-27 02:53:36 +05:30
Manish Goregaokar
552db382d6
Remove manual impls of Reflectors (autogen)
...
Obtained via:
`find . -maxdepth 1 -type f -print0 | xargs -0 sed -z -i "s/\\nimpl Reflectable for[^{]*{[^}]*}[^}]*}\\n//"`
`find . -maxdepth 1 -type f -print0 |xargs -0 grep -lZ dom_struct | xargs -0 grep -LZ "reflector()\\|Reflector::new" |xargs -0 sed -z -i "s/use dom::bindings::utils::{Reflectable, Reflector, reflect_dom_object};/use dom::bindings::utils::reflect_dom_object;/"`
followed by semi-automated removal of leftover imports
2014-12-27 02:52:33 +05:30
Ms2ger
466faac2a5
Update rustc to revision 3dcd2157403163789aaf21a9ab3c4d30a7c6494d.
2014-12-17 15:19:45 -05:00
bors-servo
5951056973
auto merge of #4133 : mttr/servo/form_resetting, r=jdm
...
We can reset `<input type=text>` fields! I wish I could've done something with checkboxes, but unfortunately, that's it for now.
In addition to that, this PR implements `HTMLInputAttribute.defaultValue`, updates wpt-test to expect passing tests as a result of that implementation, and fixes an index error crash with text inputs.
edit: also includes an html example where one may lazily watch form resets in action: ` tests/html/form_reset_handsfree.html`
2014-12-16 15:03:49 -07:00
Matthew Rasmus
504f968b20
Implements :indeterminate pseudo-class
...
Addresses reviews
2014-12-16 11:34:04 -08:00
Matthew Rasmus
0c8e1aeda3
Implements dirty value/checked flags for input
...
And modifies test-inputs.html to test.
Fixes wpt breaking mistake
2014-12-16 11:34:04 -08:00
Matthew Rasmus
a5c0bb708d
htmltextarea: Fixed some value_changed issues
...
Also modified tests/html/textarea.html to allow for the testing of the
textarea's dirty value flag.
2014-12-16 11:34:04 -08:00
Matthew Rasmus
7e0c39a82d
Implements FormControl for HTMLTextAreaElement
2014-12-16 11:34:04 -08:00
Matthew Rasmus
fc0748f50e
Makes layout respect <textarea> rows attribute
...
review addresssing
2014-12-16 11:02:01 -08:00
Matthew Rasmus
2c7f6076d1
Makes layout respect <textarea> cols attribute
2014-12-16 10:44:15 -08:00
Patrick Walton
d101c1dd91
script: Improve dirty propagation and fix script-layout synchronization.
...
This fixes race conditions whereby layout and script could be running
simultaneously.
2014-12-15 14:16:04 -08:00
Matthew Rasmus
c97a4d999e
Handle default uint attributes properly
...
...and passing a whole bunch of new tests.
2014-12-05 12:31:32 -08:00
Matthew Rasmus
f5bd8f830a
HTMLTextArea: Implements a dirty value flag
2014-12-05 12:31:31 -08:00
Matthew Rasmus
ed37b53a62
Updates WPT to expect newly passing tests
...
Addresses reviews
More review addressing
2014-12-05 12:31:31 -08:00
Matthew Rasmus
29241699fd
Implements multi line text input for TextArea
2014-12-05 12:21:31 -08:00
Matthew Rasmus
fd65b5f438
Implements some HTMLTextAreaElement attributes
...
These attributes all reflect their own related content values, with the
exception of defaultValue, which acts as an alias for its IDL
textContent attribute.
Many of these do have default values and constraints which are currently unimplemented.
2014-12-05 12:21:31 -08:00
Bruno de Oliveira Abinader
bbab8831e0
Usage of JSRef<Attr> in before_remove_attr & after_set_attr
...
JSRef<Attr> does not require allocating a DOMString for value, which are
unused in most cases. It also provides more access to Attr data.
2014-10-22 11:13:58 -04:00
Manish Goregaokar
3f2cbb275b
Use #[dom_struct] everywhere
2014-10-16 10:20:18 +05:30
Tim Taubert
df60f8b2c5
Privatize EventTarget and EventListenerEntry
2014-10-13 13:25:43 +02:00
Tim Taubert
9a52bb8310
Privatize InheritTypes
2014-10-13 11:13:12 +02:00
Manish Goregaokar
8a2c746e61
Add type IDL attr for submittable elements
2014-10-11 09:48:15 +05:30
Manish Goregaokar
1484acb7af
Address review comments
2014-10-08 14:37:22 +05:30
Manish Goregaokar
3a1f9bd7fb
Use macro setters everywhere else
2014-10-07 22:22:54 +05:30
Gilles Leblanc
3a5a66d54e
Take the prefix from createElementNS into account for HTML elements
...
Fixes #3139
2014-10-06 22:49:49 -04:00
Keegan McAllister
6429750b33
Eliminate servo_util::atom
...
We only needed this for Encodable, and now we use JSTraceable instead.
2014-09-29 18:39:36 -07:00
ProgramFOX
71a05a9c39
Made some DOM fields private.
...
Relevant to #2242 .
2014-09-26 20:35:01 +02:00
Manish Goregaokar
cc44a3b064
Use JSTraceable everywhere
2014-09-24 05:44:49 +05:30
Cameron Zwarich
2c8d51a37c
More progress in the &JSRef -> JSRef conversion
...
Change all of the <Class>Methods traits to take `self` instead of
`&self`.
2014-09-20 11:54:10 -07:00
Cameron Zwarich
4fa8725111
First steps of &JSRef -> JSRef conversion
...
Replace &JSRef with JSRef in the bulk of the generated code. This will
remove a level of indirection throughout all DOM code.
This patch doesn't change methods implemented on JSRef<T> to take `self`
rather than `&self`, and it leaves a few other uses of &JSRef, but those
changes can be made incrementally.
2014-09-19 13:39:17 -07:00
Manish Goregaokar
f5087e1490
Use #[must_root] for HTMLElements
2014-09-17 01:02:44 +05:30
Jack Moffitt
c6ab60dbfc
Cargoify servo
2014-09-08 20:21:42 -06:00
