On Android, our feeble GPU graphics stack is even less reliable than it is on Linux. To make it easier to bring Android devices online, this patch defaults to CPU rendering, which is much more stable and, frankly, faster.
r? @metajack
see #2116
I add an `is_interval` field, so that when the `TimerData` is passed by `SetInterval`, we will not delete it from `active_timers`.
Also I think maybe we can extract the code in `ClearTimeout` and `ClearInterval` into another method to avoid duplicate.
This reverts [some changes made during the 2014-03-04 Rust upgrade](bbac8aa5c3 (diff-d084c1d37003c83f26aa4dac0e8d9e6bL221)). @larsberg, what was the reason for preferring the unsafe `.to_ascii_nocheck()`?
r? @larsberg
By forgetting the Some(), we caused type inference to convert to Option<T>
for optional non-nullable primitive arguments, and to Option<Option<T>> for
optional nullable primitive arguments (essentially the same thing). This
change brings the primitive codegen in line with the DOMString codegen.
Using distinct types for optionality and nullability would have prevented
this issue.
We are calling `get` when we should call `borrow` or `borrow_mut`. This is causing bugs with iframes because we append the child frame to a copy of the parent's `children` vector rather than the original.
r? @larsbergstrom
We are calling `get` when we should call `borrow` or `borrow_mut`. This is
causing bugs with iframes because we append to a copy of the `children` vector
rather than the original.
There is no good reason to have both unwrap_object and unwrap_jsmanaged.
Removing unwrap_object simplifies the codegen and makes further
simplifications easier.
Instead, use shared code to parse stylesheet content when it is inserted,
whether during parsing or dynamically by script.
Based on work by sanools in #1350.
See #2090
One reftest compares a green image to a white div. The other has green text being compared with normal text.
If necessary, I can add some absolute positioning ones.
This improves the code written for #1822 to use a single linear traversal.
The current code uses a binary search with `CompareDocumentPosition()` for comparing element position, however this method internally calls `traverse_preorder()` (i.e. a linear traversal) so calling this on every pass is quite inefficient.
