Commit graph

412 commits

Author SHA1 Message Date
Ms2ger
944d8b00b0 Call the generated rather than the hand-written traits (fixes #2936). 2014-07-27 23:00:17 +02:00
Ms2ger
38a658d561 Generate traits for the generated bindings code to call. 2014-07-27 22:59:46 +02:00
Ms2ger
3a68b9dbf2 Remove an unused argument to needCx and use it in CGCallGenerator. 2014-07-27 22:54:51 +02:00
Ms2ger
e34bcaaa5f Pass a non-nullable string to NamedGetter.
There is no actual reason to use a nullable string here; all callers have a
string they want to pass.

The issue dates back to the time that DOMString was inherently nullable
(before #1215); this API was not converted back to the non-nullable DOMString
type after that landed.
2014-07-27 22:54:01 +02:00
Ms2ger
829259fb79 Introduce abstractions for global scopes.
Part of #2811.
2014-07-15 15:33:57 +02:00
Ms2ger
a51ed7045c Remove the unused 'obj' local from the construct hook. 2014-07-14 11:42:42 +02:00
Ms2ger
ac5a2767bf Move the call to RegisterBindings::Register into WindowBinding::Wrap. 2014-07-13 15:45:16 +02:00
Ms2ger
5baff0cc2c Pass a JSContext and a reflector to RegisterBindings::Register.
This makes the generated code less dependent on the fact that all global
objects are Windows.
2014-07-13 15:45:16 +02:00
Ms2ger
fd167f8922 Store proxy handlers in a static array rather than a hashtable per window. 2014-07-12 15:26:36 +02:00
Josh Matthews
f47b66b0c1 Merge pull request #2807 from Ms2ger/pyflakes-2
Remove some dead code and fix some pyflakes warnings in CodegenRust.py.
2014-07-11 20:48:41 -04:00
Ms2ger
a867e4bd52 Remove some dead code and fix some pyflakes warnings in CodegenRust.py. 2014-07-11 14:51:43 +02:00
Ms2ger
439bc78cab Return a Temporary from *Binding::Wrap.
Returning a JS<T> is GC-unsafe.

This commit also includes some cleanup around Node and Document reflection.
2014-07-10 16:45:41 +02:00
Manish Goregaokar
7cc8e2eb57 Remove deref_mut from Untraceable/Traceable (fixes #2736) 2014-07-01 00:59:52 +05:30
Manish Goregaokar
f5b5b337d3 Upgrade to latest Rust. 2014-06-27 18:50:32 -06:00
Ms2ger
696c57006b Store this-values and arguments in immutable locals in codegen. 2014-06-22 17:17:27 +02:00
Ms2ger
4f0d6979e7 Implement static attributes (fixes #1989). 2014-06-22 15:15:18 +02:00
Ms2ger
6d2784aece Implement static methods (fixes #1989). 2014-06-22 15:15:12 +02:00
Ms2ger
92f9fe59e5 Introduce static makeNativeName methods to share code with the upcoming static members. 2014-06-22 15:10:56 +02:00
Ms2ger
4964d2792e Pass the NativeProperties struct to CreateInterfaceObjects2.
This will simplify adding more kinds of properties, such as static attributes.
2014-06-22 13:25:18 +02:00
Ms2ger
886d401ff0 Introduce a NativeProperties struct to store the properties.
This will simplify adding more kinds of properties, such as static attributes.
2014-06-22 13:25:18 +02:00
Ms2ger
da28a791e5 Store the arrays of properties as &'static [T] rather than [T, ..N].
This means the .as_slice() call (which is problematic when storing the array
in a static struct) is no longer necessary.
2014-06-22 13:25:18 +02:00
Ms2ger
0731045249 Remove some spurious newlines from the generated code. 2014-06-21 20:07:09 +02:00
Ms2ger
5fb475617b Move the responsibility for indenting code from CGAbstractMethod.definition_body to its caller. 2014-06-21 14:48:23 +02:00
Ms2ger
46b9343459 Use CGIndenter for CGRegisterProtos.definition_body. 2014-06-21 14:44:08 +02:00
Ms2ger
f3a8f74d3c Use CGIndenter for CGClassConstructHook.definition_body. 2014-06-21 14:38:58 +02:00
Ms2ger
31ab6415c9 Use CGIndenter for CGAbstractClassHook.definition_body. 2014-06-21 14:36:35 +02:00
Ms2ger
504efb66fb Indent the contents of obj_toString correctly. 2014-06-21 14:25:08 +02:00
Ms2ger
eb4213f613 Indent the contents of get. 2014-06-21 14:22:14 +02:00
Ms2ger
b5ca6d9a37 Indent the contents of hasOwn. 2014-06-21 14:19:31 +02:00
Ms2ger
cf556cbbd6 Indent the contents of defineProperty. 2014-06-21 14:14:49 +02:00
Ms2ger
8ef51158ff Indent the contents of getOwnPropertyDescriptor. 2014-06-21 14:10:14 +02:00
Ms2ger
df552fca5d Use CGIndenter for CGProxyUnwrap.definition_body. 2014-06-21 13:57:54 +02:00
Ms2ger
5affa73aa1 Use CGIndenter for CGSpecialized{Method, Getter, Setter}.definition_body. 2014-06-21 13:57:39 +02:00
Ms2ger
437c025e99 Stop indenting in CGMethodCall. 2014-06-21 13:48:55 +02:00
Ms2ger
fa7a0aae75 Use CGIndenter for CGDefineDOMInterfaceMethod.definition_body. 2014-06-21 13:41:38 +02:00
Ms2ger
b717fbe868 Use CGIndenter for CGGetPerInterfaceObject.definition_body. 2014-06-21 13:38:57 +02:00
Ms2ger
44a609d563 Use CGIndenter for CGWrapMethod.definition_body. 2014-06-21 13:37:18 +02:00
Ms2ger
644df404f5 Return a CGThing from CGAbstractMethod.definition_body. 2014-06-21 13:34:37 +02:00
Ms2ger
6cf79732f9 Move the responsibility for indentation to CGAbstractBindingMethod.definition_body from its callees. 2014-06-21 13:24:51 +02:00
Ms2ger
8df0f981fe Keep calling the DefineDOMInterface method for NoInterfaceObject interfaces.
DefineDOMInterface also creates the proxy handler for proxy classes, so it
should be called in this case as well.
2014-06-20 19:21:47 +02:00
Ms2ger
5acbea5199 Pass the interface object-related arguments to CreateInterfaceObjects2 together in an Option.
This clarifies the code and fixes our support of NoInterfaceObject interfaces.
2014-06-20 18:47:31 +02:00
Ms2ger
f11e7ee0a9 Generate code for NoInterfaceObject interfaces in InterfaceTypes and InheritTypes.
There is no reason for those interfaces to be excluded.
2014-06-20 17:52:20 +02:00
Ms2ger
c8b8550cfb Correct the condition for generating CGGetConstructorObjectMethod.
As we don't actually implement the feature for which this is needed, I've
commented the call out for now and mentioned the issue for the feature.
2014-06-20 15:20:19 +02:00
Ms2ger
d7c4f2ba93 Stop pretending that CreateInterfaceObjects2 can return the interface object.
We do not currently support the case of a non-callback interface that doesn't
have an interface prototype object. (This case is not allowed by the WebIDL
specification; it was added to Gecko to allow feature-detecting the URL
interface. See <https://bugzilla.mozilla.org/show_bug.cgi?id=1026720>.)

It follows that, if we call CreateInterfaceObjects2 at all, we will call it
with a protoClass argument, so there is no reason to use a nullable pointer
type for that argument.

Moreover, if we had actually supported that case, the returned interface
object would have been stored in the interface prototype object cache, to ill
effect.
2014-06-20 10:33:47 +02:00
Ms2ger
5a1ed6396e Handle JSAPI OOM failures by task failure as soon as possible.
We already ensure to fail the task if GetProtoObject returns null, as we don't
have a useful way to handle OOM, and we don't wish to thread the failure
through to some place where we could handle it in a useful way.

Unfortunately, we cannot ensure through the type system that none of those
functions returns null, so we use assertions to check it dynamically.
2014-06-20 09:46:12 +02:00
Ms2ger
90b6c77666 Remove unused code to support preffed-off and chrome-only APIs. 2014-06-14 13:14:34 +02:00
bors-servo
c0576108c5 auto merge of #2585 : ebalint/servo/2530, r=jdm 2014-06-13 14:04:45 -04:00
Edit Balint
94ec3cde8a Split Page code out of script_task.rs #2530 2014-06-13 19:28:57 +02:00
Ms2ger
c331b200b1 Use Cell for Reflector::object. 2014-06-13 19:19:56 +02:00
Ms2ger
44f57ae6da Pass a JSRef to RegisterBindings::Register.
JS<T> should only be used for members of traced structures; the correct type
for arguments is JSRef.
2014-06-11 12:40:12 +02:00