Commit graph

37270 commits

Author SHA1 Message Date
Josh Matthews
0edf865deb Index taskcluster tasks by merge parents if available. 2019-05-23 18:35:07 +02:00
bors-servo
f24f517965
Auto merge of #23272 - tdelacour:ISSUE-20455, r=SimonSapin
ISSUE-20455: introduce stronger types for textinput indexing

<!-- Please describe your changes on the following line: -->
Added two new types:
- ByteOffset
- UTF16CodeUnitOffset

I've replaced any instance of `usize` that would be better represented by one or the other of these. I also updated any downstream code, including the unit tests for `textinput.rs`. Along the way, I tried to add or edit comments to better reflect my understanding of this file - happy to revisit if I have misrepresented anything.

I did not end up finding any places where types were very obviously being mixed, as the issue description suggested I should do... LMK if I should re-audit the file for that (might need a bit of guidance)!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20455 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23272)
<!-- Reviewable:end -->
2019-05-23 12:01:29 -04:00
Josh Matthews
8426c14422
Remove intermittent failure. 2019-05-23 09:47:19 -04:00
Simon Sapin
ed4c1ff3d6 Add some SSH keys to tc-mac workers 2019-05-23 13:35:36 +02:00
Bastien Orivel
c7ff341768 Update darling to 0.9 2019-05-23 12:14:56 +02:00
bors-servo
e0c95ed855
Auto merge of #23442 - jdm:no-glutin-up, r=jdm
Revert glutin upgrade.

#23409 is permanently affecting all macOS android builds starting with this PR.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23442)
<!-- Reviewable:end -->
2019-05-22 23:53:01 -04:00
Josh Matthews
60688da71a Revert "Glutin update: dependencies update"
This reverts commit 30fb18e711.
2019-05-22 14:18:38 -04:00
Josh Matthews
8606af4104 Revert "Glutin update: ignore rand-core and nix duplicate"
This reverts commit da28a0c580.
2019-05-22 14:18:33 -04:00
Josh Matthews
414a854e77 Revert "Glutin update: ignore gl_generator duplicate"
This reverts commit 5bdb0da657.
2019-05-22 14:18:27 -04:00
Josh Matthews
40cdad1b3e Revert "Glutin update: new Context API"
This reverts commit d55d6644a0.
2019-05-22 14:18:20 -04:00
Simon Sapin
5d3fc37e26 PR #23272 review nits 2019-05-22 19:59:33 +02:00
Maharsh
85c20db495 Extract canvas operations for reuse by OffscreenCanvas. 2019-05-22 10:24:54 -04:00
bors-servo
a911b82e27
Auto merge of #23288 - paulrouget:glutin-21, r=jdm
Glutin 0.21

Fix #23189

Depends on #23233

Dependencies update:
- https://github.com/servo/rust-webvr/pull/73
- https://github.com/servo/skia/pull/172
- https://github.com/servo/rust-glx/pull/23
- https://github.com/servo/rust-offscreen-rendering-context/pull/134

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23288)
<!-- Reviewable:end -->
2019-05-22 10:02:14 -04:00
WPT Sync Bot
5e5eccabf8 Update web-platform-tests to revision e426a6933a05bf144eba06a1d4c47ba876a4e2d1 2019-05-22 14:00:10 +00:00
bors-servo
377ade0aed
Auto merge of #23188 - jackxbritton:issue-22287, r=KiChjang,ferjm
Implement HTMLMediaElement.crossorigin attribute logic.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #22287
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23188)
<!-- Reviewable:end -->
2019-05-22 07:52:26 -04:00
Jack Britton
ade697b782 Implement HTMLMediaElement.crossorigin attribute logic. 2019-05-22 12:23:51 +02:00
bors-servo
1cbb04c647
Auto merge of #23282 - josephhutch:OscillatorNodeType, r=ferjm
Implemented type attribute for OscillatorNode interface

<!-- Please describe your changes on the following line: -->

Please see https://github.com/servo/media/pull/242 for implementation of the new oscillator node message.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23282)
<!-- Reviewable:end -->
2019-05-22 05:09:43 -04:00
Fernando Jiménez Moreno
f8bcddea54 Update test expectations after 'OscillatorNode.type' addition 2019-05-22 10:20:01 +02:00
Paul Rouget
d55d6644a0 Glutin update: new Context API 2019-05-22 09:55:41 +02:00
Paul Rouget
5bdb0da657 Glutin update: ignore gl_generator duplicate 2019-05-22 09:55:41 +02:00
Paul Rouget
da28a0c580 Glutin update: ignore rand-core and nix duplicate 2019-05-22 09:55:41 +02:00
Paul Rouget
30fb18e711 Glutin update: dependencies update 2019-05-22 09:55:38 +02:00
bors-servo
415b26e4f1
Auto merge of #23434 - jdm:wpt-fix, r=Manishearth
Fix nightly WPT sync job

These changes were tested by triggering the daily hook with a branch that included them, and they caused #23433 to be opened successfully.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23434)
<!-- Reviewable:end -->
2019-05-21 23:58:05 -04:00
Josh Matthews
ceff9a61ef Allow pushing updated WPT results to git remote. 2019-05-21 21:20:38 -04:00
bors-servo
f9e5e7fe41
Auto merge of #23435 - servo:jdm-patch-51, r=Manishearth
Disable sccache on macOS

This is an attempt to see if sccache is responsible for #23409 and #23428.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23435)
<!-- Reviewable:end -->
2019-05-21 19:40:17 -04:00
Josh Matthews
1cbeb7a612
Disable sccache on macOS 2019-05-21 17:43:55 -04:00
bors-servo
123f58592c
Auto merge of #23226 - mmatyas:webgl_compressed_textures, r=jdm
Add initial support for WebGL compressed textures

This patch is an initial implementation of WebGL compressed texture support, it contains

- functions for registering and querying compressed texture extensions
- initial implementation of `CompressedTexImage2D` and `CompressedTexSubImage2D` and their parameter validation
- implementation of S3TC (DXT1, DXT3, DXT5) and ETC1 extensions as examples

What's still missing:

- some of the parameter validation steps are missing
- the pixel comparison tests fail for more complex cases (I'm probably missing something trivial at the GL calls)

Related: #10209 and #20594

cc @jdm @zakorgy

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] Related issues: #10209, #20594
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23226)
<!-- Reviewable:end -->
2019-05-21 17:10:24 -04:00
Mátyás Mustoha
7f0b820d4e Add initial support for WebGL compressed textures 2019-05-21 16:56:40 -04:00
bors-servo
cde3ecf640
Auto merge of #23427 - Eijebong:outdated5ever, r=jdm
Update xml5ever and html5ever

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23427)
<!-- Reviewable:end -->
2019-05-21 15:11:27 -04:00
Josh Matthews
2406d0973a Schedule a release build for WPT daily job if necessary. 2019-05-21 15:06:38 -04:00
Maria Sable
969d61a17f Implemented type attribute for OscillatorNode interface 2019-05-21 17:20:03 +02:00
bors-servo
6fb7a8cdc7
Auto merge of #23405 - Eijebong:weedle, r=jdm
Switch from webidl to weedle in script_plugins

This removes the dependency on lalrpop and should speed up compilation
quite a bit.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23405)
<!-- Reviewable:end -->
2019-05-20 21:13:33 -04:00
bors-servo
b1fcd41efc
Auto merge of #23420 - ferjm:gst.1.16.android, r=Manishearth
Upgrade gstreamer binaries for Android to 1.16.0

- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23420)
<!-- Reviewable:end -->
2019-05-20 18:33:30 -04:00
bors-servo
255d54086b
Auto merge of #23410 - tigercosmos:proxywindow-spec-update, r=KiChjang
spec update: window.name deals with lack of browsing context

<!-- Please describe your changes on the following line: -->
new [spec](https://html.spec.whatwg.org/multipage/window-object.html#dom-name):

The name attribute's getter must run these steps:

1. If this Window object's browsing context is null, then return the empty string.
2. Return this Window object's browsing context's name.

The name attribute's setter must run these steps:

1.  If this Window object's browsing context is null, then return.
2. Set this Window object's browsing context's name to the given value.

What is `null` here? According to [spec](https://html.spec.whatwg.org/multipage/browsers.html#concept-document-bc)
>  A Document's browsing context is the browsing context whose session history contains the Document, if any such browsing context exists and has not been discarded, and null otherwise.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] passed ` tests/wpt/web-platform-tests/html/browsers/the-window-object/name-attribute.window.js`
- [X] These changes fix #22915

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23410)
<!-- Reviewable:end -->
2019-05-20 13:47:33 -04:00
bors-servo
25307c23f5
Auto merge of #23424 - servo:plugin-search-path, r=ferjm
Use correct plugin search path for locally cloned gstreamer

r? @ferjm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23424)
<!-- Reviewable:end -->
2019-05-20 11:47:01 -04:00
bors-servo
07c43f7ffd
Auto merge of #23426 - servo:jdm-patch-49, r=jdm
Add gnutls dependency for gstreamer plugins build

From one of the newer macOS taskcluster workers:
```
==> Installing gst-plugins-bad dependency: srtp
==> Downloading https://homebrew.bintray.com/bottles/srtp-2.2.0.high_sierra.bottle.tar.gz
==> Pouring srtp-2.2.0.high_sierra.bottle.tar.gz
🍺  /Users/worker/homebrew/Cellar/srtp/2.2.0: 14 files, 408.4KB
==> Installing gst-plugins-bad
Error: An exception occurred within a child process:
  RuntimeError: /Users/worker/homebrew/opt/gnutls not present or broken
Please reinstall gnutls. Sorry :(
Installing ./etc/taskcluster/macos/formula/gst-plugins-bad.rb has failed!
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23426)
<!-- Reviewable:end -->
2019-05-19 20:56:30 -04:00
bors-servo
9b6a35c1df
Auto merge of #23416 - Manishearth:mediaup, r=asajeffrey
Update servo-media

Ensuring the gl failures in https://github.com/servo/servo/pull/23377 are not caused by this

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23416)
<!-- Reviewable:end -->
2019-05-19 18:48:33 -04:00
Bastien Orivel
00ac887862 Update xml5ever and html5ever 2019-05-19 22:14:28 +02:00
bors-servo
7e766e9189
Auto merge of #23171 - hundredeir:find_elem_elems, r=jdm
add webdriver command "Find elements from Element"

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23171)
<!-- Reviewable:end -->
2019-05-19 15:25:07 -04:00
Josh Matthews
7b8511e2c5
Add gnutls dependency for gstreamer plugins build 2019-05-19 10:23:08 -04:00
bors-servo
32ddc420a4
Auto merge of #23415 - servo:jdm-patch-48, r=SimonSapin
Make net.generic.worker a LaunchDaemon

Based on my reading in https://www.launchd.info/ I don't believe it should be a LaunchAgent, since it runs for another user than the one that is logged in.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23415)
<!-- Reviewable:end -->
2019-05-19 08:59:52 -04:00
bors-servo
538a7a59d5
Auto merge of #23419 - servo:SimonSapin-patch-1, r=jdm
Fix magicleap nightly upload

Remove some extra quotes in the shell script

Failed in https://tools.taskcluster.net/tasks/WtK7OY9qQ6Wg9xbXCS8eCQ

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23419)
<!-- Reviewable:end -->
2019-05-18 18:45:39 -04:00
tigercosmos
e80fdede4c window.name deals with lack of browsing context 2019-05-19 03:23:42 +08:00
bors-servo
208d6cb99e
Auto merge of #23323 - nehalem501:master, r=jdm
Implement connectStart in PerformanceResourceTiming

<!-- Please describe your changes on the following line: -->
- Added connectStart where needed (```ResourceFetchTiming```, ```ResourceAttribute```) in ```components/net_traits/lib.rs ```
- Before calling ```client.request``` in ```obtain_response```, we now add the ```connectStart``` attribute (```components/net/http_loader.rs```)
- Updated tests to reflect those changes

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes fix #21261 (at least partially)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23323)
<!-- Reviewable:end -->
2019-05-17 18:10:09 -04:00
Manish Goregaokar
7f76ddd6b3 Use correct plugin search path for locally cloned gstreamer 2019-05-17 13:31:29 -07:00
Josh Matthews
409167d7c5 Add useful debugging output for macos builds. 2019-05-17 16:25:29 -04:00
Josh Matthews
9098e6a51a Improve dependencies for generic-worker deployment. 2019-05-17 16:06:43 -04:00
Josh Matthews
1505c9cfc9 Remove old service plist. 2019-05-17 16:06:43 -04:00
Josh Matthews
e7751d8d23 Make net.generic.worker a LaunchDaemon 2019-05-17 16:06:43 -04:00
bors-servo
cdd95caa8d
Auto merge of #23404 - Manishearth:gst16, r=jdm
Update linux desktop to gstreamer 1.16

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23404)
<!-- Reviewable:end -->
2019-05-17 13:39:35 -04:00