Commit graph

433 commits

Author SHA1 Message Date
bors-servo
f800960695 auto merge of #3520 : jdm/servo/formcontrols, r=pcwalton
So far the changes to layout seem fairly well-contained; I think this is worth integrating to give us a browser that is easier to dogfood (and allows us to work on things like form submission much easier), especially since the long-term viability of WebComponents-as-forms is not assured.
2014-10-01 16:45:29 -06:00
Josh Matthews
be41c203ac Fix linux build error. 2014-10-01 18:43:24 -04:00
bors-servo
479d8567d1 auto merge of #3538 : mrobinson/servo/events-and-layers, r=zwarich
Select the topmost layer at a given point to send mouse events and when
sending the event, ensure that they are relative to the layer origin,
rather than in absolute page coordinates.

Fixes #3504.
2014-10-01 14:33:26 -06:00
bors-servo
da6878a4e2 auto merge of #3539 : jamesberlage/servo/fix/meaningful-is, r=jdm
This is intended to address #3488.  [AnyPrivate](http://doc.rust-lang.org/core/any/trait.AnyPrivate.html) is now in the Rust core, so we can leverage that instead of writing an implementation.
2014-10-01 14:03:27 -06:00
Josh Matthews
7401cd0aeb Split a long line. 2014-10-01 15:40:37 -04:00
Josh Matthews
5794da904e Remove unneeded input type information from layout. 2014-10-01 15:40:36 -04:00
Josh Matthews
ca5d4633c2 Disallow wrapping on input elements. 2014-10-01 15:37:40 -04:00
Josh Matthews
8112859d55 Disallow toggling radio buttons. Use generated content for checkboxes and radio buttons. Switching to the glyph 0 for the average advance width. 2014-10-01 15:37:40 -04:00
Josh Matthews
f70bb68503 Implement simple layout for text, button, radio, and checkbox inputs. Implement simple interaction for checkboxes and radio buttons. 2014-10-01 15:35:42 -04:00
Josh Matthews
9b20d6e7d2 Add average advance width to the font metrics structure, using the X glyph as a best guess. 2014-10-01 15:03:15 -04:00
Josh Matthews
08cac68d5a Check if the immediate node is an element before looking at ancestors when clicking, and flush pending layout changes after dispatching the event. 2014-10-01 15:03:15 -04:00
Martin Robinson
8d93ac460d Fix layer selection and point translation for mouse events
Select the topmost layer at a given point to send mouse events and when
sending the event, ensure that they are relative to the layer origin,
rather than in absolute page coordinates.

Fixes #3504.
2014-10-01 11:23:15 -07:00
Martin Robinson
31a6270d52 No longer consider window size when scrolling
Now that scrolling roots are properly sized, we can simply look at the
scrolling root layer size when deciding the extents of layer scrolling.
This simplifies things a bit and further codifies the current model of
scrolling root + mask_to_bounds.
2014-10-01 10:58:35 -07:00
Jim Berlage
28e29dc32e Use std::intrinsics::TypeId
Fix indentation + update comment
2014-10-01 13:56:34 -04:00
bors-servo
bae5440689 auto merge of #3531 : Ms2ger/servo/MutNullableJS, r=Ms2ger
Extracted from #3527.
2014-10-01 09:09:28 -06:00
Josh Matthews
54fcab61d6 Implement MutNullableJS for mutable, nullable member pointers to DOM objects. 2014-10-01 17:06:23 +02:00
Cameron Zwarich
0ef191b37a Remove an extra lifetime parameter on PrivateTreeWalkerHelpers 2014-10-01 02:07:52 -07:00
Cameron Zwarich
72656717d4 Remove an extra lifetime parameter on NodeHelpers 2014-10-01 02:07:46 -07:00
Cameron Zwarich
78791af7d6 Convert the NodeHelpers trait to use self methods 2014-09-30 23:42:03 -07:00
Cameron Zwarich
8b0361e251 Remove an unused lifetime parameter 2014-09-30 21:26:19 -07:00
Cameron Zwarich
79b4ec99b4 Convert TNode / TElement to use self methods rather than &self 2014-09-30 21:26:19 -07:00
Cameron Zwarich
63314208c0 Add Copy bounds to TNode / TElement 2014-09-30 21:26:19 -07:00
Cameron Zwarich
1581c383bb Convert the remaining ElementHelpers methods to take self 2014-09-30 21:26:19 -07:00
Cameron Zwarich
ccc5d976f7 Refine a lifetime parameter on TElement's get_local_name 2014-09-30 21:22:24 -07:00
Cameron Zwarich
e894499c17 Disambiguate methods without using trait objects 2014-09-30 21:22:24 -07:00
Cameron Zwarich
be9618d55b Add a lifetime parameter to the ElementHelper trait
This refines the lifetime used in get_local_name / get_namespace and
makes it independent of the lifetime on the &self parameter.
2014-09-30 21:21:00 -07:00
Cameron Zwarich
4ef0f39c78 Remove a prefix from a method name by manually resolving methods 2014-09-30 21:21:00 -07:00
bors-servo
6358b7d94e auto merge of #3537 : mrobinson/servo/scale, r=zwarich
When interacting with Layers it is simpler to use LayerPixels, which
are unscaled pixels in the Layer coordinate system. This removes a lot
of room for error and makes things simpler.
2014-09-30 18:57:26 -06:00
Martin Robinson
62ef7cd7ff Use LayerPixel for Layer bounds and most arguments
When interacting with Layers it is simpler to use LayerPixels, which
are unscaled pixels in the Layer coordinate system. This removes a lot
of room for error and makes things simpler.
2014-09-30 17:42:00 -07:00
bors-servo
93e259227a auto merge of #3536 : zwarich/servo/more-jsref, r=Manishearth
This also removes the unnecessary formation of a trait object.
2014-09-30 18:39:27 -06:00
Cameron Zwarich
3953456b61 Convert a method from &JSRef to JSRef
This also removes the unnecessary formation of a trait object.
2014-09-30 15:55:05 -07:00
Glenn Watson
55ef7ca5ad Refactor background image, fix fixed attachment. Improve acid2. 2014-10-01 08:54:24 +10:00
Keegan McAllister
d50114c41d Use string-cache's Namespace type 2014-09-29 21:40:54 -07:00
Keegan McAllister
6429750b33 Eliminate servo_util::atom
We only needed this for Encodable, and now we use JSTraceable instead.
2014-09-29 18:39:36 -07:00
Martin Robinson
a75594d7cf Mask root layer rectangles to their boundaries
This prevents iframes contents from overflowing their root layers.
2014-09-29 16:42:26 -07:00
Matt Brubeck
5f0d2ae98c Pass a viewport to the rendering code
Part of servo/rust-layers#114
2014-09-29 15:48:42 -07:00
Glenn Watson
52c5007b07 Add support for <super> and <sup> tags. Fixes equations on wikipedia. 2014-09-30 07:12:54 +10:00
Bruno de Oliveira Abinader
4e6785f513 CSS selector :enabled no longer matches Anchor, Area & Link elements
HTML spec has been modified [1] to disable support for :enabled CSS
selector on Anchor, Area & Link elements, after discussion on W3C
Bugzilla [2].

[1] https://html5.org/r/8818
[2] https://www.w3.org/Bugs/Public/show_bug.cgi?id=26622
2014-09-29 13:06:03 -04:00
Simon Sapin
3996a15adb Enable rustdoc for the style crate. Fix #2924.
We’re now at a Rust version that has a fix for
https://github.com/rust-lang/rust/issues/16274
2014-09-29 17:41:45 +01:00
Simon Sapin
b3245fa407 Upgrade to rustc d2b30f7d3 2014-09-23 2014-09-29 17:41:45 +01:00
Ms2ger
e72b5613ee Don't move the data when extracting the bytes in XMLHttpRequest::Send.
The data is used later to set the Content-Type header. Current rustc
(4d2af3861) does not detect this use-after-move, but treats the later use as
if the data was None. It will, however, detect the bug in d2b30f7d3, which we
are upgrading to.
2014-09-29 17:52:44 +02:00
Glenn Watson
e237519fdd Revert "Set default resolution to 1280x1024 now that reftests render to FBO."
This reverts commit c74798bb6b.
2014-09-29 10:10:37 +10:00
Glenn Watson
c74798bb6b Set default resolution to 1280x1024 now that reftests render to FBO. 2014-09-29 07:42:45 +10:00
Ms2ger
652a867800 Fix indentation in is_htmliframeelement. 2014-09-28 15:10:44 +02:00
bors-servo
42205675b3 Merge pull request #3508 from wenderen/JSTraceable.key
trace keys as well

Reviewed-by: Manishearth
2014-09-27 23:21:28 -06:00
Rohan Prinja
e50e704f5a trace keys as well 2014-09-28 09:44:43 +05:30
bors-servo
c9c8d63727 Merge pull request #3501 from zwarich/telement-lifetimes
Remove the 'static lifetime parameters from TElement methods

Reviewed-by: jdm
2014-09-27 17:09:28 -06:00
bors-servo
1b5fac5bde Merge pull request #3503 from Ms2ger/page-url
Simplify the Page URL handling in handle_resize_inactive_msg.

Reviewed-by: jdm
2014-09-27 13:39:27 -06:00
bors-servo
b7345796bc Merge pull request #3498 from pcwalton/border-box-double-counting
Stop double-counting stuff in inline-block

Reviewed-by: glennw
2014-09-27 13:12:30 -06:00
bors-servo
c10948736f Merge pull request #3497 from zwarich/extended-deref
Add an extended_deref method to JSRef

Reviewed-by: Manishearth
2014-09-27 12:48:30 -06:00