bors-servo
9708c63b9c
Auto merge of #7227 - tafia:tafia-mime_classifier, r=jdm
...
rewrite of mime_classifier.rs to use more iterators
Rewrite few parts of the file to use more iterators.
Note that I have **no idea** what the code is actually doing functionally, I just tried to mimic exactly what was being done. All tests are ok
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7227 )
<!-- Reviewable:end -->
2015-08-28 09:35:47 -06:00
bors-servo
2f227a034a
Auto merge of #7431 - frewsxcv:dom-methods-cleanup, r=Ms2ger
...
Merge adjacent identical `impl` sections
Prior to #7416 and #7401 , many of these `impl` sections were not
identical
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7431 )
<!-- Reviewable:end -->
2015-08-28 08:49:00 -06:00
Johann Tuffe
dd1c8c826e
Refactor mime_classifier
...
Use more iterators in particular.
2015-08-28 22:47:41 +08:00
Corey Farwell
5ccb0d43ef
Merge adjacent identical impl
sections
...
Prior to #7416 and #7401 , many of these `impl` sections were not
identical
2015-08-28 10:30:42 -04:00
Simon Sapin
006dd1002f
Fix CharacterDataMethods to count UTF-16 code units, not code points.
2015-08-28 11:58:38 +02:00
Simon Sapin
95a252a650
Refactor script::textinput to count UTF-8 bytes rather than code points.
2015-08-28 11:57:40 +02:00
benshu
1e6a2f08fc
Time distribution across script event categories.
2015-08-28 00:52:41 +02:00
Anthony Ramine
709d347872
Make the traits for the IDL interfaces take &self
2015-08-27 22:27:43 +02:00
bors-servo
8c301c291a
Auto merge of #7389 - frewsxcv:implement-nihilistic-methods, r=nox
...
Implement 'do nothing' methods on Window and Document
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7389 )
<!-- Reviewable:end -->
2015-08-27 12:30:28 -06:00
Corey Farwell
bf50145fbd
Implement 'do nothing' methods on Window and Document
2015-08-27 13:13:10 -04:00
Anthony Ramine
2a028f66a2
Remove AttributeHandlers
...
On components/script/*.rs:
# Remove imports.
/^ *use dom::element::\{.*AttributeHandlers/ {
s/\{AttributeHandlers, /\{/
s/, AttributeHandlers//g
s/\{([a-zA-Z]+)\}/\1/
/\{\}/d
s/::self;$/;/
}
/^ *use dom::element::\{?AttributeHandlers\}?;$/d
# Remove AttributeHandlers.
/^pub trait AttributeHandlers \{$/,/^\}$/D
# Patch AttributeHandlers methods.
/^impl<'a> AttributeHandlers for &'a Element \{/,/^\}$/ {
s/^impl<'a> AttributeHandlers for &'a Element \{/impl Element {/
/^ *fn /s/\(self([,)])/\(\&self\1/
/^ *fn.*\(&self/s/fn/pub fn/
}
The few error cases were then fixed by hand.
2015-08-27 16:59:04 +02:00
Anthony Ramine
aa83643507
Remove reference to helper traits from documentation
2015-08-27 16:59:04 +02:00
Anthony Ramine
c0cff59df8
Remove SinkHelpers
...
Method get_or_create() is now directly on servohtmlparser::Sink.
2015-08-27 16:59:03 +02:00
Anthony Ramine
275907f256
Remove dead code that surfaced when moved outside helper trait
2015-08-27 16:59:03 +02:00
Anthony Ramine
c831c2c0a5
Remove helper traits
...
Now that JSRef<T> is gone, there is no need to have helper traits.
On components/script/*.rs:
# Remove imports.
/^ *use dom::[a-z]+::\{.*Helpers/ {
s/\{(Raw[^L]|[^L][^a])[a-zA-Z]+Helpers, /\{/
s/, (Raw[^L]|[^L][^a])[a-zA-Z]+Helpers([,}])/\2/g
s/\{([a-zA-Z]+)\}/\1/
/\{\}/d
s/::self;$/;/
}
/^ *use dom::[a-z]+::\{?(Raw[^L]|[^L][^a])[a-zA-Z]+Helpers\}?;$/d
On components/script/dom/*.rs:
# Ignore layout things.
/^(pub )?(impl|trait).*Layout.* \{/,/^}$/ { P; D; }
# Delete helpers traits.
/^(pub )?trait ([^L][^ ]|L[^a])[^ ]+Helpers(<'a>)? \{$/,/^\}$/D
# Patch private helpers.
/^impl.*Private.*Helpers/,/^\}$/ {
s/^impl<'a> Private([^L][^ ]|L[^a])[^ ]+Helpers(<'a>)? for &'a ([^ ]+) \{$/impl \3 {/
/^ *(unsafe )?fn .*\(self.*[<&]'a/ {
s/&'a /\&/g
s/<'a, /</g
}
/^ *(unsafe )?fn /s/\(self([,)])/\(\&self\1/
}
# Patch public helpers.
/^impl.*Helpers/,/^\}$/ {
s/^impl(<'a>)? ([^L][^ ]|L[^a])[^ ]+Helpers(<'a>)? for (&'a )?([^ ]+) \{$/impl \5 {/
/^ *(unsafe )?fn .*\(self.*[<&]'a/ {
s/&'a /\&/g
s/<'a, /</g
}
/^ *(unsafe )?fn .*\(&?self[,)]/s/(unsafe )?fn/pub &/
/^ *pub (unsafe )?fn /s/\(self([,)])/\(\&self\1/
}
The few error cases were then fixed by hand.
2015-08-27 16:59:02 +02:00
bors-servo
532fd19d69
Auto merge of #7361 - jxs:master, r=Ms2ger
...
make dom_struct derive HeapSizeOf
closes #7357
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7361 )
<!-- Reviewable:end -->
2015-08-27 02:35:45 -06:00
bors-servo
a897795dab
Auto merge of #7387 - Yoric:2240-2, r=Ms2ger
...
Fixes #2240 - NamedGetter and NamedSetter do not assume that the arg is named `name`
I'm not totally sure about how to test this.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7387 )
<!-- Reviewable:end -->
2015-08-27 00:38:46 -06:00
bors-servo
98728a6c75
Auto merge of #7395 - Manishearth:doc-inherit, r=nox
...
Document InheritTypes
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7395 )
<!-- Reviewable:end -->
2015-08-26 20:56:02 -06:00
João Oliveira
8d86f89f63
Remove get_unsound_ref_forever function
...
closes #7383
2015-08-27 01:36:43 +01:00
João Oliveira
fd87c8cb3e
make dom_struct derive HeapSizeOf,
...
closes #7357
2015-08-27 01:17:48 +01:00
Manish Goregaokar
4ee5b664c2
Document InheritTypes
2015-08-27 04:35:50 +05:30
Corey Farwell
6650636063
Mention tracking issue for implementing document.all
2015-08-26 18:19:26 -04:00
bors-servo
48945b0fc1
Auto merge of #7397 - Manishearth:doublepointer-meet-fire, r=nox
...
Remove doublepointer in VirtualMethods, and from_borrowed_ref
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7397 )
<!-- Reviewable:end -->
2015-08-26 15:01:12 -06:00
Manish Goregaokar
4678ec16bb
remove to_borrowed_ref, fix Activatable
2015-08-27 02:27:42 +05:30
Manish Goregaokar
b33c5427bc
Remove doublepointer in VirtualMethods, and from_borrowed_ref
...
Most of the heavy lifting done by:
```
$ ls *rs | xargs gawk -i inplace '/let .*: &&.*from_borrowed_ref/{sub("&&", "\\&");sub("_borrowed_","_");} {print $0}'
$ ls *rs | xargs gawk -i inplace "/impl.*VirtualMethods/{in_vm=1; sub(/<'a>/,\"\");sub(/&'a /,\"\")} /^}\$/{in_vm=0;} in_vm{\$0=gensub(/\\*self([^.])/,\"self\\\1\",\"g\"); sub(/from_borrowed_ref/,\"from_ref\")} {print}"
```
2015-08-27 02:14:48 +05:30
bors-servo
fa5ad1c6b4
Auto merge of #7392 - mrobinson:layered-separate, r=pcwalton
...
Split out layered child stacking contexts in display lists
This patch is in preparation for more dynamic layerization of the
pieces of display lists. It also prevents having to sort the children
by z-index multiple times.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7392 )
<!-- Reviewable:end -->
2015-08-26 11:38:34 -06:00
Martin Robinson
1c09b1d8aa
Split out layered child stacking contexts in display lists
...
This patch is in preparation for more dynamic layerization of the
pieces of display lists. It also prevents having to sort the children
by z-index multiple times.
2015-08-26 10:20:28 -07:00
David Rajchenbach-Teller
d3ab0c2909
Fixes #2240 - NamedGetter and NamedSetter do not assume that the argument is named name
2015-08-26 16:58:39 +02:00
bors-servo
0e78815242
Auto merge of #7386 - Ms2ger:emitter, r=jdm
...
Remove Emitter::markers.
The vector is filled in and immediately emptied again. It is clearer to
keep the vector in the caller instead.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7386 )
<!-- Reviewable:end -->
2015-08-26 08:52:16 -06:00
Ms2ger
18b9532b25
Remove Emitter::markers.
...
The vector is filled in and immediately emptied again. It is clearer to
keep the vector in the caller instead.
2015-08-26 16:19:01 +02:00
bors-servo
186c1d14d5
Auto merge of #6880 - dzbarsky:rAF, r=jdm
...
Don't try to unwrap the result of requestAnimationFrame callback
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6880 )
<!-- Reviewable:end -->
2015-08-26 08:13:11 -06:00
bors-servo
9e52dd8cee
Auto merge of #7378 - Ms2ger:url, r=SimonSapin
...
Update url.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7378 )
<!-- Reviewable:end -->
2015-08-26 07:18:34 -06:00
bors-servo
78d72f6a9b
Auto merge of #7352 - saratang:issue_7347, r=Ms2ger
...
BinaryOrPlaintextClassifier::classify_impl does not need to return Option
Fixes for Issue #7347 , though I wasn't sure how to test my code afterwards.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7352 )
<!-- Reviewable:end -->
2015-08-26 05:53:38 -06:00
bors-servo
06ba2167ba
Auto merge of #7360 - wilmoz:ErgonomicSignature, r=Ms2ger
...
Make handle_potential_webgl_error more ergonomic
https://github.com/servo/servo/issues/7358
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7360 )
<!-- Reviewable:end -->
2015-08-26 05:21:42 -06:00
Ms2ger
d75ba49034
Update url.
2015-08-26 13:17:45 +02:00
bors-servo
a1cd27e6a3
Auto merge of #7369 - pcwalton:relative-layer-overflow, r=glennw
...
layout: Fix calculation of overflow for stacking contexts that contain `position: relative` fragments.
Fixes placement of the header on espn.go.com.
r? @glennw
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7369 )
<!-- Reviewable:end -->
2015-08-25 17:16:34 -06:00
Patrick Walton
5c51a6214e
layout: Fix calculation of overflow for stacking contexts that contain
...
`position: relative` fragments.
Fixes placement of the header on espn.go.com.
2015-08-25 15:08:28 -07:00
Avi Weinstock
09a20bb0a5
Update rust-clipboard to a version that works on Windows and Mac.
2015-08-25 15:29:29 -04:00
wilmoz
363183d12a
Make handle_potential_webgl_error more ergonomic
2015-08-25 13:04:55 -05:00
wilmoz
63851f2650
Forbid multiline imports
2015-08-25 12:27:42 -05:00
ecoal95
6341c77700
webgl: Implement multiple calls and improve error detection
...
This commit implements WebGL's:
* cullFace
* frontFace
* enable
* disable
* depthMask
* colorMask
* clearDepth
* clearStencil
* depthFunc
* depthRange
* hint
* lineWidth
* pixelStorei
* polygonOffset
* texParameteri
* texParameterf
* texImage2D (partially)
It inlines a lot of OpenGL calls to keep the file
`components/canvas/webgl_paint_task.rs` as small as possible while
keeping readability.
It also improves error detection on previous calls, and sets node damage
on the canvas in the drawing calls.
It adds a `TexImage2D` reftest, even though it's not enabled because:
* WebGL paints the image when it loads (asynchronously), so the reftest doesn't wait for it and it finishes early
* If we change the source for the base64 src of the image it works as expected in non-headless mode, but the test harness locks
2015-08-25 17:16:46 +02:00
ecoal95
af3310f149
Update gleam to 0.1.9
2015-08-25 17:16:46 +02:00
Sara Tang
8c39e968cd
Fixed mismatched type error
2015-08-24 23:11:31 -04:00
Sara Tang
f80ae3402a
Fixes for issue #7347
2015-08-24 21:32:16 -04:00
bors-servo
e97d8bd25c
Auto merge of #7340 - pcwalton:quotes-none-crash, r=mbrubeck
...
layout: Don't crash if `quotes: none` is specified and generated content uses quotes.
Avoids a crash on The Verge.
r? @mbrubeck
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7340 )
<!-- Reviewable:end -->
2015-08-24 18:01:39 -06:00
Patrick Walton
35c67b22e5
layout: Don't crash if quotes: none
is specified and generated content
...
uses quotes.
Avoids a crash on The Verge.
2015-08-24 17:00:23 -07:00
Connor Imes
bb96710cbf
Fix heartbeats build with new -sys version. Fixes #7328
2015-08-24 15:38:45 -05:00
João Oliveira
77e8d3071c
Move RegisterBindings::RegisterProxyHandlers call into script::init
...
closes #7336
2015-08-24 18:41:39 +01:00
bors-servo
524b02dbf7
Auto merge of #7331 - paulrouget:issue-7316, r=SimonSapin
...
prevent division by 0
Fix #7316
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7331 )
<!-- Reviewable:end -->
2015-08-24 05:08:41 -06:00
bors-servo
fa06a96f8a
Auto merge of #7334 - servo:active, r=SimonSapin
...
Parse :active pseudo-class selector.
This is #7258 with a spec link added in doc-comment.
The pseudo-class is never matched, but this can still help with stylesheets like `a:hover, a:active { color: something }` where failing to parse one pseudo-class makes the entire selector list invalid.
I filed #7333 about actually making it match.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7334 )
<!-- Reviewable:end -->
2015-08-24 04:23:13 -06:00