Commit graph

5393 commits

Author SHA1 Message Date
Chris Jones
079e85c5d4 Add instructions for building servo on Fedora Core. 2014-04-16 18:21:36 -07:00
bors-servo
aafadb65f2 auto merge of #2135 : mbrubeck/servo/refcell-get, r=larsbergstrom
It's going away in the next Rust upgrade (mozilla/rust#13301). r? @larsbergstrom

We'll need to do the same in rust-layers.
2014-04-16 19:58:07 -04:00
Matt Brubeck
5cc1825537 Stop using deprecated RefCell<T>::get
It's going away in the next Rust upgrade.
2014-04-16 16:51:27 -07:00
bors-servo
a52248f765 auto merge of #2134 : mbrubeck/servo/frametree-clone, r=larsbergstrom
This fixes an issue where a ChildFrameTree is inserted into a clone of its parent, rather than its "real" parent, as noted in #2124.

This moves `FrameTree::iter` and the methods that depend on it into a new trait that is implemented on `Rc<FrameTree>`, since it's safe to clone an `Rc<FrameTree>`.

r? @larsbergstrom
2014-04-16 19:19:08 -04:00
Matt Brubeck
f7b21b82af Stop cloning FrameTrees
This fixes an issue where a ChildFrameTree is inserted into a clone of its
parent, rather than its "real" parent, as noted in #2124.
2014-04-16 16:13:45 -07:00
bors-servo
d413814379 auto merge of #2102 : jdm/servo/warnings, r=metajack 2014-04-16 17:49:04 -04:00
Josh Matthews
d04efe6037 Fix some private type in public signature warnings. 2014-04-16 17:20:15 -04:00
bors-servo
0616297c46 auto merge of #2097 : SimonSapin/servo/pseudo-cleanup, r=pcwalton 2014-04-16 17:19:12 -04:00
bors-servo
beb8513796 auto merge of #2132 : mbrubeck/servo/constellation-cleanup, r=larsbergstrom
Just some mostly-mechanical refactoring to remove unnecessary mutability and unnecessary exports in constellation.rs.
2014-04-16 15:49:16 -04:00
Matt Brubeck
315c7810bd De-RefCell FrameTree::pipeline 2014-04-16 12:16:08 -07:00
Matt Brubeck
bb22fddfff Privatize some Constellation internals 2014-04-16 12:11:29 -07:00
bors-servo
f6cd507e97 auto merge of #2130 : mbrubeck/servo/frametree-copy-fix, r=larsbergstrom
We are calling `get` when we should call `borrow` or `borrow_mut`.  This is causing bugs with iframes because we append the child frame to a copy of the parent's `children` vector rather than the original.

r? @larsbergstrom
2014-04-16 12:55:16 -04:00
Matt Brubeck
abc9540713 Remove unintentional copies due to RefCell<T>::get
We are calling `get` when we should call `borrow` or `borrow_mut`.  This is
causing bugs with iframes because we append to a copy of the `children` vector
rather than the original.
2014-04-16 09:26:03 -07:00
bors-servo
aacf261bb4 auto merge of #2126 : Ms2ger/servo/avoid-unwrap_object, r=jdm
There is no good reason to have both unwrap_object and unwrap_jsmanaged.
Removing unwrap_object simplifies the codegen and makes further
simplifications easier.
2014-04-16 08:13:13 -04:00
Ms2ger
f77b775e62 Remove unwrap_object.
There is no good reason to have both unwrap_object and unwrap_jsmanaged.
Removing unwrap_object simplifies the codegen and makes further
simplifications easier.
2014-04-16 11:54:46 +02:00
bors-servo
7149a25e91 auto merge of #2112 : Ms2ger/servo/IDLInterface-JS, r=jdm 2014-04-16 04:22:11 -04:00
bors-servo
896cadbf62 auto merge of #2119 : pcwalton/servo/rm-unused-code, r=pcwalton
trivial
2014-04-15 19:28:11 -04:00
Patrick Walton
b34b42c94f box_: Remove unused code that resurfaced with the Rust upgrade 2014-04-15 14:50:14 -07:00
Ms2ger
ac46cc6047 Implement FromJSValConvertible for JS<T>. 2014-04-15 21:33:18 +02:00
bors-servo
038730c4bb auto merge of #2054 : sankha93/servo/imageattr, r=jdm 2014-04-15 12:49:14 -04:00
bors-servo
e4f33eb9b9 auto merge of #2114 : Ms2ger/servo/unused-obj-local-arg, r=jdm
This removes the local variable and prefixes the argument with an underscore.
Neither is used right now.
2014-04-15 12:22:44 -04:00
bors-servo
613e8dfaf2 auto merge of #2113 : Ms2ger/servo/DefineDOMInterface, r=jdm
This moves the assertion from its only caller into the function itself, to
clarify that we don't intent to deal with any failure here.
2014-04-15 11:52:28 -04:00
Ms2ger
e4305fe20e Remove unused variable 'obj' from binding functions.
This removes the local variable and prefixes the argument with an underscore.
Neither is used right now.
2014-04-15 17:37:54 +02:00
Ms2ger
dc11464933 Remove the return value from DefineDOMInterface.
This moves the assertion from its only caller into the function itself, to
clarify that we don't intent to deal with any failure here.
2014-04-15 17:32:10 +02:00
bors-servo
6720b8110a auto merge of #2106 : mbrubeck/servo/1959-vtable-followup, r=jdm
Follow-up from #1984. r? @jdm
2014-04-14 17:01:11 -04:00
Matt Brubeck
28a013cfc5 Move child_inserted into VirtualMethods.
Follow-up from #1984.
2014-04-14 13:39:11 -07:00
bors-servo
18b5453e09 auto merge of #1984 : mbrubeck/servo/1959-parser-style, r=jdm
This is a partial fix for #1959.  This commit only addresses inline `<style>` elements.  Next I will need to move `<link rel="stylesheet">` handling into shared code, but I wanted to get some early feedback on this piece first.
2014-04-14 14:22:09 -04:00
Matt Brubeck
8c794c6739 Move inline stylesheet parsing out of HTML parser.
Instead, use shared code to parse stylesheet content when it is inserted,
whether during parsing or dynamically by script.

Based on work by sanools in #1350.
2014-04-14 11:14:07 -07:00
Simon Sapin
583892bf69 fixup! Rename ElementType to PseudoElementType, to avoid confusion with ElementTypeId. 2014-04-14 15:22:23 +01:00
Simon Sapin
d9c6ac5ca1 fixup! Merge new_with_pseudo_without_self() and new_with_pseudo() into with_pseudo() 2014-04-14 14:59:03 +01:00
Simon Sapin
7f139b2b07 Merge new_with_pseudo_without_self() and new_with_pseudo() into with_pseudo() 2014-04-14 14:59:03 +01:00
Simon Sapin
49521baee7 Rename ElementType to PseudoElementType, to avoid confusion with ElementTypeId. 2014-04-14 14:59:03 +01:00
Simon Sapin
0275654c4a Use #[deriving(Clone)] for ThreadSafeLayoutNode 2014-04-14 14:59:03 +01:00
bors-servo
ce877e4f5b auto merge of #2095 : zmike/servo/servo-lib, r=larsbergstrom
In pursuit of #441

r? @larsbergstrom
2014-04-12 11:43:06 -04:00
bors-servo
c27b31d9c9 auto merge of #2098 : Manishearth/servo/ref-noteq, r=metajack
See #2090

One reftest compares a green image to a white div. The other has green text being compared with normal text.

If necessary, I can add some absolute positioning ones.
2014-04-12 11:04:09 -04:00
Manish Goregaokar
07cf2d095d Add the second reftest (#2090) 2014-04-12 09:17:26 +05:30
Manish Goregaokar
50b5bd3beb A couple of != reftests (#2090) 2014-04-12 08:22:44 +05:30
bors-servo
b174a6439b auto merge of #2094 : Manishearth/servo/id-efficiency, r=Ms2ger
This improves the code written for #1822 to use a single linear traversal.

The current code uses a binary search with `CompareDocumentPosition()` for comparing element position, however this method internally calls `traverse_preorder()` (i.e. a linear traversal) so calling this on every pass is quite inefficient.
2014-04-11 17:04:09 -04:00
bors-servo
9d2a6b7824 auto merge of #2087 : Ms2ger/servo/vtable2, r=jdm
Fixes #1527. Does *not* include the code for #1528.

(Originally by @jdm in #1688 and #1866.)
2014-04-11 16:31:14 -04:00
bors-servo
257e1c0130 auto merge of #2071 : hyunjunekim/servo/try, r=larsbergstrom
If <span> element has pseudo style, draw pseudo element.
2014-04-11 16:04:17 -04:00
bors-servo
2fcba6ff81 auto merge of #2096 : larsbergstrom/servo/fix_fontconfig, r=jdm
Please don't r+ until https://github.com/mozilla-servo/rust-fontconfig/pull/12 is merged.

r? @SimonSapin @mbrubeck

or whomever.
2014-04-11 15:31:17 -04:00
Lars Bergstrom
9fa9959a93 Update fontconfig submodule version to fix linker order bug 2014-04-11 14:19:44 -05:00
Mike Blumenkrantz
b68fd73042 split servo build into library (non-android) for use in embedding 2014-04-11 14:15:42 -04:00
bors-servo
ceefbe2d05 auto merge of #2085 : lpy/servo/issue2079, r=jdm
see #2079
2014-04-11 12:49:19 -04:00
lpy
601480eaf2 Replace @s with Rc types.(fixes #2079) 2014-04-12 00:43:46 +08:00
hyunjunekim
a6066e8c03 Add a reftest for the pseudo element 2014-04-12 00:10:50 +09:00
Manish Goregaokar
9f617e9f0c Make register_named_element more efficient 2014-04-11 14:39:23 +05:30
bors-servo
0c4354a439 auto merge of #2093 : Ms2ger/servo/DOMObjectPointerType, r=jdm 2014-04-10 15:16:17 -04:00
bors-servo
55bac1900c auto merge of #2070 : larsbergstrom/servo/android_201404c, r=larsbergstrom,metajack
r? @metajack
2014-04-10 14:25:18 -04:00
Ms2ger
493227c938 Remove DOMObjectPointerType. 2014-04-10 20:19:32 +02:00