Commit graph

39081 commits

Author SHA1 Message Date
Gregory Terzian
4f3ba70704 http-cache: wait on pending stores
and various small improvements
2019-10-08 17:58:20 +08:00
Fernando Jimenez Moreno
becb694013 Allow building and cleaning for UWP without system GStreamer 2019-10-08 10:27:10 +02:00
bors-servo
7371c8689d
Auto merge of #24391 - atouchet:macports, r=jdm
Remove MacPorts instructions from Readme

<!-- Please describe your changes on the following line: -->
See https://github.com/servo/servo/pull/23743#issuecomment-510196434

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24391)
<!-- Reviewable:end -->
2019-10-08 02:15:25 -04:00
bors-servo
e05f0b41ba
Auto merge of #24387 - servo:jdm-patch-31, r=jdm
macos: Remove font size attribute from font descriptor.

This attribute isn't present in font-kit, and maybe this will help with #23290?

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24387)
<!-- Reviewable:end -->
2019-10-08 00:46:53 -04:00
Alex Touchet
b70979918e
Remove MacPorts instructions from Readme 2019-10-07 18:09:57 -07:00
bors-servo
75548f40c6
Auto merge of #24340 - jdm:image-cache-cors, r=Manishearth
Allow using CORS filtered image responses as WebGL textures

More specifically, this makes the "is this image same origin?" check consider the CORS status of the original response, rather than relying on an overly-strict "is this image's response's URL same-origin with a particular global?" check. To do this, we make the image cache double keyed based on the requested URL as well as the requesting origin, and store the CORS status of the eventual response with the final image that eventually gets sent to the HTMLImageElement consumer.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24330 and fix #24368
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24340)
<!-- Reviewable:end -->
2019-10-07 18:39:36 -04:00
Josh Matthews
6dd40962ea Ensure image cache keys on element CORS status. 2019-10-07 16:44:35 -04:00
bors-servo
95f65cdd31
Auto merge of #24383 - emilio:style-nit, r=nox
style: Use consistent naming and shared code for out-of-flow stuff.

There was already code to check abspos / floats. No need to duplicate code with
different names as ee17eedf3a did.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24383)
<!-- Reviewable:end -->
2019-10-07 16:04:17 -04:00
Josh Matthews
35f1910297
rustfmt 2019-10-07 15:05:48 -04:00
bors-servo
c60d4f46a0
Auto merge of #24378 - otaviopace:fix/responses-status-code-text, r=jdm
response: remove text from default statusCode

According to the [specification](https://fetch.spec.whatwg.org/#concept-response-status-message) the text of the default statusCode text should be empty.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24371

<!-- Either: -->
- [x] These changes do not require tests because it is a simple string change that having tests would just be useless

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24378)
<!-- Reviewable:end -->
2019-10-07 13:46:56 -04:00
Josh Matthews
b94615b3eb
macos: Remove font size attribute from font descriptor. 2019-10-07 12:04:53 -04:00
bors-servo
37ab273c82
Auto merge of #24370 - jdm:cache-crossorigin-test, r=gterzian
Cache crossorigin test

This adds a test for #24356 to ensure that we don't regress our cache behaviour.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24370)
<!-- Reviewable:end -->
2019-10-07 11:28:53 -04:00
Emilio Cobos Álvarez
6b674a670b
style: Use consistent naming and shared code for out-of-flow stuff.
Use the functions introduced in ee17eedf3a.
2019-10-07 16:57:18 +02:00
bors-servo
4c76b7a758
Auto merge of #24382 - atouchet:tinyfile, r=jdm
Update tinyfiledialogs

<!-- Please describe your changes on the following line: -->
Let's see if this helps with #24098.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24382)
<!-- Reviewable:end -->
2019-10-07 09:36:21 -04:00
Otávio Pace
a1acd29339 response: remove text from default statusCode
According to the specification the text of the
default statusCode should be empty.

Reference: https://fetch.spec.whatwg.org/#concept-response-status-message
2019-10-07 08:23:44 -03:00
Alex Touchet
f026e8651e
Update tinyfiledialogs 2019-10-06 23:26:10 -07:00
bors-servo
0b5aaeff5d
Auto merge of #24381 - servo-wpt-sync:wpt_update_06-10-2019, r=servo-wpt-sync
Sync WPT with upstream (06-10-2019)

Automated downstream sync of changes from upstream as of 06-10-2019.
[no-wpt-sync]
r? @servo-wpt-sync
2019-10-06 10:35:17 -04:00
WPT Sync Bot
393fa37c0b Update web-platform-tests to revision daac9dc806e9571ea856253fcc35a94e73d4f711 2019-10-06 14:35:02 +00:00
bors-servo
1318ea9d02
Auto merge of #24374 - Tugdual:tug-by-ref-argument, r=jdm
Pass argument by reference to CacheKey constructor

<!-- Please describe your changes on the following line: -->
Argument now passed by reference, and clone() removed when calling
constructor.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24353 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because @jdm said it only need to build

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24374)
<!-- Reviewable:end -->
2019-10-05 08:57:36 -04:00
Tugdual JULLIEN
85e6418271 Pass argument by reference to CacheKey constructor
Argument now passed by reference, and clone() removed when calling
constructor.
2019-10-05 11:18:51 +02:00
bors-servo
9785613310
Auto merge of #24365 - atouchet:tests, r=jdm
Update test expectations

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24365)
<!-- Reviewable:end -->
2019-10-04 22:36:48 -04:00
bors-servo
36f70f5ab1
Auto merge of #24360 - servo:build-box-tree, r=SimonSapin
Call BoxTreeRoot::construct from layout_thread_2020

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24360)
<!-- Reviewable:end -->
2019-10-04 20:37:28 -04:00
bors-servo
db1750673c
Auto merge of #24233 - ceyusa:get-image-pixels, r=jdm
get_image_pixels() implementation for video element

<!-- Please describe your changes on the following line: -->

Implements the webgl's get_image_pixels() call for video element

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #21995 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24233)
<!-- Reviewable:end -->
2019-10-04 18:22:15 -04:00
bors-servo
c94ca298ca
Auto merge of #24334 - servo:new-manifest-format, r=jdm
Switch to the new Cargo.lock format

The way the Cargo.lock file is encoded on stable Rust is quite unfriendly
to Git when multiple pull requests change that file at the same time,
how version numbers are everywhere and all checksums are in the same place
often produces merge conflicts for nothing.

This patch brings the new Cargo.lock format to Servo.

https://github.com/rust-lang/rust/pull/63579

The main caveat is that for now, cargo-tree and similar tools won't work
anymore.

I checked that the duplicate crate tidy check still does its job though.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24334)
<!-- Reviewable:end -->
2019-10-04 16:37:24 -04:00
Josh Matthews
b282ed9104 Add test for filtered crossorigin cache response (#24356). 2019-10-04 15:27:20 -04:00
Josh Matthews
b347cf877c Add some useful HTTP cache debug output. 2019-10-04 15:26:03 -04:00
Josh Matthews
a241232c2b Add useful debug output for HTTP response and image cache. 2019-10-04 15:08:40 -04:00
Josh Matthews
734cf9e1b3 Update WPT hosts file. 2019-10-04 15:08:40 -04:00
Josh Matthews
1df8d57dc6 Support CORS attributes for image elements. 2019-10-04 15:08:40 -04:00
Víctor Manuel Jáquez Leal
2010d89613 Enable related WPT tests 2019-10-04 19:41:06 +02:00
bors-servo
86efbe30ca
Auto merge of #24359 - servo:jdm-patch-31, r=jdm
Remove intermittent failure reporting.

The frequency with which we hit https://github.com/servo/intermittent-failure-tracker/issues/5 means that this is hurting us more than it helps.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24359)
<!-- Reviewable:end -->
2019-10-04 13:02:43 -04:00
Víctor Manuel Jáquez Leal
b75d454162 implement get_image_pixels() for video element 2019-10-04 18:08:06 +02:00
Víctor Manuel Jáquez Leal
bc07154e05 Always hold current frame
Regardless if it contains raw data or a gl texture.

It is required to hold current frame because it can be used for
webgl's get_image_pixels
2019-10-04 18:08:06 +02:00
Simon Sapin
1bb85ed05b Make some of layout_2020 private 2019-10-04 17:51:05 +02:00
Josh Matthews
583536c940 Use the paint worklet's base URL for the 2d canvas' origin checks. 2019-10-04 09:22:21 -04:00
Josh Matthews
81a67aed9e Double key image cache by requesting origin, and store CORS status with cached images. 2019-10-04 09:22:21 -04:00
Josh Matthews
050fcc989d Remove intermittent failure reporting. 2019-10-04 09:12:08 -04:00
bors-servo
dc65d825e8
Auto merge of #24361 - AntiSC2:master, r=jdm
Add missing package dependency for Arch Linux in README

Without LLVM installed you get: "Error: Can't find llvm-objdump" when
running ./mach build --dev. LLVM is not installed automatically because it's not a dependency for any of the other dependencies.

Signed-off-by: Jakob Sinclair <sinclair.jakob@mailbox.org>

<!-- Please describe your changes on the following line: -->

---
- [X] These changes do not require tests because only the README.md file was updated

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24361)
<!-- Reviewable:end -->
2019-10-04 09:01:47 -04:00
bors-servo
ea46008288
Auto merge of #24364 - servo:jdm-patch-35, r=SimonSapin
Remove outdated userscript content.

We now support WheelEvent, so this isn't necessary.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24364)
<!-- Reviewable:end -->
2019-10-04 06:47:40 -04:00
Anthony Ramine
0ce8cf9e2e Switch to the new Cargo.lock format
The way the Cargo.lock file is encoded on stable Rust is quite unfriendly
to Git when multiple pull requests change that file at the same time,
how version numbers are everywhere and all checksums are in the same place
often produces merge conflicts for nothing.

This patch brings the new Cargo.lock format to Servo.

	https://github.com/rust-lang/rust/pull/63579

The main caveat is that for now, cargo-tree and similar tools won't work
anymore.

I checked that the duplicate crate tidy check still does its job though.
2019-10-04 12:31:13 +02:00
bors-servo
ea4e3aee91
Auto merge of #24362 - Manishearth:input-selections, r=asajeffrey
Support input tracking loss and selection events in XR

Fixes https://github.com/servo/servo/issues/24192

Requires https://github.com/servo/webxr/pull/65

r? @jdm @asajeffrey

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24362)
<!-- Reviewable:end -->
2019-10-04 04:31:42 -04:00
Anthony Ramine
30e5cfcdb0 Revert "Switch to the new Cargo.lock format"
This reverts commit b7ffaa5a72.

WHY THE HELL CAN I PUSH TO MASTER
2019-10-04 10:07:15 +02:00
Anthony Ramine
ec74204fa0 Call BoxTreeRoot::construct from layout_thread_2020 2019-10-04 10:03:42 +02:00
Anthony Ramine
b7ffaa5a72 Switch to the new Cargo.lock format
The way the Cargo.lock file is encoded on stable Rust is quite unfriendly
to Git when multiple pull requests change that file at the same time,
how version numbers are everywhere and all checksums are in the same place
often produces merge conflicts for nothing.

This patch brings the new Cargo.lock format to Servo.

	https://github.com/rust-lang/rust/pull/63579

The main caveat is that for now, cargo-tree and similar tools won't work
anymore.

I checked that the duplicate crate tidy check still does its job though.
2019-10-04 10:00:16 +02:00
bors-servo
1ab4dd1351
Auto merge of #24358 - servo-wpt-sync:wpt_update_03-10-2019, r=servo-wpt-sync
Sync WPT with upstream (03-10-2019)

Automated downstream sync of changes from upstream as of 03-10-2019.
[no-wpt-sync]
r? @servo-wpt-sync

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24358)
<!-- Reviewable:end -->
2019-10-04 01:26:34 -04:00
atouchet
fb69e15d80 Update test expectations 2019-10-03 20:55:47 -07:00
bors-servo
bbc94d256c
Auto merge of #24356 - servo:jdm-patch-30, r=paulrouget
Use unfiltered response body when replicating body of cached responses.

The amount of time it took me to track this down makes me wonder if there would be a better way of representing response bodies and filtered responses.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24350
- [ ] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24356)
<!-- Reviewable:end -->
2019-10-03 19:36:21 -04:00
bors-servo
c2052437dc
Auto merge of #24352 - servo:jdm-patch-28, r=paulrouget
Use correct OpenSSL arch in UWP builds.

This is a followup from #24257. I forgot to run the UWP WACK tests after making my changes, or I would have noticed that the wrong DLLs were being selected for UWP builds.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24352)
<!-- Reviewable:end -->
2019-10-03 18:42:23 -04:00
Manish Goregaokar
931f0b12de Update WPT 2019-10-03 14:13:51 -07:00
Manish Goregaokar
b094ceb076 Add event handlers for sessionend events 2019-10-03 14:13:51 -07:00