Commit graph

16964 commits

Author SHA1 Message Date
bors-servo
bfe54539d2 Auto merge of #10590 - edunham:package-tidy, r=larsbergstrom
Package tidy

This fixes https://github.com/servo/servo/issues/861.

@askeing, I've copied your work from https://github.com/askeing/servo_tidy and attributed the commit to you. My commit in this PR is Git housekeeping to preserve `tidy`'s history. If you'd like to make additional changes, I've given you and @shinglyu push access to my fork of Servo. Apologies if this is already familiar, but the workflow for pushing to my branch is:

```
$ git remote add edunham git@github.com:edunham/servo.git
$ git checkout -b package-tidy
$ git pull edunham package-tidy
$ git push edunham package-tidy
```

Once this lands, I'll look at how to publish it to PyPI and automate that process.

Please don't merge this yet; we still need to discuss how the change should work around https://github.com/servo/servo/blob/master/python/servo/testing_commands.py#L33 , as I've yet to figure out how to get the egg to actually expose its tests.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10590)
<!-- Reviewable:end -->
2016-04-15 23:20:16 +05:30
Adrian Utrilla
739410e52d
mach install now builds servo if it hasn't been built before 2016-04-15 19:11:48 +02:00
bors-servo
a96b98f85b Auto merge of #10627 - bholley:mako_kwargs, r=SimonSapin
Use kwargs in mako to reduce all the parameters

This should keep things more manageable.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10627)
<!-- Reviewable:end -->
2016-04-15 22:39:48 +05:30
Bobby Holley
38d2063a9d Make single_keyword take kwargs. 2016-04-15 10:08:57 -07:00
Bobby Holley
e4a8613f6d Make single_keyword_computed take kwargs. 2016-04-15 10:08:57 -07:00
Bobby Holley
dea08f4ca0 Make longhand take kwargs. 2016-04-15 10:08:57 -07:00
Bobby Holley
f58ff4a4f7 Make raw_longhand take kwargs. 2016-04-15 10:08:57 -07:00
Bobby Holley
0fe55f01b5 Alter the semantics of derived_from so that it is [] rather than None when the property is not derived.
This simplifies some logic in this patch and going forward. Note that the old code stored the
derived_from array as rust idents, but then used the parameter (not rust-ident-ified) to access
DERIVED_LONGHANDS. No other consumers actually seem to use the values in derived_from, so we
change the representation to the more natural thing.
2016-04-15 10:08:57 -07:00
bors-servo
f39ec2b15e Auto merge of #10629 - frewsxcv:flatten, r=Ms2ger
Flatten a couple `net` implementations.

Working on some of the TLS related code in `net` and tried to clean up a couple implementations along the way.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10629)
<!-- Reviewable:end -->
2016-04-15 18:50:39 +05:30
Corey Farwell
12dfe6ff28 Flatten implementation of net::http_response::HttpResponse. 2016-04-15 09:13:47 -04:00
Corey Farwell
50c6d937a5 Flatten implementation of net::file_loader::factory. 2016-04-15 09:13:47 -04:00
bors-servo
6c5cfb738a Auto merge of #10345 - asajeffrey:make-nox-happy, r=nox
Replace side-effecting unwrap_or_else by if let in constellation.

This addresses @nox's comments in #10295.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10345)
<!-- Reviewable:end -->
2016-04-15 17:35:45 +05:30
bors-servo
3b96bba1d5 Auto merge of #10585 - servo:rustup_20160414, r=Ms2ger
Rust upgrade to 2016-04-12

This currently spews out a ton of ld errors of the form

```
/home/manishearth/Mozilla/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/jit/JitFrameIterator.h:455: error: undefined reference to 'js::jit::SnapshotReader::readAllocation()'
```

cc @nox

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10585)
<!-- Reviewable:end -->
2016-04-15 16:55:01 +05:30
Manish Goregaokar
e10c580768
Rust upgrade to 2016-04-12 2016-04-15 15:28:49 +05:30
bors-servo
eb78e21fbe Auto merge of #10555 - jdm:http_response_refactor, r=ms2ger
Remove unnecessary indirection in HTTP unit tests

Many of the HTTP unit tests use a custom request factory as well as a custom request that contained test logic. This is unnecessarily convoluted, and exists solely because the complete set of headers was unavailable until the request body was sent. These patches restructure the header manipulations so that the headers are available when the request object is created, allowing the test logic to move into the test factories, and enabling the deletion of almost all of the test request types.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10555)
<!-- Reviewable:end -->
2016-04-15 12:44:59 +05:30
Josh Matthews
43369fa897 Rename create_with_headers to create. 2016-04-15 01:46:04 -04:00
Josh Matthews
a761f2bed4 Remove unused header manipulation facilities. 2016-04-15 01:46:03 -04:00
Josh Matthews
4cb7dfbc59 Convert remaining factories that don't make use of headers. 2016-04-15 01:46:02 -04:00
Josh Matthews
d1b07673b8 Convert AssertMustNotIncludeHeadersRequestFactory. 2016-04-15 01:46:01 -04:00
Josh Matthews
f712ddb0db Convert AssertAuthHeaderRequestFactory. 2016-04-15 01:46:00 -04:00
Josh Matthews
36de07bfdf Convert AssertMustIncludeHeadersRequestFactory. 2016-04-15 01:45:58 -04:00
Josh Matthews
dec66b2215 Convert AssertMustHaveHeadersRequestFactory. 2016-04-15 01:45:57 -04:00
Josh Matthews
a315f8db9e Reorganize header manipulation that occurs before sending an HTTP request so we can provide the full set of headers while creating a request. 2016-04-15 01:45:56 -04:00
Josh Matthews
0e1703d747 Convert NetworkHttpRequestFactory. 2016-04-15 01:45:55 -04:00
Josh Matthews
80eaeac9f4 Make headers available when creating an HTTP request via a factory. 2016-04-15 01:45:48 -04:00
Josh Matthews
dc790048ec Remove unnecessary type annotations. 2016-04-15 01:00:44 -04:00
bors-servo
7faa3ed9cb Auto merge of #10626 - sliz1:10576, r=KiChjang
Use the document base url when resolving iframe URLs

Fixes #10576.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10626)
<!-- Reviewable:end -->
2016-04-15 10:03:51 +05:30
Stephen (Ziyun) Li
52c6fd5b03
Use the document base url when resolving iframe URLs 2016-04-15 00:02:45 -04:00
askeing
ee433a030c Add servo_tidy_tests into ignore dirs, and modify setup.py to fit the tidy check
- fix the issue of '$ ./mach test-tidy --no-progress'
2016-04-15 11:16:03 +08:00
bors-servo
7bd2381518 Auto merge of #10328 - DDEFISHER:master, r=jdm
401 authorization UI then restart request/save successful auth creds

Step 7 of the NCSU student project Implement HTTP authorization UI

> make an authorization UI appear when a 401 HTTP response is received (StatusCode::Unauthorized) - in load in http_loader.rs, right before trying to process an HTTP redirection, use the new tinyfiledialogs library to make two prompts appear (username and password), then restart the request with the new authorization value present applied. If an authorization value was present and the response is successful, add the credentials to the authorization cache.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10328)
<!-- Reviewable:end -->
2016-04-15 08:01:23 +05:30
Daniel
b0e1f10ba5 401 authorization UI then restart request/save successful auth creds 2016-04-14 21:38:45 -04:00
bors-servo
9896e53094 Auto merge of #10591 - Liamsi:base_url_script_element, r=KiChjang
Use the document base url when resolving script URLs

Does this resolve #10578?

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10591)
<!-- Reviewable:end -->
2016-04-15 06:57:36 +05:30
bors-servo
7d7404333d Auto merge of #10458 - pcwalton:block-formatting-context-margin-collapse, r=mbrubeck
layout: Disallow margins from collapsing through block formatting contexts per CSS 2.1 § 8.3.1.

Closes #10449.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10458)
<!-- Reviewable:end -->
2016-04-15 06:00:28 +05:30
Patrick Walton
f69931552b layout: Disallow margins from collapsing through block formatting
contexts per CSS 2.1 § 8.3.1.

Closes #10449.
2016-04-14 17:24:26 -07:00
Patrick Walton
a3fd226341 layout: Disallow margins from collapsing through blocks with clearance
per CSS 2.1 § 8.3.1.

Fixes the test failure in #10458.
2016-04-14 17:24:24 -07:00
bors-servo
0c51259e40 Auto merge of #10617 - perlun:extract-build-properties-script-to-py-files, r=bholley
Extracted Mako-based code generation invokation to separate .py files.

This breaks out some of the parts on #10586, that should be easily mergeable (hopefully pretty much a no-brainer really). The idea would be to let you review & merge it first, and then I'll complete the other PR rebase off of this stuff.

@bholley - I did like you suggested and broke it out for `geckolib` as well. The tests should also be running without problems (tested `./mach test-unit` locally).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10617)
<!-- Reviewable:end -->
2016-04-15 04:50:47 +05:30
Liamsi
62182f9de9 Use the document base url when resolving script URLs 2016-04-15 00:25:56 +02:00
bors-servo
db4481b450 Auto merge of #10619 - perlun:add-update-cargo-all-packages-warning, r=Wafflespeanut
mach: Added warning for update-cargo -a

To quote Lars Bergstrom:

> yeah, that's a giant footgun :-)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10619)
<!-- Reviewable:end -->
2016-04-15 03:05:48 +05:30
Per Lundberg
8815bb9594 Extracted Mako compilation to separate .py files.
This breaks out some of the parts on #10586, that should be easily mergeable. The idea would be to let you review & merge it first, and then I'll complete the other PR rebase off of this stuff.
2016-04-14 23:26:04 +03:00
Manish Goregaokar
f02fd6330f
Remove watcher threads; replace with more panic handler goodness 2016-04-15 01:52:33 +05:30
Per Lundberg
6653c26c90 Added warning for update-cargo -a
To quote Lars Bergstrom:

> yeah, that's a giant footgun :-)
2016-04-14 22:57:03 +03:00
bors-servo
d9ffefe562 Auto merge of #10589 - fitzgen:lock-stdout-when-printing-profile, r=larsbergstrom
Take the stdout lock when printing profile data

Acquiring the stdout lock while printing the profile data prevents other
messages printed to stdout from being interleaved with prints from elsewhere.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10589)
<!-- Reviewable:end -->
2016-04-15 01:03:54 +05:30
Nick Fitzgerald
1997d034fa Take the stdout lock when printing profile data
Acquiring the stdout lock while printing the profile data prevents other
messages printed to stdout from being interleaved with prints from elsewhere.
2016-04-14 12:28:00 -07:00
Patrick Walton
e32455f7b8 layout: Disallow margins from collapsing through blocks that have
floated children per CSS 2.1 § 8.3.1.

Fixes the test failure in #10458.
2016-04-14 11:22:40 -07:00
bors-servo
4807dadf19 Auto merge of #10609 - asajeffrey:add-panic-object-borrows, r=Manishearth
Make add_panic_object in thread.rs borrow rather than own the object.

r? @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10609)
<!-- Reviewable:end -->
2016-04-14 22:59:08 +05:30
bors-servo
e21e5551ec Auto merge of #10556 - bholley:keyword_setters, r=SimonSapin
Automatically generate Gecko style struct setters for most keyword properties

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10556)
<!-- Reviewable:end -->
2016-04-14 21:58:34 +05:30
edunham
e20def068e Use local tidy
https://github.com/servo/servo/issues/861#issuecomment-209547756

"I think the most important concern is that it's possible to modify tidy.py
and see how those changes affect ./mach test-tidy with the fewest possible
intermediate steps." - jdm

This takes publishing complexity away from the contributor when testing
changes and makes it an infra problem instead, where it's much easier to
automate & saner to manage pypi credentials
2016-04-14 09:22:00 -07:00
Alan Jeffrey
0cca4a9d53 Replace side-effecting unwrap_or_else by if let in constellation.
This addresses nox's comments in #10295.
2016-04-14 10:58:22 -05:00
bors-servo
415fd93a50 Auto merge of #10610 - jdm:unwrap, r=SimonSapin
Replace instances of infallible unwrap with expect.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10610)
<!-- Reviewable:end -->
2016-04-14 21:02:22 +05:30
Josh Matthews
cacbf95de8 Replace instances of infallible unwrap with expect. 2016-04-14 11:30:30 -04:00