Commit graph

32161 commits

Author SHA1 Message Date
bors-servo
90b8410b05
Auto merge of #20150 - upsuper:text-is-significant, r=emilio
Remove text-is-significant param from Gecko_IsSignificantChild

This is Servo side change of [bug 1441729](https://bugzilla.mozilla.org/show_bug.cgi?id=1441729).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20150)
<!-- Reviewable:end -->
2018-03-01 18:52:07 -05:00
Manish Goregaokar
be12b90412 Don't panic on cells with both a rowspan and colspan in include_sizes_from_previous_rows
fixes #20162
2018-03-01 15:38:29 -08:00
bors-servo
6f2cd86b8e
Auto merge of #20152 - Manishearth:rowspan-zero, r=mbrubeck
Support zero rowspans

This makes rowspan=0 work by storing notes on which group of rows we're in
for tables containing both rowgroups and rows, and using that to respan
cells with overlarge or zero rowspans.

This also gets rid of the largest_leftover_incoming_size business, because
now spans will always be correct and we'll never have any left over.

Based on https://github.com/servo/servo/pull/20128

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20152)
<!-- Reviewable:end -->
2018-03-01 13:36:43 -05:00
Emilio Cobos Álvarez
c04fc0a269
style: Rustfmt bindings on automation, and locally under an env variable.
Bug: 1432153
Reviewed-by: xidorn
MozReview-Commit-ID: HJ9J5NtYVk2
2018-03-01 16:44:04 +01:00
Emilio Cobos Álvarez
8778b46d57
style: Update bindgen. 2018-03-01 16:23:51 +01:00
bors-servo
23e9590634
Auto merge of #20153 - jdm:glutinup, r=SimonSapin
Update glutin, skia, and azure.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19901

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20153)
<!-- Reviewable:end -->
2018-03-01 10:20:05 -05:00
bors-servo
30f33eba96
Auto merge of #20145 - servo:rm-rustc-hack, r=emilio
Kill RUSTC_HAS_PR45225 🎉

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20145)
<!-- Reviewable:end -->
2018-03-01 08:49:03 -05:00
Anthony Ramine
3abc020744 Kill RUSTC_HAS_PR45225 🎉 2018-03-01 14:47:57 +01:00
Anthony Ramine
169b44bc9d Use Rust 1.24.0 for geckolib 2018-03-01 14:47:56 +01:00
bors-servo
1df6c97948
Auto merge of #20156 - paulrouget:euclid_up, r=jdm
euclid update

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20156)
<!-- Reviewable:end -->
2018-03-01 02:45:26 -05:00
Paul Rouget
9b9a53f30b euclid update 2018-03-01 06:05:14 +01:00
Manish Goregaokar
54eb1eb780 Support rowspan=0; always fixup overflowing rowspans beforehand
This makes rowspan=0 work by storing notes on which group of rows we're
in for tables containing both rowgroups and rows, and using that to
respan cells with overlarge or zero rowspans.

This also gets rid of the largest_leftover_incoming_size business,
because now spans will always be correct and we'll never have any left
over.
2018-02-28 17:37:59 -08:00
bors-servo
f58c4fda13
Auto merge of #20154 - glennw:update-wr-deadlock, r=jdm
Update WR (ipc deadlock workaround, clipped-filter fix).
2018-02-28 20:25:51 -05:00
Glenn Watson
753677f5d1 Update WR (ipc deadlock workaround, clipped-filter fix). 2018-03-01 11:13:10 +10:00
Josh Matthews
3af74b69dc Update glutin, skia, and azure. 2018-02-28 20:10:56 -05:00
Manish Goregaokar
19dba91e4d Fixup specified colspans and rowspans 2018-02-28 17:07:49 -08:00
bors-servo
e2f2814018
Auto merge of #20128 - Manishearth:rowspan, r=mbrubeck
Rowspan support for tables

fixes #20092

This just contains the first steps.

We apply a naive algorithm: Spanning cells apply a pressure equal to `block_size / rowspan` on each row they are in. We move table row block size computation into the tables, and make it two pass. In the first pass we compute the sizes of each row, and in the
second pass we assign them, adding them up for any involved cells.

This is missing:

 - [x] Accounting for border sizes
 - [x] Applying pressure to rows that are not the row containing the cell
 - [ ] Reducing pressure on future rows if the current row is able to accomodate more of the cell
 - [x] For tables containing both rows and rowgroups, reset the rowspan info when we hit a rowgroup
 - [x] Correctly handle overflowing rowspans

cc @mbrubeck @pcwalton

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20128)
<!-- Reviewable:end -->
2018-02-28 18:40:39 -05:00
Manish Goregaokar
ffe68e8010 Add reftest, update test expectations 2018-02-28 15:21:27 -08:00
Xidorn Quan
107d9d2072 Remove text-is-significant param from Gecko_IsSignificantChild 2018-03-01 09:48:32 +11:00
bors-servo
af92c06223
Auto merge of #20143 - Eijebong:bump, r=nox
Bump itertools, image, flate2 and caseless

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20143)
<!-- Reviewable:end -->
2018-02-28 13:10:59 -05:00
bors-servo
e8f77861a9
Auto merge of #20146 - bholley:explicit_load_data, r=bholley
Stylo: Pass an explicit parent SheetLoadData for child stylesheet loads

https://bugzilla.mozilla.org/show_bug.cgi?id=1441896
2018-02-28 11:32:00 -05:00
Bobby Holley
0236a6ce99 Stylo: Pass an explicit parent SheetLoadData for child stylesheet loads.
MozReview-Commit-ID: 7XNu42NtITm
2018-02-28 08:28:48 -08:00
Bastien Orivel
4ea60d3a2a Update caseless to 0.2 2018-02-28 16:55:39 +01:00
Bastien Orivel
c072829be0 Update flate2 to 1.0 2018-02-28 16:55:35 +01:00
Bastien Orivel
9ca18b510f Update image to 0.18 2018-02-28 16:25:35 +01:00
Bastien Orivel
22325df495 Update itertools to 0.7 2018-02-28 16:25:32 +01:00
bors-servo
2d4caaf749
Auto merge of #20139 - servo-wpt-sync:wpt_update_27-02-2018, r=jdm
Sync WPT with upstream (27-02-2018)

Automated downstream sync of changes from upstream as of 27-02-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20139)
<!-- Reviewable:end -->
2018-02-28 09:34:57 -05:00
bors-servo
a0be3a7fae
Auto merge of #20138 - emilio:longhand-iterator, r=nox
style: Only expose longhands to rust via iterators.

The key here is that we only filter longhands if the shorthand is accessible to
content and vice-versa. This prevents the bug that prevented me to land this
patch before, which was us not expanding properly chrome-only shorthands.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20138)
<!-- Reviewable:end -->
2018-02-28 06:28:41 -05:00
Emilio Cobos Álvarez
68971c86bc
style: Remove unused function. 2018-02-28 12:04:49 +01:00
Emilio Cobos Álvarez
3fd5f796f0
style: Handle properly potentially-disabled longhands in a shorthand. 2018-02-28 12:04:49 +01:00
Emilio Cobos Álvarez
15b0a32035
style: Put all the multicol props under the same pref for Servo.
Otherwise it becomes insane.
2018-02-28 12:04:47 +01:00
bors-servo
8471011e6b
Auto merge of #20141 - servo:rm-color-or-auto, r=emilio
Replace ColorOrAuto by CaretColor

This is its only use.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20141)
<!-- Reviewable:end -->
2018-02-28 05:37:18 -05:00
Anthony Ramine
c4efbb4d51 Replace ColorOrAuto by CaretColor
This is its only use.
2018-02-28 10:25:59 +01:00
bors-servo
38298336be
Auto merge of #20140 - Eijebong:euclid, r=SimonSapin
Bump euclid to 0.17

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20140)
<!-- Reviewable:end -->
2018-02-28 04:14:32 -05:00
Bastien Orivel
c28dcbc3e5 Bump euclid to 0.17 2018-02-28 09:46:59 +01:00
WPT Sync Bot
b3ccbe1a35 Update web-platform-tests to revision 3678c44dfe811f93a796285e9531ee34d7d15682 2018-02-27 22:03:50 -05:00
Emilio Cobos Álvarez
220cc9ba65
style: Fix overflow-clip-box-{block,inline} to be under the right pref. 2018-02-28 00:37:07 +01:00
Emilio Cobos Álvarez
6cc6280004
style: Remove a stray pref value.
This should've been removed in
https://bugzilla.mozilla.org/show_bug.cgi?id=1398492
2018-02-28 00:33:41 +01:00
Emilio Cobos Álvarez
8c4b401dd3
style: Only expose longhands to rust via iterators.
The key here is that we only filter longhands if the shorthand is accessible to
content and vice-versa. This prevents the bug that prevented me to land this
patch before, which was us not expanding properly chrome-only shorthands.

Again, this is incomplete, and I need to teach LonghandsToSerialize to get a
potentially incomplete list of properties, and all that.
2018-02-28 00:19:31 +01:00
Manish Goregaokar
cec37a492a Unconditionally layout rows when laying out tables
If the reflow flag is set on a row it will be on the table anyway
2018-02-27 14:47:22 -08:00
Manish Goregaokar
98e53db289 Assert that cells aren't floats 2018-02-27 14:44:44 -08:00
bors-servo
6fbf2c1e3c
Auto merge of #20137 - Eijebong:gl_generator, r=SimonSapin
Bump gl_generator to 0.9

Fixes #20037

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20137)
<!-- Reviewable:end -->
2018-02-27 15:17:09 -05:00
bors-servo
3d8363cd87
Auto merge of #20136 - emilio:servo-prefs, r=SimonSapin
style: Make Servo deal with CSS property prefs more correctly.

Right now you could still set preffed-off properties from CSSStyleDeclaration.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20136)
<!-- Reviewable:end -->
2018-02-27 14:16:08 -05:00
Bastien Orivel
33e1415509 Bump gl_generator to 0.9
Fixes #20037
2018-02-27 19:39:28 +01:00
Emilio Cobos Álvarez
650e947c94
style: Make Servo deal with CSS property prefs more correctly.
Right now you could still set preffed-off properties from CSSStyleDeclaration.
2018-02-27 19:29:07 +01:00
bors-servo
068c1eb9fb
Auto merge of #20135 - servo:jdm-patch-13, r=Manishearth
Clean up after some disk-space intensive builds.

This should help the ongoing disk usage problems.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20135)
<!-- Reviewable:end -->
2018-02-27 13:15:02 -05:00
Manish Goregaokar
19974e39c8 Merge fourth and fifth (assign block sizes / positions) passes 2018-02-27 09:43:38 -08:00
bors-servo
030509e66b
Auto merge of #20131 - servo:moz-tab-size, r=emilio
Replace NonNegativeLengthOrNumber by a specific type for -moz-tab-size

This is the only use of this type.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20131)
<!-- Reviewable:end -->
2018-02-27 12:17:43 -05:00
Josh Matthews
1a8507cada
Clean up after some disk-space intensive builds. 2018-02-27 12:10:24 -05:00
bors-servo
b9e16e54aa
Auto merge of #20134 - emilio:split-stuff, r=nox
style: Split out NonCustomPropertyId::enabled_for_all_content from allowed_in.

This is part of a patch that was reviewed by nox in #20081, but which I reverted because that approach didn't quite work.

I think I have something that works now, but I'm waiting for a Geckotry. Landing this should be worth it in the meantime though.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20134)
<!-- Reviewable:end -->
2018-02-27 07:12:50 -05:00