Ms2ger
acb24e80b8
Use throw_type_error and throw_range_error from js.
2015-11-12 10:20:19 +01:00
Corey Farwell
bfc4ed4cac
Cleanup PageIterator::next
2015-11-12 00:24:19 -05:00
bors-servo
1b20bc90ee
Auto merge of #8476 - frewsxcv:unnecessary-document-notification, r=nox
...
Remove unnecessary 'node changed' notification
This same notification already happens in `CharacterData::SetData`
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8476 )
<!-- Reviewable:end -->
2015-11-12 05:33:19 +05:30
Corey Farwell
1789405883
Remove unnecessary 'node changed' notification
...
This same notification already happens in `CharacterData::SetData`
2015-11-11 17:53:38 -05:00
benshu
7623e89506
Execute XHR timeout callbacks directly. (Fixes #8468.)
2015-11-11 23:12:07 +01:00
bors-servo
12f6ba29a7
Auto merge of #8412 - ecoal95:webidl-sequence-return, r=jdm
...
Add WebIDL sequence return values
And use it for `WebGLRenderingContext::getSupportedExtensions`.
Part of #544
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8412 )
<!-- Reviewable:end -->
2015-11-11 23:15:15 +05:30
Emilio Cobos Álvarez
e33330db4e
Implement WebIDL sequence return value using JS_NewArrayObject1
...
This commits changes the creation of the array to use the length, and
sets the elements later.
Reference implementation:
07ed19e582/js/xpconnect/public/nsTArrayHelpers.h (L16)
2015-11-11 18:30:34 +01:00
Emilio Cobos Álvarez
b740b90b8d
webgl: Implement getSupportedExtensions
2015-11-11 17:13:59 +01:00
Emilio Cobos Álvarez
63aa6862b4
Implement WebIDL sequence return values
2015-11-11 17:13:59 +01:00
bors-servo
01ff78b438
Auto merge of #8466 - frewsxcv:node-value, r=nox
...
Simplify script::dom::node NodeValue implementations
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8466 )
<!-- Reviewable:end -->
2015-11-11 21:43:21 +05:30
bors-servo
5e6efd62c1
Auto merge of #8459 - frewsxcv:namednodemap-iter, r=Ms2ger
...
Simplify iterating over Element attributes
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8459 )
<!-- Reviewable:end -->
2015-11-11 20:19:49 +05:30
Corey Farwell
261ce49423
Simplify script::dom::node NodeValue implementations
2015-11-11 08:53:53 -05:00
Anthony Ramine
acb13dc899
Support variadic interface arguments ( fixes #8159 )
...
We use a RootedVec value in codegen, of which we use the `r()` method to
pass `&[&T]` to the interface methods.
2015-11-11 14:52:21 +01:00
Anthony Ramine
e66a361e08
Do not import union constructors in dom::testbinding
2015-11-11 14:19:36 +01:00
Anthony Ramine
6d72293681
Remove TestBinding::global
...
Use global_root_from_reflector() instead.
2015-11-11 14:19:35 +01:00
Anthony Ramine
f84f16384d
Remove unused parameter in instantiateJSToNativeConversionTemplate()
2015-11-11 14:19:34 +01:00
Anthony Ramine
b290a3161d
Clean up the conversion routines
...
Functions returning `Root<T>` are prefixed by "root_" and the ones returning
`*const T` by "native_".
Functions taking `*mut JSObject` are now suffixed by "_from_object" and the ones
taking `&T` by "_from_reflector".
2015-11-11 14:19:30 +01:00
Corey Farwell
a7c470de09
Simplify iterating over Element attributes
2015-11-10 21:42:48 -05:00
bors-servo
fd5540df62
Auto merge of #8453 - frewsxcv:atoms, r=jdm
...
Prefer Atoms over strs for comparison
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8453 )
<!-- Reviewable:end -->
2015-11-11 06:55:39 +05:30
benshu
d27a3244f2
XHR timeouts use same abstraction as scripts timers. ( fixes #3396 )
2015-11-11 00:52:34 +01:00
bors-servo
13226f8472
Auto merge of #8381 - bholley:attr_restyle_hints, r=pcwalton
...
Implement attribute restyle hints
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8381 )
<!-- Reviewable:end -->
2015-11-11 01:27:45 +05:30
Bobby Holley
7fa7936657
Implement attribute restyle hints.
...
Fixes #6942 .
2015-11-10 11:57:24 -08:00
Corey Farwell
55477eb618
Prefer Atoms over strs for comparison
2015-11-10 08:58:57 -05:00
bors-servo
81f094b129
Auto merge of #8447 - frewsxcv:htmltableelement-width-idl-attribute, r=eefriedman
...
Implement 'width' IDL attribute on <table>
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8447 )
<!-- Reviewable:end -->
2015-11-10 12:54:30 +05:30
bors-servo
32a91bc656
Auto merge of #8444 - rilut:patch-2, r=frewsxcv
...
refactor(htmlhrelement.rs): color setter now uses macro
Changed the function in #L44-47 to a macro usage. Fixes #8433 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8444 )
<!-- Reviewable:end -->
2015-11-10 12:12:25 +05:30
Bobby Holley
c9704992a9
Factor the name-related fields of Attr into a struct and move it to style.
2015-11-09 21:40:22 -08:00
Bobby Holley
488c1291d4
Hoist AttrValue into style.
2015-11-09 21:40:22 -08:00
Corey Farwell
575b3c3d4b
Implement 'width' IDL attribute on <table>
2015-11-09 23:31:25 -05:00
bors-servo
cd6813ea39
Auto merge of #8434 - frewsxcv:dimension-attrvalue, r=eefriedman
...
Add Dimension member to AttrValue
Fixes #8417
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8434 )
<!-- Reviewable:end -->
2015-11-10 08:15:37 +05:30
Rizky Luthfianto
d0d2a64628
refactor(htmlhrelement.rs): color setter now uses macro
...
Changed the function in #L44-47 to a macro usage
2015-11-10 09:31:38 +07:00
Corey Farwell
71aa2392f8
Remove HTMLTableElement::width struct field
2015-11-09 20:35:29 -05:00
Corey Farwell
73314ab10c
Add Dimension member to AttrValue
...
Fixes #8417
2015-11-09 20:32:56 -05:00
bors-servo
b386008623
Auto merge of #8431 - eefriedman:table-bgcolor, r=frewsxcv
...
Move storage of bgcolor for `<tr>` and `<tbody>`.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8431 )
<!-- Reviewable:end -->
2015-11-10 06:58:16 +05:30
Eli Friedman
4b68fc18c3
Move storage of bgcolor for <tr>
and <tbody>
.
2015-11-09 12:27:16 -08:00
bors-servo
f39faaf994
Auto merge of #8227 - asajeffrey:versioned_dom, r=eefriedman
...
Versioned dom
This PR adds versioning to the DOM. There are now node.get_version and node.get_descendent_version methods that return a counter that is bumped when the node is dirtied. This is used to implement cache invalidation for caching HTMLCollection state. Caching HTMCollections gets a 1000x speedup in the Dromaeo DOM query tests.
Addresses https://github.com/servo/servo/issues/6901 , https://github.com/servo/servo/issues/3381 and https://github.com/servo/servo/issues/1916 .
Replaces PR https://github.com/servo/servo/pull/6927 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8227 )
<!-- Reviewable:end -->
2015-11-10 01:11:23 +05:30
bors-servo
d8df028197
Auto merge of #8404 - eefriedman:misc-attributes, r=nox
...
Misc cleanup for DOM attributes
No functional change; just cleanups related to parsing attributes.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8404 )
<!-- Reviewable:end -->
2015-11-10 00:32:24 +05:30
Eli Friedman
af78173243
Move more unsafe layout calls onto LayoutJS.
2015-11-09 10:47:38 -08:00
Eli Friedman
5293afc122
Move unsafe layout calls onto LayoutJS.
2015-11-09 10:47:37 -08:00
bors-servo
f74754f582
Auto merge of #8175 - benschulz:set-timeout-panic, r=jdm
...
Fixed panic in ActiveTimers.set_timeout_or_interval.
`ActiveTimers.set_timeout_or_interval` asserts that the pipeline is not currently frozen. Apparently that is too strict. When pending network requests complete after a pipeline is frozen, scripts may be executed and a timer scheduled.
With these changes scheduling a timer while the pipeline is frozen behaves as if the timer was scheduled at the time the pipeline was frozen.
To reproduce the panic
1. `./mach run -r http://google.com `,
2. immediately click on any link and
3. wait for the panic.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8175 )
<!-- Reviewable:end -->
2015-11-09 20:18:38 +05:30
Eli Friedman
ef52da7acd
Move storage of color attribute on <font>.
2015-11-08 17:29:50 -08:00
Eli Friedman
0901e5bc97
Move storage of bgcolor attribute on <body>.
2015-11-08 17:29:49 -08:00
Corey Farwell
ee0800abe9
Implement <hr> 'color' attribute
2015-11-08 18:34:27 -05:00
Roman Klauke
4f35941b9d
rename WebSocket::Send_Impl
...
Previos: `Send_Impl`, now: `send_impl`.
Closes : #8345
2015-11-08 14:45:59 +01:00
bors-servo
fc98b8e126
Auto merge of #8403 - frewsxcv:node-from-nodes-and-strings, r=nox
...
Minor 'node_from_nodes_and_strings' cleanup
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8403 )
<!-- Reviewable:end -->
2015-11-08 17:33:46 +05:30
bors-servo
92f9e58310
Auto merge of #8286 - eefriedman:no-move, r=nox
...
Remove unnecessary uses of #[no_move]
The patch makes RootCollection a bit safer by making the StackRootTLS hold
it in place.
RootedVec was doing an extremely delicate dance and just hoping nobody
messed it up; switch to a Box to be safe.
CodeGenRust seemed to be using no_move for no particularly good reason.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8286 )
<!-- Reviewable:end -->
2015-11-08 12:51:00 +05:30
Corey Farwell
9443b89af7
Minor 'node_from_nodes_and_strings' cleanup
...
This prevents an 'IntoIter' from getting unnecessarily allocated
2015-11-08 01:03:56 -05:00
Corey Farwell
fe4a5890d1
Add spec link for 'converting nodes into a node'
2015-11-08 00:49:33 -05:00
Eli Friedman
1a50fce67c
Clean up some code related to #[no_move].
...
The patch makes RootCollection a bit safer by making the StackRootTLS hold
it in place.
The use of no_move in CodeGenRust was leftover from when roots couldn't
be moved.
2015-11-07 21:17:24 -08:00
Sylvester Willis
4adf502846
Added call to event.PreventDefault on html text inputs and textareas.
...
This change should prevent page scrolling when up/down buttons are pressed.
2015-11-07 20:51:16 -05:00
bors-servo
7ff3a17524
Auto merge of #8039 - tschneidereit:script-owns-stylesheets, r=jdm
...
Move Stylesheet loading and ownership from the layout task into HTML elements
Stylesheets for `HTMLLinkElement`s are now loaded by the resource task, triggered by the element in question. Stylesheets are owned by the elements they're associated with, which can be `HTMLStyleElement`, `HTMLLinkElement`, and `HTMLMetaElement` (for `<meta name="viewport">).
Additionally, the quirks mode stylesheet (just as the user and user agent stylesheets a couple of commits ago), is implemented as a lazy static, loaded once per process and shared between all documents.
This all has various nice consequences:
- Stylesheet loading becomes a non-blocking operation.
- Stylesheets are removed when the element they're associated with is removed from the document.
- It'll be possible to implement the CSSOM APIs that require direct access to the stylesheets (i.e., ~ all of them).
- Various subtle correctness issues are fixed.
One piece of interesting follow-up work would be to move parsing of external stylesheets to the resource task, too. Right now, it happens in the link element once loading is complete, so blocks the script task. Moving it to the resource task would probably be fairly straight-forward as it doesn't require access to any external state.
Depends on #7979 because without that loading stylesheets asynchronously breaks lots of content.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8039 )
<!-- Reviewable:end -->
2015-11-08 01:11:54 +05:30