Commit graph

1626 commits

Author SHA1 Message Date
Patrick Walton
4f6c732b54 script: Fix double borrow error when going back. Closes #4402.
I have verified that back and forward work once again.
2014-12-16 21:54:43 -08:00
bors-servo
03666f3105 auto merge of #4397 : jdm/servo/issue_4235, r=jdm
Rebased from #4241.
2014-12-16 16:03:45 -07:00
Jerry Shih
3b4ebd7cd0 handle null for evaluating JS value. #4235 2014-12-16 17:59:23 -05:00
bors-servo
5951056973 auto merge of #4133 : mttr/servo/form_resetting, r=jdm
We can reset `<input type=text>` fields! I wish I could've done something with checkboxes, but unfortunately, that's it for now.

In addition to that, this PR implements `HTMLInputAttribute.defaultValue`, updates wpt-test to expect passing tests as a result of that implementation, and fixes an index error crash with text inputs.

edit: also includes an html example where one may lazily watch form resets in action: ` tests/html/form_reset_handsfree.html`
2014-12-16 15:03:49 -07:00
Matthew Rasmus
504f968b20 Implements :indeterminate pseudo-class
Addresses reviews
2014-12-16 11:34:04 -08:00
Matthew Rasmus
0c8e1aeda3 Implements dirty value/checked flags for input
And modifies test-inputs.html to test.

Fixes wpt breaking mistake
2014-12-16 11:34:04 -08:00
Matthew Rasmus
38e4d86b14 Implements DefaultChecked and resets of checkboxes 2014-12-16 11:34:04 -08:00
Matthew Rasmus
a5c0bb708d htmltextarea: Fixed some value_changed issues
Also modified tests/html/textarea.html to allow for the testing of the
textarea's dirty value flag.
2014-12-16 11:34:04 -08:00
Matthew Rasmus
4d0a6a6bd6 Implements reset button 2014-12-16 11:34:04 -08:00
Matthew Rasmus
7e0c39a82d Implements FormControl for HTMLTextAreaElement 2014-12-16 11:34:04 -08:00
Matthew Rasmus
a3b3295d80 Adds reset method to FormControl 2014-12-16 11:34:04 -08:00
Matthew Rasmus
f0ce2af89c Implements basic form resetting
What can this do? Reset `<input type=text>` fields back to their default
value through a call to a form's reset method. That's all for now!

Fixes compile error after rebase
2014-12-16 11:33:56 -08:00
Matthew Rasmus
f932a6947a Implements HTMLInputElement.defaultValue
...and changes SetValue to update the input text instead of the content
attr.

Also includes a comment summarizing everything I currently know with
respect to an input elements checkedness vs its IDL attributes vs its
content attributes.
2014-12-16 11:06:56 -08:00
Matthew Rasmus
f686943eb4 Fix crash in textinput 2014-12-16 11:06:55 -08:00
Matthew Rasmus
fc0748f50e Makes layout respect <textarea> rows attribute
review addresssing
2014-12-16 11:02:01 -08:00
Matthew Rasmus
2c7f6076d1 Makes layout respect <textarea> cols attribute 2014-12-16 10:44:15 -08:00
bors-servo
746b262ff4 auto merge of #4374 : thiagopnts/servo/dispatch-event, r=Ms2ger
servo/pull/4369 with the right commit.
2014-12-16 06:36:47 -07:00
thiagopnts
79487252ca Add auxiliary method to EventTargetHelpers for events without target
fixup! Add auxiliary method to EventTargetHelpers for events without target
2014-12-16 10:01:38 -02:00
Edit Balint
3036c8d21d Fixed codegen error regarding Uint8ClampedArray 2014-12-16 11:03:01 +01:00
bors-servo
fb5c1bef6f auto merge of #4385 : pcwalton/servo/page-double-borrow, r=jdm
This was my fault. It comes up on almost any page after scrolling a bit.

r? @jdm
2014-12-15 20:54:44 -07:00
bors-servo
e0ec21e814 auto merge of #4381 : Manishearth/servo/performancenow, r=jdm 2014-12-15 20:00:53 -07:00
Manish Goregaokar
eec68faa41 Fix window.performance.now() 2014-12-16 08:28:11 +05:30
Patrick Walton
34d76fef28 script: Fix double-borrow error
This was my fault. It comes up on almost any page after scrolling a bit.
2014-12-15 18:21:51 -08:00
Patrick Walton
a1ea44b294 style: Address review comments relating to bgcolor and column spans 2014-12-15 18:09:44 -08:00
Patrick Walton
17835ba0cb style: Implement quirks mode rules. 2014-12-15 17:41:51 -08:00
Patrick Walton
56b78de5bc style: Implement basic column spans.
This patch provides some of the groundwork for column spans greater than
1. It implements the column-span CSS property (prefixed so as not to be
exposed to content) as well as the corresponding colspan attribute;
although the former is not well-specified outside of CSS multi-column
layout, INTRINSIC refers to it. Although width is distributed to
spanning columns, they do not yet contribute minimum and preferred
widths; this will be implemented in a follow-up.

Additionally, this patch cleans up some miscellaneous formatting issues
and improves the handling of table rowgroups.
2014-12-15 17:41:51 -08:00
Patrick Walton
14bafb11be style: Parse the legacy bgcolor attribute per the HTML5 specification.
Additionally, this patch cleans up some miscellaneous formatting issues.
2014-12-15 17:41:44 -08:00
Patrick Walton
10f1ed5e31 style: Parse the legacy border attribute per the legacy HTML specification.
Additionally, this patch cleans up some miscellaneous formatting issues
and refactors files in `layout/css/` somewhat to eliminate needless
levels of indirection. It also fixes our handling of presentational
hints that only apply if border is nonzero.
2014-12-15 17:41:37 -08:00
bors-servo
5f2684d2f8 auto merge of #3844 : pcwalton/servo/script-layout-synchronization, r=jdm
This fixes race conditions whereby layout and script could be running
simultaneously.

r? @jdm 
cc @cgaebel
2014-12-15 15:31:21 -07:00
Patrick Walton
a200b139b6 script: Add some workarounds for image cache task races 2014-12-15 14:16:20 -08:00
Patrick Walton
d101c1dd91 script: Improve dirty propagation and fix script-layout synchronization.
This fixes race conditions whereby layout and script could be running
simultaneously.
2014-12-15 14:16:04 -08:00
Ms2ger
ba891e49f8 Correctly set the BlobType for File objects. 2014-12-15 10:45:45 +01:00
thiagopnts
60ba4a97a5 Make ErrorEvent::new take cancelable and bubbling enums 2014-12-15 00:00:06 -02:00
bors-servo
1be7d7cced auto merge of #4297 : ChrisParis/servo/parse, r=Ms2ger
Addresses https://github.com/servo/servo/issues/3756. I've tested this code with a new test that I've submitted to https://github.com/w3c/web-platform-tests.
2014-12-13 12:30:45 -07:00
Chris Paris
e0c59818d2 Make DOMParser::ParseFromString actually parse the string 2014-12-13 08:57:08 -10:00
Ms2ger
14e1455119 Skip the root node in live HTMLCollections.
The root node is never included in the collection, and omitting it here
simplifies and speeds up the filter implementations.
2014-12-13 10:38:19 +01:00
Ms2ger
4a2c4b65cc Factor out part of the traversal routine in HTMLCollection.
I would move the filter() call into the traverse function as well, but the
callback can't outlive its stack frame.
2014-12-13 10:34:42 +01:00
bors-servo
ea39b878ac auto merge of #4356 : servo/servo/msgs, r=jdm 2014-12-12 17:30:47 -07:00
bors-servo
6362d060e1 auto merge of #4355 : servo/servo/devtools-title, r=metajack
Fixes #4167.
2014-12-12 17:03:45 -07:00
Gilbert Röhrbein
31e40038cd script_trask, handle_msgs: factored out handle_msg_from_devtools 2014-12-12 23:54:54 +01:00
Gilbert Röhrbein
1fc46471ff script_trask, handle_msgs: factored out handle_msg_from_script 2014-12-12 23:54:52 +01:00
Gilbert Röhrbein
8da73afa06 script_trask, handle_msgs: factored out handle_msg_from_constellation 2014-12-12 23:51:14 +01:00
Gilbert Röhrbein
9b9f662732 script_task, handle_msgs: sort for pattern constructor 2014-12-12 23:37:42 +01:00
Greg Weng
a477893ab3 Return real page titles and URLs for devtools tab choices.
Fixes #4167.
2014-12-12 22:38:55 +01:00
bors-servo
9e83f096a5 auto merge of #4354 : neojski/servo/getElementsByTagNameNS-filter-root, r=Ms2ger
This fixes #4349.
2014-12-12 14:09:53 -07:00
Tomasz Kołodziejski
b30cdb8a5c Follow-up to work done in #4304.
all_elements should ignore root as well.
2014-12-12 10:39:21 -08:00
Tomasz Kołodziejski
5913ba983b Don't include the root element when calling Element#getElementsByTagNameNS. 2014-12-12 10:07:41 -08:00
Nathan E. Egge
b0552cb98e Sending key events through script task before processing them in the compositor.
Fixes #4163
2014-12-12 12:31:44 -05:00
Joseph Crail
c254d195ad Fix spelling mistakes in comments. 2014-12-11 23:56:29 -05:00
bors-servo
a016f7b201 auto merge of #4332 : Ms2ger/servo/performance, r=jdm 2014-12-11 17:33:53 -07:00