Commit graph

11341 commits

Author SHA1 Message Date
bors-servo
61d8f4d688 Auto merge of #14724 - zaynetro:remove-frame-change-document-ready, r=Ms2ger
Remove FrameChange::document_ready

<!-- Please describe your changes on the following line: -->

Remove unused `FrameChange::document_ready` field and remove unused boolean in `ConstellationMsg::GetPipeline`'s second argument.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14693

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because compiler validates the field is not used anywhere

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14724)
<!-- Reviewable:end -->
2016-12-25 03:23:16 -08:00
Roman Zaynetdinov
95552c4019 Remove unused boolean argument from ContellationMsg's GetPipeline 2016-12-25 13:06:31 +02:00
Roman Zaynetdinov
cb5ceec150 Remove unused FrameChange's document_ready field 2016-12-25 13:06:20 +02:00
bors-servo
fcc3447dfc Auto merge of #14722 - iamrohit7:check-secure-schemes, r=jdm
Check for wss schemes in Cookie::appropriate_for_url

* Also adds a new helper, `ServoUrl::is_secure_scheme`.
* Refactored `CookieStorage::push` and `CookieStorage::remove` to use the new helper.
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #14702

<!-- Either: -->
- [X] These changes do not require tests because we can't test the changes yet.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14722)
<!-- Reviewable:end -->
2016-12-25 00:48:09 -08:00
bors-servo
b5909f26cf Auto merge of #14710 - nox:repr-c, r=KiChjang
Mark DOM interfaces as repr(C)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14710)
<!-- Reviewable:end -->
2016-12-24 23:26:00 -08:00
Rohit Burra
3fce260f6e Check wss scheme in Cookie::appropriate_for_url 2016-12-25 09:14:06 +05:30
Rohit Burra
49abf57deb Refactor to use ServoUrl::is_secure_scheme 2016-12-25 09:13:21 +05:30
Rohit Burra
9123fe0cef Adds ServoUrl::is_secure_scheme helper 2016-12-25 09:02:44 +05:30
Emilio Cobos Álvarez
bf53447b9c
stylo: Regen bindings. 2016-12-25 01:41:21 +01:00
Emilio Cobos Álvarez
f08e851f81
style: Update bindings because of bug 1325006 2016-12-25 01:31:08 +01:00
bors-servo
4cb781a0a2 Auto merge of #14707 - asajeffrey:constellation-pipeline-docs, r=ConnorGBrewster
Pipeline documentation comments

<!-- Please describe your changes on the following line: -->

Rewrote the documentation comments for `pipeline.rs`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's just documentation

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14707)
<!-- Reviewable:end -->
2016-12-24 08:48:43 -08:00
bors-servo
f850918d8e Auto merge of #14699 - notriddle:constructive_commentary, r=emilio
Fix an outdated comment

The structures have changed, as has the syntax of the Rust language.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14699)
<!-- Reviewable:end -->
2016-12-24 06:42:57 -08:00
bors-servo
02717931ad Auto merge of #14698 - asajeffrey:constellation-docs, r=ConnorGBrewster
Constellation documentation comments

<!-- Please describe your changes on the following line: -->

Rewrote the documentation comments for `constellation.rs`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's just documentation

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14698)
<!-- Reviewable:end -->
2016-12-24 05:46:40 -08:00
bors-servo
de7d73adb0 Auto merge of #14623 - DominoTree:master, r=emilio
<!-- Please describe your changes on the following line: -->
Add check for bad ports to http_fetch(), return NetworkError::Internal if bad port/schema combination is seen.

Test added

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14514 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14623)
<!-- Reviewable:end -->
2016-12-24 03:41:14 -08:00
bors-servo
e80965f173 Auto merge of #14668 - glennw:update-wr-dwrote, r=jdm
Update WR (windows font fixes, ridge/groove borders, scrolling improvements).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14668)
<!-- Reviewable:end -->
2016-12-24 01:55:17 -08:00
bors-servo
b13afccb8a Auto merge of #14491 - KiChjang:cookie-checks, r=jdm
Add domain and path checks for secure cookies eviction

Fixes #14477.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14491)
<!-- Reviewable:end -->
2016-12-23 15:26:46 -08:00
Anthony Ramine
30e4bfec25 Mark DOM interfaces as repr(C) 2016-12-23 23:48:00 +01:00
Alan Jeffrey
a4a832e2d9 Updated documentation for pipeline. 2016-12-23 15:51:06 -06:00
Alan Jeffrey
1fbb23de9e Updated documentation for the constellation. 2016-12-23 12:23:41 -06:00
Michael Howell
7c7f76ca75 Fix an outdated comment 2016-12-23 17:23:12 +00:00
bors-servo
dd2aa4195a Auto merge of #14684 - Manishearth:regen, r=bholley
Regen bindings

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14684)
<!-- Reviewable:end -->
2016-12-22 23:26:57 -08:00
Manish Goregaokar
211682ab49 Regen bindings 2016-12-22 23:26:21 -08:00
Glenn Watson
b5c99f0acd Update WR (windows font fixes, ridge/groove borders, scrolling improvements). 2016-12-23 14:00:40 +10:00
bors-servo
f0a74ee0d2 Auto merge of #14679 - jdm:nowarntimer, r=asajeffrey
Warn when a timer event is processed for a discarded document.

Turn a panic into a warning for a situation that is easy to hit in web content.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14677
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14679)
<!-- Reviewable:end -->
2016-12-22 18:19:48 -08:00
bors-servo
89cdcbc420 Auto merge of #14632 - servo:multi-global-fetch, r=jdm
Use the API base URL in Fetch APIs.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14632)
<!-- Reviewable:end -->
2016-12-22 16:40:53 -08:00
Josh Matthews
8ca387c0e0 Warn when a timer event is processed for a discarded document. 2016-12-22 18:56:06 -05:00
bors-servo
4052744139 Auto merge of #14671 - servo:style-no-plugins, r=mbrubeck
Remove the unused dependency of style to plugins.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14671)
<!-- Reviewable:end -->
2016-12-22 12:53:33 -08:00
Bobby Holley
940cda1d15 Remove generation, remove filter pop, and add size tests. 2016-12-22 11:09:55 -08:00
Simon Sapin
6dec4580e6 Remove the unused dependency of style to plugins. 2016-12-22 19:54:04 +01:00
Bobby Holley
ea6a61af59 Stop using UnsafeNode in the parallel traversal.
\o/ \o/ \o/
2016-12-22 10:42:53 -08:00
Bobby Holley
b3cb786c81 Stop using UnsafeNode in the bloom filter. 2016-12-22 10:42:53 -08:00
Bobby Holley
96dc0d1eac Hoist SendElement into dom.rs, label construction as unsafe, and add corresponding SendNode. 2016-12-22 10:42:53 -08:00
Bobby Holley
b6e948dc5d Hoist bloom filter into scoped TLS and simplify code. 2016-12-22 10:42:53 -08:00
bors-servo
8c0f31e9fd Auto merge of #11672 - Ms2ger:dom, r=nox
Make the dom module private.

<!-- Reviewable:start -->

This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11672)

<!-- Reviewable:end -->
2016-12-22 07:51:48 -08:00
Ms2ger
4fca766bbd Make the dom module private. 2016-12-22 16:06:23 +01:00
Ms2ger
1bc0862214 Remove and allow some dead code. 2016-12-22 16:06:22 +01:00
Ms2ger
8f2d624cbf Move attributes for the bindings module to its mod.rs. 2016-12-22 15:58:54 +01:00
Ms2ger
86d59212fe Introduce a script::test module to expose the APIs needed for unit tests. 2016-12-22 15:58:53 +01:00
bors-servo
23590f683a Auto merge of #14612 - szeged:connect-disconnect-update, r=jdm
Updating GATTServer's  Connect/Disconnect calls

<!-- Please describe your changes on the following line: -->
Added the missing [Step 5.2.3](https://github.com/servo/servo/compare/master...szeged:connect-disconnect-update#diff-1dbe29f87740f5aec93f37adbecace6cR213) to the `connect` function.
Updated the [disconnect](https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattserver-disconnect) function to its current state in the specification, including the `clean_up_disconnected_device` and the `garbage_collect_the connection` functions.
Added new tests for checking the invalid state of JS objects after disconnection.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14612)
<!-- Reviewable:end -->
2016-12-22 06:51:16 -08:00
Zakor Gyula
6e02cb2eb9 refactor Connect/Disconnect calls 2016-12-22 15:49:29 +01:00
bors-servo
b843be4975 Auto merge of #14669 - emilio:dirty-descendants-unused, r=Wafflespeanut
script: Remove unused function.

This is no longer used since one of @bholley's patches to the style system.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14669)
<!-- Reviewable:end -->
2016-12-22 05:23:00 -08:00
Emilio Cobos Álvarez
544c2d993a
script: Remove unused function. 2016-12-22 13:31:39 +01:00
Cameron McCormack
2f81e8dfc9 Regenerate bindings. 2016-12-22 10:06:01 +08:00
Cameron McCormack
e1f86377bd Update atoms. 2016-12-22 10:06:00 +08:00
bors-servo
df667f16b0 Auto merge of #14633 - servo:rustup, r=SimonSapin,nox
Update Rust to 1.15.0-nightly (71c06a56a 2016-12-18)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14633)
<!-- Reviewable:end -->
2016-12-21 16:24:27 -08:00
Ms2ger
2cc1b84f34 Update Rust to 1.15.0-nightly (71c06a56a 2016-12-18) 2016-12-22 00:45:18 +01:00
bors-servo
641010eed8 Auto merge of #14663 - ctjhoa:moz-orient, r=Manishearth
Stylo: implement -moz-orient

<!-- Please describe your changes on the following line: -->
https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-orient
![2016-12-21-213132_1342x870_scrot](https://cloud.githubusercontent.com/assets/1716173/21405334/c6c49cb2-c7c5-11e6-85d7-e10f71c331ef.png)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14198 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it's a style addition

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14663)
<!-- Reviewable:end -->
2016-12-21 15:29:27 -08:00
Camille TJHOA
e8114ce19b Stylo: implement -moz-orient
Fix #14198
2016-12-21 21:31:58 +01:00
Bobby Holley
946e7fb7c3 Stop using UnsafeNode in the StyleSharingCandidateCache. 2016-12-21 11:10:41 -08:00
Bobby Holley
c5f01fe3b8 Introduce and use Scoped TLS.
It turns out that it's problematic to embed ThreadLocalStyleContext within
LayoutContext, because parameterizing the former on TElement (which we do
in the next patch) infects all the traversal stuff with the trait parameters,
which we don't really want.

In general, it probably makes sense to use separate scoped TLS types for
the separate DOM and Flow tree passes, so we can add a different ScopedTLS
type for the Flow pass if we ever need it.

We also reorder the |scope| and |shared| parameters in parallel.rs, because
it aligns more with the order in style/parallel.rs. I did this when I was
adding a TLS parameter to all these functions, which I realized we don't need
for now.
2016-12-21 11:10:39 -08:00