Commit graph

36 commits

Author SHA1 Message Date
WPT Sync Bot
7ef7c78b1b Update web-platform-tests to revision 57727f82763c80c89a94593a7b0960abcf4daa4a 2020-06-10 10:42:31 +00:00
bors-servo
e2d980a071
Auto merge of #26480 - CYBAI:missing-on, r=jdm
Prefix `on` for function name of inline events

While checking what needs to be done for the spec-update, I've noticed the logic of checking `is window-reflecting element (e.g. body and frameset)` is already handled by the `is` casting function.

However, we still failed to pass the tests because we're missing `on` prefix for inline functions.

I'm not sure if this patch is good enough (or maybe at least I need to add a comment for why adding `on` prefix?).

Besides, I checked [how Gecko handles](https://searchfox.org/mozilla-central/rev/8bc4e35c9bb47c1fe3131e6155d9f482e1efef9a/dom/events/EventListenerManager.cpp#1012-1022) and looks like they also just pass the atom directly.
But, the [generated atom](https://searchfox.org/mozilla-central/source/__GENERATED__/xpcom/ds/nsGkAtomList.h#775) is prefixed with `on` which is correct to just pass it into the `CompileFunction`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26479
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-06-04 16:45:22 -04:00
WPT Sync Bot
7f8c29593f Update web-platform-tests to revision fd60ba25a0726dfea59024d8143240b355c46a55 2020-06-02 13:10:28 +00:00
WPT Sync Bot
ce1de3b503 Update web-platform-tests to revision c99723afe33bc5b265e41c1a9446eaff7f8e0d57 2020-05-31 11:24:52 +00:00
WPT Sync Bot
1c115a1737 Update web-platform-tests to revision 8fd32a0f7c18d32ae9e147d267746accc3ee9ad5 2020-05-30 10:56:10 +00:00
WPT Sync Bot
4702cbe05c Update web-platform-tests to revision e529eb9501876273c9612f5602bc530723a01147 2020-05-29 11:22:44 +00:00
WPT Sync Bot
1b463fce85 Update web-platform-tests to revision 5c34fc630374b9eb0559139a486ff1a2e4247c4f 2020-05-28 11:23:41 +00:00
WPT Sync Bot
fc2af06212 Update web-platform-tests to revision 82b3595ce0ea99dd2a04b578421b4d281e53ee31 2020-05-26 11:20:12 +00:00
WPT Sync Bot
8bfe9992ce Update web-platform-tests to revision 1d8a9889466f2ec219a879323c63cae86ef50bc1 2020-05-23 10:45:50 +00:00
WPT Sync Bot
e9b62f1a9b Update web-platform-tests to revision 31500c8726aeb1871bc5ca19642f5cb94a0e1a92 2020-05-22 11:27:02 +00:00
WPT Sync Bot
9cff065d01 Update web-platform-tests to revision 7cb66930f16381536cec572cd3f4f86c7bbb6787 2020-05-19 11:08:36 +00:00
WPT Sync Bot
4f13fd6595 Update web-platform-tests to revision afb5f984d7beecafa3d68ea7719ae2f4d203f1e1 2020-05-18 11:17:09 +00:00
WPT Sync Bot
f67126ace0 Update web-platform-tests to revision e6695b77fc9bb1e5c71ce474c4e7f8784713c754 2020-05-17 11:07:53 +00:00
WPT Sync Bot
6f4d1ac19b Update web-platform-tests to revision 823cca0c2c6b421912973e7f699a357411738c64 2020-05-16 10:41:56 +00:00
WPT Sync Bot
96553cb7e2 Update web-platform-tests to revision ae1e2d51f38e208f3d07a97b5d82f9ca0dda2c94 2020-05-14 11:21:00 +00:00
WPT Sync Bot
ab5c81c0bb Update web-platform-tests to revision 85ffed21f7a96f6d67a5a0110459d67f50cff624 2020-05-13 11:06:53 +00:00
WPT Sync Bot
354984b2bf Update web-platform-tests to revision 46b884903ba0153b2cd9d932504f6b88f57614cf 2020-05-10 11:17:26 +00:00
CYBAI
b4d1f5b309 Prefix on for function name of inline events 2020-05-10 19:53:36 +09:00
WPT Sync Bot
f05c813634 Update web-platform-tests to revision 3a7b40eb73bf5359adf0d378b71d36488885057f 2020-05-09 11:10:45 +00:00
WPT Sync Bot
f71dd608db Update web-platform-tests to revision 7ef67f2d8c667d7f5a828fa0f6878ed45d1432d8 2020-05-04 13:10:47 +00:00
WPT Sync Bot
3f44ddc852 Update web-platform-tests to revision c19e2b60b554e64ad07f25675f659ce76cee9e82 2020-05-03 11:19:37 +00:00
WPT Sync Bot
00971fa7af Update web-platform-tests to revision ef4113222efb4cc08100f34f2dd9ab8ecc3660eb 2020-05-02 11:27:29 -04:00
WPT Sync Bot
909e31e110 Update web-platform-tests to revision dfe0b490c6018fd36379f4c7726f9f6a37728838 2020-05-01 11:11:41 +00:00
WPT Sync Bot
db4f300c7c Update web-platform-tests to revision e51f414776c4e7efa7cfa5fe63a3a8b3969e06ac 2020-04-30 18:22:37 -04:00
WPT Sync Bot
d4bfc5902a Update web-platform-tests to revision d9ff48a8babff036c1f9d5285ec0dc55609bebb8 2020-04-29 11:14:24 +00:00
WPT Sync Bot
94f517b8d8 Update web-platform-tests to revision 6a2f0e6a0110fd0830fc3196680f671bb83c2747 2020-04-28 11:09:30 +00:00
WPT Sync Bot
58265ed975 Update web-platform-tests to revision 55367a4c706fa32301980773cb2c09cbcd291635 2020-04-27 11:19:06 +00:00
WPT Sync Bot
629790db5d Update web-platform-tests to revision 5e7cbed423a3040dc8ca50359dd033a46dba5cf4 2020-04-26 11:12:33 +00:00
WPT Sync Bot
55139554ba Update web-platform-tests to revision 78eae724c61bb01d858a01a324363e997ac66851 2020-04-25 11:14:57 +00:00
WPT Sync Bot
906e45aab0 Update web-platform-tests to revision 9a6026305062c90d84a567d81434010dde6c6c22 2020-04-21 11:23:54 +00:00
WPT Sync Bot
10112eddce Update web-platform-tests to revision 9b5bdedc2ad7797a6b99895157aeaa2b3a2d61e6 2020-04-20 11:12:41 +00:00
WPT Sync Bot
e116a19f0b Update web-platform-tests to revision 9d583db6a1a16763322dce912bf057490cd7b0c7 2020-04-19 11:09:10 +00:00
WPT Sync Bot
10cafa3df2 Update web-platform-tests to revision a4482f355e2848f4623cf46f521cb9b3bca56129 2020-04-14 11:10:36 +00:00
WPT Sync Bot
c9a04ea515 Update web-platform-tests to revision ec1023a6b5f4dc6c8cbeb3507081e2ac3741adad 2020-04-13 11:07:48 +00:00
WPT Sync Bot
e854d6a62a Update web-platform-tests to revision 1461434ba9b333a8f4ee0c9acfe9884ac5fbe112 2020-04-12 11:06:54 +00:00
WPT Sync Bot
d8c042fbb2 Update web-platform-tests to revision 3bf30e8f1c56700c4b48508e876e72cccb7437ed 2020-04-01 10:58:32 +00:00