Commit graph

12333 commits

Author SHA1 Message Date
bors-servo
d654841288 Auto merge of #7177 - pcwalton:intervening-inline-block, r=mbrubeck
layout: Improve our handling of inline absolute containing blocks.

Several issues are addressed in this commit:

* Inline flows now bubble up their absolute descendants instead of
  making the inline flow the containing block for them. (In the future,
  we will need to make the inline flow *sometimes* be the containing
  block for them, but for now it improves sites to unconditionally
  bubble up.)

* Fragments now look at their inline fragment context to determine
  whether they are positioned.

* Inline flows now push the stacking-relative position of the absolute
  containing block down to their inline-block fragments.

* Inline absolute hypothetical fragments can be containing blocks.

* Fixes the logic in
  `containing_block_range_for_flow_surrounding_fragment_at_index`. The
  condition to determine whether fragments are positioned was inverted!

* `Descendants`/`AbsDescendants` has been refactored in order to become
  more friendly to inline absolute containing blocks in the future.

Improves the inline position of the green drop-down arrow in the Google
SERPs. (The block position is still wrong.)

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7177)
<!-- Reviewable:end -->
2015-08-17 13:56:53 -06:00
Patrick Walton
a30379975a layout: Improve our handling of inline absolute containing blocks.
Several issues are addressed in this commit:

* Inline flows now bubble up their absolute descendants instead of
  making the inline flow the containing block for them. (In the future,
  we will need to make the inline flow *sometimes* be the containing
  block for them, but for now it improves sites to unconditionally
  bubble up.)

* Fragments now look at their inline fragment context to determine
  whether they are positioned.

* Inline flows now push the stacking-relative position of the absolute
  containing block down to their inline-block fragments.

* Inline absolute hypothetical fragments can be containing blocks.

* Fixes the logic in
  `containing_block_range_for_flow_surrounding_fragment_at_index`. The
  condition to determine whether fragments are positioned was inverted!

* `Descendants`/`AbsDescendants` has been refactored in order to become
  more friendly to inline absolute containing blocks in the future.

Improves the inline position of the green drop-down arrow in the Google
SERPs. (The block position is still wrong.)
2015-08-17 12:43:12 -07:00
bors-servo
72fa45155b Auto merge of #7252 - nnethercote:fix-reporter-panics, r=Ms2ger
Fix panics in the script_task memory reporter.

These are caused by page_root being empty.

@jdm, I think it was #6874 that introduced these. I'm seeing them all the time when starting Servo on Reddit with memory profiling enabled. With this patch applied they go away.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7252)
<!-- Reviewable:end -->
2015-08-17 08:56:29 -06:00
Nicholas Nethercote
97e3b24aa6 Fix panics in the script_task memory reporter.
These are caused by page_root being empty.
2015-08-17 04:37:43 -07:00
bors-servo
d90907cb5f Auto merge of #7245 - jxs:master, r=Ms2ger
replace len() !=0 with !is_empty()



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7245)
<!-- Reviewable:end -->
2015-08-17 02:33:28 -06:00
bors-servo
71ae18bae4 Auto merge of #7219 - vectorijk:issue#7042, r=Ms2ger
remove unused static collection type in htmlcollection.rs

ref #7042 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7219)
<!-- Reviewable:end -->
2015-08-17 02:03:23 -06:00
bors-servo
95c6301cf4 Auto merge of #7249 - servo:gold, r=paulrouget
Only use a rustc wrapper script when ld.gold is available.

Fixes #7247.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7249)
<!-- Reviewable:end -->
2015-08-17 01:26:26 -06:00
Simon Sapin
1dab9294f4 Only use a rustc wrapper script when ld.gold is available.
Fixes #7247.
2015-08-17 09:20:07 +02:00
João Oliveira
1e20447746 replace len() !=0 with !is_empty() 2015-08-17 02:56:07 +01:00
bors-servo
3bb930661d Auto merge of #7244 - wartman4404:master, r=nox
Remove the DOMRefCell wrapper around Window::compositor.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7244)
<!-- Reviewable:end -->
2015-08-16 16:52:01 -06:00
wartman4404
8d665008f8 Remove the DOMRefCell wrapper around Window::compositor. 2015-08-16 17:28:21 -05:00
vectorijk
59d704b53f turn enum into struct
pub enum CollectionTypeId -> pub struct Collection
2015-08-16 12:01:51 -07:00
vectorijk
d853aaba65 remove unused static collection 2015-08-16 11:38:22 -07:00
bors-servo
e74825f9fd Auto merge of #7203 - jdm:style, r=Ms2ger
Add automated style nit checks to test-tidy

Expands on the work by @wilmoz and cleans up the existing errors. Closes #7180. Closes #7111.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7203)
<!-- Reviewable:end -->
2015-08-16 08:37:40 -06:00
Josh Matthews
f6b3bebf84 Deal with /* /* when checking syntax. 2015-08-16 10:31:49 -04:00
Josh Matthews
a147cbe0c1 Tighten up checks for spaces around colons to deal with trait inheritance syntax. 2015-08-16 10:31:36 -04:00
Josh Matthews
8bb853f643 Fix existing syntactics nits. 2015-08-16 10:30:43 -04:00
Josh Matthews
7f935f010b Deal with multiline comments and reduce false positives for common syntax overlaps. Improve error messages. 2015-08-16 10:25:51 -04:00
Josh Matthews
4e593280ff Deal with multiline strings and tighten up syntax nit error messages. 2015-08-16 10:25:51 -04:00
wilmoz
e57a3888a5 Check for simple Rust style nits in tidy.py 2015-08-16 10:25:50 -04:00
bors-servo
4d7dd66ec9 Auto merge of #7240 - Ms2ger:slice_extras, r=nox
Stop using [T]::tail.

It has been removed upstream (rust-lang/rust#27684).

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7240)
<!-- Reviewable:end -->
2015-08-16 07:13:57 -06:00
Ms2ger
a3bc438a9d Stop using [T]::tail.
It has been removed upstream (rust-lang/rust#27684).
2015-08-16 14:50:37 +02:00
bors-servo
a2978f2add Auto merge of #7236 - nox:dictionary-failure-code, r=Ms2ger
Fix dictionary member conversion failure (fixes #7231)



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7236)
<!-- Reviewable:end -->
2015-08-16 06:39:56 -06:00
Anthony Ramine
47e76ff4ab Fix dictionary member conversion failure (fixes #7231) 2015-08-16 14:32:54 +02:00
Anthony Ramine
44aabbe64d Support required dictionary members (fixes #7216) 2015-08-16 14:16:32 +02:00
Anthony Ramine
efe982392e Update WebIDL parser 2015-08-16 14:16:31 +02:00
bors-servo
5ab9aa5013 Auto merge of #7191 - vectorijk:removeScriptListener, r=Ms2ger
remove ScriptListener

Fix issue #7175 and for code review

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7191)
<!-- Reviewable:end -->
2015-08-16 03:23:27 -06:00
vectorijk
270df6bac8 without the explicit dereferencing 2015-08-16 01:34:58 -07:00
vectorijk
7758f81ffd dereference via * instead of RefMut 2015-08-16 01:34:57 -07:00
vectorijk
14ac1ef75a remove ScriptListener
ref #7175
2015-08-16 01:34:55 -07:00
bors-servo
7c63c7d7c1 Auto merge of #7214 - tomjakubowski:websocket-binaryType, r=Ms2ger
Implement WebSocket#binaryType

Closes #7098

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7214)
<!-- Reviewable:end -->
2015-08-15 19:57:58 -06:00
Tom Jakubowski
e92f4629db WebSocket: Implement WebSocket#binaryType 2015-08-15 12:44:22 -07:00
bors-servo
55e755e35a Auto merge of #7233 - nox:default-float-value, r=Ms2ger
Support default values for restricted float members (fixes #7217)



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7233)
<!-- Reviewable:end -->
2015-08-15 10:59:44 -06:00
bors-servo
a1aed50b5a Auto merge of #7229 - servo:gold, r=metajack
Use the gold linker when available.

This shaves 50 seconds off the build time on my machine.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7229)
<!-- Reviewable:end -->
2015-08-15 10:25:26 -06:00
Simon Sapin
fb7a53c6cf Use the gold linker when available.
This shaves 50 seconds off the build time on my machine.
2015-08-15 18:09:18 +02:00
Simon Sapin
70abd79f62 Upgrade cargo to 0.4.0-nightly (425fd85 2015-08-05)
Pick up https://github.com/rust-lang/cargo/pull/1830
2015-08-15 18:08:33 +02:00
bors-servo
7f69a2994d Auto merge of #7232 - vks:print-commands, r=jdm
mach: Print commands if '--verbose' is set

Fixes #6363.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7232)
<!-- Reviewable:end -->
2015-08-15 09:47:13 -06:00
bors-servo
31413f4313 Auto merge of #7188 - servo:set_inline_style_property_priority, r=nox
Fix Element::set_inline_style_property_priority’s handling of priority

Thanks to @michaelwu for pointing out a copy-paste error.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7188)
<!-- Reviewable:end -->
2015-08-15 09:17:31 -06:00
bors-servo
0080d0de0e Auto merge of #7234 - Ms2ger:PerformanceActor, r=metajack
Implement a PerformanceActor.

This is necessary for the devtools "Start Recording Performance" button to
send a message.

(This message is not yet supported, so it leads to
'unexpected message type "startRecording" found for actor "performance4"'.)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7234)
<!-- Reviewable:end -->
2015-08-15 08:16:55 -06:00
Anthony Ramine
ec2a6b24b1 Support default values for restricted float members (fixes #7217) 2015-08-15 14:45:26 +02:00
Vinzent Steinberg
824384a1c2 Fix 'mach test' 2015-08-15 14:38:44 +02:00
Ms2ger
238beec038 Implement a PerformanceActor.
This is necessary for the devtools "Start Recording Performance" button to
send a message.

(This message is not yet supported, so it leads to
'unexpected message type "startRecording" found for actor "performance4"'.)
2015-08-15 14:21:25 +02:00
Vinzent Steinberg
fe7b443c16 mach: Print commands if '--verbose' is set
Fixes #6363.
2015-08-15 13:58:36 +02:00
bors-servo
6a52ec9484 Auto merge of #7006 - Wafflespeanut:script_cleanup, r=jdm
Splitting ScriptMsg into various enums...

... for #3734, which is also one of the oldest issues. (/cc @jdm)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7006)
<!-- Reviewable:end -->
2015-08-15 03:48:47 -06:00
bors-servo
a1b3f477aa Auto merge of #7225 - jxs:master, r=nox
Replace uses of `for foo in bar.iter()` and `for foo in bar.iter_mut()`

closes #7197

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7225)
<!-- Reviewable:end -->
2015-08-15 03:03:21 -06:00
João Oliveira
0038580abf Replace uses of for foo in bar.iter() and for foo in bar.iter_mut()
closes #7197
2015-08-15 02:27:39 +01:00
Patrick Walton
3f4487d81d gfx: Paint dashed borders with nonzero radii the same way Gecko does.
It's not ideal, but it was easy to implement and will do for now.

Closes #7157.
2015-08-14 16:42:47 -07:00
Ravi Shankar
89153116fb Splitting ScriptMsg into various enums; r=jdm 2015-08-15 02:00:48 +05:30
bors-servo
13e7de482c Auto merge of #7195 - servo:rustup_20150814, r=Ms2ger
Upgrade Rust to nightly 2015-08-10

Still needs snapshot.

Snapshot probably could also work as today's nightly (I wasn't able to download the latest one due to choppy internet), there isn't any plugins churn I know of

r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7195)
<!-- Reviewable:end -->
2015-08-14 12:53:54 -06:00
Manish Goregaokar
91bc14711d Upgrade Rust to nightly 2015-08-10 2015-08-15 00:21:33 +05:30