bors-servo
394921e33c
Auto merge of #17716 - emilio:reconstruct-root, r=heycam
...
style: Don't early return before updating the root font-size.
We never use the reconstruct path for the root, but feels less handwavy.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17716 )
<!-- Reviewable:end -->
2017-07-13 18:57:47 -07:00
Xidorn Quan
1362ba5f3c
Update binding file.
2017-07-14 10:54:00 +10:00
Xidorn Quan
6a12de1c1a
Add style adjustments for ruby.
2017-07-14 10:53:58 +10:00
Xidorn Quan
fcf37b19fd
Move HAS_TEXT_DECORATION_LINES setting into StyleAdjuster.
2017-07-14 10:53:50 +10:00
Xidorn Quan
86799d4d6e
Inherit computed value flags when inheriting computed values.
2017-07-14 10:53:48 +10:00
Xidorn Quan
2a05c29c30
Rename HAS_TEXT_DECORATION_LINE to match gecko side name.
2017-07-14 10:53:46 +10:00
Xidorn Quan
5270b766c1
Skip parent-display-based display type fixup for all anonymous boxes.
2017-07-14 10:53:38 +10:00
bors-servo
788ba8ccf0
Auto merge of #17717 - emilio:style-sharing-stop, r=bzbarsky
...
style: Don't stop looking at the sharing cache for various reasons.
All the information that made those failures expensive is now lazily computed
and cached, or eagerly computed anyway, so seems not worth to stop iteration.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17717 )
<!-- Reviewable:end -->
2017-07-13 15:05:07 -07:00
Simon Sapin
09d6c83c50
Use match
instead of if let
of one-line branches.
2017-07-13 16:58:19 +02:00
Emilio Cobos Álvarez
8667cea4ca
style: Don't stop looking at the sharing cache for various reasons.
...
All the information that made those failures expensive is now lazily computed
and cached, or eagerly computed anyway, so seems not worth to stop iteration.
2017-07-13 16:23:56 +02:00
Simon Sapin
34c5a21691
Merge per-property substitute_variables* functions into one.
2017-07-13 16:23:36 +02:00
Simon Sapin
3d3c196d90
Fix shorthand parsing pushing declarations when parse_entirely returns Err
2017-07-13 16:23:35 +02:00
Simon Sapin
66c357feef
Fix handling of all
shorthand with var() functions
2017-07-13 16:23:14 +02:00
Simon Sapin
42813bc813
Move property value parsing from longhand/shorthand ID into separate methods.
2017-07-13 16:23:13 +02:00
Simon Sapin
54f1325a49
var() functions in longhands: use a single code path with IDs
...
… rather than generating similar code for every longhand property
2017-07-13 16:23:12 +02:00
Simon Sapin
252e52e24e
var() functions in shorthands: use a single code path with IDs
...
… rather than generating similar code for each shorthand.
2017-07-13 16:23:11 +02:00
Simon Sapin
8a8614eccd
CSS-wide keywords parsing in longhands: use a single code path with IDs
...
… rather than generating similar code for every longhand property.
2017-07-13 16:23:10 +02:00
Simon Sapin
a5b80e2d75
CSS-wide keywords parsing in shorthand: use a single code path with IDs
...
… rather than generating similar code for each shorthand.
2017-07-13 16:23:09 +02:00
Simon Sapin
3075746edd
Property validity checks: generated tables rather than genrated code
2017-07-13 16:23:08 +02:00
Emilio Cobos Álvarez
f77bfedb9e
style: Don't early return before updating the root font-size.
...
We never use the reconstruct path for the root, but feels less handwavy.
2017-07-13 16:00:20 +02:00
Emilio Cobos Álvarez
62310d9bd5
style: Don't use the current element info for cached validation data.
...
We can take it straight from the validation target.
2017-07-13 15:36:59 +02:00
Emilio Cobos Álvarez
36310e3b66
style: Kill some style sharing code.
...
MozReview-Commit-ID: 42MyHx3QHuu
2017-07-13 15:32:20 +02:00
bors-servo
347cbb0635
Auto merge of #17711 - ferjm:bug1367274.linear.gradient, r=xidorn
...
Implement serialization of linear-gradient the same ways as in Gecko
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
From https://bugzilla.mozilla.org/show_bug.cgi?id=1367274
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17711 )
<!-- Reviewable:end -->
2017-07-13 05:17:06 -07:00
bors-servo
9515abbca3
Auto merge of #17707 - emilio:invalidation-less-memory, r=heycam
...
stylo: Waste less memory in invalidation stuff and style rules.
This should help a lot with https://bugzilla.mozilla.org/show_bug.cgi?id=1380488 .
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17707 )
<!-- Reviewable:end -->
2017-07-13 04:15:15 -07:00
Fernando Jiménez Moreno
6ae4bf6ee8
Implement serialization of linear-gradient the same ways as in Gecko
2017-07-13 12:20:30 +02:00
bors-servo
9d74ae890b
Auto merge of #17710 - emilio:revert-bloom-sharing, r=heycam
...
Revert "Auto merge of #17701 - bholley:reuse_allocations, r=emilio"
This reverts commit ebfc8f5858
, reversing
changes made to 5585ff2c44
.
Animation code can reenter and create a new TLS context from the traversal
SequentialTask, so this won't work as written, and it's making test fails.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17710 )
<!-- Reviewable:end -->
2017-07-13 01:26:34 -07:00
Emilio Cobos Álvarez
a34f288b98
Revert "Auto merge of #17701 - bholley:reuse_allocations, r=emilio"
...
This reverts commit ebfc8f5858
, reversing
changes made to 5585ff2c44
.
Animation code can reenter and create a new TLS context from the traversal
SequentialTask, so this won't work as written.
2017-07-13 09:58:08 +02:00
bors-servo
9451b41d33
Auto merge of #17702 - upsuper:python-addr-in-generated, r=emilio
...
Avoid random python address to be added to generated files
This would catch cases like #17691 and avoid regressing [bug 1380327](https://bugzilla.mozilla.org/show_bug.cgi?id=1380327 ) in this manner.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17702 )
<!-- Reviewable:end -->
2017-07-12 23:34:58 -07:00
Emilio Cobos Álvarez
445b8fb3e8
style: Remove SelectorAndHashes.
2017-07-13 05:44:55 +02:00
Emilio Cobos Álvarez
dee4aea264
style: Remove hashes from style rules and dependencies.
...
Dependencies are very numerous, and now we shouldn't be getting so many of them.
Style rules just don't need them, so it's a waste of memory.
2017-07-13 05:44:53 +02:00
Emilio Cobos Álvarez
1785fd66a4
style: Avoid parsing negative padding in the padding shorthand.
2017-07-13 04:58:21 +02:00
Emilio Cobos Álvarez
9394ea9644
style: Remove unneeded bounds in SelectorMap and related code.
...
MozReview-Commit-ID: CWwdVCwWijn
2017-07-13 03:34:33 +02:00
bors-servo
ebfc8f5858
Auto merge of #17701 - bholley:reuse_allocations, r=emilio
...
reuse the bloom filter and style sharing cache across traversals
https://bugzilla.mozilla.org/show_bug.cgi?id=1380198
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17701 )
<!-- Reviewable:end -->
2017-07-12 16:48:19 -07:00
Bobby Holley
3bce0c7652
Stop using SendElement in StyleSharingCandiate.
...
MozReview-Commit-ID: AuNPDsq8bgk
2017-07-12 16:38:08 -07:00
Bobby Holley
ec6cca6d08
Reuse style sharing cache across traversals.
...
MozReview-Commit-ID: 9wCJtciqs6K
2017-07-12 16:38:07 -07:00
Bobby Holley
0614010552
Store the bloom filter in TLS and reuse it across traversals.
...
MozReview-Commit-ID: EbzDehr2Y2L
2017-07-12 16:38:06 -07:00
Bobby Holley
d1c31f7eaf
Add owning_ref back as a style dep, and update parking_lot.
2017-07-12 16:37:50 -07:00
Xidorn Quan
455dffc919
Avoid random python address to be added to generated files
2017-07-13 09:06:35 +10:00
bors-servo
5585ff2c44
Auto merge of #17692 - canaltinova:grid-pls, r=wafflespeanut
...
stylo: Fix grid-template serialization in grid shorthand
Because of some unnecessary checks, it wasn't able to serialize the '40px / none' value properly before. That will fix one failure on `test_value_storage.html`
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17692 )
<!-- Reviewable:end -->
2017-07-12 14:38:14 -07:00
Nazım Can Altınova
8f12485d4b
stylo: Fix grid-template serialization in grid shorthand
...
Because of some unnecessary checks, it wasn't able to serialize the '40px / none' value properly before.
2017-07-12 14:06:04 -07:00
bors-servo
55c3e6ed87
Auto merge of #17691 - emilio:nondeter, r=Manishearth
...
stylo: Fix causes of non-determinism in gecko_properties.rs.
We should sort out all the different ways we have to get sides and all those
nasty loops, eventually...
Bug: 1380327
Reviewed-By: Manishearth
MozReview-Commit-ID: 4lAPEGeZaik
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17691 )
<!-- Reviewable:end -->
2017-07-12 13:10:12 -07:00
Emilio Cobos Álvarez
c591df7012
stylo: Fix causes of non-determinism in gecko_properties.rs.
...
We should sort out all the different ways we have to get sides and all those
nasty loops, eventually...
Bug: 1380327
Reviewed-By: Manishearth
MozReview-Commit-ID: 4lAPEGeZaik
2017-07-12 21:59:11 +02:00
bors-servo
f9fad3d959
Auto merge of #17662 - servo:derive-all-the-things, r=emilio,SimonSapin
...
Improve derivation of ToCss again
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17662 )
<!-- Reviewable:end -->
2017-07-12 04:56:31 -07:00
Anthony Ramine
d03bcfa8b3
Derive ToCss for TrackSize<L>
2017-07-12 12:36:20 +02:00
bors-servo
ce52c16a8f
Auto merge of #17687 - upsuper:tree-pseudo, r=heycam
...
Support parsing ::-moz-tree-* pseudo-elements selector
This is the Servo side change of [bug 1348488](https://bugzilla.mozilla.org/show_bug.cgi?id=1348488 ).
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17687 )
<!-- Reviewable:end -->
2017-07-12 03:35:37 -07:00
Xidorn Quan
97b2b95f99
Update generated files.
2017-07-12 20:33:15 +10:00
Xidorn Quan
a307653581
Implement parsing of tree pseudo-elements.
2017-07-12 20:33:11 +10:00
Anthony Ramine
7bc9a95b46
Rename MinMax to Minmax
2017-07-12 11:45:17 +02:00
Anthony Ramine
c2e746004a
Derive ToCss for MozImageRect<Color>
2017-07-12 11:45:16 +02:00
Anthony Ramine
907d629ca4
Rename ImageRect to MozImageRect
2017-07-12 11:45:15 +02:00