Commit graph

31404 commits

Author SHA1 Message Date
Anthony Ramine
4f3a113312 Update gecko-media (fixes #19348) 2017-12-04 10:56:55 +01:00
Alan Jeffrey
d13ff4daf0 Move the trap instruction in /etc/ci/performance/test_all.sh. 2017-12-03 21:22:38 -06:00
Cameron McCormack
89bf25b879
geckolib: Fix typo in CSS parser error message name. 2017-12-04 10:33:01 +08:00
Cameron McCormack
ec4f9a5f3b style: Update Gecko bindings. 2017-12-04 09:21:54 +08:00
Cameron McCormack
3513b31091 style: Add FFI function to parse a @counter-style descriptor. 2017-12-04 08:57:46 +08:00
Cameron McCormack
c00944046c geckolib: Add FFI function to parse a @counter-style name. 2017-12-04 08:57:46 +08:00
bors-servo
e4dba3abef Auto merge of #19462 - emilio:angle-parsing, r=nox
style: Cleanup Angle parsing.

This PR also contains a functional change, allowing to parse unitless zero angles in hue-rotate().

See the links and the comments for why.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19462)
<!-- Reviewable:end -->
2017-12-03 09:14:59 -06:00
bors-servo
14f757817e Auto merge of #19463 - emilio:bye-parse-functions, r=jdm
style: Remove free parsing functions, use Integer::parse and Number::parse instead.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19463)
<!-- Reviewable:end -->
2017-12-03 06:02:12 -06:00
Fabrice Desré
e8d82a5426
Prevent an unused import warning on non desktop platforms
opts is not used on Android for instance.
2017-12-02 19:29:55 -08:00
bors-servo
d198caa9ff Auto merge of #19436 - aethanyc:shape-image-threshold, r=heycam
style: Support 'shape-image-threshold' property

This has been reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1265343

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19436)
<!-- Reviewable:end -->
2017-12-02 10:03:16 -06:00
Emilio Cobos Álvarez
93fc9ab63a
style: Remove free parsing functions, use Integer::parse and Number::parse instead. 2017-12-02 16:15:11 +01:00
Emilio Cobos Álvarez
3631b1e197
style: Deduplicate Angle parsing code. 2017-12-02 15:39:06 +01:00
Emilio Cobos Álvarez
55439e6222
style: Allow parsing unitless zero angles in hue-rotate().
Per https://github.com/w3c/fxtf-drafts/issues/228
2017-12-02 15:39:05 +01:00
Emilio Cobos Álvarez
25ae329156
style: Formatting nits in gradient parsing. 2017-12-02 15:20:01 +01:00
bors-servo
45bbbac9d9 Auto merge of #19454 - emilio:has-class-is-stupid, r=upsuper
style: Add a missing fast-path in GeckoElement::each_class.

This shows up when inserting elements in the bloom filter.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19454)
<!-- Reviewable:end -->
2017-12-02 01:40:00 -06:00
bors-servo
e8593e2963 Auto merge of #19452 - emilio:layers-as-an-onion, r=jdm
style: Remove pretty useless layer of abstraction.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19452)
<!-- Reviewable:end -->
2017-12-01 22:08:22 -06:00
Emilio Cobos Álvarez
d570fc8164
style: Remove pretty useless layer of abstraction. 2017-12-02 03:23:22 +01:00
bors-servo
49e6594bc9 Auto merge of #19455 - emilio:color-does-stupid-things-too, r=upsuper
style: Don't waste an allocation when failing to parse a CSSParserColor.

I see that allocation show up in the profiles, and it makes sense, because
system colors and such are common in Firefox, and they're just wasting it.

Note that the clone() added is refcounted.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19455)
<!-- Reviewable:end -->
2017-12-01 18:03:11 -06:00
bors-servo
f7aa22a87e Auto merge of #19451 - emilio:inlining-is-fun, r=upsuper
style: Inline some things that should never ever appear in a profile.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19451)
<!-- Reviewable:end -->
2017-12-01 16:52:34 -06:00
bors-servo
bca8951182 Auto merge of #19453 - emilio:is-root-is-slow, r=upsuper
style: Add a fast-path for GeckoElement::is_root.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19453)
<!-- Reviewable:end -->
2017-12-01 15:14:13 -06:00
bors-servo
75f348ecc4 Auto merge of #19449 - emilio:calc-serialization-test, r=jdm
style: Upstream calc serialization test.

And test https://github.com/w3c/csswg-drafts/issues/1731 too, since it was fixed.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19449)
<!-- Reviewable:end -->
2017-12-01 13:56:44 -06:00
Emilio Cobos Álvarez
848a8581ac
style: Don't waste an allocation when failing to parse a color.
I see that allocation show up in the profiles, and it makes sense, because
system colors and such are common in Firefox, and they're just wasting it.

Note that the clone() added is refcounted.
2017-12-01 20:55:24 +01:00
Emilio Cobos Álvarez
a4cb6b8f09
style: Formatting nits in snapshot_helpers-related code. 2017-12-01 20:37:45 +01:00
Emilio Cobos Álvarez
bea7b31445
style: Add a missing fast-path in GeckoElement::each_class.
This shows up when inserting elements in the bloom filter.
2017-12-01 20:37:28 +01:00
Emilio Cobos Álvarez
382a89511a
style: Add a fast-path for GeckoElement::is_root. 2017-12-01 20:17:53 +01:00
Emilio Cobos Álvarez
2bbeda97d3
style: Inline some things that should never ever appear in a profile. 2017-12-01 20:04:33 +01:00
bors-servo
210d0ab30a Auto merge of #19447 - emilio:arc-soundness, r=jdm
servo_arc: Add some #[inline] and repr(C) annotations.

inline is probably unnecessary, but anyway... We rely on those being repr(C), so
they rather have some.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19447)
<!-- Reviewable:end -->
2017-12-01 12:58:11 -06:00
Alan Jeffrey
524df9e18e Upload buildbot perf data to S3. 2017-12-01 11:47:07 -06:00
bors-servo
712d75af01 Auto merge of #19307 - avadacatavra:domrefcellpanic, r=jdm
change parse_own_css to queue event not fire synchronously

<!-- Please describe your changes on the following line: -->
fixes a panic and aligns with spec

I've also added checks around each mutable borrow of the tokenizer to see if we can catch any other panics

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18930 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19307)
<!-- Reviewable:end -->
2017-12-01 11:41:47 -06:00
Emilio Cobos Álvarez
d45a8425af
style: Upstream calc serialization test. 2017-12-01 18:15:26 +01:00
Emilio Cobos Álvarez
a350a86e6f
style: Test calc() percentage position in serialization.
The spec issue was resolved.
2017-12-01 18:13:30 +01:00
bors-servo
af8d53372f Auto merge of #19446 - emilio:bye-moz-border-colors, r=xidorn
style: Make -moz-border-colors chrome only.

This also makes the `border` shorthand not reset them.

Bug: 1417200
Reviewed-by: xidorn
MozReview-Commit-ID: KNais1e5FnE

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19446)
<!-- Reviewable:end -->
2017-12-01 10:41:33 -06:00
Emilio Cobos Álvarez
0f12380db3
style: Make -moz-border-colors chrome only.
This also makes the `border` shorthand not reset them.

Bug: 1417200
Reviewed-by: xidorn
MozReview-Commit-ID: KNais1e5FnE
2017-12-01 16:49:55 +01:00
Emilio Cobos Álvarez
a1521d9d4d
servo_arc: Add some #[inline] and repr(C) annotations.
inline is probably unnecessary, but anyway... We rely on those being repr(C), so
they rather have some.
2017-12-01 14:34:38 +01:00
bors-servo
9da7663e29 Auto merge of #19344 - asajeffrey:buldbot-perf-download-json, r=jdm
Download the buildbot statistics and save them as CSV

<!-- Please describe your changes on the following line: -->

Download timing data from build.servo.org, and convert it to CSV for feeding to Google Data Studio.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19344)
<!-- Reviewable:end -->
2017-12-01 06:52:26 -06:00
Ting-Yu Lin
668795ad16 style: Update gecko bindings
MozReview-Commit-ID: CBPdp0e1k6h
2017-12-01 15:01:15 +08:00
Ting-Yu Lin
1b14ca3a9d style: Support 'shape-image-threshold' property
MozReview-Commit-ID: 14lzl3ln3Rg
2017-12-01 11:18:54 +08:00
Alan Jeffrey
7151f24ca5 Download the buildbot statistics and save them as CSV. 2017-11-30 16:20:23 -06:00
bors-servo
b7bb6ffbb8 Auto merge of #19440 - asajeffrey:test-perf-utf8, r=jdm
Added explicit UTF-8 encoding to test-perf.

<!-- Please describe your changes on the following line: -->

Added explicit UTF-8 encoding to test-perf, to try to avoid:
```
Traceback (most recent call last):
  File "runner.py", line 371, in <module>
    main()
  File "runner.py", line 361, in main
    save_result_csv(results, args.output_file, testcases, args.runs, args.base)
  File "runner.py", line 287, in save_result_csv
    writer.writerows(results)
  File "/usr/lib/python3.4/csv.py", line 159, in writerows
    return self.writer.writerows(rows)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 101-107: ordinal not in range(128)
```
http://build.servo.org/builders/linux-nightly/builds/526/steps/test/logs/stdio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19440)
<!-- Reviewable:end -->
2017-11-30 13:46:15 -06:00
Alan Jeffrey
4ad801930a Added explicit UTF-8 encoding to test-perf. 2017-11-30 12:45:26 -06:00
bors-servo
ba0240a388 Auto merge of #19437 - servo:SimonSapin-patch-1, r=jdm
Remove 5 second pause in `./mach test-unit`

Details of why this pause happens in the first place are at https://github.com/servo/servo/issues/19439.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19437)
<!-- Reviewable:end -->
2017-11-30 12:15:45 -06:00
bors-servo
ec794c8297 Auto merge of #19438 - emilio:redundant-sharing, r=upsuper
style: Remove redundant style sharing check.

We check that a few lines before calling test_candidate.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19438)
<!-- Reviewable:end -->
2017-11-30 10:45:14 -06:00
Emilio Cobos Álvarez
0bcd36838d
style: Remove redundant style sharing check.
We check that a few lines before calling test_candidate.
2017-11-30 17:26:45 +01:00
Simon Sapin
0739b5d57a
Remove 5 second pause in ./mach test-unit
The pause is likely due to a Servo bug that I’m about to file, this does not fix the underlying bug.
2017-11-30 17:25:49 +01:00
ddh
79d896d474 queue event instead of immediately fire
created checks to see if parser is in use before event dispatch

changed tests to expect crash and added async style test
2017-11-30 16:18:57 +00:00
bors-servo
d85641bcbb Auto merge of #19433 - servo:bumps, r=emilio
Update openssl to 0.9.22

This removes foreign-types 0.2.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19433)
<!-- Reviewable:end -->
2017-11-30 09:33:20 -06:00
bors-servo
fce44a2e13 Auto merge of #19429 - upsuper:sharing-quirks-id, r=emilio
Don't try to share style on quirks mode whenever two elements have different id

This fixes [bug 1420946](https://bugzilla.mozilla.org/show_bug.cgi?id=1420946).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19429)
<!-- Reviewable:end -->
2017-11-30 08:23:07 -06:00
bors-servo
3b78cf1045 Auto merge of #19434 - emilio:moz-document, r=xidorn
style: Disable @-moz-document on author sheets on nightly and early beta.

Bug: 1035091
Reviewed-by: xidorn
MozReview-Commit-ID: AAUs1jJifjS

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19434)
<!-- Reviewable:end -->
2017-11-30 07:24:27 -06:00
Emilio Cobos Álvarez
1168305e93
style: Update bindings. 2017-11-30 14:23:49 +01:00
Emilio Cobos Álvarez
b45686f243
style: Disable @-moz-document on author sheets on nightly and early beta.
Bug: 1035091
Reviewed-by: xidorn
MozReview-Commit-ID: AAUs1jJifjS
2017-11-30 14:08:55 +01:00