Commit graph

31404 commits

Author SHA1 Message Date
bors-servo
2bbc458c5b Auto merge of #18751 - bholley:poison_hashtable, r=Manishearth
Poison hashtable buffers

This gives us extra defense in depth.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18751)
<!-- Reviewable:end -->
2017-10-04 23:54:56 -05:00
Xidorn Quan
23d9d12430 Only generate structs file for the current build 2017-10-05 15:29:32 +11:00
Xidorn Quan
44e0ce3ffe Don't do gecko_debug build in build-geckolib 2017-10-05 15:29:30 +11:00
Matt Brubeck
ae67eb5fe3 Use raw pointers instead of transmute for UnsafeFlow 2017-10-04 20:00:31 -07:00
bors-servo
43686a8738 Auto merge of #18734 - Manishearth:stylo-all, r=upsuper
stylo: `all` shorthand should not apply to internal properties

r=xidorn https://bugzilla.mozilla.org/show_bug.cgi?id=1404057

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18734)
<!-- Reviewable:end -->
2017-10-04 20:57:24 -05:00
Emilio Cobos Álvarez
6f836bed5a
style: Use the flattened tree parent to find the closest non-nac ancestor of an element.
This only matters for document level NAC like canvas custom content, in which
case otherwise we inherit from the document element (which is wrong).

Bug: 1405635
2017-10-05 01:07:05 +02:00
Bobby Holley
c866486b99 Poison hashtable buffers.
MozReview-Commit-ID: 8uLGtFv6X4P
2017-10-04 15:59:04 -07:00
Josh Matthews
bceaca9694 Fix up a test metadata classification. 2017-10-05 00:43:16 +02:00
Josh Matthews
da8677221e Avoid endless testrunner restart loops.
If the first test selected by a testrunner thread had a CRASH expectation,
the testrunner believed that it needed to restart and would never actually
get around to running the test.
2017-10-05 00:43:13 +02:00
Josh Matthews
c1c60beda1 Minimal changes to get WPT tests running on Windows. 2017-10-05 00:43:11 +02:00
Josh Matthews
2fb74cb9e9 Avoid testharness.js errors for assert_throws. 2017-10-05 00:43:09 +02:00
Josh Matthews
933b42ef46 Allow running wpt directories by path on the command line. 2017-10-05 00:43:07 +02:00
Josh Matthews
ca340eca39 Use upstream wptrunner from web-platform-tests. 2017-10-05 00:43:03 +02:00
Josh Matthews
d9baadd3df Use git's path stripping when upstreaming patches. 2017-10-05 00:42:22 +02:00
Josh Matthews
578498ba24 Update web-platform-tests to revision a46616a5b18e83587ddbbed756c7b96cbb4b015d 2017-10-05 00:42:13 +02:00
bors-servo
2268546515 Auto merge of #18735 - glennw:update-wr-angle-clips, r=mbrubeck
Update WR (clip masks on angle gradients, fix clips on transformed images).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18735)
<!-- Reviewable:end -->
2017-10-04 17:09:40 -05:00
Glenn Watson
bcd74053a8 Update WR (clip masks on angle gradients, fix clips on transformed images). 2017-10-05 08:00:03 +10:00
bors-servo
3f07cfec7c Auto merge of #18733 - bradwerth:nativeDPPX, r=heycam
Change resolution queries to compare in unconverted dppx units.

MozReview-Commit-ID: 7wYlixTQTIC

<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1376931
https://reviewboard.mozilla.org/r/182424/

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because the tests are in Gecko

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18733)
<!-- Reviewable:end -->
2017-10-04 15:31:17 -05:00
bors-servo
d8c7066464 Auto merge of #18724 - mrobinson:test-runner-count, r=jdm
Fix the test count in the WPT grouping_formatter

The internal WPT API seems to have changed again, so we must revert the
previous change here to get the correct test count.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because this is a change to the test harness runner script.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18724)
<!-- Reviewable:end -->
2017-10-04 13:54:47 -05:00
bors-servo
1a84dd594b Auto merge of #18719 - hiikezoe:use-normal-declaration-iterator, r=emilio
Use NormalDeclarationIterator for AnimationValueIterator

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18719)
<!-- Reviewable:end -->
2017-10-04 11:56:42 -05:00
bors-servo
b1c2d7195d Auto merge of #18702 - paulrouget:android_res_path, r=Manishearth
do not force resource_path on android

I want to be able to configure the resource path via `set_resources_path`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18702)
<!-- Reviewable:end -->
2017-10-04 10:34:52 -05:00
Emilio Cobos Álvarez
089d5eecb7
style: Reformat the substitute_block function. 2017-10-04 14:55:23 +02:00
Emilio Cobos Álvarez
c4dbbf0656
style: Use map_or instead of map(..) == Some(false). 2017-10-04 14:53:05 +02:00
Emilio Cobos Álvarez
583d89ac08
style: Use the OrderedMap iterator instead of doing our own thing. 2017-10-04 14:51:53 +02:00
Emilio Cobos Álvarez
f072c0bb05
style: Use the hashmap indexed getter in the custom props iterator code.
This will give a nicer error message, plus it's more compact.
2017-10-04 14:51:52 +02:00
Emilio Cobos Álvarez
08fd5ba8c1
style: Use Option<&mut> instead of &mut Option in custom_properties.rs 2017-10-04 14:51:51 +02:00
bors-servo
1f9182507f Auto merge of #18716 - jdm:parseSrcset, r=jdm
Parse srcset attribute values

Squashed version of #18313.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix (partially) #11416
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18716)
<!-- Reviewable:end -->
2017-10-04 07:32:53 -05:00
Bastien Orivel
511a4d65a2 Bump base64 to 0.6
This allows us to update hyper to 0.10.13 (closer to 0.11)
2017-10-04 13:26:12 +02:00
bors-servo
3b7a82b8c7 Auto merge of #18722 - heycam:family-list, r=upsuper
style: Use a SharedFontList object to store font-family values for Gecko

Reviewed by Xidorn and Manish in https://bugzilla.mozilla.org/show_bug.cgi?id=1397626.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18722)
<!-- Reviewable:end -->
2017-10-04 05:01:45 -05:00
Anthony Ramine
eb0c1a53ad Implement MediaError::Message
The spec says that it's ok to put an empty string in it if we don't have more
informations.
2017-10-04 11:41:41 +02:00
Anthony Ramine
b8c55e7da6 Set have_metadata for audio elements too
We don't store video-specific metadata anymore, and we don't ignore audio-specific
metadata anymore. We now just acknowledge that we received some metadata.
2017-10-04 11:28:47 +02:00
bors-servo
f044fa4e9f Auto merge of #18741 - servo:no-step, r=nox
Remove usage the unstable Step trait

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18741)
<!-- Reviewable:end -->
2017-10-04 03:12:33 -05:00
Simon Sapin
b77bdf1818 Remove usage the unstable Step trait 2017-10-04 10:10:04 +02:00
Cameron McCormack
fde77ee693 style: Regenerate Gecko bindings. 2017-10-04 13:38:07 +08:00
Cameron McCormack
4d9dd4b757 style: Use a SharedFontList object to store font-family values for Gecko. 2017-10-04 13:38:07 +08:00
bors-servo
c0f404999c Auto merge of #18736 - nnethercote:bug-1403506, r=erahm,mystor
Remove nsTFixedString<T>.

This is for https://bugzilla.mozilla.org/show_bug.cgi?id=1403506, which is r=erahm,mystor.

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1403506.

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they are tested in Gecko.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18736)
<!-- Reviewable:end -->
2017-10-03 23:21:18 -05:00
Paul Rouget
8f04b71f3b remove workaround 2017-10-04 05:34:06 +02:00
Nicholas Nethercote
365ae0b637 Remove nsTFixedString<T>.
nsTFixedString<T> is only used as a base class for nsTAutoStringN<T, N>, so
this patch merges the former into the latter, cutting some code and simplifying
the string class hierarchy.

Because the "Fixed" name is now gone, the patch also renames
StringDataFlags::FIXED as INLINE and ClassDataFlags::FIXED as INLINE.

The patch also removes nsFixed[C]String and ns_auto_[c]string! from Rust code
because nsAutoString can't be implemented directly in Rust due to its move
semantics. There were only two uses of ns_auto_string! outside of tests so this
seems like a minor loss.
2017-10-04 13:31:09 +11:00
bors-servo
a4f642185e Auto merge of #18728 - emilio:rayonup, r=jdm
style: Update rayon.

It has a couple soundness fixes.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18728)
<!-- Reviewable:end -->
2017-10-03 20:34:09 -05:00
Manish Goregaokar
aac31a35d7
stylo: all shorthand should not apply to internal properties 2017-10-03 18:01:57 -07:00
bors-servo
89724c6b32 Auto merge of #18712 - Manishearth:fnv, r=bholley
stylo: use FnvHashMap everywhere, remove default HashMap construction methods

r=bholley bug 1385971

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18712)
<!-- Reviewable:end -->
2017-10-03 18:47:46 -05:00
bors-servo
82cc22fab4 Auto merge of #18669 - glennw:update-wr-memory, r=jdm,emilio
Update WR (reduce GPU allocations for render targets)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18669)
<!-- Reviewable:end -->
2017-10-03 17:03:55 -05:00
Manish Goregaokar
8bce37e6ba stylo: use FnvHashMap everywhere, remove default HashMap construction methods 2017-10-03 14:10:31 -07:00
Brad Werth
b8e78d20bf Change resolution queries to compare in unconverted dppx units.
MozReview-Commit-ID: 7wYlixTQTIC
2017-10-03 13:56:14 -07:00
bors-servo
0b69887387 Auto merge of #18732 - bholley:revert_mprotect_diagnostics, r=bholley
Revert #18668 - Add mprotect diagnostics for HashMap crash (except for round-up-to-page behavior).

These diagnostics have served their purpose, time to remove them.

https://bugzilla.mozilla.org/show_bug.cgi?id=1403397

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18732)
<!-- Reviewable:end -->
2017-10-03 14:45:33 -05:00
Bobby Holley
15b866d8de Revert #18668 - Add mprotect diagnostics for HashMap crash 2017-10-03 12:44:26 -07:00
bors-servo
3dc4614991 Auto merge of #18696 - emilio:ua-sheets-reflow, r=jdm
layout_thread: Avoid adding the UA sheets multiple times when there's no root flow.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18696)
<!-- Reviewable:end -->
2017-10-03 12:46:53 -05:00
bors-servo
eff768679d Auto merge of #18414 - jdm:animdecl-codesize, r=SimonSapin
Reduce the size of AnimationValue code

According to bloaty, these commits shave off 25k from code in the animated_properties module.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18414)
<!-- Reviewable:end -->
2017-10-03 11:25:28 -05:00
bors-servo
e07c6f38a5 Auto merge of #18725 - mrobinson:tick-animation-display-list, r=jdm
TickAnimations should create a display list

This is a regression from the removal of ReflowQueryType.

Fixes #18701.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #18701  (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because this should fix tests currently failing on the build infrastructure, but the failures seem to be very timing dependent.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18725)
<!-- Reviewable:end -->
2017-10-03 10:21:23 -05:00
Emilio Cobos Álvarez
a08ab7bbec
style: Update rayon.
It has a couple soundness fixes.
2017-10-03 17:18:32 +02:00