David Zbarsky
b77698a649
Don't try to unwrap the result of requestAnimationFrame callback
2015-08-20 13:27:11 -04:00
bors-servo
0466766b2c
Auto merge of #7238 - Wafflespeanut:workerglobal, r=Ms2ger
...
Improved field names for devtools-related channels...
(for #6924 ) - I took this because the confusion was actually caused by me while working on #6829
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7238 )
<!-- Reviewable:end -->
2015-08-20 08:17:30 -06:00
Ravi Shankar
46195f29df
Improved field names for devtools-related channels; r=Ms2ger
2015-08-20 19:38:23 +05:30
Johann Tuffe
ec07178b6f
sort all uses
2015-08-20 20:47:12 +08:00
bors-servo
d3c7e31722
Auto merge of #7271 - Ms2ger:xhret, r=nox
...
Remove the unused XMLHttpRequestEventTarget::eventtarget method.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7271 )
<!-- Reviewable:end -->
2015-08-20 06:01:39 -06:00
bors-servo
15b09fc0af
Auto merge of #7272 - wilmoz:EventType, r=Ms2ger
...
Make EventTypeId reflect DOM inheritance hierarchy
https://github.com/servo/servo/issues/7205#issuecomment-132285499
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7272 )
<!-- Reviewable:end -->
2015-08-19 02:47:22 -06:00
bors-servo
70b9922eb0
Auto merge of #7260 - notriddle:issue_7169, r=Ms2ger
...
Navigate to a new page even when there's a fragment.
Closes #7169
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7260 )
<!-- Reviewable:end -->
2015-08-19 01:40:28 -06:00
Michael Howell
af31e8ed0f
Navigate to a new page even when there's a fragment.
...
Closes #7169
2015-08-18 17:35:09 -07:00
wilmoz
d3c60af5c6
Make EventTypeId reflect DOM inheritance hierarchy
2015-08-18 14:04:28 -05:00
Ms2ger
09dc9c44f3
Remove the unused XMLHttpRequestEventTarget::eventtarget method.
2015-08-18 21:01:10 +02:00
bors-servo
ef98e57429
Auto merge of #7230 - nox:required-dictionary-member, r=Ms2ger
...
Support required dictionary members (fixes #7216 )
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7230 )
<!-- Reviewable:end -->
2015-08-18 12:58:09 -06:00
bors-servo
50e1c967e4
Auto merge of #7224 - Manishearth:clippy, r=Ms2ger
...
Integrate clippy into Servo; cleanup some of script
The integration is off by default for now. You can try it out with `./mach build --features "script/plugins/clippy"`.
We're using a branch of clippy with some of the lints changed to Allow, either because they don't apply to us, or because they're noisy and dwarf other warnings (but still should be fixed)
After going through the rest of Servo's warnings I'll figure out which lints we should be keeping.
There's a cargo bug with optional deps that makes it hard for this to work with Cargo.lock -- so this PR contains no changes to lockfiles (and running the build with clippy on may dirty the lockfile, though it gets fixed later)
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7224 )
<!-- Reviewable:end -->
2015-08-18 08:15:51 -06:00
Manish Goregaokar
19241c95f7
Cleanup NodeIterator, Range, ServoHTMLParser, TextEncoder, URLHelper, URL, VirtualMethods
2015-08-18 19:37:42 +05:30
Manish Goregaokar
a53b86f107
Cleanup WebGLRenderingContext, Websocker, WorkerGlobalScope
2015-08-18 18:38:36 +05:30
Manish Goregaokar
5c4f91c0f1
Cleanup Window, XHR
2015-08-18 18:38:32 +05:30
Manish Goregaokar
ac1b7a3896
Cleanup textinput, timers
2015-08-18 18:37:12 +05:30
Manish Goregaokar
53e155e8ac
Cleanup treewalker
2015-08-18 18:37:10 +05:30
Manish Goregaokar
b21df4844c
Cleanup node.rs
2015-08-18 18:37:02 +05:30
Manish Goregaokar
94cd004c28
Cleanup script_task
2015-08-18 18:35:47 +05:30
bors-servo
ff6a70fad3
Auto merge of #7241 - Wafflespeanut:event_handler, r=Ms2ger
...
Matching over event listeners and handlers; r=Ms2ger
... for #7065
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7241 )
<!-- Reviewable:end -->
2015-08-18 06:49:26 -06:00
Ravi Shankar
f3db59972a
Matching over event listeners and handlers; r=Ms2ger
...
fixup! Matching over event listeners and handlers; r=Ms2ger
2015-08-18 18:11:57 +05:30
Ms2ger
a9671550ff
Update js.
2015-08-18 12:21:03 +02:00
bors-servo
0d6d6a0500
Auto merge of #7257 - jxs:master, r=Ms2ger
...
Replace uses of `for foo in bar.iter()`,
and `for foo in bar.iter_mut(), and for foo in bar.into_iter()
(continuation of #7197 )
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7257 )
<!-- Reviewable:end -->
2015-08-18 02:46:46 -06:00
bors-servo
f340900c38
Auto merge of #7246 - glennw:platform-ua, r=larsbergstrom
...
Add a simple method to emulate a platform UA (e.g. pretend a desktop build is an android UA).
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7246 )
<!-- Reviewable:end -->
2015-08-17 22:44:38 -06:00
Glenn Watson
6d9fccbae7
Add a simple method to emulate a platform UA (e.g. pretend a desktop build is an android UA).
2015-08-18 14:42:28 +10:00
João Oliveira
067a22a868
Replace uses of for foo in bar.iter()
,
...
and `for foo in bar.iter_mut(), and for foo in bar.into_iter()
(continuation of #7197 )
2015-08-18 01:46:11 +01:00
Nicholas Nethercote
97e3b24aa6
Fix panics in the script_task memory reporter.
...
These are caused by page_root being empty.
2015-08-17 04:37:43 -07:00
bors-servo
71ae18bae4
Auto merge of #7219 - vectorijk:issue#7042, r=Ms2ger
...
remove unused static collection type in htmlcollection.rs
ref #7042
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7219 )
<!-- Reviewable:end -->
2015-08-17 02:03:23 -06:00
wartman4404
8d665008f8
Remove the DOMRefCell wrapper around Window::compositor.
2015-08-16 17:28:21 -05:00
vectorijk
59d704b53f
turn enum into struct
...
pub enum CollectionTypeId -> pub struct Collection
2015-08-16 12:01:51 -07:00
vectorijk
d853aaba65
remove unused static collection
2015-08-16 11:38:22 -07:00
Josh Matthews
8bb853f643
Fix existing syntactics nits.
2015-08-16 10:30:43 -04:00
bors-servo
a2978f2add
Auto merge of #7236 - nox:dictionary-failure-code, r=Ms2ger
...
Fix dictionary member conversion failure (fixes #7231 )
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7236 )
<!-- Reviewable:end -->
2015-08-16 06:39:56 -06:00
Anthony Ramine
47e76ff4ab
Fix dictionary member conversion failure ( fixes #7231 )
2015-08-16 14:32:54 +02:00
Anthony Ramine
44aabbe64d
Support required dictionary members ( fixes #7216 )
2015-08-16 14:16:32 +02:00
Anthony Ramine
efe982392e
Update WebIDL parser
2015-08-16 14:16:31 +02:00
vectorijk
270df6bac8
without the explicit dereferencing
2015-08-16 01:34:58 -07:00
vectorijk
7758f81ffd
dereference via * instead of RefMut
2015-08-16 01:34:57 -07:00
vectorijk
14ac1ef75a
remove ScriptListener
...
ref #7175
2015-08-16 01:34:55 -07:00
bors-servo
7c63c7d7c1
Auto merge of #7214 - tomjakubowski:websocket-binaryType, r=Ms2ger
...
Implement WebSocket#binaryType
Closes #7098
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7214 )
<!-- Reviewable:end -->
2015-08-15 19:57:58 -06:00
Tom Jakubowski
e92f4629db
WebSocket: Implement WebSocket#binaryType
2015-08-15 12:44:22 -07:00
bors-servo
55e755e35a
Auto merge of #7233 - nox:default-float-value, r=Ms2ger
...
Support default values for restricted float members (fixes #7217 )
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7233 )
<!-- Reviewable:end -->
2015-08-15 10:59:44 -06:00
bors-servo
31413f4313
Auto merge of #7188 - servo:set_inline_style_property_priority, r=nox
...
Fix Element::set_inline_style_property_priority’s handling of priority
Thanks to @michaelwu for pointing out a copy-paste error.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7188 )
<!-- Reviewable:end -->
2015-08-15 09:17:31 -06:00
Anthony Ramine
ec2a6b24b1
Support default values for restricted float members ( fixes #7217 )
2015-08-15 14:45:26 +02:00
bors-servo
6a52ec9484
Auto merge of #7006 - Wafflespeanut:script_cleanup, r=jdm
...
Splitting ScriptMsg into various enums...
... for #3734 , which is also one of the oldest issues. (/cc @jdm)
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7006 )
<!-- Reviewable:end -->
2015-08-15 03:48:47 -06:00
João Oliveira
0038580abf
Replace uses of for foo in bar.iter()
and for foo in bar.iter_mut()
...
closes #7197
2015-08-15 02:27:39 +01:00
Ravi Shankar
89153116fb
Splitting ScriptMsg into various enums; r=jdm
2015-08-15 02:00:48 +05:30
João Oliveira
9c11781880
replace .len() == 0 with is_empty()
...
closes #7198
2015-08-14 04:00:33 +01:00
bors-servo
2e1ca10eea
Auto merge of #7199 - frewsxcv:codegen-if-let, r=Manishearth
...
Prefer if..let over if..is_some..unwrap in codegen
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7199 )
<!-- Reviewable:end -->
2015-08-13 15:35:21 -06:00
bors-servo
289decb064
Auto merge of #7196 - frewsxcv:double-unsafe, r=jdm
...
Avoid marking codegen method bodies as unsafe twice
`CGAbstractMethod` takes a couple boolean parameters, among others:
* `extern`: will mark the method as `unsafe` and `extern`
* `unsafe`: will wrap the method body in an `unsafe` block
Passing both as `True` should not mark it as `unsafe` twice.
Example from a generated `HTMLCollectionBinding.rs`:
Before:
```
unsafe extern fn get_length(..) -> u8 {
unsafe {
// code here
}
}
```
After
```
unsafe extern fn get_length(..) -> u8 {
// code here
}
```
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7196 )
<!-- Reviewable:end -->
2015-08-13 15:00:37 -06:00