Martin Robinson
b7d089930e
layout: Remove LayoutRPC and query layout via the Layout trait ( #31937 )
...
Instead of the tricky `LayoutRPC` interface, query layout using the
`Layout` trait. This means that now queries will requires calling layout
and then running the query. During layout an enum is used to indicate
what kind of layout is necessary.
This change also removes the mutex-locked `rw_data` from both layout
threads. It's no longer necessary since layout runs synchronously. The
one downside here is that for resolved style queries, we now have to
create two StyleContexts. One for layout and one for the query itself.
The creation of this context should not be very expensive though.
`LayoutRPC` used to be necessary because layout used to run
asynchronously from script, but that no longer happens. With this
change, it becomes possible to safely pass nodes to layout from script
-- a cleanup that can happen in a followup change.
2024-03-29 16:25:47 +00:00
Ekta Siwach
b0196ad373
clippy: Fix a variety of warnings in components/script/dom ( #31894 )
2024-03-29 14:43:10 +00:00
Oluwatobi Sofela
4a68243f65
clippy: Fix needless_lifetimes warnings ( #31933 )
2024-03-29 11:59:07 +00:00
Oluwatobi Sofela
a8976ff00a
clippy: Fix option_as_ref_deref warnings ( #31936 )
2024-03-29 11:52:45 +00:00
Oluwatobi Sofela
c3b6d40f90
clippy: Fix len_zero warnings ( #31935 )
2024-03-29 10:05:20 +00:00
Azhar Ismagulova
c4739675d8
clippy: Fix needless_borrow warnings in components/script ( #31928 )
2024-03-29 08:58:22 +00:00
Azhar Ismagulova
4d5bcdc057
fix: remove unused imports ( #31929 )
2024-03-28 23:20:20 +00:00
Ekta Siwach
7ce78f5a74
clippy: Fix some warnings in script/dom ( #31915 )
...
* fixed some clippy warnings
* resolved conflict
* updated texttracklist.rs
---------
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
2024-03-28 16:57:25 +00:00
Azhar Ismagulova
0728378424
clippy: remove unneeded return statements ( #31923 )
2024-03-28 16:17:47 +00:00
Oluwatobi Sofela
7349ce5b6a
clippy: Fix manual_map warnings ( #31922 )
2024-03-28 15:58:36 +00:00
Oluwatobi Sofela
66ad795014
clippy: Fix mem_replace_with_default warnings ( #31921 )
2024-03-28 13:10:37 +00:00
Rosemary Ajayi
7100465d1a
clippy: Fix various clippy warnings in components/scripts/dom/bindings ( #31901 )
...
* single-character string constant used as pattern
* singuse of with literal radix of 16
2024-03-28 11:49:36 +00:00
Rosemary Ajayi
18054d0737
clippy: Fix another set of clippy problems in components/script/dom ( #31909 )
...
* a reference to a reference
* length comparison to zero
* length comparison to zero
* length comparison to zero
2024-03-28 11:33:29 +00:00
Rosemary Ajayi
af358f51db
clippy: Fix another batch of clippy warnings in components/scripts ( #31912 )
...
* boolean can be simplified
* boolean can be simplified
* boolean can be simplified
2024-03-28 11:28:33 +00:00
Rosemary Ajayi
3ddb47e902
clippy: Fix more clippy warnings in components/scripts/dom ( #31914 )
...
* refrence to a reference
* refrence to a reference
2024-03-28 11:26:39 +00:00
Rosemary Ajayi
5aae820f6d
clippy: Fix a few clippy problems in components/scripts/dom ( #31905 )
...
* option_as_ref_deref
* fix
2024-03-28 11:24:39 +00:00
Ekta Siwach
1bc63801e7
fix redundant closures in component/script/dom ( #31917 )
...
* fixed unnecessary conversions
* resolved conflicts
* resolved conflicts
* fix redundant closures in component/script/dom
* resolved conflicts
* fixed formatting
2024-03-28 09:06:02 +00:00
Azhar Ismagulova
f183170786
clippy: Fix all errors in components/script ( #31911 )
...
* clippy: Fix errors in components/script/dom
* clippy: fixed remaining errors in components/script
2024-03-28 09:03:18 +00:00
Rosemary Ajayi
eccb60e548
deref on an immutable reference ( #31899 )
2024-03-28 08:57:56 +00:00
Rosemary Ajayi
072b892706
clippy:fix various clippy problems in components/scripts ( #31907 )
...
* manual implementation of an assign operation
* manual implementation of an assign operation
* single-character string
* manual cjheck for common ascii range
2024-03-27 22:14:41 +00:00
eri
1c8c287f01
WebIDL: Replace NonNull<JSObject> in xmlhttprequest ( #31880 )
...
* WebIDL: Replace `NonNull<JSObject>` in `xmlhttprequest.rs`
* doc: Update functions comments to docstring
* fix: Actually allocate `response_arraybuffer`
* fix: Change step descriptions
* fix: change step numbers
2024-03-27 20:28:51 +00:00
Azhar Ismagulova
ff95ce5abd
fix: omitted the let bindings ( #31908 )
2024-03-27 20:22:51 +00:00
Oluwatobi Sofela
da76ebabe9
clippy: Fix option_map_unit_fn warnings ( #31906 )
2024-03-27 18:43:56 +00:00
Rosemary Ajayi
a5bcae212a
clippy: Fix clippy problems in components/script/dom ( #31891 )
...
* deref on an immutable reference
* use of with literal radix of 10
* fix
2024-03-27 18:36:16 +00:00
Oluwatobi Sofela
da518823ff
clippy: Fix op_ref warnings ( #31900 )
2024-03-27 16:45:58 +00:00
Oluwatobi Sofela
773e881971
clippy: Fix unnecessary_lazy_evaluations warnings ( #31898 )
2024-03-27 16:16:48 +00:00
Rosemary Ajayi
bb7778774d
clippy:Fix clippy problems in components/scripts/binding ( #31893 )
...
* constants have by default a static lifetime
* constants have by default a static lifetime
* unneeded unit expression
* unneeded unit expression
* Box of default value
* casting raw pointers
* casting raw pointers
2024-03-27 12:32:04 +00:00
Aarya Khandelwal
1f31609952
clippy: Fix warnings in components/script/dom/request.rs ( #31867 )
2024-03-27 12:10:43 +00:00
Rosemary Ajayi
15cb9dd5fc
clippy: Fix various warnings in components/script/dom ( #31890 )
...
* redundant field names in struct initialization
* reduthis pattern creates a reference to a reference
2024-03-27 10:19:49 +00:00
Ekta Siwach
92b557867c
clippy: fixed some warnings in components/script ( #31888 )
2024-03-26 21:25:42 +00:00
Martin Robinson
8dece05980
fonts: Add support for WOFF2 and properly load web fonts from @imports ( #31879 )
...
This change also makes two fixes that are necessary to get WOFF2 fonts
working:
1. It adds support for loading web fonts from stylesheets included via
@import rules.
2. It ensure that when web fonts are loaded synchronusly they invalidate
the font cache. This led to incorrect font rendering when running
tests before.
Fixes #31598 .
2024-03-26 20:31:52 +00:00
Oluwatobi Sofela
b55d0a2053
clippy: Fix clone-on-copy warnings ( #31877 )
2024-03-26 19:55:20 +00:00
Frederik Reiter
5f7baf31c2
dom: Abort media element load on decode errors ( #31748 )
...
Signed-off-by: Frederik Reiter <hi@frereit.de>
2024-03-26 19:05:37 +00:00
Martin Robinson
bf3798bbde
layout: More conservatively replace Stylist's Device ( #31857 )
...
Instead of replacing Stylist's device on every reflow, only replace it
when the viewport changes. In addition, preserve the root font size from
the previous reflow fixing an issue where `rem` units were not properly
computed between reflows.
This fixes a bug where fonts that are sized using `rem` units change
size on reload.
2024-03-26 15:00:50 +00:00
Oluwatobi Sofela
b71de92569
clippy: Fix single_match warnings ( #31876 )
2024-03-26 14:01:10 +00:00
Ekta Siwach
188f3caff1
clippy: fix some warnings in components/script ( #31865 )
2024-03-26 10:31:22 +00:00
Oluwatobi Sofela
f8a2eaea47
clippy: Fix collapsible_else_if warnings ( #31853 )
2024-03-26 09:15:04 +00:00
Aarya Khandelwal
d814d05539
fixed the unneeded return statement warnings. ( #31863 )
2024-03-26 08:58:34 +00:00
Aarya Khandelwal
f7669b5238
fixes dereferencing on an immutable reference ( #31864 )
2024-03-26 08:37:44 +00:00
Oluwatobi Sofela
a53632c0e5
clippy: Fix collapsible_if warnings ( #31852 )
2024-03-25 13:55:45 +00:00
Rosemary Ajayi
3d10dbae32
clippy: Fix some clippy warnings in components/script ( #31843 )
...
* deref on an immutable reference
* fix deref on an immutable reference
* fix deref on an immutable reference
2024-03-25 12:57:35 +00:00
Bastiaan van der Plaat
97144ddf71
script: Add pre element obsolete width attribute support ( #31792 )
2024-03-25 11:36:48 +00:00
Aarya Khandelwal
bd39e03eeb
changed match to 'matches!' ( #31850 )
2024-03-25 11:28:12 +00:00
eri
9a76dd9325
clippy: Fix remaining warnings in generated code ( #31844 )
...
* clippy: fix warnings in generated code
* clippy: fix wrap_panic closure warnings
2024-03-25 11:12:36 +00:00
Ekta Siwach
d8adeb1b44
clippy: Fix some warnings in components/script ( #31849 )
...
* clippy: fixed some warnings in components/script
* fixed formatting
* fix formatting
2024-03-25 10:22:21 +00:00
eri
58081579e9
WebIDL: Remove JSObject from Document::NamedGetter ( #31841 )
...
* WebIDL: Remove `JSObject` from `Document::NamedGetter`
* fix: update rustdoc comment
2024-03-24 18:04:04 +00:00
Oluwatobi Sofela
1ab38fcd3f
clippy: Fix default_constructed_unit_structs warnings in components ( #31827 )
...
* clippy: Fix default constructed unit structs warnings
* refactor: Allow default constructed unit structs to avoid gfx build error
2024-03-24 17:24:34 +00:00
Rosemary Ajayi
0a771169b8
fix redundant closure ( #31842 )
2024-03-23 16:51:41 +00:00
Aarya Khandelwal
566fd475d9
Clippy: Fixed some clippy warnings ( #31818 )
...
* Fixed clippy warnings
* made changes for lowercase characters.
* changed is_lowercase() to is_ascii_lowercase()
* added std library function `is_ascii_uppercase()` and `is_ascii_lowercase()`
* made recommended changes
2024-03-23 12:48:49 +00:00
Oluwatobi Sofela
3c05b58221
clippy: Fix explicit_auto_deref warnings in components/script ( #31837 )
...
* clippy: Fix explicit auto-deref warnings
* clippy: Fix explicit auto-deref warnings
* refactor: Tidy up code
* refactor: Fix method not found errors
2024-03-23 11:29:20 +00:00
