Commit graph

20159 commits

Author SHA1 Message Date
Bobby Holley
ee890ecff2 Update binding blacklist to account for rename of nsProxyReleaseEvent to ProxyReleaseEvent. 2016-07-07 19:51:47 -07:00
bors-servo
9c00331634 Auto merge of #12313 - cynicaldevil:tidy-test, r=Wafflespeanut
test-tidy command now ignores files in subdirectories of ignored dirs

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12225 .

I did not add a test for this, instead I added a directory with an empty file inside the ignored directory, and checked whether this file was being ignored or not.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12313)
<!-- Reviewable:end -->
2016-07-07 19:16:31 -07:00
bors-servo
a8fd13bac3 Auto merge of #12309 - szeged:descriptor-functions, r=jdm
Add missing steps to descriptors writeValue function

<!-- Please describe your changes on the following line: -->
Add two missing steps to characteristic's writeValue function. https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattdescriptor-writevalue (Step 4 and 5)
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests, because there is no Web Bluetooth test API implementation yet.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12309)
<!-- Reviewable:end -->
2016-07-07 18:15:38 -07:00
bors-servo
0eed0e0b1e Auto merge of #12302 - Gozala:bhtml@0.1.15, r=ConnorGBrewster
Update browserhtml version to 0.1.15

Update browserhtml version to 0.1.15

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] ~~These changes fix #__ (github issue number if applicable).~~

<!-- Either: -->
- [ ] ~~There are tests for these changes OR~~
- [x] These changes do not require tests because it just updates dependency

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12302)
<!-- Reviewable:end -->
2016-07-07 17:20:02 -07:00
bors-servo
1f5c26a320 Auto merge of #12299 - jimberlage:fixup-scripts, r=emilio
Fix up shell scripts

<!-- Please describe your changes on the following line: -->
This brings these two scripts in line with the style guidelines.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it's a small change to bring some shell scripts in line with the style guide

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12299)
<!-- Reviewable:end -->
2016-07-07 16:24:52 -07:00
Emilio Cobos Álvarez
3a4539f043
style: stylistic nit. be consistent on how we write inline annotations. 2016-07-07 16:05:30 -07:00
Emilio Cobos Álvarez
8ba676533b
style: Fix timing-function overriding from the keyframe declaration list.
The previous behavior is plain wrong, since that array has always at least one
element, so we effectively couldn't specify anything else than "ease" in our
animations.
2016-07-07 16:05:28 -07:00
Emilio Cobos Álvarez
8bbebd0514
style: bonus: Fix parsing of steps() function.
Still doesn't work properly (this also happened with transitions).

This is spec'd in:
https://www.w3.org/TR/css3-transitions/#transition-timing-function
2016-07-07 16:05:26 -07:00
Emilio Cobos Álvarez
411ae84908
style: Add support to the animation shorthand and fix parsing of animation-name. 2016-07-07 16:05:22 -07:00
bors-servo
d0ab03bb29 Auto merge of #12294 - mbrubeck:always-be-updating, r=KiChjang
Update num_cpus, libc, openssl, threadpool, smallvec, string_cache, gleam, gl_generator, x11

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12294)
<!-- Reviewable:end -->
2016-07-07 15:22:13 -07:00
bors-servo
fdfde1c5eb Auto merge of #12292 - ConnorGBrewster:runnable_variant, r=KiChjang
Consolidate runnable variants on DOMManipulationTask into a single Runnable variant.

<!-- Please describe your changes on the following line: -->
Consolidates the runnable variants on `DOMManipulationTask` into a single `Runnable` variant.
Also combines `MainThreadRunnable` into the `Runnable` trait.

I plan on filing a few E-Easy issues after this lands to implement `name` on each of the structs that implement `Runnable`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because refactoring

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12292)
<!-- Reviewable:end -->
2016-07-07 14:26:44 -07:00
Malisa Smith
1a1d8daede added spaces around - sign 2016-07-07 13:29:58 -07:00
Malisa Smith
854cb5839f added comment to profiler get_statistics function 2016-07-07 13:19:45 -07:00
Jeena Lee
b7510bd89f Add test to assert that servo panics when the length of a given data is zero. 2016-07-07 13:14:35 -07:00
Malisa Smith
e1092b8b1d simplifying min and max calculation for profiler get_statistics function 2016-07-07 13:08:20 -07:00
Malisa Smith
7dccf09ff6 added test and assertion that profiler statistics data must be sorted 2016-07-07 12:59:16 -07:00
bors-servo
75cb4250b5 Auto merge of #12310 - nox:say-intermittent-again, r=Ms2ger
Disable change_parentage.html and transform-table-007.html

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12310)
<!-- Reviewable:end -->
2016-07-07 12:49:14 -07:00
bors-servo
b3c58f25ef Auto merge of #12291 - mbrubeck:font-panic, r=Wafflespeanut
Bail out gracefully on malformed kern table headers.

This changes a debug assert to a debug log and early return.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12081 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because I'm just removing an assertion

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12291)
<!-- Reviewable:end -->
2016-07-07 11:54:11 -07:00
Jeena Lee
d47b769cf7 Add test for Profiler::get_statistics, and remove empty space around Profiler::get_statistics.
Profiler::get_statistics calculates mean, median, min, and max for a given vector of data. This commit adds a test for the calculated statistics.
2016-07-07 11:00:56 -07:00
bors-servo
d7b3bfee35 Auto merge of #12324 - jdm:whee, r=larsberg
Port dd8ba1a071…

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12324)
<!-- Reviewable:end -->
2016-07-07 10:59:40 -07:00
Josh Matthews
fcffefcc46 Port dd8ba1a071 to avoid mac builder bustage. 2016-07-07 13:54:58 -04:00
Malisa Smith
6230911330 separate profiler statistics calculation to its own function 2016-07-07 10:18:10 -07:00
Owen Coutts
28399d0877 [tidy] Add test for existing json functionality 2016-07-07 17:07:03 +02:00
Ms2ger
b17ff481fe Add a test for interfaces exposed in web workers. 2016-07-07 16:20:43 +02:00
Nikhil Shagrithaya
6c6bfdb523 Added a subdirectory with a file to test whether tidy command ignores files in subdirectories 2016-07-07 15:08:41 +05:30
Nikhil Shagrithaya
be98fc4c59 tidy command now ignores files in subdirectories of ignored directories 2016-07-07 15:06:06 +05:30
Anthony Ramine
3f8bf30eac Disable change_parentage.html and transform-table-007.html 2016-07-07 10:31:12 +02:00
zakorgyula
2ab4511de8 Add missing steps to descriptors writeValue function 2016-07-07 10:07:15 +02:00
Connor Brewster
6c7e812966 Add unit test for setting selection with selection direction 2016-07-06 22:38:23 -06:00
bors-servo
4fafcb121f Auto merge of #12272 - Ms2ger:report, r=jdm
Reuse report_pending_exception in CallSetup.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12272)
<!-- Reviewable:end -->
2016-07-06 20:49:54 -07:00
bors-servo
32fa565baf Auto merge of #12289 - nox:slate, r=Ms2ger
Properly check storage size against QUOTA_SIZE_LIMIT (fixes #12247)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12289)
<!-- Reviewable:end -->
2016-07-06 18:52:05 -07:00
bors-servo
5dae3cc01b Auto merge of #12275 - emilio:prefs-rwlock, r=jdm
prefs: Make the preferences be guarded by a RwLock instead of a Mutex

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because internals.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

This should reduce unnecessary locks that happen when we read preferences.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12275)
<!-- Reviewable:end -->
2016-07-06 17:54:13 -07:00
gozala
1a5a05083e Update browserhtml version to 0.1.15 2016-07-06 16:06:09 -07:00
bors-servo
921f605c05 Auto merge of #12287 - nox:die-util-die, r=KiChjang
Remove util::breakpoint

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12287)
<!-- Reviewable:end -->
2016-07-06 15:49:18 -07:00
Connor Brewster
8e5d5a45ef Take selection direction into account when setting selection 2016-07-06 16:14:32 -06:00
Tshepang Lekhonkhobe
9283770e61 doc: small fixes to HACKING_QUICKSTART.md 2016-07-06 23:51:13 +02:00
Jim Berlage
bf92401283 Fix up shell scripts
This brings these two scripts in line with the style guidelines.
2016-07-06 16:34:36 -05:00
Matt Brubeck
10020761a3 Update num_cpus, libc, openssl, threadpool, smallvec, string_cache, gleam, gl_generator, x11 2016-07-06 11:43:35 -07:00
bors-servo
7da28b7ca6 Auto merge of #12261 - szeged:gattcharacteristicfunctions, r=jdm
Missing steps of Characteristic's readValue, writeValue functions

<!-- Please describe your changes on the following line: -->
Add a check for the read property of the characteristic as described in https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattcharacteristic-readvalue (Step 4.1)
Add two missing steps to characteristic's WriteValue function. https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattcharacteristic-writevalue (Step 4 and 5)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because, there are no Web Bluetooth test API implementation yet.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12261)
<!-- Reviewable:end -->
2016-07-06 11:11:26 -07:00
Connor Brewster
54cf3afe30 Add name method to Runnable trait 2016-07-06 11:23:56 -06:00
bors-servo
3679b0a328 Auto merge of #12208 - nox:fontloading, r=metajack
Continue loading font-face sources on missing local font

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12208)
<!-- Reviewable:end -->
2016-07-06 10:16:23 -07:00
Michael Howell
c11f85947e Correct negative margins in centered table cells
Fixes @AelitaBot queue viewer page
2016-07-06 10:02:33 -07:00
Connor Brewster
d6f4dc06df Combined DOMManipulationTask runnable variants into a single variant 2016-07-06 10:46:56 -06:00
Matt Brubeck
5582fcc219 Bail out gracefully on malformed kern table headers.
Fixes #12081.
2016-07-06 08:16:37 -07:00
bors-servo
beff8ee68f Auto merge of #12271 - mbrubeck:host_triple, r=emilio
Fix installation location for downloaded std packages

Fixes a "can't find crate for `std`" error in mach build. Regression from #11945. r? @larsbergstrom

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12271)
<!-- Reviewable:end -->
2016-07-06 07:31:08 -07:00
Anthony Ramine
e252793b1f Properly check storage size against QUOTA_SIZE_LIMIT (fixes #12247) 2016-07-06 14:01:25 +02:00
bors-servo
4aaae7a4e6 Auto merge of #12267 - Manishearth:nocrash-plist, r=metajack
Don't warn about reopening a crashed Servo window on Mac

Mac warns about reopening an application that crashed in the last run. With Servo this is
quite often the case, so we should get rid of the dialog.

Generated by running http://stackoverflow.com/a/20291771/1198729 on the plist file directly,
and then using plutil to convert back to xml. It got prettified in the process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12267)
<!-- Reviewable:end -->
2016-07-06 04:42:15 -07:00
Anthony Ramine
5f2d5ef748 Remove util::breakpoint 2016-07-06 12:20:47 +02:00
bors-servo
68fb9ebc41 Auto merge of #11950 - jdm:keylayout2, r=emilio
Support non-QWERTY keyboards

Using the ReceivedCharacter event from glutin, we can obtain the actual key characters that the user is pressing and releasing. This gets passed to the script thread along with the physical key data, since KeyboardEvent needs both pieces of information, where they get merged into a single logical key that gets processed by clients like TextInput without any special changes.

Tested by switching my macbook keyboard to dvorak and looking at the output of keypress/keyup/keydown event listeners, as well as playing with tests/html/textarea.html. Non-content keybindings like reload work as expected, too - the remapped keybinding triggers the reload action.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #4144
- [X] These changes do not require tests because I can't think of a way to test remapped keyboard input

Fixes  #11991.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11950)
<!-- Reviewable:end -->
2016-07-06 02:51:50 -07:00
bors-servo
23f5264e1c Auto merge of #12265 - servo:wpt-20160705, r=Ms2ger
Update web-platform-tests

@bors-servo: try

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12265)
<!-- Reviewable:end -->
2016-07-06 01:57:08 -07:00