Corey Farwell
8e3f4bba85
Reduce max line length from 150 to 120 characters
...
Part of https://github.com/servo/servo/issues/6041
2015-05-24 00:01:49 -04:00
bors-servo
fada39164c
Auto merge of #5858 - pgonda:tabindex-focus-flag, r=jdm
...
Added support for the tabindex field, also added its correct defaults (-2 TODOs for things not supported in Servo yet). Also added tabindex logic into Element::is_focusable_area.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5858 )
<!-- Reviewable:end -->
2015-05-20 14:34:31 -05:00
Patrick Walton
1a3395e077
script: Implement the width
and height
attributes for iframes per
...
HTML5 § 4.8.6.
Improves Amazon and Ars Technica.
2015-05-20 11:15:25 -07:00
Peter
1c96eed544
fixes #5603 , adds support for tabindex
2015-05-20 10:34:16 -04:00
Patrick Walton
7d9eda916b
script: Implement the color
attribute of the <font>
element.
...
Improves Hacker News.
2015-05-19 16:31:20 -07:00
Mukilan Thiyagarajan
3c56c58e38
Fix implementation of Element::get_root_element
2015-05-14 18:22:28 +05:30
Ms2ger
69f92596ca
Move table border to the new infrastructure.
2015-05-12 14:18:58 +02:00
Ms2ger
1b99fd7ecb
Implement get_attr_for_layout that returns an AttrValue.
2015-05-12 13:02:50 +02:00
Ms2ger
8b0505930f
Move textarea cols/rows to the new infrastructure.
2015-05-12 09:14:42 +02:00
Ms2ger
f571a69b2e
Move table/td width to the new infrastructure.
2015-05-12 09:14:40 +02:00
Ms2ger
0c8e55bff1
Move input size to the new infrastructure.
2015-05-11 23:43:58 +02:00
Ms2ger
83f4b077eb
Move table cellspacing to the new infrastructure.
2015-05-11 23:43:56 +02:00
Ms2ger
fa31d7d909
Replace TElement::get_link() by specific methods.
2015-05-11 10:52:58 +02:00
Ms2ger
34e35df986
Move get_attr and get_attrs into TElementAttributes.
...
These methods are only called on LayoutElement.
2015-05-10 18:26:06 +02:00
bors-servo
19744984da
Auto merge of #5923 - nox:limited-unsigned-long, r=jdm
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5923 )
<!-- Reviewable:end -->
2015-05-06 14:22:45 -05:00
Anthony Ramine
fedad2af1f
Improve support of limited unsigned long attributes
2015-05-06 20:18:08 +02:00
bors-servo
16a7c792b5
Auto merge of #5931 - nox:rm-helpers, r=jdm
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5931 )
<!-- Reviewable:end -->
2015-05-06 01:31:26 -05:00
Simon Sapin
ef8edd4e87
Upgrade to rustc 551a74dddd84cf01440ee84148ebd18bc68bd7c8.
2015-05-05 10:07:34 -04:00
Anthony Ramine
06436e9c79
Remove helpers that correspond to DOM methods
2015-05-04 15:18:27 +02:00
Ms2ger
a3adf6ab75
Stop using MemWriter in Element::serialize.
2015-05-01 21:21:50 +02:00
Ms2ger
903305416a
Implement Clone for Copy types.
2015-04-28 23:31:10 +02:00
bors-servo
b8ae33e510
Auto merge of #5871 - nox:rootable, r=jdm
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5871 )
<!-- Reviewable:end -->
2015-04-28 04:23:05 -05:00
bors-servo
1cb012fc50
Auto merge of #5857 - Ms2ger:preshints, r=pcwalton
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5857 )
<!-- Reviewable:end -->
2015-04-28 03:24:14 -05:00
Anthony Ramine
7197052c0d
Uniformise root() methods
...
They now live in traits Rootable, OptionalOptionalRootable, OptionalRootable
and ResultRootable.
2015-04-28 09:22:45 +02:00
Manish Goregaokar
369a568264
Make RootedVec/RootCollection #[no_move]; improve code ( fixes #5737 )
2015-04-28 04:35:58 +05:30
Manish Goregaokar
dcb0a0eab6
Fix some no_move errors
2015-04-28 04:20:45 +05:30
bors-servo
8ecb9d681c
Auto merge of #5692 - pgonda:get_attributes-memory-safety, r=jdm
...
Changes Element::get_attributes to use a `&mut Rooted<JS<Attr>>` param instead of returning a `Vec<Temporary<Attr>>`, fixes #5684 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5692 )
<!-- Reviewable:end -->
2015-04-27 15:25:30 -05:00
Ms2ger
9435565f85
Pass an Atom to Element::create.
2015-04-27 12:31:37 -07:00
Ms2ger
e8b02acb1d
Pass Atom to Attr:new for the prefix argument.
2015-04-27 12:20:23 -07:00
Peter
a270f3e39b
Switched Element::Get_attributes to use a RootedVec instead of returning a Vec<Temporary>, fixes #5684
2015-04-27 10:04:54 -04:00
Anthony Ramine
afafde5191
Change MutNullableJS<T> to MutNullableHeap<JS<T>>
2015-04-27 10:45:38 +02:00
Ms2ger
e3440c8a59
Move bgcolor over to the new infrastructure.
...
Note that I call is_htmltabledatacellelement in
synthesize_presentational_hints_for_legacy_attributes, rather than
is_htmltablecellelement (which was used in
get_simple_color_attribute_for_layout), because that function was never called
for th elements.
2015-04-26 22:25:11 +02:00
Anthony Ramine
4e7b9d319c
Remove useless unsafe methods on LayoutJS<T>
2015-04-26 21:39:11 +02:00
Ms2ger
582ee1c2b3
Create a new infrastructure for presentational hints.
2015-04-26 21:25:06 +02:00
Ms2ger
852d973a70
Sort imports in element.rs.
2015-04-26 19:28:09 +02:00
Ms2ger
a862479ca8
Remove as_slice() calls from script.
2015-04-26 10:52:55 +02:00
Ms2ger
41cc0a939e
Replace the Str implementation for AttrValue by a Deref implementation.
2015-04-25 15:24:27 +02:00
Ms2ger
4108af0c11
Introduce AttrValue::atom().
2015-04-25 15:13:03 +02:00
bors-servo
a3dafe4999
Auto merge of #5594 - mskrzypkows:get_attribute_by_name, r=Ms2ger
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5594 )
<!-- Reviewable:end -->
2015-04-21 10:23:03 -05:00
Maciej Skrzypkowski
6a31a75bc6
Refactoring, added conversion to lowercase for get_attribute_by_name method. ( fixes #5561 )
2015-04-21 16:08:15 +02:00
Ms2ger
0042f78aa7
Use get_attr_for_layout in get_classes_for_layout.
...
This fixes a bug with elements with multiple class attributes. In this case,
the class attribute in the null namespace would only be considered if it was
the first class attribute in the list.
2015-04-18 17:51:03 +02:00
Ms2ger
bdb8657cf6
Use get_attr_for_layout in ghas_class_for_layout.
...
This fixes a panic if this code was ever called on an element with a class
attribute in a non-null namespace. In this case, the attribute would not have
been parsed into a list of tokens, so value_tokens_forever() would have
returned None.
However, this function is, as far as I can tell, never called, because of the
way selectors are evaluated in layout. ('Return the selectors that match this
node' rather than 'return the nodes that match this selector'; the latter
uses only each_class.)
2015-04-18 16:56:54 +02:00
Ms2ger
39e3ace817
Use get_attr_for_layout in get_attr_atom_for_layout.
...
The code is equivalent.
2015-04-18 16:53:05 +02:00
Ms2ger
d67d6bfa3a
Give get_attr_for_layout a more useful signature.
2015-04-18 16:51:57 +02:00
bors-servo
4fd4370a96
Auto merge of #5721 - nox:nodeorstring, r=jdm
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5721 )
<!-- Reviewable:end -->
2015-04-16 14:47:32 -05:00
Anthony Ramine
45e1b9628e
Finish implementation of ChildNode and ParentNode
2015-04-16 20:31:34 +02:00
Md. Enzam Hossain
4c5bebeb10
Implement node::LookupPrefix and add test.
...
Tracking issue #1826 .
2015-04-16 11:38:07 +01:00
Corey Farwell
cc4a64e1fe
Add/update comments with links to spec
...
Extracted out of #5649
* add more hyperlinks to associated specification for structs/methods
* follow redirects and update links
* replace broken links
* removal of WHATWG multipage page name since the page name is not
guaranteed to be stable
2015-04-14 18:03:13 -04:00
Ms2ger
49393a8762
Update some URLs.
...
The HTML spec's division into pages is not stable, so it is safer to use the
URL without a specific page (which will redirect).
2015-04-14 10:44:51 +02:00
bors-servo
4997d3a112
Auto merge of #5677 - frewsxcv:https, r=Ms2ger
...
Extracted this out of #5649
This commit was created with the following commands:
```
find . -iname "*.webidl" -type f -print0 | xargs -0 sed -i '' 's/http:\(.*\)whatwg.org/https:\1whatwg.org/g'
```
```
find . -iname "*.rs" -type f -print0 | xargs -0 sed -i '' 's/http:\(.*\)whatwg.org/https:\1whatwg.org/g'
```
2015-04-14 02:57:41 -05:00