Commit graph

21881 commits

Author SHA1 Message Date
bors-servo
d9323121b6 Auto merge of #11470 - servo:postmessage1.5, r=Ms2ger
Make script origins sendable and immutable.

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because no behaviour change

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11470)
<!-- Reviewable:end -->
2016-05-27 13:06:37 -05:00
Josh Matthews
3cb8af20c2 Remove empty lines following braces. 2016-05-27 13:32:05 -04:00
Josh Matthews
4ebc065cba Warn about empty lines following an open brace. 2016-05-27 13:30:51 -04:00
bors-servo
3052e4f478 Auto merge of #11465 - nox:open, r=jdm
Implement window.openURLInDefaultBrowser() (fixes #11292)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11465)
<!-- Reviewable:end -->
2016-05-27 12:03:56 -05:00
bors-servo
c9534dffc8 Auto merge of #11437 - Ms2ger:pipeline-creation, r=asajeffrey
Simplify and improve Pipeline creation.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because refactoring

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11437)
<!-- Reviewable:end -->
2016-05-27 11:14:19 -05:00
Ms2ger
28b5cd1c8d Split up Constellation::handle_requests.
The function is too long to easily work with.
2016-05-27 17:49:31 +02:00
bors-servo
d160f8cb80 Auto merge of #11463 - Ms2ger:LayoutChan, r=nox
Remove the LayoutChan type.

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because refactoring

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

It is a pointless abstraction.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11463)
<!-- Reviewable:end -->
2016-05-27 10:26:23 -05:00
Josh Matthews
555661ef1c Make script origins sendable and immutable. 2016-05-27 17:16:13 +02:00
Anthony Ramine
056bdc5514 Implement window.openURLInDefaultBrowser() (fixes #11292) 2016-05-27 16:16:02 +02:00
Anthony Ramine
8003687deb Properly hide BrowserElementPrivileged members 2016-05-27 16:16:01 +02:00
bors-servo
3ab5c07559 Auto merge of #11462 - Manishearth:devtools-fixes, r=Ms2ger
devtools: fix segfault, remove println

This fixes the segfault from #11457 by adding an autocompartment.

It also removes the print statements which clog the command line and replaces
them with `debug!()`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11457 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because we don't have full-server
  devtools tests

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11462)
<!-- Reviewable:end -->
2016-05-27 08:49:43 -05:00
Ms2ger
e94f3d4fe0 Remove the LayoutChan type.
It is a pointless abstraction.
2016-05-27 15:33:04 +02:00
bors-servo
922aef9dd6 Auto merge of #11460 - servo:expectations, r=nox
Simplify platform-specific test expectations.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11460)
<!-- Reviewable:end -->
2016-05-27 08:00:34 -05:00
Anthony Ramine
3cc7b575fb Initialise reflector earlier for globals
This allows us to use global_root_from_object in the context of a Condition.
2016-05-27 14:11:34 +02:00
bors-servo
2f9796fa69 Auto merge of #11329 - c-rhodes:11320, r=jdm
Report use statements that use {} with only one entry

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [X ] `./mach build -d` does not report any errors
- [X ] `./mach test-tidy --faster` does not report any errors
- [X ] These changes fix #11320  (github issue number if applicable).

Either:
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11329)
<!-- Reviewable:end -->
2016-05-27 07:11:17 -05:00
Ms2ger
5d0bbe87a7 Remove unused UnprivilegedPipelineContent::paint_shutdown_chan. 2016-05-27 13:41:02 +02:00
Ms2ger
43bf035f6c Avoid some clones in UnprivilegedPipelineContent::start_all. 2016-05-27 13:38:56 +02:00
bors-servo
fb8934a138 Auto merge of #11449 - djc:rm-get-html-element, r=nox
Remove Document.get_html_element() (fixes #8409)

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #8409 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because small refactor

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Replace uses by calling self.GetDocumentElement(), instead.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11449)
<!-- Reviewable:end -->
2016-05-27 06:21:36 -05:00
bors-servo
d890453f78 Auto merge of #11434 - catchmrbharath:status, r=nox
WIP: Fixes #11407: Implement Window.status

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #11407 (github issue number if applicable).

Either:
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11434)
<!-- Reviewable:end -->
2016-05-27 05:33:14 -05:00
Dirkjan Ochtman
51e2802047 Remove side-effecting map call per review comments 2016-05-27 11:47:32 +02:00
bors-servo
073c5e3b6b Auto merge of #11308 - nox:guarded, r=jdm
Implement [Func]

First part of #11292, this just includes support of `[Func]`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11308)
<!-- Reviewable:end -->
2016-05-27 04:45:06 -05:00
Manish Goregaokar
283fc8dd25
Use JSautoCompartment in devtools handle_evaluate_js to avoid segfault
fixes #11457
2016-05-27 15:12:27 +05:30
Manish Goregaokar
48257ef282
Use debug instead of println in devtools 2016-05-27 15:09:26 +05:30
Dirkjan Ochtman
a79f00c337 Use GetDocumentElement() in Document::invalidate_stylesheets() (fixes #8409) 2016-05-27 11:29:09 +02:00
Bharath M R
a4d9a1d6a1 Fixes #11407: Implement Window.status 2016-05-27 02:28:36 -07:00
Cullen Rhodes
40acd24e8f Report use statements that use {} with only one entry 2016-05-27 10:18:44 +01:00
bors-servo
f2f2987e74 Auto merge of #11458 - kevgs:log2, r=Manishearth
add log2(u32) and use it to prevent casting to and from float to int

<!-- Please describe your changes on the following line: -->
PR for #11440
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11458)
<!-- Reviewable:end -->
2016-05-27 03:56:51 -05:00
Ms2ger
bd5ff90c38 Simplify platform-specific test expectations. 2016-05-27 09:55:32 +02:00
Ms2ger
948b69f503 Move the Pipeline creation to the end of Pipeline::spawn(). 2016-05-27 09:26:57 +02:00
Ms2ger
f6ae542c15 Avoid some unnecessary runtime checks. 2016-05-27 09:26:57 +02:00
Ms2ger
c943c745a9 Improve code flow in Pipeline::spawn(). 2016-05-27 09:26:56 +02:00
Ms2ger
e6546a54e8 Avoid some unnecessary work if we're not spawning content. 2016-05-27 09:26:19 +02:00
Ms2ger
9e0aa09984 Remove PrivilegedPipelineContent. 2016-05-27 09:23:19 +02:00
Ms2ger
88a36e6947 Inline Pipeline::create() into Pipeline::spawn(). 2016-05-27 09:23:18 +02:00
Ms2ger
739e091e8b Introduce Pipeline::spawn(). 2016-05-27 09:23:17 +02:00
Ms2ger
82832f134b Move spawn_multiprocess into UnprivilegedPipelineContent. 2016-05-27 09:23:17 +02:00
Ms2ger
cc83cb8b09 Privatize Pipeline::new(). 2016-05-27 09:23:14 +02:00
Kosov Eugene
94ad5aef62 add log2(u32) and use it to prevent casting to and from float to int 2016-05-27 10:15:37 +03:00
bors-servo
4dcb05ca4f Auto merge of #11423 - servo:jdm-patch-2, r=mbrubeck
Update spec link for timers.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy --faster` does not report any errors
- [X] These changes do not require tests because documentation only

---
The specification link was broken.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11423)
<!-- Reviewable:end -->
2016-05-26 23:26:09 -05:00
bors-servo
86e583fbed Auto merge of #11408 - Ms2ger:layoutthread-url, r=Manishearth
Take LayoutThread::url out of its RefCell.

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy --faster` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because refactoring

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11408)
<!-- Reviewable:end -->
2016-05-26 22:37:23 -05:00
bors-servo
1efacd3938 Auto merge of #11406 - aneeshusa:add-missing-build-apk-semicolon, r=mbrubeck
Fix Android APK building (packaging)

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy --faster` does not report any errors
- [ ] These changes help with #10339.

Either:
- [x] There are tests for these changes (android-nightly builder) OR
- [ ] These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

I missed this syntax error during my review, and we don't check that
packaging succeeds in regular build suite, but only as a Nightly build.

@larsbergstrom should we run the packaging as part of the regular build? I think it is important that this continue to stay working, especially with #9918. In that case, the only difference with the nightly builder is whether or not to upload to S3.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11406)
<!-- Reviewable:end -->
2016-05-26 21:48:17 -05:00
bors-servo
126a197df8 Auto merge of #11455 - ConnorGBrewster:fix_warning, r=emilio
Remove unused import

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] These changes do not require tests because removing unused import

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11455)
<!-- Reviewable:end -->
2016-05-26 20:56:14 -05:00
bors-servo
a01d44ea23 Auto merge of #11436 - nox:s-osx-mac, r=jgraham
Fix all the Mac-specific test expectations

It's "mac", not "osx".

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11436)
<!-- Reviewable:end -->
2016-05-26 19:10:12 -05:00
bors-servo
c432e9ac54 Auto merge of #11429 - nox:unlimited-referrer-works, r=jdm
Partially enable referrer-policy tests with some modifications

This is a part of @rebstar6's work on #11422, with only her test fixes and the enabling of them, to ease review on the actual implementation.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11429)
<!-- Reviewable:end -->
2016-05-26 18:21:04 -05:00
Connor Brewster
4bb2edd0f1 Remove unused import 2016-05-26 17:03:25 -06:00
Anthony Ramine
694deabcd5 Use [Func] on HTMLIFrameElement.mozbrowser 2016-05-27 00:55:05 +02:00
Anthony Ramine
34dfc28e98 Move mozbrowser_enabled to util::prefs 2016-05-27 00:55:04 +02:00
Anthony Ramine
34858fd0c9 Clean up the functions to retrieve a global root from JS objects 2016-05-27 00:55:03 +02:00
Anthony Ramine
e179cb02ff Implement [Func] 2016-05-27 00:55:02 +02:00
bors-servo
25c2d20f56 Auto merge of #11433 - heycam:dummy-base-url, r=bholley
Don't re-parse dummy base URL every time in GeckoElement::style_attribute

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because geckolib-only

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

----

r? @bholley

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11433)
<!-- Reviewable:end -->
2016-05-26 17:18:26 -05:00