Josh Matthews
d385cb701b
Reject websocket protocol requests that don't match https://tools.ietf.org/html/rfc6455#section-4.1 .
2015-07-22 09:35:07 -04:00
bors-servo
8a6681ba70
Auto merge of #6688 - Manishearth:smarter-root-lint, r=jdm
...
Handle type parameters in unused_must_root
fixes #6651
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6688 )
<!-- Reviewable:end -->
2015-07-22 07:05:31 -06:00
Manish Goregaokar
a9f651cfa1
Address review comments; add docs
2015-07-22 18:34:54 +05:30
Corey Farwell
b1b03a32db
Upgrade rust-selectors, pass ':empty' tests
...
https://github.com/servo/rust-selectors/pull/36
2015-07-22 18:27:33 +07:00
Manish Goregaokar
521d8bc32e
Make enum/fn part of unrooted_must_root handle type parameters
2015-07-22 10:44:26 +05:30
Sam Gibson
118122da38
Uses the approach suggested by @SimonSapin for changing Url scheme
...
servo/rust-url#61
2015-07-22 11:49:10 +12:00
Sam Gibson
5014da42fc
Only secure URL's that aren't already to HTTPS.
...
Cuts down on logger spam, and unnecessary Url::clone's
2015-07-22 11:49:09 +12:00
Sam Gibson
bae979137a
Moves HSTS includeSubdomains enum to net_traits
2015-07-22 11:49:09 +12:00
Sam Gibson
82cafc4274
Passes an Arc<Mutex<HSTSList>> to threads instead of cloning
2015-07-22 11:49:09 +12:00
Sam Gibson
11f5be6d85
Responds to more code review feedback
...
* Use regex from resource task
* Don't have an option of an HSTS list, default to empty
2015-07-22 11:49:08 +12:00
Sam Gibson
f2148f06b1
Moves the HSTS replacement code to http_loader
...
This respects STS for redirects as well.
2015-07-22 11:49:08 +12:00
Sam Gibson
826f56bdf3
Moves HSTS code to it's own module
2015-07-22 11:49:07 +12:00
Sam Gibson
02bd5cdc1b
Resolves remaining code review issues
...
* Don't pass a boolean to the HSTSEntry constructor, use an enum instead
* Don't clone when securing load data
* Comment about the Url bug
* Change remaining assert!(... == ...) to assert_eq!(..., ...)
2015-07-22 11:49:07 +12:00
Sam Gibson
29a34dbdb5
Resolves code review comments
...
* Lots of rust-isms
* Mutable iterator for modifying entries (much better)
2015-07-22 11:49:06 +12:00
Sam Gibson
a068a80619
Don't unnecessarily clone strings
2015-07-22 11:49:06 +12:00
Sam Gibson
8a401d5a7f
Re-parse URL to not have inconsistent state
2015-07-22 11:49:05 +12:00
Sam Gibson
795454fb81
Adds control message for HSTS headers
2015-07-22 11:49:04 +12:00
Sam Gibson
f284181781
Abstract out ResourceManager messaging from impl
...
De-coupling makes testing a bit easier.
2015-07-22 11:49:04 +12:00
Sam Gibson
ff1777e446
Evict HSTS entries when a max-age of 0 is seen
2015-07-22 11:49:03 +12:00
Sam Gibson
690ac636eb
Rename/refactor
2015-07-22 11:49:03 +12:00
Sam Gibson
15c90a58b2
Expire HSTS entries that have exceeded their max-age
...
servo/servo#6105
2015-07-22 11:49:03 +12:00
Sam Gibson
8d39fb6dcf
Shift checking for IP address host for HSTS entry to constructor
...
servo/servo#6105
2015-07-22 11:48:05 +12:00
Sam Gibson
cb9b0c2a7a
Add max-age to HSTS entries
...
Refactors API for pushing new entries on, and adds a max age. This does
not add a check for the max-age, or remove old entries from the list.
Instead this just adds the data-field.
servo/servo#6105
2015-07-22 11:48:05 +12:00
Sam Gibson
72d4433587
Do not allow IP address in HSTS list
...
As per [rfc6797](https://tools.ietf.org/html/rfc6797#section-8.1.1 ), do
not allow IPv4 or IPv6 addresses as host entries into the HSTS list.
servo/servo#6105
2015-07-22 11:48:04 +12:00
Sam Gibson
d2f35555b9
Implement mutable HSTS list
...
This prepares the resource task to update the HSTS list when it sees STS
headers. This will allow full HSTS support for servo/servo#6105 when the
resource task implements the header checking
2015-07-22 11:48:03 +12:00
Sam Gibson
aa19a9a741
Preload an HSTS domain list from chromium
...
This resolves the first part of servo/servo#6105 . The remaining part is
to update the list based on the STS headers from the server.
2015-07-22 11:48:03 +12:00
Michael Howell
91c61ae751
Tidy finds WebIDLs with no spec.
...
Closes #6689
2015-07-21 15:36:33 -07:00
Glenn Watson
2e074ce452
Implement mouseevent.which (needed for enyojs sampler).
2015-07-22 08:20:06 +10:00
Glenn Watson
2a2c7e18c0
Set detail field to be 1 by default for mouse events.
...
The spec says this should be "A count of consecutive clicks that happened in a short amount of time, incremented by one."
This change matches the typical behaviour in FF.
2015-07-22 08:17:57 +10:00
Ms2ger
94e1d4d34c
Don't call mutate_layout_data in get_{before,after}_pseudo.
...
We don't mutate anything.
2015-07-21 22:58:16 +02:00
Till Schneidereit
126938a963
Address review comments
2015-07-21 22:56:26 +02:00
Ms2ger
093204a224
Replace get_{before,after}_display by get_{before,after}_pseudo.
2015-07-21 22:27:40 +02:00
Ms2ger
2e6a723970
Merge has_{before,after}_pseudo into get_{before,after}_display.
2015-07-21 22:27:38 +02:00
Ms2ger
cc356e58ae
Remove unused ThreadSafeLayoutNode::get_normal_display.
2015-07-21 22:27:36 +02:00
bors-servo
b1c4862119
Auto merge of #6657 - Ms2ger:ThreadSafeLayoutNodeChildrenIterator, r=pcwalton
...
Cleanup ThreadSafeLayoutNodeChildrenIterator.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6657 )
<!-- Reviewable:end -->
2015-07-21 13:38:33 -06:00
Manish Goregaokar
fda3eb6327
Make struct part of unrooted_must_root handle type parameters
2015-07-22 00:01:26 +05:30
Manish Goregaokar
511e3337fb
Fix rooting in script
2015-07-22 00:00:15 +05:30
Manish Goregaokar
f6f0a7e4aa
Make stmt part of unrooted_must_root handle type parameters ( fixes #6651 )
2015-07-22 00:00:14 +05:30
Ms2ger
930e111713
Scope ThreadSafeLayoutNode::first_child to ThreadSafeLayoutNodeChildrenIterator::new.
...
It is only used there.
2015-07-21 19:53:34 +02:00
Ms2ger
b3892b74f7
Simplify ThreadSafeLayoutNodeChildrenIterator::next().
2015-07-21 19:53:23 +02:00
bors-servo
a9f12da4f8
Auto merge of #6592 - frewsxcv:notimplementederror, r=Ms2ger
...
Use NotImplementedError for Python base class methods
From the Python docs:
https://docs.python.org/2/library/exceptions.html#exceptions.NotImplementedError
"In user defined base classes, abstract methods should raise this
exception when they require derived classes to override the method."
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6592 )
<!-- Reviewable:end -->
2015-07-21 11:28:21 -06:00
Josh Matthews
fecb2e3960
Make the global options more resilient to unit tests running in parallel.
2015-07-21 09:14:06 -04:00
bors-servo
cb52cc6658
Auto merge of #6608 - nnethercote:tweak-reporter-registration, r=glennw
...
Register/unregister memory reporters in a better place.
By doing this on either side of the call to the relevant tasks' start()
method, we don't need to store the mem::ProfilerChan or the reporter
name in the task itself.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6608 )
<!-- Reviewable:end -->
2015-07-20 21:43:09 -06:00
bors-servo
faa180c972
Auto merge of #6678 - glennw:gleam0.1.4, r=pcwalton
...
Update to gleam 0.1.4
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6678 )
<!-- Reviewable:end -->
2015-07-20 18:27:06 -06:00
Nicholas Nethercote
f6525b8009
Register/unregister memory reporters in a better place.
...
By doing this on either side of the call to the relevant tasks' start()
method, we don't need to store the mem::ProfilerChan or the reporter
name in the task itself.
2015-07-20 16:19:51 -07:00
bors-servo
5ac80bff8e
Auto merge of #6666 - glennw:exit-flag, r=larsbergstrom
...
Restore exit after load command line flag.
Also updates glutin with a crash fix that was exposed by this patch.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6666 )
<!-- Reviewable:end -->
2015-07-20 15:37:33 -06:00
Glenn Watson
12a2573e51
Update to gleam 0.1.4
2015-07-21 07:22:46 +10:00
bors-servo
58e9bc6583
Auto merge of #6648 - boghison:tidytoml, r=jdm
...
Make tidy check for "*" in toml files
This checks every .toml file for an asterisk and prints an error if found.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6648 )
<!-- Reviewable:end -->
2015-07-20 14:43:05 -06:00
Bogdan Cuza
0baa6b477c
Replace astersisks with appropriate versions in deps
2015-07-20 20:08:08 +03:00
Tetsuharu OHZEKI
eb47185d58
Implement Window.trap() to trigger a breakpoint trap
2015-07-21 00:53:17 +09:00