Commit graph

1113 commits

Author SHA1 Message Date
Ms2ger
64b0a6b0b4 Reuse the final_url in ScriptTask::load.
In both the javascript and non-javascript url cases, final_url is set to the
same url as is stored by the Page.
2014-12-09 15:14:59 +01:00
Ms2ger
795327d5c4 Pass a borrowed Url to parse_html.
It does not need to take ownership, and I want to reuse final_url in the
caller.
2014-12-09 15:12:01 +01:00
Ms2ger
8838f2460e Rename base_url to final_url in ScriptTask::load.
This seems like a clearer name, as it's used for more than just as a base url.
2014-12-09 15:05:50 +01:00
Emanuel Rylke
8ed6ace682 Don't include the root element when calling Element#getElementsByTagName
Fixes #4249
2014-12-09 13:41:14 +01:00
bors-servo
02955d39cc auto merge of #4293 : Ms2ger/servo/script_task, r=Manishearth 2014-12-09 04:57:56 -07:00
Chris Manchester
d25bc49772 Return early and decline analysis when linting within unsafe functions for must_root analysis.
Removes a handful of whitelist annotations obsoleted by this change. fixes #3658
2014-12-09 02:10:39 -05:00
bors-servo
7d4ec33375 auto merge of #4298 : Manishearth/servo/zirak-link-attrs, r=Manishearth
Carried over from #4248

Critic review: https://critic.hoppipolla.co.uk/r/3392
2014-12-08 23:30:59 -07:00
Zirak
a586e05e83 Bound several link properties.
Specifically: href, rel, media, hreflang and type.
2014-12-09 11:38:51 +05:30
Manish Goregaokar
f221cb5178 Restrict size tests to 64 bit 2014-12-09 11:27:02 +05:30
Manish Goregaokar
16ffd543dd Add unit test to freeze sizes of DOM structs 2014-12-09 11:26:58 +05:30
Ms2ger
0fc65d4088 Remove the url from the InputUrl variant.
This url is the pre-redirect url, which is not particularly meaningful, and it
is used only in a panic message.
2014-12-09 01:07:16 +01:00
Ms2ger
e76c3386ce Move the load response into the HTMLInput enum.
It is None iff the parser input is an InputString variant, so it makes more
sense to pass it in the same enum.
2014-12-09 00:53:33 +01:00
Ms2ger
fbedf030d4 Combine two conditionals in ScriptTask::load.
Now that the code lives in the same function, I see no reason for them to
remain separate.
2014-12-09 00:53:33 +01:00
bors-servo
b64bb47e9d auto merge of #4284 : ema-fox/servo/textinput_selection, r=jdm 2014-12-08 14:25:07 -07:00
bors-servo
368d6dc6bf auto merge of #4280 : Ms2ger/servo/cleanup-node, r=jdm 2014-12-08 13:55:08 -07:00
bors-servo
feabaf34ac auto merge of #4270 : ProgramFOX/servo/issue-4252, r=saneyuki
Resolves #4252
2014-12-08 13:28:12 -07:00
bors-servo
5c506f7a98 auto merge of #4194 : cgaebel/servo/incremental-reflow-fix, r=pcwalton
When inserting a node that was already dirtied, the dirtying logic
would short circuit: "This node is already dirty? Great! Then its
parents must be HAS_DIRTY_DESCENDANTS, too! Let's skip that step."

This isn't appropriate when nodes move around the tree. In that case,
the node may be marked HAS_CHANGED, but ancestors may not yet have
the HAS_DIRTY_DESCENDANTS flag set.

This patch adds a `content_and_heritage_changed` hook in the document,
to deal with these cases appropriately.
2014-12-08 12:28:14 -07:00
bors-servo
f18c18371d auto merge of #4190 : mttr/servo/checked_pseudo_class, r=Manishearth
Relevant spec:
https://html.spec.whatwg.org/multipage/scripting.html#selector-checked

Also modifies HTMLInputElement::SetChecked to no longer modify its
checked content value, instead making use of its internal checkedness
state now that we can match `:checked` properly.
2014-12-08 12:01:51 -07:00
bors-servo
0b486b1210 auto merge of #4279 : saneyuki/servo/rename, r=jdm
#4275 

* This changeset rename "render"/"rendering" to "paint"/"painting" under `components/`.
* This does not rename words which are used as general browser's working.
  * So this doesn't change `reftest.rs`.
2014-12-08 10:28:10 -07:00
ProgramFOX
6104d5105f Implemented Document#inputEncoding
Resolves #4252
2014-12-08 18:22:29 +01:00
bors-servo
3f60bcf2c2 auto merge of #4268 : Ms2ger/servo/script_task, r=jdm 2014-12-08 09:43:11 -07:00
Matthew Rasmus
1b84bd22b8 Implements the :checked pseudo-class for inputs
Relevant spec:
https://html.spec.whatwg.org/multipage/scripting.html#selector-checked

Also modifies HTMLInputElement::SetChecked to no longer modify its
checked content value, instead making use of its internal checkedness
state now that we can match `:checked` properly.
2014-12-08 08:40:15 -08:00
Emanuel Rylke
29b672ded4 Implement selection ranges and deletion of \n for TextInput. 2014-12-08 17:29:38 +01:00
bors-servo
9ac817523c auto merge of #4267 : ema-fox/servo/textinput, r=jdm 2014-12-08 09:04:14 -07:00
Ms2ger
3e031bdaf8 Make parse_html's base_url argument non-optional.
It turns out the case where it woul be None can't happen.
2014-12-08 12:44:49 +01:00
Ms2ger
c7c7dc03ee Move the networking code in parse_html into ScriptTask::load.
This doesn't really have anything to do with parsing HTML, and fits in better
with the code in ScriptTask::load. In particular, all changes to Page's url
now go through ScriptTask methods.
2014-12-08 12:44:49 +01:00
Ms2ger
de318ae8f1 Simplify the LoadData creation in parse_html. 2014-12-08 12:44:49 +01:00
Ms2ger
5d0934d8ec Pass the load data to parse_html directly, rather than in an Option. 2014-12-08 12:44:49 +01:00
Ms2ger
69e13f3267 Cleanup last_loaded_url/last_url handling in ScriptTask::load. 2014-12-08 12:44:49 +01:00
Ms2ger
6374d74d6e Simplify the content_changed call in ScriptTask::load. 2014-12-08 12:44:49 +01:00
Ms2ger
e63a92956d Cleanup Node::is_html_element_in_html_document. 2014-12-08 12:26:10 +01:00
Ms2ger
c009bdec4e Cleanup Node::as_element. 2014-12-08 12:23:34 +01:00
Ms2ger
ba5a08c106 Cleanup Node::CloneNode. 2014-12-08 12:19:43 +01:00
Ms2ger
327b5d0ce5 Cleanup Node::Normalize. 2014-12-08 12:16:41 +01:00
Ms2ger
19e44362e2 Cleanup Node::ChildNodes. 2014-12-08 12:13:17 +01:00
Ms2ger
91c43ac18d Cleanup Node::clone. 2014-12-08 12:09:58 +01:00
Ms2ger
1611b8d0a8 Cleanup Node::summarize. 2014-12-08 12:03:12 +01:00
Ms2ger
54c0601950 Cleanup Node::query_selector. 2014-12-08 11:58:59 +01:00
bors-servo
ea907c1311 auto merge of #4266 : Ms2ger/servo/js-document-crash, r=Manishearth
This prevents a crash when the script in the javascript URL accesses the
document attribute.
2014-12-08 02:49:06 -07:00
bors-servo
bdb3a2538b auto merge of #4257 : johnathan79717/servo/4008, r=jdm
This is a fix for issue #4008.
2014-12-08 01:55:08 -07:00
Tetsuharu OHZEKI
71257e6604 Rename CanvasRenderTask -> CanvasPaintTask. 2014-12-08 14:01:07 +09:00
Tetsuharu OHZEKI
062854b164 Rename canvas_render_task -> canvas_paint_task 2014-12-08 11:46:43 +09:00
Emanuel Rylke
b5e7cba598 Fix bug of TextInput.adjust_horizontal causing stack overflow or wraparound
When the edit_point is in the first position of a multiline TextInput
adjust_horizontal(-1) moves the edit_point to the end of the first line.
When the first line is empty this causes a stack overflow. When the edit_point
is in the last position adjust_horizontal(1) causes a stack overflow.
2014-12-06 20:59:04 +01:00
bors-servo
c68e2af0a7 auto merge of #4263 : Ms2ger/servo/or_init, r=jdm 2014-12-06 08:01:06 -07:00
Ms2ger
f0ef1f97ad Use or_init where appropriate. 2014-12-06 15:59:17 +01:00
Emanuel Rylke
f99c0e2c15 Implement Page(Up|Down) functionality for TextInput. 2014-12-06 15:34:37 +01:00
Emanuel Rylke
2ec16a0e88 Fix bug of TextInput.adjust_vertical(1) always moving to the end of text. 2014-12-06 15:34:37 +01:00
bors-servo
b805e74fef auto merge of #4265 : ProgramFOX/servo/issue-4251, r=Ms2ger
Resolves #4251
2014-12-06 07:31:01 -07:00
Ms2ger
10e39161f7 Create the root frame before evaluating the javascript URL.
This prevents a crash when the script in the javascript URL accesses the
document attribute.
2014-12-06 15:04:37 +01:00
bors-servo
3eec780c00 auto merge of #4262 : tamird/servo/4261, r=jdm
`self` is never used, so there's no need for this to be a method.
Fixes #4261. @jdm
2014-12-06 04:28:01 -07:00