Commit graph

436 commits

Author SHA1 Message Date
Petr Klíma
c0bc90d122 Handle exception with errormessage on topdir with Unicode characters.
https://github.com/servo/servo/issues/10002
2016-03-15 11:08:38 +01:00
malayaleecoder
4b9ee25fdc test_ref() got an unexpected keyword argument 'kind'.Fixes #9986 2016-03-15 01:09:17 +05:30
bors-servo
8eb4fb801b Auto merge of #9966 - mrobinson:tidy-pyc, r=jdm
Do not run WPT tidy on pyc files

Generalize the mechanism for skipping file patterns and use it for
generating the list of WPT files to lint. Add *.pyc to the list of
file patterns to skip.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9966)
<!-- Reviewable:end -->
2016-03-11 12:16:03 +05:30
Martin Robinson
39ace782a9 Do not run WPT tidy on pyc files
Generalize the mechanism for skipping file patterns and use it for
generating the list of WPT files to lint. Add *.pyc to the list of
file patterns to skip.
2016-03-10 18:09:02 -08:00
bors-servo
f1bb0b0fa3 Auto merge of #9889 - MichaelRFairhurst:github-bug-9806-tidy-linting-string-contents, r=ecoal95
Handle escaped strings in rust linting, tidy.py

A little annoying to read since we have to escape for python (\\) and
then escape for re (\\\\) and then even at times escape for single
quotes immediately after, (\\\\\), but tidy.py now strips strings even
if they have escapes before linting.

Fixes #9806 -- basically the problem is that the PR which first revealed this had an escape in one of its strings which included an = sign. The escape meant the string wasn't escaped before it looked for spaces around spaces.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9889)
<!-- Reviewable:end -->
2016-03-11 05:07:43 +05:30
Mike Fairhurst
9b91c7afeb Handle escaped strings in rust linting, tidy.py
tidy.py now strips strings even if they have escapes before linting.

Use raw strings for regex with lots of backslashes

Handle ALL escape sequences in strings for tidy, not just escaped string terminators
2016-03-10 13:18:06 -08:00
Ms2ger
7e7495366c Update the list of files tidy ignores.
The deque file was removed in favour of an external crate.

The sync and sync_css directories are automatically created when updating the
in-tree copies of the wpt and css tests.
2016-03-09 16:18:23 +01:00
Wei Tang
cc1bb8d5df Detect Cygwin environment on Windows
Currently if Servo is built using Cygwin, it is incorrectly classified
as "unknown" host, which makes downloading Rust and Cargo fail. This
commit fixes that.
2016-03-09 10:55:22 +08:00
bors-servo
e3bea4f887 Auto merge of #9908 - UK992:tidy-fix, r=ecoal95
Check tidy for "support/android/build-apk/"

Fixes  #9893
r? @ecoal95

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9908)
<!-- Reviewable:end -->
2016-03-08 12:27:08 +05:30
UK992
607cd5923e check tidy for support/android/build-apk/ 2016-03-08 01:38:35 +01:00
bors-servo
41864c4524 Auto merge of #9871 - creativcoder:fix-tidy-single-import, r=Wafflespeanut
tidy fix for longer single line imports

Fixes #9864

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9871)
<!-- Reviewable:end -->
2016-03-08 01:06:08 +05:30
Rahul Sharma
9e887157e3 tidy fix for longer single line imports 2016-03-07 23:04:03 +05:30
Jack Moffitt
96cbe7ac97 Add --browserhtml/-b command to ./mach run
This will run Servo with browser.html. We use the latest package in the
dependency tree if there are multiple copies, since there is no way for
Cargo to tell us which one is canonical.
2016-03-04 15:07:32 -07:00
Paul Padier
a9c8f592a9 Lint json files 2016-02-26 23:42:51 +09:00
bors-servo
455ed0ae6d Auto merge of #9685 - danlrobertson:i9666, r=Wafflespeanut
Mach update-wpt should default to "--no-patch"

Change mach default behavior for `update-wpt` to use the "--no-patch" option and provide an alternate option "--patch" for anyone who does in fact want `update-wpt` to automatically create a commit.

Fixes #9666

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9685)
<!-- Reviewable:end -->
2016-02-26 00:13:27 +05:30
bors-servo
553cf3d8e8 Auto merge of #9649 - Wafflespeanut:tidy_progress, r=jdm
Refactoring tidy...

Improved tidy's code for efficiency (which now shows progress while checking through files)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9649)
<!-- Reviewable:end -->
2016-02-25 22:36:21 +05:30
Ravi Shankar
78a966c547 Refactored tidy for efficiency and optionally provide feedback on progress 2016-02-25 13:07:29 +05:30
Lars Bergstrom
ef95eb3bbe Fix for gonk bootstrapping 2016-02-23 02:29:06 +01:00
Daniel Robertson
9a563fa109 Mach update-wpt shoudl default to "--no-patch"
Change mach default behavior for update-wpt to "--no-patch" provide an
alternate option "--patch" for anyone who does want this behavior
2016-02-17 20:44:06 +00:00
Jason Williams
cf2e0c0f4c Now we use python for os_type, we need to catch 'windows' as well as 'mingw65_nt- fixes #9597' 2016-02-13 22:43:39 +00:00
bors-servo
2fd8cbccdd Auto merge of #9588 - Jayflux:hotfix/9499, r=Wafflespeanut
add check for win32 or msys before running rustc-with-gold fixes #9499

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9588)
<!-- Reviewable:end -->
2016-02-13 23:32:49 +05:30
Jason Williams
939f409042 use python's built in platform module for detection, for more accuracy and cross platform support 2016-02-13 13:24:04 +00:00
Jayflux
45c9521dc9 add check for win32 or msys before running rustc-with-gold fixes #9499 2016-02-13 13:05:15 +00:00
bors-servo
088963f774 Auto merge of #9611 - danlrobertson:i9557, r=larsbergstrom
Download extra stdlib only when required: #9557

Split [`ensure_bootstrap`](https://github.com/danlrobertson/servo/blob/i9557/python/servo/command_base.py#L397-L422) into two phases including a phase checking the compiler, and a phase checking for target libraries. E.g.

```
    # should download the stdlib for "i686-unknown-linux-gnu", "arm-linux-androideabi"
    # and the hosts target
    ./mach build -d --target i686-unknown-linux-gnu --android
    # should only download the stdlib for the hosts target
    ./mach build -d
```

Let me know if I missed anything! There are a few parts of this patch in its current state that I'm not a huge fan of, but I couldn't think of a better way in the moment.

Still new to working on servo, so any comments or critiques are welcome!

Fix #9557

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9611)
<!-- Reviewable:end -->
2016-02-13 03:09:51 +05:30
Daniel Robertson
0df4118db9 Download extra std lib when cross-compiling #9557
Split ensure_bootstrap into two phases including a phase checking the
compiler, and a phase checking for target libraries.
2016-02-12 14:58:08 -05:00
bors-servo
76381418bd Auto merge of #9601 - vishy1618:issue_9442, r=Wafflespeanut
Exit mach with an error when building on a path with spaces. Fixes #9442

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9601)
<!-- Reviewable:end -->
2016-02-12 19:20:35 +05:30
Matt Brubeck
7c740d395b Add an rr chaos mode 2016-02-11 11:18:12 -08:00
Matt Brubeck
d11a70f53a Factor out common code for mach test-wpt/test-css 2016-02-11 10:01:05 -08:00
Suvish Varghese Thoovamalayil
ded08d5fe6 Exit mach with an error when building on a path with spaces. Fixes #9442 2016-02-11 16:28:58 +05:30
qpid
9801552535 Removed documentation referencing 'android-rs-glue', and updated a similar comment to mention 'build-apk' 2016-02-05 21:03:13 +05:30
bors-servo
9e68285d35 Auto merge of #9509 - servo:cocoa, r=Ms2ger
Deduplicate the cocoa crate.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9509)
<!-- Reviewable:end -->
2016-02-05 01:56:50 +05:30
bors-servo
d574b78313 Auto merge of #9469 - fhahn:compiletest2, r=jdm
Integrate compiletest_rs

This PR integrates `compiletest_rs` as suggested in #5646. I created a new  `tests/compiletest` directory which contains separate crates for the tests.

Currently this PR includes `compile-fail` tests for some lints (acutally all except  inheritance_integrity, beacuse I'm not sure how to include the dom stuff in a way the `#[dom_struct]` works).

I gathered that there should be more crates for which compiletests make sense and would appreciate any pointers to relevant crates.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9469)
<!-- Reviewable:end -->
2016-02-04 21:00:21 +05:30
Simon Sapin
809f633f25 Deduplicate the cocoa crate. 2016-02-04 16:19:02 +01:00
Florian Hahn
dfdbcabc2e Add infrastructure for compiletests
Also adds compilefail tests for some lints, closes #5646.
2016-02-04 16:00:09 +01:00
bors-servo
220ead14b1 Auto merge of #9449 - larsbergstrom:revert_gold_removal, r=mbrubeck
Revert "Remove gold hack, since it's in rustc automatically now"

This reverts commit 2955d895a4.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9449)
<!-- Reviewable:end -->
2016-02-01 14:57:02 +05:30
Anthony Ramine
74b6d8b70d Bump clipboard to remove libc 0.1.z dependency 2016-01-31 23:46:47 +01:00
Shing Lyu
83a492a533 Fixed nits 2016-01-30 09:40:46 +08:00
Shing Lyu
18b6817755 Add mach test-webidl command 2016-01-29 21:12:21 +08:00
Lars Bergstrom
864fe53956 Revert "Remove gold hack, since it's in rustc automatically now"
This reverts commit 2955d895a4.
2016-01-28 11:49:08 -06:00
Adam Casey
74524f03c4 Prepend PATH extras instead of append.
Fixes multirust issue #9437
2016-01-27 11:09:45 +00:00
Adam Casey
bd0f7d107b Fix ./mach run on Windows
Fix unicode PATH the same way as mozilla-central does it for windows.
Also append extra PATHs instead of prepending, for some reason that broke ./mach run
2016-01-24 22:29:47 +00:00
Adam Casey
25b0ee22f2 Fix build on windows when default python is MSYS64 python 2016-01-23 15:04:34 +00:00
bors-servo
525e77f64f Auto merge of #9385 - larsbergstrom:win32, r=frewsxcv,pcwalton,jdm,ecoal95
Win32 support

r? @frewsxcv for python stuff
r? @pcwalton for the "remove usage of Gaol" stuff for Win32
r? anybody else for misc cargo.lock updates, etc.

This replaces #7878.

This works best with https://github.com/servo/mozjs/pull/71, too, to enable static linking, but can be run without (via some PATH hackery).

The instructions are here, and will be added to a .md file in the repo once the mozjs changes also land:
https://hackpad.com/Servo-on-Windows-C1LPcI2bP25

I'd like to get these changes landed because I've been rebasing them for months, they're otherwise quite stable, and don't affect our other platforms and targets.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9385)
<!-- Reviewable:end -->
2016-01-23 07:27:27 +05:30
Jason Williams
13d98f153a adding check for windows then using Scripts instead of bin 2016-01-22 19:27:29 -06:00
Ms2ger
aa1ae9b355 Include the wpt lint in test-tidy --faster. 2016-01-21 14:34:03 +01:00
Vladimir Vukicevic
5b845cbf79 win32: force PATH to be non-unicode on win32, if virtualenv munges it 2016-01-20 08:38:26 -06:00
Vladimir Vukicevic
ee863fde59 win32: mach and build command fixes
- Add SERVO_USE_NIGHTLY_RUST env var to use the latest rust/cargo nightly snapshot
- Fix up looking for cargo binary (in cargo/bin/cargo, not bin/cargo)
- Fix up win32 executable checking (use .exe suffix)
- fix up win32 PATH handling (subprocess must use shell=True for PATH change to be honored)
2016-01-20 08:38:24 -06:00
bors-servo
77d3fbcca3 Auto merge of #9284 - bholley:bootstrap_stylo, r=SimonSapin
Add Partial Implementation of style DOM traits for Gecko, and some basic glue to let Gecko call into Servo

The wrapper stuff is partially-complete, modulo some unimplemented methods. The glue code is just a toy for now. Regardless, I think it's worth getting some of this stuff in-tree to minimize breakage.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9284)
<!-- Reviewable:end -->
2016-01-19 14:19:10 +05:30
bors-servo
dba1f27305 Auto merge of #9333 - servo:list-properties, r=larsbergstrom
Add a script to list all CSS properties parsed by Servo.

I’ve been asked for that list by two different people this week :)

r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9333)
<!-- Reviewable:end -->
2016-01-16 01:06:03 +05:30
Simon Sapin
2222f345c8 Make the properties list JSON and add some more info. 2016-01-15 18:13:12 +01:00