bors-servo
8eb4fb801b
Auto merge of #9966 - mrobinson:tidy-pyc, r=jdm
...
Do not run WPT tidy on pyc files
Generalize the mechanism for skipping file patterns and use it for
generating the list of WPT files to lint. Add *.pyc to the list of
file patterns to skip.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9966 )
<!-- Reviewable:end -->
2016-03-11 12:16:03 +05:30
Martin Robinson
39ace782a9
Do not run WPT tidy on pyc files
...
Generalize the mechanism for skipping file patterns and use it for
generating the list of WPT files to lint. Add *.pyc to the list of
file patterns to skip.
2016-03-10 18:09:02 -08:00
bors-servo
f1bb0b0fa3
Auto merge of #9889 - MichaelRFairhurst:github-bug-9806-tidy-linting-string-contents, r=ecoal95
...
Handle escaped strings in rust linting, tidy.py
A little annoying to read since we have to escape for python (\\) and
then escape for re (\\\\) and then even at times escape for single
quotes immediately after, (\\\\\), but tidy.py now strips strings even
if they have escapes before linting.
Fixes #9806 -- basically the problem is that the PR which first revealed this had an escape in one of its strings which included an = sign. The escape meant the string wasn't escaped before it looked for spaces around spaces.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg " height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9889 )
<!-- Reviewable:end -->
2016-03-11 05:07:43 +05:30
Mike Fairhurst
9b91c7afeb
Handle escaped strings in rust linting, tidy.py
...
tidy.py now strips strings even if they have escapes before linting.
Use raw strings for regex with lots of backslashes
Handle ALL escape sequences in strings for tidy, not just escaped string terminators
2016-03-10 13:18:06 -08:00
Ms2ger
7e7495366c
Update the list of files tidy ignores.
...
The deque file was removed in favour of an external crate.
The sync and sync_css directories are automatically created when updating the
in-tree copies of the wpt and css tests.
2016-03-09 16:18:23 +01:00
bors-servo
e3bea4f887
Auto merge of #9908 - UK992:tidy-fix, r=ecoal95
...
Check tidy for "support/android/build-apk/"
Fixes #9893
r? @ecoal95
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg " height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9908 )
<!-- Reviewable:end -->
2016-03-08 12:27:08 +05:30
UK992
607cd5923e
check tidy for support/android/build-apk/
2016-03-08 01:38:35 +01:00
Rahul Sharma
9e887157e3
tidy fix for longer single line imports
2016-03-07 23:04:03 +05:30
Paul Padier
a9c8f592a9
Lint json files
2016-02-26 23:42:51 +09:00
Ravi Shankar
78a966c547
Refactored tidy for efficiency and optionally provide feedback on progress
2016-02-25 13:07:29 +05:30
Simon Sapin
809f633f25
Deduplicate the cocoa crate.
2016-02-04 16:19:02 +01:00
Anthony Ramine
74b6d8b70d
Bump clipboard to remove libc 0.1.z dependency
2016-01-31 23:46:47 +01:00
Ms2ger
aa1ae9b355
Include the wpt lint in test-tidy --faster.
2016-01-21 14:34:03 +01:00
bors-servo
77d3fbcca3
Auto merge of #9284 - bholley:bootstrap_stylo, r=SimonSapin
...
Add Partial Implementation of style DOM traits for Gecko, and some basic glue to let Gecko call into Servo
The wrapper stuff is partially-complete, modulo some unimplemented methods. The glue code is just a toy for now. Regardless, I think it's worth getting some of this stuff in-tree to minimize breakage.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9284 )
<!-- Reviewable:end -->
2016-01-19 14:19:10 +05:30
Ms2ger
671cfd9940
Remove legacy reftest lints.
2016-01-14 09:49:42 +01:00
Bobby Holley
84f24a04a4
Basic wrappers and glue for GeckoLib.
2016-01-13 12:14:00 -08:00
PythonNut
fcd33e2b70
Call WPT lint directly in tidy, fixes #9189
2016-01-12 21:13:54 +00:00
PythonNut
3dfa89540a
Fix literal braces in string formatting in tidy.py, fixes #9151
2016-01-11 01:32:24 +00:00
Daan Sprenkels
a9b8d47d5d
add a --faster option to ./mach test-tidy
...
which will
- only check files changed since the last merge by bors
- and skip the wpt-lint
2016-01-07 16:28:13 +01:00
Daan Sprenkels
c9f188d163
tidy.py: made check_rust(file_name, lines)
more readable
...
also added a rule that requires a space before '-' (except in cases of scientific notation)
fixes #8733
2015-12-31 12:00:26 +01:00
Daan Sprenkels
a01400734d
tidy.py: split checking functions into {normal,line}-checking categories
...
This is done, because the majority of the functions splits the lines, and
it would be better to do this just once.
This commit also optimised the licence checking function slightly by only
checking the fist lines of the file (where the amount of lines is the
line span of the longest license)
2015-12-26 13:47:54 +01:00
Simon Martin
cec661fa86
Issue #9042 : Report incorrect number of spaces around => in the style checker.
2015-12-23 20:54:26 +01:00
Corey Farwell
75d64d3b3f
Print tidy errors as they happen instead of all-at-once
2015-12-14 18:07:11 -05:00
Ms2ger
07d837bd03
Update bincode.
2015-12-08 14:49:38 -05:00
bors-servo
cad77d5f1c
Auto merge of #8824 - Ms2ger:tidy-lock, r=Wafflespeanut
...
Rewrite the Cargo.lock tidy check.
Fixes #8691 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8824 )
<!-- Reviewable:end -->
2015-12-08 10:21:55 +05:30
Guillaume Gomez
db3457e498
Improve checking algorithms
2015-12-06 03:34:59 +01:00
Ms2ger
b72c8e5e18
Rewrite the Cargo.lock tidy check.
2015-12-04 17:55:48 +01:00
bors-servo
8b95d7b8d8
Auto merge of #8757 - servo:skia, r=mbrubeck
...
Use skia and deps from crates.io.
This makes the initial download for skia go from a 300 MB git repository to a 5 MB tarball. This should help with issues like #6132 and #7687 .
Fix https://github.com/servo/skia/issues/70
This builds, but the at the moment causes a number of tidy errors for duplicated crates.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8757 )
<!-- Reviewable:end -->
2015-12-03 12:58:29 +05:30
Simon Sapin
b8a3a64691
Tidy ports/cef/Cargo.lock
...
Despite the rest of ports/cef/ being ignored.
2015-12-02 19:11:08 +01:00
Simon Sapin
aa1eba4f5a
Use skia and deps from crates.io.
...
Fix https://github.com/servo/skia/issues/70
2015-12-02 19:07:59 +01:00
jmr0
e301ff46b2
adding wpt lint script to tidy checks
2015-11-30 10:08:10 -05:00
bors-servo
dbff1ab336
Auto merge of #8692 - GuillaumeGomez:patch-1, r=Wafflespeanut
...
Ensure crate are alphabetically sorted
cc @nox
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8692 )
<!-- Reviewable:end -->
2015-11-28 19:34:11 +05:30
Guillaume Gomez
6e7de62b38
Add check up on extern crate order and sort extern crates alphabetically
2015-11-28 03:11:08 +01:00
Manish Goregaokar
dc0e467945
Upgrade to rustc 1.6.0-nightly (d5fde83ae 2015-11-12)
...
… and libc 0.2 and many other dependencies
2015-11-27 00:15:29 -05:00
bors-servo
bc618b0d53
Auto merge of #8689 - jdm:deps, r=frewsxcv
...
Remove remaining version-conflict exceptions in tidy.py.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8689 )
<!-- Reviewable:end -->
2015-11-27 09:17:54 +05:30
Josh Matthews
c36cbf58e8
Remove remaining version-conflict exceptions in tidy.py.
2015-11-26 11:26:28 -05:00
jmr0
df49cf2b13
adding tidy rule to warn against use of &String and refactoring instances of &String in codebase
2015-11-25 21:49:12 -05:00
Ms2ger
026994e4be
Ignore sync directories in test-tidy.
2015-11-10 10:29:26 +01:00
Corey Farwell
d1824aea48
Expand tidy to lint parts of /tests/wpt
2015-11-03 17:11:44 -05:00
Anthony Ramine
bd363b009d
Make test-tidy ignore braces surrounded by backticks
2015-10-21 10:59:36 +02:00
Till Schneidereit
499a847141
Whitelist drafts.fxtf.org in tidy.py's webidl spec link check
2015-10-17 22:25:21 +02:00
Gilles Leblanc
d99149701f
Adds a tidy check for single-page HTML specification links
...
Flags links to the single-page WHATWG specification and suggests the URL
for the multi page one.
Fixes #7998
2015-10-15 21:03:58 -04:00
bors-servo
0f597d3890
Auto merge of #7933 - mbrubeck:piston-image, r=glennw
...
Replace libpng and stb_image with PistonDevelopers/image
Fixes #3368 . r? @glennw
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7933 )
<!-- Reviewable:end -->
2015-10-12 15:06:31 -06:00
Corey Farwell
85f2b6fc5b
Replace usage of old-style WHATWG spec links
2015-10-10 11:55:09 -04:00
Matt Brubeck
e2e142aae8
Replace libpng with image everywhere.
2015-10-10 07:43:11 -07:00
Matt Brubeck
b649246fe2
Replace stb_image with PistonDevelopers/image
...
Fixes #3368
2015-10-09 12:23:33 -07:00
Pierre Chevalier
d2481c37d5
Refactor away unnecessary use of regex
...
We don't need regex matching since ": &Vec<" doesn't
contain any special character.
New code reads better.
Fixes #7914 .
2015-10-09 16:43:26 +01:00
Jaydeep
2a99915188
Check for Extra pointer dereferencing. Issue #7640 .
2015-09-26 19:33:29 -07:00
Mathieu Rheaume
705d8f7a1c
Raise max length error over 120 chars not at 120 chars. python/tidy.py
2015-09-21 22:25:32 -04:00
Brandon Fairchild
e924393be8
tidy.py: Check for import blocks separated by whitespace
...
This enables flagging multiple import blocks separated by whitespace
as errors.
Fixes #7381 .
2015-09-19 12:46:01 -04:00