Commit graph

3027 commits

Author SHA1 Message Date
bors-servo
0f5c614609 Auto merge of #9051 - bholley:split_style_and_layout_wrappers, r=SimonSapin
Split layout wrappers into style+layout and layout-only functionality

This is a step towards removing the dependency of stylo on layout/.

This PR depends on #9004.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9051)
<!-- Reviewable:end -->
2015-12-30 10:04:14 +05:30
Nikki
773a15d28a added a check for buffer overflow 2015-12-29 17:08:46 -07:00
bors-servo
0d52170f35 Auto merge of #9054 - frewsxcv:parse-non-zero-dimension, r=eefriedman
Implement non-zero dimension attribute parsing

Fixes #8445

The only attributes I found that we have implemented that uses non-zero
dimenion attributes:

* `width` for `<td>` and `<th>` (table cells)
* `width` for `<table>`

I updated these implementations to use the new non-zero dimension
attribute parsing and added associated regression tests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9054)
<!-- Reviewable:end -->
2015-12-30 05:26:56 +05:30
Nikki
20edf21352 updated websocket buffered_amount to be u64 instead of u32 2015-12-29 13:30:35 -07:00
Bobby Holley
47059d2d26 Separate style+layout and layout-specific wrapper functionality.
This patch does a number of things, unfortunately all at once:
* Hoists a large subset of the layout wrapper functionality into the style system.
* Merges TElementAttributes into the newly-created TElement.
* Reorganizes LayoutData by style vs layout, and removes LayoutDataShared.
* Simplifies the API for borrowing style/layout data.

There's still more to do to make the style system usable standalone, but
this is a good start.
2015-12-29 11:50:03 -08:00
Josh Matthews
7693b03468 Make button elements activatable. Fixes #4837. Fixes #8101. 2015-12-29 10:45:04 -05:00
Alberto Corona
e6a3c16e9a Enable Pattern variant of CanvasFillOrStrokeStyle
Closes #7608
2015-12-29 10:38:00 -05:00
bors-servo
c1cb9403a7 Auto merge of #8948 - simartin:issue_8738, r=ecoal95
Issue #8738: bufferSubData and texImage2D argument sanity checks.

Fixes https://github.com/servo/servo/issues/8738

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8948)
<!-- Reviewable:end -->
2015-12-29 17:27:27 +05:30
Dongie Agnir
12afd837a0 Ask for reset when option is removed. 2015-12-27 21:47:13 -10:00
Manish Goregaokar
6a0ec85d43 Fix placeholders for password inputs
currently they show dots
2015-12-27 00:18:06 +05:30
Simon Martin
f2fe401d7d Issue #8738: bufferSubData and texImage2D argument sanity checks. 2015-12-26 18:56:48 +01:00
Joe Kachmar
655268d111 Separate script and layout messages, issue #8843 2015-12-26 12:24:51 -05:00
bors-servo
89ab368258 Auto merge of #8506 - nox:finish-ranges, r=dzbarsky
Properly propagate changes when range or trees are mutated

Does the same thing as #6817, but storing Range instances directly in their start and end containers.

Cc @dzbarsky

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8506)
<!-- Reviewable:end -->
2015-12-26 04:08:15 +05:30
Anthony Ramine
3c76835615 Properly propagate changes when range or trees are mutated 2015-12-25 23:35:57 +01:00
Corey Farwell
ba659cb99c Implement non-zero dimension attribute parsing
Fixes #8445

The only attributes I found that we have implemented that uses non-zero
dimenion attributes:

* `width` for `<td>` and `<th>` (table cells)
* `width` for `<table>`

I updated these implementations to use the new non-zero dimension
attribute parsing and added associated regression tests.
2015-12-24 13:20:43 -08:00
bors-servo
7db6ce41d2 Auto merge of #8725 - dzbarsky:no_context, r=eefriedman
Handle toDataURL with no context

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8725)
<!-- Reviewable:end -->
2015-12-25 02:04:40 +05:30
David Zbarsky
84ec9c4266 Handle toDataURL with no context 2015-12-24 11:48:04 -08:00
bors-servo
f77c792886 Auto merge of #9055 - simartin:issue_9042, r=Wafflespeanut
Issue #9042: Report incorrect number of spaces around => in the style checker

Fixes https://github.com/servo/servo/issues/9042

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9055)
<!-- Reviewable:end -->
2015-12-24 10:55:48 +05:30
Simon Martin
cec661fa86 Issue #9042: Report incorrect number of spaces around => in the style checker. 2015-12-23 20:54:26 +01:00
bors-servo
68c4f290c7 Auto merge of #8938 - nerith:gfx, r=Ms2ger
Move LayerKind and ScrollPolicy enums to gfx_traits

Fixes #8836.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8938)
<!-- Reviewable:end -->
2015-12-23 18:38:51 +05:30
bors-servo
dafdc856ac Auto merge of #9030 - askobara:refactoring-add-htmlformelement-fire_event, r=Manishearth
Add helper method HTMLFormElement::fire_event

Fixes #8777

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9030)
<!-- Reviewable:end -->
2015-12-22 22:38:19 +05:30
Corey Farwell
7a2b3535f9 Precompute width & height attribute values on <iframe> 2015-12-22 08:13:40 -08:00
Arthur Skobara
d38771e270 Implement EventTarget::fire_simple_event and EventTarget::fire_simple_event_params 2015-12-22 13:47:57 +06:00
bors-servo
df087cc6cf Auto merge of #9036 - KiChjang:document-charset, r=Ms2ger
Implement Document charset

Rebase of #7966.

Fixes #7718.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9036)
<!-- Reviewable:end -->
2015-12-21 22:05:02 +05:30
vectorijk
c559270b83 implement document charset
- pre-compute the adjusted encoding name

Fix build errors and update test expectations
2015-12-21 03:17:52 -08:00
Brandon Fairchild
637afecec9 Move LayerKind and ScrollPolicy enums to gfx_traits
This also moves LayerId and LayerProperties to gfx_traits.

Fixes #8836.
2015-12-20 20:43:31 -05:00
bors-servo
9a4d82c314 Auto merge of #8863 - simartin:issue_8352, r=jdm
Issue #8352: Dispatch mozbrowsershowmodalprompt event for alert().

Fixes https://github.com/servo/servo/issues/8352

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8863)
<!-- Reviewable:end -->
2015-12-21 02:28:32 +05:30
bors-servo
5b91daa923 Auto merge of #9025 - k-cross:master, r=nox
touchlist dom api #8225

Sorry for the wait, I just finished my finals.

Fixes #8225

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9025)
<!-- Reviewable:end -->
2015-12-21 01:19:41 +05:30
Beomjin Kim
82f39d5a1c Moved ScriptToCompositorMsg enum and EventResult enum to script_traits
Moved ScriptToCompositorMsg enum and EventResult enum to script_traits

(rebased)
2015-12-20 11:53:41 +09:00
k-cross
ae8d3f67c8 touchlist dom api #8225 2015-12-19 12:10:18 -08:00
bors-servo
8c87477138 Auto merge of #9026 - Manishearth:attack-of-the-clones, r=Ms2ger
Remove clone in collect_text_contents

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9026)
<!-- Reviewable:end -->
2015-12-20 00:14:02 +05:30
Beomjin Kim
2637d30c2a Moved ScriptToCompositorMsg enum and EventResult enum to script_traits
Moved ScriptToCompositorMsg enum and EventResult enum to script_traits
resolving issue #8835.
2015-12-20 00:31:33 +09:00
Simon Martin
0d910bb934 Issue #8352: Dispatch mozbrowsershowmodalprompt event for alert(). 2015-12-19 12:51:33 +01:00
bors-servo
f9141ef2db Auto merge of #9019 - magopian:9002-use-url.join, r=SimonSapin
Use Url.join instead of UrlParser.base_url(...).parse (#9002)

Fix issue #9002

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9019)
<!-- Reviewable:end -->
2015-12-19 01:58:56 +05:30
Manish Goregaokar
ef5de267d9 Remove clone in collect_text_contents 2015-12-19 01:06:16 +05:30
bors-servo
21277b1fa0 Auto merge of #8959 - nox:domtokenlist-stringifier, r=Ms2ger
Fix DOMStringMap's stringifier behaviour according to the spec

It should just return its associated attribute's value, if any.

https://github.com/whatwg/dom/issues/105

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8959)
<!-- Reviewable:end -->
2015-12-19 00:51:17 +05:30
bors-servo
6ba4ef22fa Auto merge of #8882 - GuillaumeGomez:dom_quad, r=nox
Add DOMQuad element

cc  @nox

Part of #8821

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8882)
<!-- Reviewable:end -->
2015-12-18 23:37:12 +05:30
Guillaume Gomez
823e1b96c3 Add DOMQuad element 2015-12-18 17:37:10 +01:00
Anthony Ramine
e7a9f44df9 Fix DOMStringMap's stringifier behaviour according to the spec
It should just return its associated attribute's value, if any.

https://github.com/whatwg/dom/issues/105
2015-12-18 17:03:49 +01:00
Mathieu Agopian
11234f5370 Use Url.join instead of UrlParser.base_url(...).parse (#9002) 2015-12-18 17:02:41 +01:00
bors-servo
22e1ccae37 Auto merge of #9010 - Ms2ger:warnings, r=jdm
Silence warnings in htmlformelement.rs.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9010)
<!-- Reviewable:end -->
2015-12-18 15:16:32 +05:30
bors-servo
8dc4b8dcb9 Auto merge of #8993 - nox:small-codegen-slimming, r=Ms2ger
Slightly reduce the output of codegen

Interfaces which we know are never instantiated can generate less code.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8993)
<!-- Reviewable:end -->
2015-12-18 06:35:15 +05:30
bors-servo
63923bc7c9 Auto merge of #8825 - jmr0:master, r=jdm
adding initial support for websocket subprotocol negotation

Addresses #8177

I also noticed some bugs/gaps (and at least one of my TODO's can be an E-Easy)

cc @jdm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8825)
<!-- Reviewable:end -->
2015-12-18 05:23:15 +05:30
bors-servo
82e73e7a5f Auto merge of #8723 - dzbarsky:origin_clean, r=dzbarsky
Add origin-clean flag tracking for canvas

The resulting failures are because we aren't doing origin-comparison correctly (I bet the image ends up with an empty hostname or something). We could probably hack around that if we care, but it should just go away when we get the origin checking right.

r? @jdm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8723)
<!-- Reviewable:end -->
2015-12-18 04:26:59 +05:30
David Zbarsky
b8e9064fe6 Add origin-clean flag tracking for canvas 2015-12-17 11:40:38 -08:00
Ms2ger
50ff54c37c Silence warnings in htmlformelement.rs. 2015-12-17 16:03:22 +01:00
jmr0
7d0bede8ba adding initial support for websocket subprotocol negotation 2015-12-17 09:17:15 -05:00
bors-servo
9570b51565 Auto merge of #8618 - paulrouget:reload, r=jdm
Browser API: implement iframe.reload()

fixes #8575

The implementation is naive, and doesn't support the `hardreload` parameter.
And for the test, I'm not sure how else I can test the reload.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8618)
<!-- Reviewable:end -->
2015-12-17 19:45:44 +05:30
bors-servo
c6ae32abdd Auto merge of #8612 - glennw:pending-frames, r=jdm
Add test to constellation to avoid writing reftest image if there are pending frames.

This changes several tests that contain <iframe></iframe> from FAIL to TIMEOUT. This is correct
since there is a bug that prevents these iframes from ever rendering.

~~~There are also a few previous FAILs that changed to OK. These may be intermittents or they
may genuinely be fixed by this change.~~~

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8612)
<!-- Reviewable:end -->
2015-12-17 16:19:16 +05:30
Glenn Watson
b670430cb2 Add test to constellation to avoid writing reftest image if there are pending frames.
Also change when pipelines become active.

This makes the constellation activate a pipeline as the current frame
when it is ready to do initial reflow, rather than when it is ready
to paint.

This fixes a number of intermittent failures that could previously occur
if an iframe was not visible - which would mean it was never moved from
a pending frame in the constellation to an active frame.

(It happens that webrender exposes these intermittents as permanent failures).
2015-12-17 12:30:19 +10:00