Commit graph

12597 commits

Author SHA1 Message Date
Matt Brubeck
7d2257bdd6 Update glutin
To servo/glutin#46
2015-09-04 09:22:43 -07:00
James Graham
a208379f46 Update prefs API to return an Option<bool>.
This allows for situations where there is no reasonable default
to apply for the pref value e.g. when we are just listing values
2015-09-04 15:55:29 +01:00
bors-servo
14c6d5db41 Auto merge of #7540 - servo:update-css, r=Ms2ger
Update CSS tests to revision 584b6cdd10401df603bd7bdf4ec801fcddc65468



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7540)
<!-- Reviewable:end -->
2015-09-04 08:52:30 -06:00
Ms2ger
58b5cd27de Update CSS tests to revision 584b6cdd10401df603bd7bdf4ec801fcddc65468 2015-09-04 16:52:07 +02:00
bors-servo
c2c2646d37 Auto merge of #7536 - Manishearth:clippyfix, r=Ms2ger
More clippy fixes

Elided almost all the lifetimes and removed needless returns. Mostly done by sed + manual fixes.

r? @nox

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7536)
<!-- Reviewable:end -->
2015-09-04 07:59:04 -06:00
Manish Goregaokar
8e2c37a542 Fix match_refs and let_returns in layout, address review changes 2015-09-04 18:30:46 +05:30
bors-servo
cc1eb3f741 Auto merge of #7508 - jxs:master, r=SimonSapin
Add style_traits crate to improve crate separation,

closes #7353

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7508)
<!-- Reviewable:end -->
2015-09-04 06:46:11 -06:00
João Oliveira
4a305d1e62 Add style_traits crate to improve crate separation,
closes #7353
2015-09-04 12:59:37 +01:00
bors-servo
43e7cd5fae Auto merge of #7538 - saneyuki:requestAnimationFrame, r=Ms2ger
script: change requestAnimationFrame returns the unsigned long type.

By https://github.com/whatwg/html/pull/97, the returned type of`requestAnimationFrame()` and the argument type of `cancelAnimationFrame()` are changed to `unsigned long` WebIDL type.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7538)
<!-- Reviewable:end -->
2015-09-04 02:49:16 -06:00
bors-servo
8d21a79246 Auto merge of #7539 - servo:warnings, r=SimonSapin
Fix or silence some warnings.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7539)
<!-- Reviewable:end -->
2015-09-04 02:15:10 -06:00
Simon Sapin
24a6a53633 Fix or silence some warnings. 2015-09-04 10:11:57 +02:00
Tetsuharu OHZEKI
63627405d9 script: change requestAnimationFrame returns the unsigned long type. 2015-09-04 15:40:30 +09:00
Manish Goregaokar
5c24da3e2d Undo elision for trait object; trait objects are strange 2015-09-04 09:24:49 +05:30
Manish Goregaokar
e94df1ed5c Remove needless returns 2015-09-04 09:13:48 +05:30
Manish Goregaokar
2e02ea38fc Elide most 'b lifetimes 2015-09-04 09:02:12 +05:30
Manish Goregaokar
54c036cd66 Elide most 'a lifetimes 2015-09-04 08:55:51 +05:30
Manish Goregaokar
35dd1816a9 Improve style in properties.mako.rs 2015-09-04 08:16:32 +05:30
Patrick Walton
dba3e41a63 layout: Lay absolutely-positioned blocks with inline containing blocks out of
flow.

Removes the long space before the site-specific drop-down in the Google SERPs.
2015-09-03 15:37:40 -07:00
bors-servo
05deb3dcc8 Auto merge of #7518 - servo:custom-properties, r=pcwalton
Initial support for CSS Custom Properties

https://drafts.csswg.org/css-variables/

Missing: 

* `var()` in shorthand property declarations.
* Correct handling of EOF in custom property declarations.

r? @pcwalton

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7518)
<!-- Reviewable:end -->
2015-09-03 16:09:02 -06:00
Simon Sapin
c651c2f3db Remove obsolete FIXME comment.
See https://lists.w3.org/Archives/Public/www-style/2015Jul/0360.html
2015-09-03 23:02:25 +02:00
Simon Sapin
a9db4eef14 Factor out custom property name parsing. 2015-09-03 23:02:24 +02:00
Simon Sapin
b0aedc6f4c Enable css-variables-1 tests
```
Summary
=======

Ran 548 tests (525 parents, 23 subtests)
Expected results: 242
Unexpected results: 306 (FAIL: 304, TIMEOUT: 2)
```
2015-09-03 23:02:23 +02:00
Simon Sapin
b4fdb5d803 Substitute var() in longhand property declarations. 2015-09-03 23:02:22 +02:00
Simon Sapin
b2ee828520 [T]::position_elem is deprecated. 2015-09-03 23:02:22 +02:00
Simon Sapin
1d47857be9 Invalid at computed-value time customp properties get their inherited value. 2015-09-03 23:02:21 +02:00
Simon Sapin
a18a1a8d79 Add a FIXME comment of EOF handling in custom properties. 2015-09-03 23:02:20 +02:00
Simon Sapin
c3b8b39437 An empty <declaration-value> is invalid. 2015-09-03 23:02:19 +02:00
Simon Sapin
4bf28417b4 Make custom property substitution do less work.
When var() is substituted, record that result rather than re-compute it later.
2015-09-03 23:02:18 +02:00
Simon Sapin
1c1a9379a3 Substitute var() in custom properties at computed value time. 2015-09-03 23:02:17 +02:00
Simon Sapin
7bcf9f0c9a Use nested parsers as appropritate 2015-09-03 23:02:16 +02:00
Simon Sapin
5fb6acb753 Rename DeclaredValue::SpecifiedValue to DeclaredValue::Value 2015-09-03 23:02:15 +02:00
bors-servo
0ad284766b Auto merge of #7443 - mbrubeck:get_table, r=pcwalton
Implement get_table_for_tag on FreeType

Updates freetype to pick up servo/rust-freetype#37

r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7443)
<!-- Reviewable:end -->
2015-09-03 14:37:38 -06:00
Matt Brubeck
afafb0b71c Implement get_table_for_tag on FreeType
Also fixes use-after-free of FontTable buffers.
2015-09-03 13:35:44 -07:00
bors-servo
d3efcb707c Auto merge of #7522 - thiagopnts:from-str-canvas, r=Manishearth
Make use of FromStr and Default traits in lib canvas

fixes #7517

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7522)
<!-- Reviewable:end -->
2015-09-03 12:36:23 -06:00
bors-servo
8bbace7815 Auto merge of #7207 - pcwalton:surround-whitespace-stripping, r=mbrubeck
layout: Fix several bugs relating to inline borders, padding, and margins.

* The code that attempted to strip out borders that span multiple
  fragments in the same element could go wrong if fragments were
  stripped out due to text clumping or whitespace stripping. This patch
  rewrites that code to maintain flags in the inline fragment context
  specifying whether the node is the beginning or end of the element.
  Not only is this easier to maintain, it's closer in spirit to what roc
  originally suggested two years ago: it's isomorphic to "begin element,
  end element" markers for inline layout.

* Padding and margins for spans containing inline-blocks are now
  properly handled via a division of labor between the `InlineBlock`
  fragment and the `BlockFlow` that represents the inline-block.

* Unscanned text fragments may not be joined together into a text run if
  borders, padding, or margins separate them.

Because Servo now matches the rendering of Gecko and WebKit on the
`input_button_margins_a` reftest, I had to modify it to add some
vertical alignment.

The combined effect of all of these fixes places "Advertising" on the
right place on google.com.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7207)
<!-- Reviewable:end -->
2015-09-03 11:55:03 -06:00
Thiago Pontes
a2a9c0489d Make use of FromStr and Default traits in lib canvas
fixup! Make use of FromStr and Default traits in lib canvas
2015-09-03 14:42:53 -03:00
Patrick Walton
ee8741b7a8 layout: Fix several bugs relating to inline borders, padding, and
margins.

* The code that attempted to strip out borders that span multiple
  fragments in the same element could go wrong if fragments were
  stripped out due to text clumping or whitespace stripping. This patch
  rewrites that code to maintain flags in the inline fragment context
  specifying whether the node is the beginning or end of the element.
  Not only is this easier to maintain, it's closer in spirit to what roc
  originally suggested two years ago: it's isomorphic to "begin element,
  end element" markers for inline layout.

* Padding and margins for spans containing inline-blocks are now
  properly handled via a division of labor between the `InlineBlock`
  fragment and the `BlockFlow` that represents the inline-block.

* Unscanned text fragments may not be joined together into a text run if
  borders, padding, or margins separate them.

Because Servo now matches the rendering of Gecko and WebKit on the
`input_button_margins_a` reftest, I had to modify it to add some
vertical alignment.

The combined effect of all of these fixes places "Advertising" on the
right place on google.com.
2015-09-03 10:24:59 -07:00
bors-servo
3f9b6f8586 Auto merge of #7530 - Ms2ger:html, r=jdm
Disable html tests in __dir__.ini rather than include.ini.

This ensures those tests are skipped when running ./mach test-wpt html.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7530)
<!-- Reviewable:end -->
2015-09-03 09:02:50 -06:00
Ms2ger
509b050712 Disable html tests in __dir__.ini rather than include.ini.
This ensures those tests are skipped when running ./mach test-wpt html.
2015-09-03 17:02:06 +02:00
bors-servo
33063fd887 Auto merge of #7528 - jdm:updatecssfix, r=frewsxcv
Remove obsolete method call that breaks ./mach update-css.

r? @frewsxcv

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7528)
<!-- Reviewable:end -->
2015-09-02 23:29:03 -06:00
bors-servo
3a09c027e2 Auto merge of #7526 - frewsxcv:bump-no-warnings, r=jdm
Upgrade rust-block to silence warning

https://github.com/SSheldon/rust-block/pull/1

Relevant to https://github.com/servo/servo/pull/7513

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7526)
<!-- Reviewable:end -->
2015-09-02 22:57:13 -06:00
Josh Matthews
152b76b963 Remove obsolete method call that breaks ./mach update-css. 2015-09-03 00:37:44 -04:00
Corey Farwell
68e65d775a Upgrade rust-block to silence warning
https://github.com/SSheldon/rust-block/pull/1

Relevant to https://github.com/servo/servo/pull/7513
2015-09-03 00:00:48 -04:00
bors-servo
625b4938ef Auto merge of #7525 - eefriedman:ogl-version-requirement, r=glennw
Cut required desktop OpenGL version from 3.0 to 2.1.

Mesa software rendering on Ubuntu 14.04 only claims to support OpenGL 2.1,
so servo crashes on startup.  It seems to work fine if an OpenGL 2.1 context
is requested.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7525)
<!-- Reviewable:end -->
2015-09-02 21:12:34 -06:00
Eli Friedman
c82401f213 Cut required desktop OpenGL version from 3.0 to 2.1.
Mesa software rendering on Ubuntu 14.04 only claims to support OpenGL 2.1,
so servo crashes on startup.  It seems to work fine if an OpenGL 2.1 context
is requested.
2015-09-02 19:51:28 -07:00
bors-servo
0f596cdb55 Auto merge of #7521 - eefriedman:unnecessary-refcell, r=jdm
Remove unnecessary uses of DOMRefCell.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7521)
<!-- Reviewable:end -->
2015-09-02 17:28:37 -06:00
Eli Friedman
94dec69247 Fix up some unnecessary uses of unsafe. 2015-09-02 15:50:17 -07:00
Eli Friedman
57a3e1465c Remove unnecessary uses of DOMRefCell. 2015-09-02 15:21:57 -07:00
bors-servo
d01ab61734 Auto merge of #7519 - Manishearth:clippyfix, r=SimonSapin
Make style clippy-free

(except for properties.rs)

I might add more fixes to this PR later.

r? @SimonSapin

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7519)
<!-- Reviewable:end -->
2015-09-02 16:11:30 -06:00
Manish Goregaokar
97422ad252 Various fixes in style 2015-09-03 03:16:00 +05:30