Commit graph

2719 commits

Author SHA1 Message Date
bors-servo
c6ae32abdd Auto merge of #8612 - glennw:pending-frames, r=jdm
Add test to constellation to avoid writing reftest image if there are pending frames.

This changes several tests that contain <iframe></iframe> from FAIL to TIMEOUT. This is correct
since there is a bug that prevents these iframes from ever rendering.

~~~There are also a few previous FAILs that changed to OK. These may be intermittents or they
may genuinely be fixed by this change.~~~

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8612)
<!-- Reviewable:end -->
2015-12-17 16:19:16 +05:30
Glenn Watson
b670430cb2 Add test to constellation to avoid writing reftest image if there are pending frames.
Also change when pipelines become active.

This makes the constellation activate a pipeline as the current frame
when it is ready to do initial reflow, rather than when it is ready
to paint.

This fixes a number of intermittent failures that could previously occur
if an iframe was not visible - which would mean it was never moved from
a pending frame in the constellation to an active frame.

(It happens that webrender exposes these intermittents as permanent failures).
2015-12-17 12:30:19 +10:00
bors-servo
d9bf1ba616 Auto merge of #8747 - KiChjang:form-interactive-validation, r=Manishearth
Implement basic framework for static and interactive validation on forms

This came along when I was trying to do #3648. I was about to do form validation as well, but then I saw it was actually intended to be a student project. Hopefully I didn't step on too many toes on this one; I did leave most of the important bits out (the fun bits I believe, e.g. interactive validation doesn't actually interactively validate anything right now).

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8747)
<!-- Reviewable:end -->
2015-12-17 05:41:45 +05:30
Keith Yeung
5ed03a5466 Remove big blob of commented code 2015-12-16 10:36:13 -08:00
bors-servo
d1ea209f0f Auto merge of #8996 - nox:rm-empty-modules, r=frewsxcv
Do not create modules from files with nothing to codegen (fixes #8711)

Fixes #8711.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8996)
<!-- Reviewable:end -->
2015-12-16 21:06:37 +05:30
Corey Farwell
1dee779d45 Delete GenerateCSS2PropertiesWebIDL.py 2015-12-16 09:12:56 -05:00
bors-servo
9c4ca39ebe Auto merge of #8055 - nox:rm-webidl-patches, r=Ms2ger
Remove all our patches to the WebIDL parser

All the tweaks we need can just be made through Configuration.py.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8055)
<!-- Reviewable:end -->
2015-12-16 15:19:25 +05:30
David Zbarsky
6a72d4dd12 Implement WebGL scissor method 2015-12-15 20:43:38 -08:00
Keith Yeung
3395e54585 Implement basic framework for static and interactive validation on forms 2015-12-15 16:34:42 -08:00
Anthony Ramine
2522cfe539 Do not create modules from files with nothing to codegen (fixes #8711) 2015-12-16 01:17:06 +01:00
bors-servo
59a3544279 Auto merge of #8991 - nox:clean-construct-hook, r=frewsxcv
Merge CGClassConstructHook and CGClassNameConstructHook (fixes #8934)

Fixes #8934.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8991)
<!-- Reviewable:end -->
2015-12-16 05:13:50 +05:30
Alan Jeffrey
348a68fe2c Bump string_cache version to 0.2.5.
Atom::to_lower_case() now returns an Atom rather than a String,
so there are a few asserts that need a different collection of &s and *s.
2015-12-15 17:00:36 -06:00
Anthony Ramine
561fdbb150 Merge CGClassConstructHook and CGClassNameConstructHook (fixes #8934) 2015-12-15 23:55:06 +01:00
Anthony Ramine
c1718a0b1f Update WebIDL parser 2015-12-15 23:24:16 +01:00
Anthony Ramine
06947965b1 Remove all our local patches to the WebIDL parser
All the tweaks we need can just be made through Configuration.py, and
[Abstract] is being submitted upstream by Ms2ger.
2015-12-15 23:06:35 +01:00
Guillaume Gomez
14a22953dd Fix invalid returned value for dictionary types 2015-12-15 18:26:35 +01:00
GauriGNaik
fc81276c8e Add pipeline information to CSS error reporting. 2015-12-14 11:18:30 -05:00
bors-servo
6032f8225b Auto merge of #8963 - Aesthetikx:unforgeable-istrusted, r=jdm
Make Event's isTrusted attribute unforgeable

Three failure expectations were able to be removed from `tests/wpt/web-platform-tests/dom/interfaces.html`. This is my first commit to servo and my first time with rust, hopefully I didn't overlook anything.

Fixes #8956.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8963)
<!-- Reviewable:end -->
2015-12-14 17:43:15 +05:30
bors-servo
201b5c9820 Auto merge of #8966 - GuillaumeGomez:patch-1, r=nox
Fix invalid dictionary inheritance

Needed by #8882.

cc @nox

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8966)
<!-- Reviewable:end -->
2015-12-14 17:08:23 +05:30
bors-servo
1d7f296fb8 Auto merge of #8955 - askobara:docs-htmlformelement-get_form_dataset, r=waffles
Add comments for the "Constructing the form data set" algorithm

Fixes #7852

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8955)
<!-- Reviewable:end -->
2015-12-14 14:01:25 +05:30
bors-servo
cbd2c9560b Auto merge of #8964 - nox:replacewith, r=frewsxcv
Fix Node::replace_with

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8964)
<!-- Reviewable:end -->
2015-12-14 10:44:21 +05:30
bors-servo
89d9aad1e1 Auto merge of #8761 - dzbarsky:gl_functions, r=dzbarsky
Implement some more WebGL functions

r? @ecoal95

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8761)
<!-- Reviewable:end -->
2015-12-14 08:25:20 +05:30
Arthur Skobara
8d2f9fc586 Add comments for the "Constructing the form data set" algorithm 2015-12-14 08:37:30 +06:00
David Zbarsky
0f4d6d58aa Implement various WebGL functions 2015-12-13 17:39:20 -08:00
Guillaume Gomez
4c99a85c73 Fix invalid dictionary inheritance 2015-12-14 00:53:21 +01:00
Anthony Ramine
748dfdf575 Fix Node::replace_with 2015-12-14 00:13:56 +01:00
John DeSilva
f244a7075c Make Event's isTrusted attribute unforgeable 2015-12-13 12:27:05 -05:00
bors-servo
8bab1cd7a4 Auto merge of #8854 - KiChjang:undefined-as-missing, r=frewsxcv
Treat 'undefined' passed to optional JS arguments as missing

@frewsxcv please don't hurt me for this.

I've added an AND condition to check whether the value being passed is undefined while checking whether the argument exists at all. Essentially, this is now treating undefined arguments the same as missing arguments.

Fixes #8813.
Fixes #6558.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8854)
<!-- Reviewable:end -->
2015-12-13 10:41:56 +05:30
Keith Yeung
db92a8b030 Treat undefined arguments in JS as missing 2015-12-12 21:13:29 -08:00
Arthur Skobara
8acb21a594 Remove from Trusted::new an unnecessary argument 2015-12-12 22:31:19 +06:00
bors-servo
f4783a0ec3 Auto merge of #8942 - Ms2ger:rename-bc, r=nox
Rename the browsercontext module.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8942)
<!-- Reviewable:end -->
2015-12-12 14:18:25 +05:30
Ms2ger
70653bfe08 Remove unused imports. 2015-12-12 02:13:59 -05:00
Ms2ger
b7b5c79787 Rename the browsercontext module. 2015-12-11 15:27:27 -05:00
bors-servo
2a416e77a8 Auto merge of #8935 - Ms2ger:get_or_create, r=Manishearth
Avoid some rooting in parsing.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8935)
<!-- Reviewable:end -->
2015-12-12 01:38:49 +05:30
bors-servo
99fd946130 Auto merge of #8930 - frewsxcv:event-type-atom, r=nox
Pass around event types as Atoms instead of Strings

`Event` internally stores the `type` as an `Atom`, and we're `String`s
everywhere, which can cause unnecessary allocations to occur since
they'll end up as `Atom`s anyways.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8930)
<!-- Reviewable:end -->
2015-12-11 21:12:35 +05:30
Ms2ger
14acf1616e Avoid some rooting in parsing. 2015-12-11 09:40:17 -05:00
bors-servo
e71ec40462 Auto merge of #8918 - Ms2ger:trace, r=nox
Initialize the slots of global objects before a possible GC.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8918)
<!-- Reviewable:end -->
2015-12-11 11:21:55 +05:30
Corey Farwell
4accaf50b2 Pass around event types as Atoms instead of Strings
`Event` internally stores the `type` as an `Atom`, and we're `String`s
everywhere, which can cause unnecessary allocations to occur since
they'll end up as `Atom`s anyways.
2015-12-10 23:47:25 -05:00
bors-servo
0abddae49d Auto merge of #8926 - frewsxcv:no-map, r=SimonSapin
Prefer 'if let' over 'map() with side effects'

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8926)
<!-- Reviewable:end -->
2015-12-11 06:53:36 +05:30
Corey Farwell
6952d256d4 Prefer 'if let' over 'map() with side effects' 2015-12-10 19:23:07 -05:00
Tetsuharu OHZEKI
e8c12c1c6d Fix warnings: Use Vec.extend_from_slice instead of Vec.push_all 2015-12-10 16:49:29 -05:00
Ms2ger
b353d70f44 Initialize the slots of global objects before a possible GC. 2015-12-10 12:08:42 -05:00
bors-servo
7438bc0425 Auto merge of #8909 - cnaj:msg_refactoring, r=jdm
Move ScriptMsg to script_traits crate, Fixes #8833

Review of documentation that was missing needed.

Fixes #8833.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8909)
<!-- Reviewable:end -->
2015-12-10 11:24:44 +05:30
Jitendra Jain
88e6504e0a Implement responseXML API and document response type for XHR 2015-12-09 17:48:04 -05:00
Tomas Cernaj
5507be2653 Move ScriptMsg from msg crate into script_traits 2015-12-09 20:50:11 +01:00
bors-servo
951ab565d1 Auto merge of #8867 - nfallen:6638-websocket_loader, r=jdm
Move websocket creation to resource task

This is a pull request for part of https://github.com/servo/servo/issues/6638

It includes the following changes:
-The websocket networking code (ie. making a connection, receiving data, and sending data) has been extracted out of components/script/dom/websocket.rs and into the new file components/net/websocket_loader.rs.
-websocket.rs now communicates with the resource task (components/net/resource_task.rs) to instruct it to initiate a new websocket connection
- websocket_loader.rs now provides an API sent over an IPCChannel that allows websocket.rs to receive feedback about this process and to subsequently send and receive data

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8867)
<!-- Reviewable:end -->
2015-12-08 20:40:50 +05:30
Nova Fallen
e8c8277f34 move websocket creation to resource task 2015-12-08 02:04:40 -05:00
bors-servo
59029325c0 Auto merge of #8827 - jdm:debugmozjscrash, r=Ms2ger
Avoid a null-dereference using debug mozjs builds. This matches the e…

…quivalent code upstream in Gecko.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8827)
<!-- Reviewable:end -->
2015-12-08 12:11:53 +05:30
bors-servo
9cccd34bc4 Auto merge of #8876 - ecoal95:webgl-nits, r=jdm
WebGL nits

This improves support for running our triangle test (see: https://github.com/servo/servo/pull/8831), and adds missing error in `BufferSubData`

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8876)
<!-- Reviewable:end -->
2015-12-08 03:56:52 +05:30
Josh Matthews
30d1ff6abc Avoid a null-dereference using debug mozjs builds. This matches the equivalent code upstream in Gecko. 2015-12-07 14:58:00 -05:00