Commit graph

6640 commits

Author SHA1 Message Date
bors-servo
132ade0fce auto merge of #3517 : glennw/servo/revert-res-change, r=metajack
...FBO."

This reverts commit c74798bb6b.
2014-09-28 19:42:27 -06:00
Glenn Watson
e237519fdd Revert "Set default resolution to 1280x1024 now that reftests render to FBO."
This reverts commit c74798bb6b.
2014-09-29 10:10:37 +10:00
bors-servo
18b35faffe Merge pull request #3514 from glennw/gdb-helper
Fix gdb helper for Au printer

Reviewed-by: metajack
2014-09-28 18:09:30 -06:00
bors-servo
276ca5f2e9 Merge pull request #3513 from glennw/default-res
Set default resolution to 1280x1024 now that reftests render to FBO.

Reviewed-by: metajack
2014-09-28 17:42:31 -06:00
Glenn Watson
bc06e27fe2 Add some vertical align reftests now that text elements get correct vertical align property. 2014-09-29 08:05:30 +10:00
Glenn Watson
370b1a2d72 Fix gdb helper for Au printer 2014-09-29 07:55:51 +10:00
Glenn Watson
c74798bb6b Set default resolution to 1280x1024 now that reftests render to FBO. 2014-09-29 07:42:45 +10:00
bors-servo
6184c13f95 Merge pull request #3509 from Ms2ger/indentation-iframe
Fix indentation in is_htmliframeelement.

Reviewed-by: jdm
2014-09-28 07:45:27 -06:00
Ms2ger
652a867800 Fix indentation in is_htmliframeelement. 2014-09-28 15:10:44 +02:00
bors-servo
42205675b3 Merge pull request #3508 from wenderen/JSTraceable.key
trace keys as well

Reviewed-by: Manishearth
2014-09-27 23:21:28 -06:00
Rohan Prinja
e50e704f5a trace keys as well 2014-09-28 09:44:43 +05:30
bors-servo
089d1fbd16 Merge pull request #3506 from metajack/fix-doc-build
Fix the doc build step.

Reviewed-by: SimonSapin
2014-09-27 18:24:28 -06:00
bors-servo
c9c8d63727 Merge pull request #3501 from zwarich/telement-lifetimes
Remove the 'static lifetime parameters from TElement methods

Reviewed-by: jdm
2014-09-27 17:09:28 -06:00
Jack Moffitt
3d0ae07d77 Fix the doc build step. 2014-09-27 16:17:11 -06:00
bors-servo
1b5fac5bde Merge pull request #3503 from Ms2ger/page-url
Simplify the Page URL handling in handle_resize_inactive_msg.

Reviewed-by: jdm
2014-09-27 13:39:27 -06:00
bors-servo
b7345796bc Merge pull request #3498 from pcwalton/border-box-double-counting
Stop double-counting stuff in inline-block

Reviewed-by: glennw
2014-09-27 13:12:30 -06:00
bors-servo
c10948736f Merge pull request #3497 from zwarich/extended-deref
Add an extended_deref method to JSRef

Reviewed-by: Manishearth
2014-09-27 12:48:30 -06:00
bors-servo
6fb8eb32f2 Merge pull request #3474 from glennw/reftest-fbo
When rendering to PNG, draw to an FBO rather than default framebuffer.

Reviewed-by: mrobinson
2014-09-27 12:21:31 -06:00
Cameron Zwarich
b2a3519011 Remove the 'static lifetime parameters from TElement methods
This improves the static correctness of layout's use of DOM nodes.

Fixes #2595.
2014-09-27 11:14:10 -07:00
Cameron Zwarich
bf025e9b9b Refine a lifetime parameter 2014-09-27 11:14:10 -07:00
Cameron Zwarich
61ae80e186 Add an extra lifetime parameter to TElement / TNode
This isn't used for anything yet, but it's easier to propagate this
change in a separate commit.
2014-09-27 11:14:10 -07:00
Patrick Walton
690bf079f7 layout: Refactor a few things, mostly just to obey the line limit. 2014-09-27 06:07:58 -07:00
Patrick Walton
fb5952fed0 layout: Don't double-count padding, etc, and don't draw
backgrounds/borders/etc. twice for inline-blocks.

Improves Reddit, GitHub, and many other sites.
2014-09-27 06:07:58 -07:00
Ms2ger
a12f2b9f06 Simplify the Page URL handling in handle_resize_inactive_msg.
This also makes it more obvious what's actually happening.
2014-09-27 13:56:33 +02:00
bors-servo
a2220f1ea4 Merge pull request #3499 from pcwalton/ua-fixes
style: Tweak the UA style a little bit.

Reviewed-by: SimonSapin
2014-09-27 03:03:31 -06:00
bors-servo
f7e5d29518 Merge pull request #3500 from glennw/warning-fix
Fix some mutable variable warnings.

Reviewed-by: pcwalton
2014-09-26 23:09:31 -06:00
Glenn Watson
15e1e5e43f Fix some mutable variable warnings. 2014-09-27 15:04:40 +10:00
bors-servo
33e2a7b362 Merge pull request #3492 from pcwalton/clear-generated-content-table
layout: Support any `display` property in generated content, and allow

Reviewed-by: glennw
2014-09-26 22:24:32 -06:00
bors-servo
94b7c486b1 Merge pull request #3486 from glennw/inline-fixes
Improve acid2. Fix line height calculation. Text fragments get correct enclosing element style.

Reviewed-by: pcwalton
2014-09-26 21:57:35 -06:00
Glenn Watson
71758643dc Remove unneeded clones and add some comments. 2014-09-27 13:51:10 +10:00
Patrick Walton
0a0e73b21f style: Tweak the UA style a little bit. 2014-09-26 20:44:41 -07:00
bors-servo
a35212410a Merge pull request #3496 from zwarich/disabled-state-helpers-jsref
Convert &JSRef -> JSRef in DisabledStateHelpers

Reviewed-by: jdm
2014-09-26 20:24:33 -06:00
bors-servo
86eec63a02 Merge pull request #3493 from zwarich/root-lifetimes
Improve the correctness of Root lifetimes

Reviewed-by: jdm
2014-09-26 19:57:33 -06:00
Cameron Zwarich
bad7915914 Make the DocumentHelpers trait use extended_deref 2014-09-26 18:38:58 -07:00
Cameron Zwarich
2789750f66 Make the AttrHelpers trait use extended_deref 2014-09-26 18:38:36 -07:00
Cameron Zwarich
8334942d0c Add an extended_deref method to JSRef
The extended_deref method will take a JSRef<'a, T> and produce an &'a T,
in contrast to the standard deref method that takes an &'b JSRef<'a, T>
and produces an &'a T. This is useful when avoiding passing a JSRef by
reference.
2014-09-26 18:37:26 -07:00
bors-servo
39b6bd9b95 Merge pull request #3489 from ProgramFOX/issue2242-2
Made some DOM fields private.

Reviewed-by: jdm
2014-09-26 19:30:33 -06:00
bors-servo
1e5770a138 Merge pull request #3432 from gilles-leblanc/issue-3361
Handle dynamic addition of attributes

Reviewed-by: jdm
2014-09-26 19:00:35 -06:00
bors-servo
1da014a13d Merge pull request #3495 from zwarich/private-node-helpers-jsref
Convert &JSRef -> JSRef for the PrivateNodeHelpers trait

Reviewed-by: jdm
2014-09-26 18:36:38 -06:00
Gilles Leblanc
8e77422d8e Handle dynamic addition of attributes
Handles dynamic addition of attributes to <link rel=stylesheet>
elements.

Fixes #3361
2014-09-26 19:04:32 -04:00
bors-servo
ecfa1a9040 Merge pull request #3494 from SimonSapin/flake8
Fix /python/servo code formatting.

Reviewed-by: larsbergstrom
2014-09-26 17:03:41 -06:00
Cameron Zwarich
4bf2a88ae2 Convert &JSRef -> JSRef in DisabledStateHelpers 2014-09-26 15:58:36 -07:00
Cameron Zwarich
4f32d54fd8 Convert &JSRef -> JSRef for the PrivateNodeHelpers trait 2014-09-26 15:46:37 -07:00
Simon Sapin
cd45258bf3 Fix /python/servo code formatting.
(My editor screams at me for flake8 lint errors.)
2014-09-26 23:12:51 +01:00
Cameron Zwarich
78f061ee54 Improve the correctness of Root lifetimes
Use the new lifetime bounds feature of Rust to enforce that the
RootCollection field of Root outlives the jsref field. This still
doesn't enforce that the Root itself outlives the jsref field, and
doing this would require some sort of init dance.
2014-09-26 14:25:43 -07:00
Patrick Walton
47fc64052c layout: Support any display property in generated content, and allow
tables to clear floats.

Improves the GitHub header.
2014-09-26 14:09:25 -07:00
ProgramFOX
71a05a9c39 Made some DOM fields private.
Relevant to #2242.
2014-09-26 20:35:01 +02:00
Glenn Watson
26cf00ef4e Don't render backgrounds for text fragments. 2014-09-26 18:28:40 +10:00
bors-servo
ab17d31bbf Merge pull request #3483 from pcwalton/block-formatting-contexts-containing-floats
layout: Block formatting contexts should contain all their floats.

Reviewed-by: glennw
2014-09-26 01:42:27 -06:00
Patrick Walton
36f3f5a0ab layout: Block formatting contexts should contain all their floats.
Improves Pinterest considerably.
2014-09-26 00:39:07 -07:00