Commit graph

14291 commits

Author SHA1 Message Date
Corey Farwell
a7c470de09 Simplify iterating over Element attributes 2015-11-10 21:42:48 -05:00
bors-servo
fd5540df62 Auto merge of #8453 - frewsxcv:atoms, r=jdm
Prefer Atoms over strs for comparison

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8453)
<!-- Reviewable:end -->
2015-11-11 06:55:39 +05:30
bors-servo
df81cd7ce9 Auto merge of #8168 - benschulz:xhr-timeout-ordering, r=jdm
XHR timeouts use same abstraction as scripts timers. (fixes #3396)

Alright, this is it. Finally the fix for #3396. :D

I'll add two comments via reviewable in a second.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8168)
<!-- Reviewable:end -->
2015-11-11 06:08:28 +05:30
Lars Bergstrom
d3277ae57a Disable zipalign until we have stable builder automation to install and locate it 2015-11-10 18:30:26 -06:00
benshu
d27a3244f2 XHR timeouts use same abstraction as scripts timers. (fixes #3396) 2015-11-11 00:52:34 +01:00
bors-servo
532f9a053a Auto merge of #8256 - notriddle:master, r=eefriedman
Write reflow results, even with no root node.

Fixes #8240

Test in w3c/csswg-test#928.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8256)
<!-- Reviewable:end -->
2015-11-11 04:49:49 +05:30
Michael Howell
d32a2d6cfc Write reflow results, even with no root node.
Fixes #8240
2015-11-10 15:01:46 -07:00
bors-servo
13226f8472 Auto merge of #8381 - bholley:attr_restyle_hints, r=pcwalton
Implement attribute restyle hints

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8381)
<!-- Reviewable:end -->
2015-11-11 01:27:45 +05:30
Bobby Holley
5d859568cf Update test expectations. 2015-11-10 11:57:27 -08:00
Bobby Holley
a79f6e43a0 Tests. 2015-11-10 11:57:26 -08:00
Bobby Holley
b29369296c Add ::from_layout_js factory to LayoutNode, LayoutElement, and LayoutDocument. 2015-11-10 11:57:25 -08:00
Bobby Holley
7fa7936657 Implement attribute restyle hints.
Fixes #6942.
2015-11-10 11:57:24 -08:00
Bobby Holley
47744d95ad Make RESTYLE_SELF imply RESTYLE_DESCENDANTS.
This is a temporary workaround for #8438.
2015-11-10 11:41:28 -08:00
bors-servo
8e80e38c78 Auto merge of #8456 - mrobinson:wpt-fixes, r=jgraham
Fix some issues with the WPT UI output

When running in non-interactive mode, print test names as they are run.
This prevent timeouts on the bots, which are detected by watching for
output from the test runner.

When running in iTerm.app don't use the multi-line status line, as the
carriage return is not processed properly. Instead use a single-line
output with the last test run and then backspace characters to keep it
up to date.

Fixes #8368.
Fixes #8395.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8456)
<!-- Reviewable:end -->
2015-11-10 22:32:03 +05:30
Martin Robinson
75f8963d63 Fix some issues with the WPT UI output
When running in non-interactive mode, print test names as they are run.
This prevent timeouts on the bots, which are detected by watching for
output from the test runner.

When running in iTerm.app don't use the multi-line status line, as the
carriage return is not processed properly. Instead use a single-line
output with the last test run and then backspace characters to keep it
up to date.

Fixes #8368.
Fixes #8395.
2015-11-10 08:24:50 -08:00
Corey Farwell
55477eb618 Prefer Atoms over strs for comparison 2015-11-10 08:58:57 -05:00
bors-servo
fb00e6143f Auto merge of #8452 - Ms2ger:test-ref, r=frewsxcv
Use wptrunner for some old-style reftests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8452)
<!-- Reviewable:end -->
2015-11-10 19:27:18 +05:30
bors-servo
6772461002 Auto merge of #8451 - Ms2ger:tidy-sync, r=frewsxcv
Ignore sync directories in test-tidy.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8451)
<!-- Reviewable:end -->
2015-11-10 18:44:20 +05:30
Ms2ger
866eb0551e Move jpeg_normal.html and jpeg_progressive.html to wpt reftests. 2015-11-10 14:03:33 +01:00
Ms2ger
eb882403fb Move inset_blackborder.html and outset_blackborder.html to wpt reftests. 2015-11-10 12:35:01 +01:00
Ms2ger
17cdd1769d Move input_height_a.html to wpt reftests. 2015-11-10 12:25:47 +01:00
Ms2ger
17376dd96b Move inline_whitespace_a.html and inline_whitespace_b.html to wpt reftests. 2015-11-10 12:15:38 +01:00
Ms2ger
3ed4e62057 Move inline_block_parent_width.html and inline_block_parent_width_percentage.html to wpt reftests. 2015-11-10 11:36:54 +01:00
Ms2ger
cfbe639e79 Move inline_block_margin_auto_a.html to wpt reftests. 2015-11-10 11:23:39 +01:00
Ms2ger
7d376bfe81 Move inline_background_a.html to wpt reftests. 2015-11-10 11:16:10 +01:00
Ms2ger
026994e4be Ignore sync directories in test-tidy. 2015-11-10 10:29:26 +01:00
bors-servo
81f094b129 Auto merge of #8447 - frewsxcv:htmltableelement-width-idl-attribute, r=eefriedman
Implement 'width' IDL attribute on <table>

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8447)
<!-- Reviewable:end -->
2015-11-10 12:54:30 +05:30
bors-servo
32a91bc656 Auto merge of #8444 - rilut:patch-2, r=frewsxcv
refactor(htmlhrelement.rs): color setter now uses macro

Changed the function in #L44-47 to a macro usage. Fixes #8433.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8444)
<!-- Reviewable:end -->
2015-11-10 12:12:25 +05:30
Bobby Holley
c9704992a9 Factor the name-related fields of Attr into a struct and move it to style. 2015-11-09 21:40:22 -08:00
Bobby Holley
488c1291d4 Hoist AttrValue into style. 2015-11-09 21:40:22 -08:00
Corey Farwell
575b3c3d4b Implement 'width' IDL attribute on <table> 2015-11-09 23:31:25 -05:00
bors-servo
cff9173208 Auto merge of #8442 - rilut:patch-1, r=Manishearth
refactor(devtools/lib.rs): Remove unused import

Removed `RecvError` imports from #L57. Fixes #8442.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8442)
<!-- Reviewable:end -->
2015-11-10 09:35:53 +05:30
bors-servo
4ec96963f8 Auto merge of #8440 - mbrubeck:range-unused, r=Manishearth
Remove unused method from Range

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8440)
<!-- Reviewable:end -->
2015-11-10 08:43:59 +05:30
bors-servo
cd6813ea39 Auto merge of #8434 - frewsxcv:dimension-attrvalue, r=eefriedman
Add Dimension member to AttrValue

Fixes #8417

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8434)
<!-- Reviewable:end -->
2015-11-10 08:15:37 +05:30
Rizky Luthfianto
d0d2a64628 refactor(htmlhrelement.rs): color setter now uses macro
Changed the function in #L44-47 to a macro usage
2015-11-10 09:31:38 +07:00
bors-servo
0d21158eb3 Auto merge of #8378 - Ms2ger:rwdata, r=eefriedman
Reduce LayoutTaskData to the fields used for RPC.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8378)
<!-- Reviewable:end -->
2015-11-10 07:47:45 +05:30
Rizky Luthfianto
df02ed4050 refactor(devtools/lib.rs): Remove unused import
Removed `RecvError` imports from #L57
2015-11-10 09:07:25 +07:00
Matt Brubeck
603fb5e1c2 Remove unused method from Range 2015-11-09 17:47:08 -08:00
Corey Farwell
71aa2392f8 Remove HTMLTableElement::width struct field 2015-11-09 20:35:29 -05:00
Corey Farwell
73314ab10c Add Dimension member to AttrValue
Fixes #8417
2015-11-09 20:32:56 -05:00
bors-servo
b386008623 Auto merge of #8431 - eefriedman:table-bgcolor, r=frewsxcv
Move storage of bgcolor for `<tr>` and `<tbody>`.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8431)
<!-- Reviewable:end -->
2015-11-10 06:58:16 +05:30
bors-servo
aa62cc74d3 Auto merge of #8432 - rnestler:refactor_loops, r=frewsxcv
Refactor some loop{} to while let{}

I searched for some similar cases like in #8384 and tried to refactor them as well.
@frewsxcv Care to review?

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8432)
<!-- Reviewable:end -->
2015-11-10 04:33:23 +05:30
Raphael Nestler
98d70aec3c Use while let{} instead of loop{match{}} in run_server() 2015-11-09 23:32:00 +01:00
Raphael Nestler
004ed44755 Use while let{} instead of loop{match{}} in TimerScheduler::run_event_loop() 2015-11-09 23:31:59 +01:00
Eli Friedman
4b68fc18c3 Move storage of bgcolor for <tr> and <tbody>. 2015-11-09 12:27:16 -08:00
bors-servo
f39faaf994 Auto merge of #8227 - asajeffrey:versioned_dom, r=eefriedman
Versioned dom

This PR adds versioning to the DOM. There are now node.get_version and node.get_descendent_version methods that return a counter that is bumped when the node is dirtied. This is used to implement cache invalidation for caching HTMLCollection state. Caching HTMCollections gets a 1000x speedup in the Dromaeo DOM query tests.

Addresses https://github.com/servo/servo/issues/6901, https://github.com/servo/servo/issues/3381 and https://github.com/servo/servo/issues/1916.

Replaces PR https://github.com/servo/servo/pull/6927.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8227)
<!-- Reviewable:end -->
2015-11-10 01:11:23 +05:30
bors-servo
d8df028197 Auto merge of #8404 - eefriedman:misc-attributes, r=nox
Misc cleanup for DOM attributes

No functional change; just cleanups related to parsing attributes.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8404)
<!-- Reviewable:end -->
2015-11-10 00:32:24 +05:30
Eli Friedman
af78173243 Move more unsafe layout calls onto LayoutJS. 2015-11-09 10:47:38 -08:00
Eli Friedman
5293afc122 Move unsafe layout calls onto LayoutJS. 2015-11-09 10:47:37 -08:00
bors-servo
5fda719fa8 Auto merge of #8415 - mrobinson:create-wpt-relative, r=frewsxcv
Form relative reference URLs during create-wpt

Instead of always using the absolute path to the reference file when
creating new reference tests, create-wpt now creates relative URLs if
the files are in the same directory. This is the most common case for
new Servo tests. Also fix some missing quotation marks in the
create-wpt template.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8415)
<!-- Reviewable:end -->
2015-11-09 22:43:25 +05:30