Commit graph

311 commits

Author SHA1 Message Date
Pierre Chevalier
d2481c37d5 Refactor away unnecessary use of regex
We don't need regex matching since ": &Vec<" doesn't
contain any special character.

New code reads better.

Fixes #7914.
2015-10-09 16:43:26 +01:00
Matt Brubeck
d5f883ee45 Upgrade to latest mach from mozilla-central 2015-10-02 15:52:07 -07:00
Martin Robinson
f64a960ab1 Make Linux build notifications transient
Continuous non-transient notifications, common in workflows involving
many syntax errors, can completely take over the message tray. Making
Linux build notifications transient prevents them from stacking up in
Gnome Shell without having to click them individually.
2015-10-01 17:43:40 -07:00
bors-servo
ba2714f4f6 Auto merge of #7813 - servo:parallel-unit-tests, r=mbrubeck
Run all unit tests with just one Cargo command.

Upgrade Cargo to get https://github.com/rust-lang/cargo/pull/1828, and use it for unit tests. This allows Cargo to get some more parallelism when compiling the test crates’ dependencies.

`touch components/util/lib.rs && mach test-unit` on my machine goes from 149 seconds to 124.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7813)
<!-- Reviewable:end -->
2015-10-01 12:39:10 -06:00
Simon Sapin
9228b5011d Run all unit tests with just one Cargo command.
Upgrade Cargo to get https://github.com/rust-lang/cargo/pull/1828,
and use it for unit tests.
This allows Cargo to get some more parallelism
when compiling the test crates’ dependencies.

`touch components/util/lib.rs && mach test-unit` on my machine
goes from 149 seconds to 124.
2015-10-01 17:59:18 +02:00
Matt Brubeck
ab68d51eda Fixes for mach test-ref argument handling
* Change parameter from `name` to `include`. This is consistent with other
  test suites, and also fixes a bug in `mach test` caused by a conflicting
  keyword parameter in `Registrar.dispatch`.
* Allow any number of `include` arguments.
2015-10-01 08:54:18 -07:00
bors-servo
5d04f8dc8e Auto merge of #7809 - 6112:master, r=frewsxcv
Make `./mach test` work with unit tests

Fixes #7618.

Allows running a specific Rust test with one of:

```
./mach test tests/unit/net/http_loader.rs

./mach test-unit tests/unit/net/http_loader.rs
./mach test-unit tests/unit/net/http_loader
./mach test-unit net/http_loader
```

Allows running a whole package's tests with one of:

```
./mach test tests/unit/net

./mach test-unit tests/unit/net
```

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7809)
<!-- Reviewable:end -->
2015-09-30 20:30:26 -06:00
Nicolas
a844ce74f9 Allow ./mach test and ./mach test-unit to run unit tests with file path 2015-09-30 20:23:52 -04:00
bors-servo
4e749eb714 Auto merge of #7790 - frewsxcv:expand-python-executable-names, r=mbrubeck
Expand list of Python executable names to search in PATH

Fixes #7784

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7790)
<!-- Reviewable:end -->
2015-09-29 20:26:14 -06:00
bors-servo
9a4eb565c4 Auto merge of #7789 - 6112:master, r=mbrubeck
allow `./mach test` to run tests in tests/wpt/mozilla/

Allows running WPT tests in the tests/wpt/mozilla/ directory by using commands such as: 

```
./mach test tests/wpt/mozilla/tests/mozilla/union.html
```

Fixes #7772.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7789)
<!-- Reviewable:end -->
2015-09-29 19:58:28 -06:00
bors-servo
2049357d14 Auto merge of #7759 - jdramani:cmp_dromaeo_output_tool, r=mbrubeck
Add a tool for comparing Dromaeo outputs



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7759)
<!-- Reviewable:end -->
2015-09-29 18:58:28 -06:00
Corey Farwell
1a9263c2b4 Expand list of Python executable names to search in PATH
Fixes #7784
2015-09-29 18:13:43 -04:00
Nicolas
a3eee70727 allow ./mach test to run tests in tests/wpt/mozilla/ 2015-09-29 17:27:04 -04:00
Matt Brubeck
aa7e9ddb73 Fix build notifications in Python 2.x on Linux
In Python 2.x on Linux, `sys.platform == 'linux2'`.

https://docs.python.org/2/library/sys.html#sys.platform
2015-09-28 10:01:29 -07:00
Jaydeep
19be6f9f8e fix issue#6888 2015-09-27 10:18:15 -07:00
bors-servo
9523283c14 Auto merge of #7643 - jdramani:extra_ptr_dref, r=jdm
Check for Extra pointer dereferencing

Solves issue #7640

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7643)
<!-- Reviewable:end -->
2015-09-27 08:19:30 -06:00
Jaydeep
2a99915188 Check for Extra pointer dereferencing. Issue #7640. 2015-09-26 19:33:29 -07:00
Tamir Duberstein
b6bbd75479 mach: fix OS X notifications 2015-09-26 16:14:45 -04:00
bors-servo
83435d7765 Auto merge of #7716 - servo:host-triple-assign, r=Manishearth
Fix a comparison that should be an assignment in host_triple().



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7716)
<!-- Reviewable:end -->
2015-09-23 07:39:50 -06:00
bors-servo
8f1469eb08 Auto merge of #7692 - ddrmanxbxfr:TidyMaxLineOver120, r=nox
Raise max length error over 120 chars not at 120 chars. python/tidy.py

This is a follow up of issue : Tidy has an off-by-one error #7686 

It allows to raise the max length error when line is over than 120 not at 120 specifically.

Thanks for looking into it.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7692)
<!-- Reviewable:end -->
2015-09-23 04:17:16 -06:00
Ms2ger
65e50be657 Fix a comparison that should be an assignment in host_triple(). 2015-09-23 09:40:08 +02:00
Mathieu Rheaume
705d8f7a1c Raise max length error over 120 chars not at 120 chars. python/tidy.py 2015-09-21 22:25:32 -04:00
bors-servo
44de9173cc Auto merge of #7678 - AnthonyBroadCrawford:improved-error-messaging-mach-bootstrap, r=frewsxcv
#7630 Adding better error messaging in mach bootstrap for missing virtualenv/pip dependencies 

This PR is in reference to #7630 

I've added a simple try catch around our use of subprocess.check_all when trying to invoke and use python's 

- virtualenv 
- pip

Upon failure, I use sys.exit with an error message for the user.  Exit seemed appropriate as anything beneath those dependencies will fail to execute and result in a non friendly error message

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7678)
<!-- Reviewable:end -->
2015-09-21 18:13:35 -06:00
Anthony Broad-Crawford
2e0e2288ed Added error handling and improved error messaging when running mach without python's virtualenv or pip installed 2015-09-21 13:38:30 -05:00
Brandon Fairchild
e924393be8 tidy.py: Check for import blocks separated by whitespace
This enables flagging multiple import blocks separated by whitespace
as errors.

Fixes #7381.
2015-09-19 12:46:01 -04:00
Hugo Thiessard
e81e91207c fixes #7390 : tidy now check the order of mod declarations even whith attribute 2015-09-18 21:32:00 +02:00
Aidan Hobson Sayers
9737b2375e Create a marker file to avoid running pip when possible 2015-09-14 20:55:22 +01:00
bors-servo
3a97455a65 Auto merge of #7570 - jxs:ignore_length_tidy_script, r=Ms2ger
ignore length on .lock files on tidy.py,

closes #7569

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7570)
<!-- Reviewable:end -->
2015-09-11 03:07:34 -06:00
João Oliveira
b9ffb80b7c ignore length on .lock files on tidy.py,
closes #7569
2015-09-09 14:02:43 +01:00
bors-servo
8397219660 Auto merge of #7568 - frewsxcv:os-agnostic-paths, r=jdm
Use OS-agnostic filesystem paths in Python

This will eventually need to be done for #1908

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7568)
<!-- Reviewable:end -->
2015-09-08 22:29:04 -06:00
bors-servo
2733060564 Auto merge of #7565 - akiss77:config-gold, r=SimonSapin
Make the use of gold linker configurable

Currently, ld.gold is always used for linking if found on the
system. There are some cases however when one may want to opt out
from using it. This patch adds the boolean field `rustc-with-gold`
to the `[tools]` section of `.servobuild`, which if set false,
disables the use of ld.gold.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7565)
<!-- Reviewable:end -->
2015-09-08 13:57:13 -06:00
Corey Farwell
244af42d89 Use OS-agnostic filesystem paths in Python
This will eventually need to be done for #1908
2015-09-08 21:16:02 +02:00
Akos Kiss
9afa930728 Make the use of gold linker configurable
Currently, ld.gold is always used for linking if found on the
system. There are some cases however when one may want to opt out
from using it. This patch adds the boolean field `rustc-with-gold`
to the `[tools]` section of `.servobuild`, which if set false,
disables the use of ld.gold.
2015-09-08 17:10:46 +00:00
bors-servo
c442132196 Auto merge of #7494 - wilmoz:upgradeWptRunner, r=jdm
Add a mach command to upgrade wptrunner

https://github.com/servo/servo/issues/7491

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7494)
<!-- Reviewable:end -->
2015-09-08 08:41:05 -06:00
bors-servo
33063fd887 Auto merge of #7528 - jdm:updatecssfix, r=frewsxcv
Remove obsolete method call that breaks ./mach update-css.

r? @frewsxcv

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7528)
<!-- Reviewable:end -->
2015-09-02 23:29:03 -06:00
Josh Matthews
152b76b963 Remove obsolete method call that breaks ./mach update-css. 2015-09-03 00:37:44 -04:00
bors-servo
3424e234c8 Auto merge of #7499 - nerith:style, r=metajack
Improve style nit check for space after a comma

Fixes #7345.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7499)
<!-- Reviewable:end -->
2015-09-02 12:05:58 -06:00
wilmoz
adbc6d045b Add a mach command to upgrade wptrunner 2015-09-02 12:29:56 -05:00
Corey Farwell
31e57cb349 Remove references to no-longer-in-tree Python packages 2015-09-02 09:34:02 -04:00
Corey Farwell
e38df50bbf Revert "Revert "Auto merge of #7103 - frewsxcv:python-venv, r=metajack" for breaking web-platform-tests."
This reverts commit 47d6d958f5.
2015-09-02 09:34:01 -04:00
bors-servo
8b5418f58f Auto merge of #7438 - Wafflespeanut:cargo-tidy, r=jdm
Tidy can now check for version conflicts...

fixes #7133

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7438)
<!-- Reviewable:end -->
2015-09-01 14:38:48 -06:00
Brandon Fairchild
24bc6dfb52 python/tidy.py: Ignore macros in style nit check
Lines with macros were flagged as errors when checking
for space after a comma.
2015-09-01 16:25:44 -04:00
Brandon Fairchild
0bddd25805 Improve style nit check for space after a comma
Only a small number of things that followed a comma were flagged.
This improves the thoroughness of that check.

Fixes #7345.
2015-09-01 15:02:41 -04:00
Ravi Shankar
da1c8581d9 Tidy could now check for version conflicts! 2015-09-02 00:23:25 +05:30
bors-servo
15de679f11 Auto merge of #7468 - JoshTheGoldfish:Issue7460, r=jdm
Making test-tidy check that = have space after them

For issue #7460. Need to ensure compatibility with #7390.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7468)
<!-- Reviewable:end -->
2015-09-01 08:33:02 -06:00
Josh Matthews
7457dbf3fc Remove hack for android builders now that build is successful once more. 2015-09-01 09:10:25 -04:00
erneyja
17663315dd make test-tidy check that = have space after them 2015-09-01 07:18:19 -04:00
Corey Farwell
3a1d140ab5 Enforce linking to spec for method implementations via macros 2015-08-31 21:02:23 -04:00
bors-servo
7474b29510 Auto merge of #7478 - frewsxcv:spec-link-tidy-fix, r=jdm
Update spec link pattern to reflect `impl` signature changes

Relevant to #7416

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7478)
<!-- Reviewable:end -->
2015-08-31 15:48:24 -06:00
Corey Farwell
20c0af8b7d Update spec link pattern to reflect impl signature changes
Relevant to #7416
2015-08-31 17:38:23 -04:00