Ms2ger
9f91984415
Use the passed-in reflow root rather than the one stored in the SharedLayoutContext.
2015-10-26 17:51:26 +01:00
bors-servo
f6e3146de2
Auto merge of #8208 - Ms2ger:lnfuln, r=jdm
...
Return a LayoutNode with a limited lifetime from layout_node_from_unsafe_layout_node (fixes #3044 ).
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8208 )
<!-- Reviewable:end -->
2015-10-26 11:08:33 -05:00
bors-servo
2091aafcfb
Auto merge of #8206 - Ms2ger:dlb-canvas, r=jdm
...
Cleanup layout interaction with canvas elements.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8206 )
<!-- Reviewable:end -->
2015-10-26 10:27:47 -05:00
bors-servo
af8a1cb8a0
Auto merge of #8178 - frewsxcv:label, r=nox
...
Implement a couple attributes for <label> elements
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8178 )
<!-- Reviewable:end -->
2015-10-26 09:51:56 -05:00
Ms2ger
2f019f2d88
Return a LayoutNode with a limited lifetime from layout_node_from_unsafe_layout_node ( fixes #3044 ).
2015-10-26 15:03:23 +01:00
bors-servo
3a254b7e20
Auto merge of #8205 - Ms2ger:query, r=jdm
...
Return the result from query functions.
This reduces some unnecessarily tight coupling, makes it clearer what these functions do, and may help avoid bugs where we would return from such a function without updating the relevant field.
It is also a precondition for some future experimentation I'm thinking of doing with this querying design.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8205 )
<!-- Reviewable:end -->
2015-10-26 09:00:30 -05:00
bors-servo
6b95c3957b
Auto merge of #8097 - wenderen:8090-partialeq-for-mutheap, r=nox
...
implement PartialEq for MutHeap<JS<T>> and MutNullableHeap<JS<T>>
for #8090
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8097 )
<!-- Reviewable:end -->
2015-10-26 06:08:01 -05:00
Ms2ger
b1f4bf617d
Pass all the data layout needs from canvas elements at once.
2015-10-26 11:43:23 +01:00
Ms2ger
a5a4ef7d70
Only construct a channel if necessary when building a fragment for a canvas.
2015-10-26 11:22:36 +01:00
Ms2ger
68830ed66f
Return the result from process_content_box_request.
2015-10-26 10:41:51 +01:00
Ms2ger
60e60b6f8a
Return the result from process_content_boxes_request.
2015-10-26 10:41:50 +01:00
Ms2ger
a84055d8fe
Return the result from process_node_geometry_request.
2015-10-26 10:41:50 +01:00
Ms2ger
9754bfc330
Return the result from process_resolved_style_request.
2015-10-26 10:41:49 +01:00
Ms2ger
16b6e812a2
Return the result from process_offset_parent_query.
2015-10-26 10:41:48 +01:00
bors-servo
4e015b5378
Auto merge of #8203 - Ms2ger:unsafe-impl-baseflow, r=nox
...
Remove manual implementations of Send and Sync for BaseFlow.
They don't appear to be necessary.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8203 )
<!-- Reviewable:end -->
2015-10-26 03:48:19 -05:00
bors-servo
83b72e8669
Auto merge of #8204 - Ms2ger:privatize-FlowConstructionUtils, r=nox
...
Privatize FlowConstructionUtils.
This makes it match the documentation.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8204 )
<!-- Reviewable:end -->
2015-10-26 03:04:24 -05:00
Ms2ger
28f9302b38
Privatize FlowConstructionUtils.
...
This makes it match the documentation.
2015-10-26 08:52:52 +01:00
Ms2ger
c8ad7c750e
Remove manual implementations of Send and Sync for BaseFlow.
...
They don't appear to be necessary.
2015-10-26 08:47:57 +01:00
bors-servo
ec691904cc
Auto merge of #8165 - paulrouget:hackingQuickstart, r=Manishearth
...
hacking quickstart documentation
Please someone review this (content and english).
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8165 )
<!-- Reviewable:end -->
2015-10-26 00:33:41 -05:00
bors-servo
64cae0c590
Auto merge of #8196 - Ms2ger:clone-font-cache-task, r=nox
...
Remove a pointless clone() from add_font_face_rules.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8196 )
<!-- Reviewable:end -->
2015-10-25 17:58:11 -05:00
Ms2ger
4cac3f4f97
Remove a pointless clone() from add_font_face_rules.
2015-10-25 22:46:34 +01:00
bors-servo
1982ae38e3
Auto merge of #8195 - Ms2ger:update-js, r=jdm
...
Update js.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8195 )
<!-- Reviewable:end -->
2015-10-25 14:23:57 -05:00
Rohan Prinja
c1abb4fdb2
clean code as per code review
2015-10-26 03:52:05 +09:00
Ms2ger
54d3462fa5
Use the new define_methods and define_properties functions from js.
2015-10-25 19:50:10 +01:00
Ms2ger
5da7af0b14
Update js.
2015-10-25 19:49:34 +01:00
bors-servo
41df37cf1b
Auto merge of #8070 - badboy:inline-block-for-button, r=jdm
...
Move inline-block styling to user-agent and add button
First Servo PR for me. \o/
Fixes #8064
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8070 )
<!-- Reviewable:end -->
2015-10-25 12:43:00 -05:00
Jan-Erik Rediger
4153291361
Update test manifest
2015-10-25 18:38:44 +01:00
Jan-Erik Rediger
c5ecd65fec
Add reftest for css button width
2015-10-25 18:35:42 +01:00
Jan-Erik Rediger
dbe43237cc
Move inline-block styling to user-agent and add button
...
Fixes #8064
2015-10-25 18:35:42 +01:00
Axel Solis Trompler
5542f87400
Refactor document.createEvent(touchevent)
2015-10-25 16:36:16 +01:00
bors-servo
662ff9b8c2
Auto merge of #8185 - Ms2ger:white-space, r=frewsxcv
...
Correct the match urls for the white-space tests.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8185 )
<!-- Reviewable:end -->
2015-10-25 10:12:20 -05:00
bors-servo
47f6eb744f
Auto merge of #8188 - servo:jdm-patch-1, r=frewsxcv
...
Remove bad advice from WPT docs.
I misunderstood the purpose of `--no-run`.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8188 )
<!-- Reviewable:end -->
2015-10-25 09:29:32 -05:00
Josh Matthews
e843135be0
Remove bad advice from WPT docs.
...
I misunderstood the purpose of `--no-run`.
2015-10-25 09:48:35 -04:00
Corey Farwell
98a6fc07e2
Implement 'htmlFor' attribute for <label> elements
2015-10-25 08:06:44 -04:00
Corey Farwell
f97d1d148b
Implement 'control' attribute for <label> elements
2015-10-25 08:06:31 -04:00
bors-servo
4b5bc4f9a9
Auto merge of #8186 - Ms2ger:rm-clone, r=nox
...
Remove an unnecessary Atom::clone() call.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8186 )
<!-- Reviewable:end -->
2015-10-25 05:09:11 -05:00
Ms2ger
c86141c55a
Remove an unnecessary Atom::clone() call.
2015-10-25 11:08:15 +01:00
Ms2ger
f59ef17921
Correct the match urls for the white-space tests.
2015-10-25 10:37:30 +01:00
bors-servo
47a8256c2c
Auto merge of #8183 - saneyuki:matches, r=nox
...
script: Element.webkitMatchesSelector()
spec:
- 9ac9c15486
- https://github.com/whatwg/compat/issues/3
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8183 )
<!-- Reviewable:end -->
2015-10-25 02:47:30 -05:00
Tetsuharu OHZEKI
04967ed97e
script: Element.webkitMatchesSelector()
...
spec:
9ac9c15486
2015-10-25 15:27:20 +09:00
Dongie Agnir
15a8b6b62c
Mark failure for remove test as expected.
...
Currently unable to get former parent after unbind_from_tree, so it's
not possible to call ask_for_reset upon removal.
2015-10-24 19:22:03 -10:00
Dongie Agnir
d561b4ffe9
Remove extra indent.
2015-10-24 19:14:31 -10:00
Dongie Agnir
b5e991c89e
Replace if-else with match.
2015-10-24 19:10:52 -10:00
bors-servo
bb88832c07
Auto merge of #8073 - eefriedman:root-lint, r=Manishearth
...
Make unrooted_must_root a bit more aggressive.
Basically, instead of trying to check for specific kinds of statements,
just check the types of all local variables.
Also included are some commented-out proposals for some slightly more
aggressive lints which might be useful (but trigger a little too
frequently at the moment).
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8073 )
<!-- Reviewable:end -->
2015-10-24 20:20:04 -05:00
bors-servo
3b50f21963
Auto merge of #8181 - frewsxcv:no-alloc-get-element-by-id, r=nox
...
Remove unnecessary allocation with getElementById
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8181 )
<!-- Reviewable:end -->
2015-10-24 17:25:09 -05:00
Corey Farwell
48ea5959c7
Remove unnecessary allocation with getElementById
2015-10-24 17:50:42 -04:00
benshu
a3859c0726
Fixed panic in ActiveTimers.set_timeout_or_interval.
2015-10-24 11:27:59 +02:00
Gilles Leblanc
595f11dbd2
Modify wpt test following review comment
2015-10-23 20:56:52 -04:00
Gilles Leblanc
725484d619
Compute value of float according to position value
...
According to CSS2 Section 9.7, if 'position' has a value of 'absolute'
or 'fixed' the computed value of 'float' should be 'none'.
This changes the float to a single_keyword_computed which checks the
positioned value of the element to compute the float value.
Fixes #8002
2015-10-23 20:56:52 -04:00
Dongie Agnir
fcfc3918a4
Update test.
...
Fix comments and test when size > 1.
2015-10-23 14:01:58 -10:00