Commit graph

801 commits

Author SHA1 Message Date
bors-servo
f5a3d68513 Auto merge of #13930 - shinglyu:perf-llvmpipe, r=aneeshusa
Use headless rendering for performance test

<!-- Please describe your changes on the following line: -->

Properly set the software rendering environment variables and use `-z` to run the performance test in headless mode. Also changed some logging format to improve the readability and reduce log size.
---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13903 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because need manual test

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13930)

<!-- Reviewable:end -->
2016-11-07 01:24:06 -06:00
Shing Lyu
9aaa088624 Use headless rendering for performance test 2016-11-07 15:20:36 +08:00
bors-servo
dbce416ad4 Auto merge of #14025 - iamrohit7:debug-assertions, r=Wafflespeanut
Add --with-debug-assertions flag for Mach

I tested out building a release with the flag and added a `debug_assert!(false)` in `fn main` and it panicked.
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14009  (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they are manually tested

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14025)
<!-- Reviewable:end -->
2016-11-05 22:57:44 -05:00
Rohit Burra
76ec3f423a Add --with-debug-assertions flag for Mach 2016-11-05 16:02:40 +05:30
Jake Goldsborough
d302cf23bc moving datetimestamping responsiblities from mach package
to CI upload, swaps semicolons for dashes
2016-11-03 23:02:48 -07:00
bors-servo
291f393723 Auto merge of #13986 - iamrohit7:tidy-feature-attrs, r=Wafflespeanut
Make test-tidy check for alphabetical ordering of #![feature(...)] statements

<!-- Please describe your changes on the following line: -->

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #13954  (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13986)

<!-- Reviewable:end -->
2016-11-01 01:13:35 -05:00
Rohit Burra
c4cb3f345b Tests alphabetical ordering of #![feature(...)] 2016-11-01 11:35:39 +05:30
Rohit Burra
877d7166db Alphabetical order for #![feature(...)] in lib.rs 2016-11-01 11:35:32 +05:30
bors-servo
ccefef5be4 Auto merge of #13988 - dsprenkels:tidy-fncalls, r=Wafflespeanut
test-tidy: Check for space between function name and `(`

<!-- Please describe your changes on the following line: -->

Disallow an extraneous space in a function call between
the function name and the opening parenthesis in Rust
code, while ignoring macro declarations.

---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy --all` does not report any errors
- [x] `./mach test-tidy --self` does not report any errors
- [x] These changes fix #13980

<!-- Either: -->
- [x] There are tests for these changes, these are written in
 - `python/tidy/servo_tidy_tests/rust_tidy.rs`
 - `python/tidy/servo_tidy_tests/test_tidy.py`
- [ ] These changes do not require tests

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13988)

<!-- Reviewable:end -->
2016-10-31 13:03:32 -05:00
Daan Sprenkels
179e11ad8d test-tidy: Check for space between function name and (
Disallow an extraneous space in a function call between
the function name and the opening parenthesis in Rust
code, while ignoring macro declarations.

This commit fixes #13980.
2016-10-31 18:11:35 +01:00
Ms2ger
2ff0f33b2b Reinstate the wpt lint checking. 2016-10-31 15:00:59 +01:00
bors-servo
b9330151b9 Auto merge of #13945 - mmatyas:android_libcpp_change, r=larsbergstrom,aneeshusa
Update the Android build system

A huge update for the Android build system, which makes the Android target build again.

There are still some runtime issues, see #13154. CC & created by @larsbergstrom.

Fixes #12562.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13945)
<!-- Reviewable:end -->
2016-10-28 16:11:26 -05:00
Mátyás Mustoha
5bb550dbf0 Update to use the new Android library build rules. 2016-10-28 22:17:10 +02:00
bors-servo
af48de91fb Auto merge of #13558 - aneeshusa:fix-path-to-browserhtml-in-linux-runservo.sh, r=shinglyu
Fix path to browserhtml in Linux runservo.sh

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13552 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because needs to be verified manually

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13558)
<!-- Reviewable:end -->
2016-10-28 12:31:55 -05:00
Shing Lyu
303ba20648 Don't check untracked file in tidy 2016-10-28 11:41:05 +08:00
Manish Goregaokar
b0c50d8219 Fix style unit tests 2016-10-18 20:46:59 +05:30
bors-servo
80447a79c4 Auto merge of #13614 - jdm:wptrunnerup3, r=Ms2ger
Upgrade wptrunner

This gets us back to a pristine local copy and allows us to start experimenting with webdriver tests.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13614)
<!-- Reviewable:end -->
2016-10-18 08:15:11 -05:00
bors-servo
0af9be9429 Auto merge of #13432 - shinglyu:layout_viewer_clean, r=mbrubeck
Restore the layout trace viewer

<!-- Please describe your changes on the following line: -->
This patch restores the layout trace viewer removed in e7510ab90c , with some changes that makes it work with https://github.com/servo/servo/pull/13214

Sorry for the minified 3rd party CSS frameworks, it was from the original version and I haven't got time to replace them with hand-crafted CSS.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because is a stand-alone debugging tool

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13432)
<!-- Reviewable:end -->
2016-10-17 10:06:50 -05:00
Bobby Holley
eec06798be Implement ./mach test-unit --bench. 2016-10-16 22:40:19 -07:00
Shing Lyu
0cab0501f4 Restore the layout trace viewer 2016-10-17 10:58:52 +08:00
Manish Goregaokar
25342f4c9c Remove test-geckolib, run test-stylo on travis 2016-10-12 18:46:17 +05:30
Manish Goregaokar
3d7c997a4f Run bindings tests with whole crate 2016-10-12 10:00:31 +05:30
UK992
b9f39cb111 Warn and exit mach if it detects MinGW Python 2016-10-10 18:27:48 +02:00
bors-servo
dad3b4785a Auto merge of #13589 - splav:SVGElement#12974, r=pcwalton,Ms2ger
Support SVG element

<!-- Please describe your changes on the following line: -->
minimal SVG element implementation
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12974 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13589)
<!-- Reviewable:end -->
2016-10-07 17:40:13 -05:00
Alexandrov Sergey
a1fd802d65 add SVG2 draft link to WEBIDL_STANDARDS test-tidy list 2016-10-07 21:41:21 +03:00
Josh Matthews
a2bc9d7775 Avoid #12321 by creating environment before switching directories. 2016-10-06 07:45:43 -04:00
Josh Matthews
906b7b33ef Rename mach command to upgrade wptrunner and make it work more than once. 2016-10-06 07:45:43 -04:00
Lars Bergstrom
e16c7ec861 Ensure that SERVO_ENABLE_DEBUG_ASSERTIONS is also used in build-cef 2016-10-05 09:54:28 -05:00
bors-servo
19a5a30113 Auto merge of #13387 - emilio:debug-assertions, r=aneeshusa,jdm,pcwalton
Honor SERVO_ENABLE_DEBUG_ASSERTIONS on the build machines.

<!-- Please describe your changes on the following line: -->

As part of #13127.

cc @aneeshusa

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13387)
<!-- Reviewable:end -->
2016-10-04 14:01:49 -05:00
Josh Matthews
cb0709a64e Add mako to required python packages
It's required for the OSMesa build process.
2016-10-03 12:37:11 -04:00
Aneesh Agrawal
972520ddc5 Fix path to browserhtml in Linux runservo.sh 2016-10-03 09:02:30 -04:00
bors-servo
3a5fd8b49a Auto merge of #13447 - gterzian:check_webidls_folder_files, r=Wafflespeanut
Have tidy ensure that the there are no extra files in the webidls folder #13427

<!-- Please describe your changes on the following line: -->
 Have tidy ensure that the there are no extra files in the webidls folder #13427

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13427 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13447)
<!-- Reviewable:end -->
2016-10-02 12:00:36 -05:00
Emilio Cobos Álvarez
6496efd0e7
build: Honor SERVO_ENABLE_DEBUG_ASSERTIONS. 2016-10-02 17:57:06 +02:00
Gregory
62d9882185 update docs with test command 2016-10-02 14:41:03 +08:00
Gregory
1f99381720 tidy: checking directories for unexpected file extensions
update config, check_dir func to use config

pass only_changed_files and exclude_dirs as args

simplify config

better conditional

remove unused default, amend error message

undo doc change
2016-10-02 14:40:28 +08:00
bors-servo
a83ef43be0 Auto merge of #13538 - mschmo:master, r=Wafflespeanut
Avoid unecessary loop evaluation on empty lines for tidy check_license

Refactored file line loop in `check_license()` to skip when a blank line is encountered. Only difference should be a very very small performance boost.

Also changed the name of a test from the mispelling `test_licence()` to `test_license()`

---
- [ ] `./mach build -d` does not report any errors (I'm not able to download the rust compiler on my laptop due to me probably just needing to update openssl: `Error downloading Rust compiler: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590). The failing URL was: https://static-rust-lang-org.s3.amazonaws.com/dist/2016-09-21/rustc-nightly-x86_64-apple-darwin.tar.gz`)
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are no added tests for this since `test_license()`, `test_shebang_license()` and  `test_apache2_incomplete()` should suffice in this case. Though I'd be more than happy to add a test if requested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13538)
<!-- Reviewable:end -->
2016-10-01 16:17:00 -05:00
Matt Schmoyer
4846be1fdb using word license in test name for consistency 2016-10-01 12:25:57 -04:00
Matt Schmoyer
616eb83bba Avoid unecessary loop evaluation on empty lines for tidy check_license 2016-10-01 11:36:58 -04:00
Guillaume Gomez
eb27bcff7e Ensure cargo is up to date before running update crate command 2016-10-01 13:38:45 +02:00
bors-servo
0e950c0ba5 Auto merge of #13513 - nivekuil:master, r=Wafflespeanut
Return the error codes instead of implicitly returning None

See https://github.com/servo/servo/issues/13344

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13344 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because refactoring without logic changes, 0 is falsey as None

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13513)
<!-- Reviewable:end -->
2016-09-30 23:02:37 -05:00
bors-servo
7fbd35efab Auto merge of #12850 - Coder206:newFolderLinux, r=aneeshusa
New folder linux

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11983 (github issue number if applicable).

- [x] There are tests for these changes (./mach package)

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12850)
<!-- Reviewable:end -->
2016-09-30 18:29:56 -05:00
Patrick Trottier
d672750ca4 Use a temp folder when packaging on Linux
The purpose of the code is to make a new temporary folder with the
necessary resources used to package Linux. Before this, the package
was built based on a modified target directory. By using a temporary
folder, it removes the need to rebuild Servo every time it gets
packaged for Linux.
2016-09-30 22:56:55 +00:00
bors-servo
31415588a3 Auto merge of #13488 - vvuk:master, r=larsbergstrom
Use default console subsystem on Windows for dev builds

<!-- Please describe your changes on the following line: -->
If we keep the windows subsystem, we don't get any kind of log output.  We should keep the normal console subsystem for dev builds.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13488)
<!-- Reviewable:end -->
2016-09-30 16:33:53 -05:00
bors-servo
9acd7f390a Auto merge of #13486 - UK992:mach-bootstrap-2, r=larsbergstrom
Fix msvc packages download dir for custom `.servo` location

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13486)
<!-- Reviewable:end -->
2016-09-30 15:39:40 -05:00
Kevin Liu
b3a0ff5f31 Return the error codes instead of implicitly returning None 2016-09-29 16:46:34 -07:00
Simon Sapin
2108fa026e Fix OS-Mesa discovery in debug mode. 2016-09-29 09:15:01 +02:00
bors-servo
13c4393516 Auto merge of #13415 - Manishearth:style-testing-disable, r=SimonSapin
Run style unit tests in testing mode, disable some properties in testing mode

Another crack at making it possible to test geckolib properties.

In the previous PR I added support for a testing mode but neglected to use it in the style unit tests.

Using it brought out some bugs with properties that exist in both gecko and servo but have different names. Added the ability to disable them.

Hopefully this isn't too unweildy.

r? @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13415)
<!-- Reviewable:end -->
2016-09-28 16:39:49 -05:00
UK992
b0fabec6c7 Fix msvc packages download dir for custom .servo location 2016-09-28 22:58:38 +02:00
Vladimir Vukicevic
da8f06b0f9 Use default console subsystem on Windows for dev builds 2016-09-28 13:37:31 -07:00
Glenn Watson
dd4827d85f Update test expectations, remove webrender prefs/cmd line. 2016-09-28 18:42:30 +10:00