Anthony Ramine
6f3c46ca61
Remove uses of parse_four_sides and serialize_four_sides
2017-05-25 17:27:17 +02:00
Anthony Ramine
a65c874ec8
Refactor basic shapes
2017-05-22 14:03:12 +02:00
Michael Brennan
f7459fd848
Make no_viewport_percentage! use an absolute path for HasViewportPercentage
2017-05-11 14:24:03 +02:00
Anthony Ramine
70ec61cf01
Refactor Position
...
A specified position is now a struct made of two values of different types,
the first one being PositionComponent<X>, and the second one PositionComponent<Y>.
A position component is represented by the new enum PositionComponent<Side>,
with the three values Center, Length(LengthOrPercentage), and
Side(Side, Option<LengthOrPercentage>).
Side keywords are represented by the X and Y enums, which don't include a value
for the center keyword anymore. They are accompanied by the Side trait, which
allows us to determine whether a side keyword is "left" or "top".
This refactor simplified the parsing and serialisation code and exposed bugs in it,
where it would reject valid <position> values followed by arbitrary tokens,
and where it would fail to prefer "left" to "right" when serialising positions
in basic shapes.
2017-05-10 16:56:01 +02:00
Ravi Shankar
d56aec4109
Make ShapeSource generic
2017-04-25 17:42:02 +05:30
Ravi Shankar
24226af794
Make InsetRect generic
2017-04-25 17:40:41 +05:30
Ravi Shankar
61a17993eb
Cleanup position and make use of generic Position for its users
2017-04-25 17:32:45 +05:30
Ravi Shankar
f4b18643c2
Cleanup Polygon and make it generic
2017-04-25 17:13:45 +05:30
Ravi Shankar
a36bf9efc4
Make ShapeRadius generic
2017-04-25 17:13:44 +05:30
Ravi Shankar
b2b3f99427
Make BorderRadius generic
2017-04-25 17:13:42 +05:30
Ravi Shankar
76df67fc7b
Add add_impls_for_keyword_enum macro for implementing necessary traits
2017-04-13 15:27:13 +05:30
Ravi Shankar
6bd3469e28
Cleanup specified basic shape code
2017-04-13 11:03:40 +05:30
Ravi Shankar
26fda04888
Separate serialization function for BorderRadius
2017-04-13 11:03:39 +05:30
J. Ryan Stinnett
1a31b87c22
Pass ParserContext down to lengths
...
To make it possible to check the rule type when parsing lengths, we need to pass
the `ParserContext` down through many layers to the place where length units are
parsed.
This change leaves it unused, so it's only to prepare for the next change.
MozReview-Commit-ID: 70YwtcCxnWw
2017-04-12 16:40:48 +08:00
cku
e8d8b9984f
stylo: Update clip-path glue.
2017-03-17 19:55:31 +08:00
#
f5253c9f09
Fix and tests for negative border radius
2017-03-09 07:48:51 -05:00
Simon Sapin
0f2d000a23
Borrow input to match_ignore_ascii_case!
...
In cssparser version 0.11, this macro will stop implicitly borrowing its
own input.
2017-02-26 10:40:09 +01:00
Alon Levy
48bb508f66
fix #15492
2017-02-12 07:22:28 +02:00
Ravi Shankar
590c9579f0
Change LengthOrPercentage to make use of NoCalcLength
2017-01-29 02:30:25 +05:30
Ravi Shankar
377a23df50
Refactor and modify stuff to make use of NoCalcLength
2017-01-29 02:04:24 +05:30
Manish Goregaokar
f59557d2f2
Box CalcLengthOrPercentage to reduce inline size of PropertyDeclaration(s)
2017-01-17 08:09:54 -08:00
Nazım Can Altınova
c2dd14d3bb
Remove unnecessary try!'s
2017-01-11 22:29:15 +03:00
Emilio Cobos Álvarez
f37aa12927
style: Prevent more missing docs in the values module.
2016-12-31 12:17:02 +01:00
Nazım Can Altınova
a409d41d1d
Implement HorizontalPosition / VerticalPosition
2016-12-12 13:48:36 +03:00
Ravi Shankar
dee1a65a69
Use the ParserContext along with Parser in the parse function
2016-11-27 08:49:20 +05:30
Artem Biryukov
9564673b5a
Fix related to #14101
...
Add Parse trait implementation for some structures
2016-11-12 05:26:15 +03:00
Emilio Cobos Álvarez
5f2e7af864
style: Centralize specified url value handling, and refcount urls.
2016-11-10 13:15:21 +01:00
Ravi Shankar
6061985898
Prefer Servo-specific ToCss for all types
2016-11-07 09:14:22 +05:30
Manish Goregaokar
d81c6af59c
Add from_computed_value() function for converting computed values to specified
2016-09-23 09:44:32 +05:30
UK992
93a103ba73
Reorder use statements
2016-09-09 04:55:19 +02:00
Manish Goregaokar
7c9aff33c5
Handle specialized serialization of <position> in basic shapes ( fixes #13083 )
2016-09-01 13:59:59 +05:30
Nazım Can Altınova
8372f295b3
Change parsing behavior and implement to_computed_value function
2016-08-27 22:56:46 +03:00
Nazım Can Altınova
4eb93c85bc
Handle 3- and 4- valued <position>s in specified style
2016-08-26 00:06:56 +03:00
bors-servo
609d47b44f
Auto merge of #12878 - Manishearth:clip-path, r=heycam
...
stylo: Support clip-path
Todo:
- [x] `set_clip_path` (probably needs a bunch of gecko bindings for running constructors/destructors)
- [ ] Ensure that I've ordered the coordinates correctly
- [ ] Check that it works
- [x] Might want to convert NS_STYLE_FILL_RULE and NS_RADIUS to enum classes
Depends on:
- https://github.com/servo/rust-bindgen/pull/29
- https://github.com/Manishearth/gecko-dev/compare/servo:stylo...Manishearth:clip-path
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12878 )
<!-- Reviewable:end -->
2016-08-19 14:24:08 -05:00
Manish Goregaokar
3895b7118e
Handle clip-path in stylo
2016-08-19 23:36:37 +05:30
Manish Goregaokar
254900bd1a
Add ShapeSource to basic-shape values
2016-08-18 11:38:33 +05:30
David Raifaizen
3831c0650c
Adding support for correct shorthand serialization
2016-08-16 22:28:51 -04:00
Anthony Ramine
2c7d1ddfa1
Fix basic_shape warnings ( fixes #12762 )
2016-08-08 15:55:22 +02:00
Manish Goregaokar
234219cd84
Address review comments
2016-08-05 16:58:38 +05:30
Manish Goregaokar
d1e45f78af
Add serialize_four_sides, use for serializing BorderRadius
2016-08-02 19:22:03 +05:30
Manish Goregaokar
973796b989
Various fixes in basic-shape parsing/serialization found by unit tests
2016-08-02 15:57:34 +05:30
Manish Goregaokar
1e7973263f
Fix tidy
2016-08-02 15:57:30 +05:30
Manish Goregaokar
eb82cc25ef
Add Polygon to basic_shape.rs
2016-08-02 15:57:28 +05:30
Manish Goregaokar
78ce65d5a8
Add Ellipse to basic_shape.rs
2016-08-02 15:57:27 +05:30
Manish Goregaokar
77f345476f
Add Circle to basic_shape.rs
2016-08-02 15:57:25 +05:30
Manish Goregaokar
88c1a67d89
Add ShapeRadius to basic_shape.rs
2016-08-02 15:57:22 +05:30
Manish Goregaokar
2580c1dc6e
Add InsetRect, move BorderRadius to basic_shape.rs
2016-08-02 15:57:20 +05:30
